-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Add startsWith/endsWith constraints #12286
Merged
andy31415
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_StartsWithAndEndsWith
Nov 26, 2021
Merged
[YAML] Add startsWith/endsWith constraints #12286
andy31415
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_StartsWithAndEndsWith
Nov 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
pan-apple and
sagar-apple
November 26, 2021 10:34
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
wbschiller,
woody-apple and
yunhanw-google
November 26, 2021 10:34
vivien-apple
changed the title
Yaml starts with and ends with
[YAML] Add startsWith/endsWith constraints
Nov 26, 2021
PR #12286: Size comparison from 659190d to 4747530 Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
approved these changes
Nov 26, 2021
Damian-Nordic
approved these changes
Nov 26, 2021
andy31415
approved these changes
Nov 26, 2021
fast track: test code changes, has several checkmarks, simple change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The YAML test framework does not provide a way to test if a string starts/ends with a given prefix/suffix.
Change overview
startsWith
andendsWith
to YAMLTesting
Some tests has been added into
TestContraints.yaml