Re-enable test coverage that the python test suite runner disabled. #12282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern for tests is not "test_*"; there are a bunch of tests (e.g. TestCluster) that don't match that. The correct pattern is "Test*" (and "TV_*" for the TV tests). "test*" also does not work right because it includes src/app/tests/suites/certification/tests.yaml which is not a test yaml we want to be running. Summary of changes: 1. Stop lowercasing test names in creating the test definitions, so we can actually match against "Test*" sanely. This also makes the test names match what consumers see in the actual filenames. 2. Change the test name detection to match on "Test*", which fixes the actual regression. 3. Move the lowercasing to the --target and --target-glob matching. 4. Add more useful error output when unrecognized --target values are specified, and exit with a failure in that case instead of silently succeeding.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic and
vivien-apple
pullapprove
bot
requested review from
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #12282: Size comparison from 659190d to 510f97e Full report (34 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 26, 2021
|
fast track: test behaviour change only |
|
PR #12282: Size comparison from bcada22 to 9f55946 Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
|
PR #12282: Size comparison from 67c8f1d to 385c2eb Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern for tests is not "
test_*"; there are a bunch of tests(e.g. TestCluster) that don't match that. The correct pattern is
"
Test*" (and "TV_*" for the TV tests). "test*" also does not workright because it includes
src/app/tests/suites/certification/tests.yaml which is not a test yaml
we want to be running.
Summary of changes:
can actually match against "
Test*" sanely. This also makes the testnames match what consumers see in the actual filenames.
Test*", which fixes the actualregression.
specified, and exit with a failure in that case instead of silently
succeeding.
Problem
See above.
Change overview
See above.
Testing
Verified that "TestCluster" not appears in the list of tests the script knows about.