-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request/power source configuration cluster #12209
Merged
jmartinez-silabs
merged 19 commits into
project-chip:master
from
fessehaeve:pull-request/power-source-configuration-cluster
Dec 3, 2021
Merged
Pull request/power source configuration cluster #12209
jmartinez-silabs
merged 19 commits into
project-chip:master
from
fessehaeve:pull-request/power-source-configuration-cluster
Dec 3, 2021
+13,825
−6,691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fessehaeve
requested review from
tcarmelveilleux,
andy31415,
LuDuda,
msandstedt,
tecimovic,
cecille,
holbrookt,
yunhanw-google,
chrisbeach59,
yufengwangca,
woody-apple,
anush-apple,
bzbarsky-apple,
kkasperczyk-no,
Damian-Nordic,
jepenven-silabs,
jmartinez-silabs,
franck-apple,
pjzander-signify,
andyp-apple,
austinh0,
jmeg-sfy and
a user
November 24, 2021 16:20
woody-apple
approved these changes
Nov 24, 2021
yunhanw-google
approved these changes
Nov 25, 2021
bzbarsky-apple
force-pushed
the
pull-request/power-source-configuration-cluster
branch
from
December 3, 2021 15:22
a6bb87c
to
fc7d23e
Compare
PR #12209: Size comparison from e8da685 to fc7d23e Increases above 0.2%:
Increases (3 builds for k32w, qpg)
Full report (7 builds for k32w, qpg, telink)
|
bzbarsky-apple
force-pushed
the
pull-request/power-source-configuration-cluster
branch
from
December 3, 2021 16:42
fc7d23e
to
38fb3fc
Compare
- A read on Sources attribute searches for all power source server clusters and decodes it in the response
Regenerate all after rebasing on ToT
…tion + regenerate all
… toggles on autogen.
Regenerate after changing descriptor cluster tests
Rebase and regenerate Rebase and regenerate
bzbarsky-apple
force-pushed
the
pull-request/power-source-configuration-cluster
branch
from
December 3, 2021 17:50
38fb3fc
to
4ef05f9
Compare
@msandstedt @saurabhst @jepenven-silabs @jmartinez-silabs @LuDuda @Damian-Nordic Please review? |
saurabhst
approved these changes
Dec 3, 2021
jmartinez-silabs
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Implement Power source configuration cluster
Change overview
Created XML file and included cluster in all-clusters-app and controller-cluster
Testing
Tested manually with Nordic dev kit and chip-tool.