Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K32W0] Fix BLE commissioning failure #12203

Merged
merged 1 commit into from
Nov 24, 2021
Merged

[K32W0] Fix BLE commissioning failure #12203

merged 1 commit into from
Nov 24, 2021

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Nov 24, 2021

Problem

  • DUT refused the send the PBKDF param response due to insufficient memory on the BLE Host side.

Change overview

  • The fix is to increase the memory pool.

Testing

  • tested using chip-device-ctrl

Duplicate of #11910, but targeted for the master branch

@doru91
[K32W0] Fix BLE commissioning failure
258d26f 
DUT refused the send the PBKDF param response due to insufficient
memory on the BLE Host side. THe fix is to increase the memory pool.

Signed-off-by: Doru Gucea <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 24, 2021 •
edited
Loading

PR #12203: Size comparison from 8f73103 to 258d26f

Increases above 0.2%:

platform target config section 8f73103 258d26f change % change
k32w lighting-app k32w061+se05x+release .bss 77316 78148 832 1.1
.data 1924 1932 8 0.4
lock-app k32w061+debug .bss 67756 68588 832 1.2
.data 1892 1900 8 0.4
shell k32w061+debug .bss 78916 79748 832 1.1
.data 1860 1868 8 0.4
Increases (3 builds for k32w)
platform target config section 8f73103 258d26f change % change
k32w lighting-app k32w061+se05x+release (read/write) 711916 712756 840 0.1
.bss 77316 78148 832 1.1
.data 1924 1932 8 0.4
lock-app k32w061+debug (read/write) 602112 602952 840 0.1
.bss 67756 68588 832 1.2
.data 1892 1900 8 0.4
shell k32w061+debug (read/write) 667608 668448 840 0.1
.bss 78916 79748 832 1.1
.data 1860 1868 8 0.4
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8f73103 258d26f change % change
efr32 lighting-app BRD4161A (read only) 757712 757712 0 0.0
(read/write) 119796 119796 0 0.0
.bss 117980 117980 0 0.0
.data 1812 1812 0 0.0
.text 757704 757704 0 0.0
BRD4161A+rpc (read only) 745172 745172 0 0.0
(read/write) 136420 136420 0 0.0
.bss 134484 134484 0 0.0
.data 1936 1936 0 0.0
.text 745164 745164 0 0.0
lock-app BRD4161A (read only) 733568 733568 0 0.0
(read/write) 117508 117508 0 0.0
.bss 115740 115740 0 0.0
.data 1768 1768 0 0.0
.text 733560 733560 0 0.0
window-app BRD4161A (read only) 737016 737016 0 0.0
(read/write) 117868 117868 0 0.0
.bss 116092 116092 0 0.0
.data 1776 1776 0 0.0
.text 737008 737008 0 0.0
esp32 all-clusters-app c3devkit (read only) 836066 836066 0 0.0
(read/write) 1222698 1222698 0 0.0
.dram0.bss 57840 57840 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165504 165504 0 0.0
.flash.text 836066 836066 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907519 907519 0 0.0
(read/write) 422004 422004 0 0.0
.dram0.bss 63232 63232 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 193428 193428 0 0.0
.flash.text 902135 902135 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 711916 712756 840 0.1
.bss 77316 78148 832 1.1
.data 1924 1932 8 0.4
.text 626876 626876 0 0.0
lock-app k32w061+debug (read/write) 602112 602952 840 0.1
.bss 67756 68588 832 1.2
.data 1892 1900 8 0.4
.text 526664 526664 0 0.0
shell k32w061+debug (read/write) 667608 668448 840 0.1
.bss 78916 79748 832 1.1
.data 1860 1868 8 0.4
.text 581032 581032 0 0.0
linux all-clusters-app debug (read only) 1768145 1768145 0 0.0
(read/write) 129496 129496 0 0.0
.bss 58608 58608 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 64432 64432 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138485 138485 0 0.0
.text 1491602 1491602 0 0.0
bridge-app debug+rpc (read only) 1343661 1343661 0 0.0
(read/write) 77408 77408 0 0.0
.bss 41488 41488 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29200 29200 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113044 113044 0 0.0
.text 1130837 1130837 0 0.0
chip-tool debug (read only) 5959917 5959917 0 0.0
(read/write) 197224 197224 0 0.0
.bss 39896 39896 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 149368 149368 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283954 283954 0 0.0
.text 5292597 5292597 0 0.0
lighting-app debug+rpc (read only) 1616945 1616945 0 0.0
(read/write) 110688 110688 0 0.0
.bss 47216 47216 0 0.0
.data 1330 1330 0 0.0
.data.rel.ro 56800 56800 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131409 131409 0 0.0
.text 1348130 1348130 0 0.0
ota-provider-app debug (read only) 1307833 1307833 0 0.0
(read/write) 75928 75928 0 0.0
.bss 44128 44128 0 0.0
.data 880 880 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114831 114831 0 0.0
.text 1092962 1092962 0 0.0
ota-requestor-app debug (read only) 1404337 1404337 0 0.0
(read/write) 79792 79792 0 0.0
.bss 46592 46592 0 0.0
.data 944 944 0 0.0
.data.rel.ro 27112 27112 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126240 126240 0 0.0
.text 1175266 1175266 0 0.0
shell debug (read only) 820345 820345 0 0.0
(read/write) 66584 66584 0 0.0
.bss 23272 23272 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38440 38440 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79119 79119 0 0.0
.text 634802 634802 0 0.0
tv-app debug (read only) 1913497 1913497 0 0.0
(read/write) 319704 319704 0 0.0
.bss 249976 249976 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61184 61184 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159317 159317 0 0.0
.text 1606290 1606290 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294768 2294768 0 0.0
.bss 180396 180396 0 0.0
.data 5240 5240 0 0.0
.heap 850808 850808 0 0.0
.text 1257368 1257368 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278944 2278944 0 0.0
.bss 172292 172292 0 0.0
.data 5592 5592 0 0.0
.heap 858560 858560 0 0.0
.text 1241544 1241544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253264 2253264 0 0.0
.bss 171108 171108 0 0.0
.data 5576 5576 0 0.0
.heap 859760 859760 0 0.0
.text 1215864 1215864 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051224 2051224 0 0.0
.bss 156320 156320 0 0.0
.data 4984 4984 0 0.0
.heap 875144 875144 0 0.0
.text 1013824 1013824 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 871847 871847 0 0.0
bss 112640 112640 0 0.0
rodata 96784 96784 0 0.0
text 586792 586792 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 834215 834215 0 0.0
bss 108992 108992 0 0.0
rodata 87968 87968 0 0.0
text 560960 560960 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 796886 796886 0 0.0
bss 114012 114012 0 0.0
rodata 92040 92040 0 0.0
text 516260 516260 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 843963 843963 0 0.0
bss 109672 109672 0 0.0
rodata 92788 92788 0 0.0
text 566036 566036 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 769234 769234 0 0.0
bss 111084 111084 0 0.0
rodata 88076 88076 0 0.0
text 495596 495596 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 850071 850071 0 0.0
bss 109812 109812 0 0.0
rodata 94496 94496 0 0.0
text 570220 570220 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 843663 843663 0 0.0
bss 109708 109708 0 0.0
rodata 92744 92744 0 0.0
text 565656 565656 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778907 778907 0 0.0
bss 109184 109184 0 0.0
rodata 73304 73304 0 0.0
text 521828 521828 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693962 693962 0 0.0
bss 110168 110168 0 0.0
rodata 67948 67948 0 0.0
text 442436 442436 0 0.0
p6 all-clusters-app default (read/write) 2309800 2309800 0 0.0
.bss 113384 113384 0 0.0
.data 2536 2536 0 0.0
.heap 917424 917424 0 0.0
.text 1268064 1268064 0 0.0
lock-app default (read/write) 2221784 2221784 0 0.0
.bss 100968 100968 0 0.0
.data 2416 2416 0 0.0
.heap 929960 929960 0 0.0
.text 1180048 1180048 0 0.0
qpg lighting-app qpg6100+debug (read only) 498644 498644 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50360 50360 0 0.0
.data 1020 1020 0 0.0
.text 493324 493324 0 0.0
lock-app qpg6100+debug (read only) 472548 472548 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49232 49232 0 0.0
.data 976 976 0 0.0
.text 467228 467228 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 773510 773510 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 537292 537292 0 0.0

@andy31415
Copy link
Contributor

fast track: platform specific change made by a platform maintainer

@andy31415 andy31415 merged commit b87d1fa into project-chip:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doru91 @andy31415