-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add events to Generic Switch XML #12197
Conversation
PR #12197: Size comparison from 8f73103 to 254de33 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving provided that MultiPress Complete will be fixed.
PR #12197: Size comparison from b87d1fa to 3b3594d Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
@jonsmirl it looks like zap updates are needed (or restyle diff) |
fast track: xml changes only |
Yes, it needs regen before committing. But if I keep regening as top of tree changes I trigger a large amount of pointless CI jobs. |
PR #12197: Size comparison from 1315dec to 808b041 Increases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #12197: Size comparison from e917860 to 94f9ab3 Increases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Generic switch XML missing event definitions, this adds them.
Tested with full regen. No code using these.