Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CHIP_IM_MAX_NUM_COMMAND_SENDER define. #12178

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Remove unused CHIP_IM_MAX_NUM_COMMAND_SENDER define. #12178

merged 1 commit into from
Nov 23, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

Define is unused.

Change overview

Remove it.

Testing

Tree compiles.

@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

PR #12178: Size comparison from 972406e to 13f1dea

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 972406e 13f1dea change % change
efr32 lighting-app BRD4161A (read only) 752624 752624 0 0.0
(read/write) 119796 119796 0 0.0
.bss 117980 117980 0 0.0
.data 1812 1812 0 0.0
.text 752616 752616 0 0.0
BRD4161A+rpc (read only) 740108 740108 0 0.0
(read/write) 136420 136420 0 0.0
.bss 134484 134484 0 0.0
.data 1936 1936 0 0.0
.text 740100 740100 0 0.0
lock-app BRD4161A (read only) 729624 729624 0 0.0
(read/write) 117508 117508 0 0.0
.bss 115740 115740 0 0.0
.data 1768 1768 0 0.0
.text 729616 729616 0 0.0
window-app BRD4161A (read only) 733072 733072 0 0.0
(read/write) 117868 117868 0 0.0
.bss 116092 116092 0 0.0
.data 1776 1776 0 0.0
.text 733064 733064 0 0.0
esp32 all-clusters-app c3devkit (read only) 834076 834076 0 0.0
(read/write) 1222394 1222394 0 0.0
.dram0.bss 57840 57840 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165200 165200 0 0.0
.flash.text 834076 834076 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 905135 905135 0 0.0
(read/write) 421700 421700 0 0.0
.dram0.bss 63232 63232 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 193124 193124 0 0.0
.flash.text 899751 899751 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 708732 708732 0 0.0
.bss 77316 77316 0 0.0
.data 1924 1924 0 0.0
.text 623692 623692 0 0.0
lock-app k32w061+debug (read/write) 599984 599984 0 0.0
.bss 67756 67756 0 0.0
.data 1892 1892 0 0.0
.text 524536 524536 0 0.0
shell k32w061+debug (read/write) 665464 665464 0 0.0
.bss 78916 78916 0 0.0
.data 1860 1860 0 0.0
.text 578888 578888 0 0.0
linux all-clusters-app debug (read only) 1752209 1752209 0 0.0
(read/write) 129016 129016 0 0.0
.bss 58672 58672 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63984 63984 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138453 138453 0 0.0
.text 1476994 1476994 0 0.0
bridge-app debug+rpc (read only) 1330677 1330677 0 0.0
(read/write) 76960 76960 0 0.0
.bss 41552 41552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 28784 28784 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113052 113052 0 0.0
.text 1119093 1119093 0 0.0
chip-tool debug (read only) 5924485 5924485 0 0.0
(read/write) 196328 196328 0 0.0
.bss 39960 39960 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 148520 148520 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283834 283834 0 0.0
.text 5259541 5259541 0 0.0
lighting-app debug+rpc (read only) 1601569 1601569 0 0.0
(read/write) 110240 110240 0 0.0
.bss 47312 47312 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 56368 56368 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131409 131409 0 0.0
.text 1334002 1334002 0 0.0
ota-provider-app debug (read only) 1281601 1281601 0 0.0
(read/write) 75480 75480 0 0.0
.bss 44192 44192 0 0.0
.data 800 800 0 0.0
.data.rel.ro 25368 25368 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114775 114775 0 0.0
.text 1068034 1068034 0 0.0
ota-requestor-app debug (read only) 1378105 1378105 0 0.0
(read/write) 79344 79344 0 0.0
.bss 46656 46656 0 0.0
.data 864 864 0 0.0
.data.rel.ro 26696 26696 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126184 126184 0 0.0
.text 1150338 1150338 0 0.0
shell debug (read only) 805705 805705 0 0.0
(read/write) 66200 66200 0 0.0
.bss 23368 23368 0 0.0
.data 274 274 0 0.0
.data.rel.ro 38024 38024 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79055 79055 0 0.0
.text 621474 621474 0 0.0
tv-app debug (read only) 1900353 1900353 0 0.0
(read/write) 319288 319288 0 0.0
.bss 250072 250072 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 60752 60752 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159325 159325 0 0.0
.text 1594386 1594386 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291112 2291112 0 0.0
.bss 180388 180388 0 0.0
.data 5240 5240 0 0.0
.heap 850816 850816 0 0.0
.text 1253712 1253712 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275320 2275320 0 0.0
.bss 172292 172292 0 0.0
.data 5592 5592 0 0.0
.heap 858560 858560 0 0.0
.text 1237920 1237920 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2251120 2251120 0 0.0
.bss 171108 171108 0 0.0
.data 5576 5576 0 0.0
.heap 859760 859760 0 0.0
.text 1213720 1213720 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050992 2050992 0 0.0
.bss 156320 156320 0 0.0
.data 4984 4984 0 0.0
.heap 875144 875144 0 0.0
.text 1013592 1013592 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 868663 868663 0 0.0
bss 112640 112640 0 0.0
rodata 96192 96192 0 0.0
text 584204 584204 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 831031 831031 0 0.0
bss 108992 108992 0 0.0
rodata 87376 87376 0 0.0
text 558372 558372 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793702 793702 0 0.0
bss 114012 114012 0 0.0
rodata 91448 91448 0 0.0
text 513672 513672 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841815 841815 0 0.0
bss 109672 109672 0 0.0
rodata 92624 92624 0 0.0
text 564056 564056 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 767106 767106 0 0.0
bss 111084 111084 0 0.0
rodata 87916 87916 0 0.0
text 493616 493616 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847927 847927 0 0.0
bss 109812 109812 0 0.0
rodata 94336 94336 0 0.0
text 568240 568240 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841519 841519 0 0.0
bss 109708 109708 0 0.0
rodata 92584 92584 0 0.0
text 563676 563676 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778707 778707 0 0.0
bss 109184 109184 0 0.0
rodata 73200 73200 0 0.0
text 521724 521724 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693746 693746 0 0.0
bss 110168 110168 0 0.0
rodata 67844 67844 0 0.0
text 442332 442332 0 0.0
p6 all-clusters-app default (read/write) 2304688 2304688 0 0.0
.bss 113376 113376 0 0.0
.data 2536 2536 0 0.0
.heap 917432 917432 0 0.0
.text 1262952 1262952 0 0.0
lock-app default (read/write) 2217840 2217840 0 0.0
.bss 100968 100968 0 0.0
.data 2416 2416 0 0.0
.heap 929960 929960 0 0.0
.text 1176104 1176104 0 0.0
qpg lighting-app qpg6100+debug (read only) 495484 495484 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50360 50360 0 0.0
.data 1020 1020 0 0.0
.text 490164 490164 0 0.0
lock-app qpg6100+debug (read only) 470420 470420 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49232 49232 0 0.0
.data 976 976 0 0.0
.text 465100 465100 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769974 769974 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 534642 534642 0 0.0

@andy31415
Copy link
Contributor

fast track: trivial change by a domain owner.

@andy31415 andy31415 merged commit 6eba258 into project-chip:master Nov 23, 2021
@bzbarsky-apple bzbarsky-apple deleted the remove-unused-command-sender-count branch November 24, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @yufengwangca