Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FeatureMap for General Commissioning Cluster #12177

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Support FeatureMap for General Commissioning Cluster #12177

merged 2 commits into from
Nov 24, 2021

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Nov 23, 2021 •
edited
Loading

Problem

What is being fixed? Examples:

  • Missing FeatureMap support in General Commissioning Cluster.

Change overview

Support FeatureMap for General Commissioning Cluster

Testing

How was this tested? (at least one bullet point required)

  • Read featuremap of General Commissioning Cluster against lighting-app and confirm features WI(bit1) and TH(bit2) are enabled
yufengw@yufengw-SEi:~/connectedhomeip/out/debug/standalone$ ./chip-tool generalcommissioning read feature-map 12344321 0
......
[1637699655.493154][477876:477881] CHIP:DMG: ReportDataMessage =
[1637699655.493171][477876:477881] CHIP:DMG: {
[1637699655.493177][477876:477881] CHIP:DMG: 	AttributeReportIBs =
[1637699655.493186][477876:477881] CHIP:DMG: 	[
[1637699655.493195][477876:477881] CHIP:DMG: 		AttributeReportIB =
[1637699655.493206][477876:477881] CHIP:DMG: 		{
[1637699655.493217][477876:477881] CHIP:DMG: 			AttributeDataIB =
[1637699655.493231][477876:477881] CHIP:DMG: 			{
[1637699655.493240][477876:477881] CHIP:DMG: 				AttributePathIB =
[1637699655.493254][477876:477881] CHIP:DMG: 				{
[1637699655.493263][477876:477881] CHIP:DMG: 					Endpoint = 0x0,
[1637699655.493271][477876:477881] CHIP:DMG: 					Cluster = 0x30,
[1637699655.493278][477876:477881] CHIP:DMG: 					Attribute = 0x0000_FFFC,
[1637699655.493292][477876:477881] CHIP:DMG: 				}
[1637699655.493303][477876:477881] CHIP:DMG: 					
[1637699655.493316][477876:477881] CHIP:DMG: 					Data = 6, 
[1637699655.493329][477876:477881] CHIP:DMG: 				DataVersion = 0x0,
[1637699655.493339][477876:477881] CHIP:DMG: 			},
[1637699655.493349][477876:477881] CHIP:DMG: 			
[1637699655.493354][477876:477881] CHIP:DMG: 		},
[1637699655.493369][477876:477881] CHIP:DMG: 		
[1637699655.493374][477876:477881] CHIP:DMG: 	],
[1637699655.493386][477876:477881] CHIP:DMG: 	
[1637699655.493395][477876:477881] CHIP:DMG: 	SuppressResponse = true, 
[1637699655.493406][477876:477881] CHIP:DMG: }
[1637699655.493505][477876:477881] CHIP:ZCL: ReadAttributesResponse:
[1637699655.493529][477876:477881] CHIP:ZCL:   ClusterId: 0x0000_0030
[1637699655.493545][477876:477881] CHIP:ZCL:   attributeId: 0x0000_FFFC
[1637699655.493551][477876:477881] CHIP:ZCL:   status: Success                (0x0000)
[1637699655.493560][477876:477881] CHIP:ZCL:   attribute TLV Type: 0x04
[1637699655.493568][477876:477881] CHIP:TOO: Int32u attribute Response: 6

@yufengwangca yufengwangca marked this pull request as draft November 23, 2021 19:44
@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

PR #12177: Size comparison from 972406e to 89f6845

Increases (19 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 972406e 89f6845 change % change
efr32 lighting-app BRD4161A (read only) 752624 752640 16 0.0
(read/write) 119796 119804 8 0.0
.bss 117980 117988 8 0.0
.text 752616 752632 16 0.0
BRD4161A+rpc (read only) 740108 740132 24 0.0
(read/write) 136420 136428 8 0.0
.bss 134484 134492 8 0.0
.text 740100 740124 24 0.0
lock-app BRD4161A (read only) 729624 729648 24 0.0
(read/write) 117508 117516 8 0.0
.bss 115740 115748 8 0.0
.text 729616 729640 24 0.0
window-app BRD4161A (read only) 733072 733096 24 0.0
(read/write) 117868 117876 8 0.0
.bss 116092 116100 8 0.0
.text 733064 733088 24 0.0
k32w lighting-app k32w061+se05x+release (read/write) 708732 708752 20 0.0
.text 623692 623712 20 0.0
lock-app k32w061+debug (read/write) 599984 600004 20 0.0
.text 524536 524556 20 0.0
shell k32w061+debug (read/write) 665464 665492 28 0.0
.bss 78916 78924 8 0.0
.text 578888 578908 20 0.0
linux all-clusters-app debug (read only) 1752209 1752265 56 0.0
(read/write) 129016 129048 32 0.0
.bss 58672 58704 32 0.1
.rodata 138453 138485 32 0.0
bridge-app debug+rpc (read only) 1330677 1330701 24 0.0
(read/write) 76960 77024 64 0.1
.bss 41552 41584 32 0.1
.data.rel.ro 28784 28816 32 0.1
chip-tool debug (read only) 5924485 5924509 24 0.0
lighting-app debug+rpc (read only) 1601569 1601593 24 0.0
(read/write) 110240 110272 32 0.0
.data.rel.ro 56368 56400 32 0.1
ota-provider-app debug (read only) 1281601 1281625 24 0.0
ota-requestor-app debug (read only) 1378105 1378129 24 0.0
(read/write) 79344 79376 32 0.0
.data.rel.ro 26696 26728 32 0.1
tv-app debug (read only) 1900353 1900377 24 0.0
p6 all-clusters-app default (read/write) 2304688 2304712 24 0.0
.bss 113376 113384 8 0.0
.text 1262952 1262976 24 0.0
lock-app default (read/write) 2217840 2217864 24 0.0
.bss 100968 100976 8 0.0
.text 1176104 1176128 24 0.0
qpg lighting-app qpg6100+debug (read only) 495484 495504 20 0.0
.bss 50360 50368 8 0.0
.text 490164 490184 20 0.0
lock-app qpg6100+debug (read only) 470420 470440 20 0.0
.bss 49232 49240 8 0.0
.text 465100 465120 20 0.0
telink lighting-app tlsr9518adk80d (read/write) 769974 770010 36 0.0
bss 79216 79220 4 0.0
Decreases (2 builds for p6)
platform target config section 972406e 89f6845 change % change
p6 all-clusters-app default .heap 917432 917424 -8 -0.0
lock-app default .heap 929960 929952 -8 -0.0
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 972406e 89f6845 change % change
efr32 lighting-app BRD4161A (read only) 752624 752640 16 0.0
(read/write) 119796 119804 8 0.0
.bss 117980 117988 8 0.0
.data 1812 1812 0 0.0
.text 752616 752632 16 0.0
BRD4161A+rpc (read only) 740108 740132 24 0.0
(read/write) 136420 136428 8 0.0
.bss 134484 134492 8 0.0
.data 1936 1936 0 0.0
.text 740100 740124 24 0.0
lock-app BRD4161A (read only) 729624 729648 24 0.0
(read/write) 117508 117516 8 0.0
.bss 115740 115748 8 0.0
.data 1768 1768 0 0.0
.text 729616 729640 24 0.0
window-app BRD4161A (read only) 733072 733096 24 0.0
(read/write) 117868 117876 8 0.0
.bss 116092 116100 8 0.0
.data 1776 1776 0 0.0
.text 733064 733088 24 0.0
k32w lighting-app k32w061+se05x+release (read/write) 708732 708752 20 0.0
.bss 77316 77316 0 0.0
.data 1924 1924 0 0.0
.text 623692 623712 20 0.0
lock-app k32w061+debug (read/write) 599984 600004 20 0.0
.bss 67756 67756 0 0.0
.data 1892 1892 0 0.0
.text 524536 524556 20 0.0
shell k32w061+debug (read/write) 665464 665492 28 0.0
.bss 78916 78924 8 0.0
.data 1860 1860 0 0.0
.text 578888 578908 20 0.0
linux all-clusters-app debug (read only) 1752209 1752265 56 0.0
(read/write) 129016 129048 32 0.0
.bss 58672 58704 32 0.1
.data 1042 1042 0 0.0
.data.rel.ro 63984 63984 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138453 138485 32 0.0
.text 1476994 1476994 0 0.0
bridge-app debug+rpc (read only) 1330677 1330701 24 0.0
(read/write) 76960 77024 64 0.1
.bss 41552 41584 32 0.1
.data 1584 1584 0 0.0
.data.rel.ro 28784 28816 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113052 113052 0 0.0
.text 1119093 1119093 0 0.0
chip-tool debug (read only) 5924485 5924509 24 0.0
(read/write) 196328 196328 0 0.0
.bss 39960 39960 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 148520 148520 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283834 283834 0 0.0
.text 5259541 5259541 0 0.0
lighting-app debug+rpc (read only) 1601569 1601593 24 0.0
(read/write) 110240 110272 32 0.0
.bss 47312 47312 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 56368 56400 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131409 131409 0 0.0
.text 1334002 1334002 0 0.0
ota-provider-app debug (read only) 1281601 1281625 24 0.0
(read/write) 75480 75480 0 0.0
.bss 44192 44192 0 0.0
.data 800 800 0 0.0
.data.rel.ro 25368 25368 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114775 114775 0 0.0
.text 1068034 1068034 0 0.0
ota-requestor-app debug (read only) 1378105 1378129 24 0.0
(read/write) 79344 79376 32 0.0
.bss 46656 46656 0 0.0
.data 864 864 0 0.0
.data.rel.ro 26696 26728 32 0.1
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126184 126184 0 0.0
.text 1150338 1150338 0 0.0
shell debug (read only) 805705 805705 0 0.0
(read/write) 66200 66200 0 0.0
.bss 23368 23368 0 0.0
.data 274 274 0 0.0
.data.rel.ro 38024 38024 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79055 79055 0 0.0
.text 621474 621474 0 0.0
tv-app debug (read only) 1900353 1900377 24 0.0
(read/write) 319288 319288 0 0.0
.bss 250072 250072 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 60752 60752 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159325 159325 0 0.0
.text 1594386 1594386 0 0.0
p6 all-clusters-app default (read/write) 2304688 2304712 24 0.0
.bss 113376 113384 8 0.0
.data 2536 2536 0 0.0
.heap 917432 917424 -8 -0.0
.text 1262952 1262976 24 0.0
lock-app default (read/write) 2217840 2217864 24 0.0
.bss 100968 100976 8 0.0
.data 2416 2416 0 0.0
.heap 929960 929952 -8 -0.0
.text 1176104 1176128 24 0.0
qpg lighting-app qpg6100+debug (read only) 495484 495504 20 0.0
(read/write) 114140 114140 0 0.0
.bss 50360 50368 8 0.0
.data 1020 1020 0 0.0
.text 490164 490184 20 0.0
lock-app qpg6100+debug (read only) 470420 470440 20 0.0
(read/write) 114144 114144 0 0.0
.bss 49232 49240 8 0.0
.data 976 976 0 0.0
.text 465100 465120 20 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769974 770010 36 0.0
bss 79216 79220 4 0.0
noinit 37160 37160 0 0.0
text 534642 534642 0 0.0

@boring-cyborg boring-cyborg bot added the darwin label Nov 23, 2021
@yufengwangca yufengwangca marked this pull request as ready for review November 23, 2021 20:36
@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

PR #12177: Size comparison from c1b032a to e88c52d

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c1b032a e88c52d change % change
efr32 lighting-app BRD4161A (read only) 754832 754856 24 0.0
(read/write) 119796 119804 8 0.0
.bss 117980 117988 8 0.0
.text 754824 754848 24 0.0
BRD4161A+rpc (read only) 742292 742308 16 0.0
(read/write) 136420 136428 8 0.0
.bss 134484 134492 8 0.0
.text 742284 742300 16 0.0
lock-app BRD4161A (read only) 730688 730704 16 0.0
(read/write) 117508 117516 8 0.0
.bss 115740 115748 8 0.0
.text 730680 730696 16 0.0
window-app BRD4161A (read only) 734136 734152 16 0.0
(read/write) 117868 117876 8 0.0
.bss 116092 116100 8 0.0
.text 734128 734144 16 0.0
esp32 all-clusters-app c3devkit (read/write) 1222658 1222682 24 0.0
.dram0.bss 57832 57840 8 0.0
.flash.rodata 165464 165488 24 0.0
m5stack (read/write) 421956 421980 24 0.0
.dram0.bss 63224 63232 8 0.0
.flash.rodata 193388 193404 16 0.0
k32w lighting-app k32w061+se05x+release (read/write) 710268 710288 20 0.0
.text 625228 625248 20 0.0
lock-app k32w061+debug (read/write) 600480 600500 20 0.0
.text 525032 525052 20 0.0
shell k32w061+debug (read/write) 665960 665988 28 0.0
.bss 78916 78924 8 0.0
.text 579384 579404 20 0.0
linux all-clusters-app debug (read only) 1752673 1752697 24 0.0
(read/write) 129432 129464 32 0.0
.bss 58576 58608 32 0.1
bridge-app debug+rpc (read only) 1331405 1331429 24 0.0
(read/write) 77408 77472 64 0.1
.bss 41488 41520 32 0.1
.data.rel.ro 29200 29232 32 0.1
chip-tool debug (read only) 5939053 5940269 1216 0.0
(read/write) 196776 196840 64 0.0
.data.rel.ro 148936 149000 64 0.0
.text 5272773 5273797 1024 0.0
lighting-app debug+rpc (read only) 1602017 1602041 24 0.0
(read/write) 110688 110720 32 0.0
.data.rel.ro 56800 56832 32 0.1
ota-provider-app debug (read only) 1296153 1296177 24 0.0
ota-requestor-app debug (read only) 1392673 1392697 24 0.0
(read/write) 79792 79824 32 0.0
.data.rel.ro 27112 27144 32 0.1
tv-app debug (read only) 1901081 1901105 24 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293064 2293088 24 0.0
.text 1255664 1255688 24 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2277344 2277368 24 0.0
.bss 172292 172300 8 0.0
.text 1239944 1239968 24 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2251664 2251688 24 0.0
.bss 171108 171116 8 0.0
.text 1214264 1214288 24 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 870183 870235 52 0.0
bss 112640 112644 4 0.0
rodata 96784 96804 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 832551 832603 52 0.0
bss 108992 108996 4 0.0
rodata 87968 87988 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795222 795242 20 0.0
bss 114012 114016 4 0.0
rodata 92040 92060 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 842299 842319 20 0.0
bss 109672 109676 4 0.0
rodata 92788 92808 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 767586 767606 20 0.0
bss 111084 111088 4 0.0
rodata 88076 88096 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 848407 848427 20 0.0
bss 109812 109816 4 0.0
rodata 94496 94516 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841999 842019 20 0.0
bss 109708 109712 4 0.0
rodata 92744 92764 20 0.0
p6 all-clusters-app default (read/write) 2306904 2306920 16 0.0
.bss 113376 113384 8 0.0
.text 1265168 1265184 16 0.0
lock-app default (read/write) 2218904 2218920 16 0.0
.bss 100968 100976 8 0.0
.text 1177168 1177184 16 0.0
qpg lighting-app qpg6100+debug (read only) 497012 497032 20 0.0
.bss 50360 50368 8 0.0
.text 491692 491712 20 0.0
lock-app qpg6100+debug (read only) 470916 470936 20 0.0
.bss 49232 49240 8 0.0
.text 465596 465616 20 0.0
telink lighting-app tlsr9518adk80d (read/write) 771514 771550 36 0.0
bss 79216 79220 4 0.0
Decreases (4 builds for mbed, p6)
platform target config section c1b032a e88c52d change % change
mbed lighting-app CY8CPROTO_062_4343W+release .heap 858560 858552 -8 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859760 859752 -8 -0.0
p6 all-clusters-app default .heap 917432 917424 -8 -0.0
lock-app default .heap 929960 929952 -8 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c1b032a e88c52d change % change
efr32 lighting-app BRD4161A (read only) 754832 754856 24 0.0
(read/write) 119796 119804 8 0.0
.bss 117980 117988 8 0.0
.data 1812 1812 0 0.0
.text 754824 754848 24 0.0
BRD4161A+rpc (read only) 742292 742308 16 0.0
(read/write) 136420 136428 8 0.0
.bss 134484 134492 8 0.0
.data 1936 1936 0 0.0
.text 742284 742300 16 0.0
lock-app BRD4161A (read only) 730688 730704 16 0.0
(read/write) 117508 117516 8 0.0
.bss 115740 115748 8 0.0
.data 1768 1768 0 0.0
.text 730680 730696 16 0.0
window-app BRD4161A (read only) 734136 734152 16 0.0
(read/write) 117868 117876 8 0.0
.bss 116092 116100 8 0.0
.data 1776 1776 0 0.0
.text 734128 734144 16 0.0
esp32 all-clusters-app c3devkit (read only) 834242 834242 0 0.0
(read/write) 1222658 1222682 24 0.0
.dram0.bss 57832 57840 8 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165464 165488 24 0.0
.flash.text 834242 834242 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 905103 905103 0 0.0
(read/write) 421956 421980 24 0.0
.dram0.bss 63224 63232 8 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 193388 193404 16 0.0
.flash.text 899719 899719 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 710268 710288 20 0.0
.bss 77316 77316 0 0.0
.data 1924 1924 0 0.0
.text 625228 625248 20 0.0
lock-app k32w061+debug (read/write) 600480 600500 20 0.0
.bss 67756 67756 0 0.0
.data 1892 1892 0 0.0
.text 525032 525052 20 0.0
shell k32w061+debug (read/write) 665960 665988 28 0.0
.bss 78916 78924 8 0.0
.data 1860 1860 0 0.0
.text 579384 579404 20 0.0
linux all-clusters-app debug (read only) 1752673 1752697 24 0.0
(read/write) 129432 129464 32 0.0
.bss 58576 58608 32 0.1
.data 1138 1138 0 0.0
.data.rel.ro 64400 64400 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138485 138485 0 0.0
.text 1476178 1476178 0 0.0
bridge-app debug+rpc (read only) 1331405 1331429 24 0.0
(read/write) 77408 77472 64 0.1
.bss 41488 41520 32 0.1
.data 1680 1680 0 0.0
.data.rel.ro 29200 29232 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113044 113044 0 0.0
.text 1118581 1118581 0 0.0
chip-tool debug (read only) 5939053 5940269 1216 0.0
(read/write) 196776 196840 64 0.0
.bss 39896 39896 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 148936 149000 64 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283922 283922 0 0.0
.text 5272773 5273797 1024 0.0
lighting-app debug+rpc (read only) 1602017 1602041 24 0.0
(read/write) 110688 110720 32 0.0
.bss 47216 47216 0 0.0
.data 1330 1330 0 0.0
.data.rel.ro 56800 56832 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131409 131409 0 0.0
.text 1333202 1333202 0 0.0
ota-provider-app debug (read only) 1296153 1296177 24 0.0
(read/write) 75928 75928 0 0.0
.bss 44128 44128 0 0.0
.data 880 880 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114831 114831 0 0.0
.text 1081282 1081282 0 0.0
ota-requestor-app debug (read only) 1392673 1392697 24 0.0
(read/write) 79792 79824 32 0.0
.bss 46592 46592 0 0.0
.data 944 944 0 0.0
.data.rel.ro 27112 27144 32 0.1
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126240 126240 0 0.0
.text 1163602 1163602 0 0.0
shell debug (read only) 820313 820313 0 0.0
(read/write) 66584 66584 0 0.0
.bss 23272 23272 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38440 38440 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79119 79119 0 0.0
.text 634770 634770 0 0.0
tv-app debug (read only) 1901081 1901105 24 0.0
(read/write) 319704 319704 0 0.0
.bss 249976 249976 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61184 61184 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159317 159317 0 0.0
.text 1593874 1593874 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293064 2293088 24 0.0
.bss 180388 180388 0 0.0
.data 5240 5240 0 0.0
.heap 850816 850816 0 0.0
.text 1255664 1255688 24 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2277344 2277368 24 0.0
.bss 172292 172300 8 0.0
.data 5592 5592 0 0.0
.heap 858560 858552 -8 -0.0
.text 1239944 1239968 24 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2251664 2251688 24 0.0
.bss 171108 171116 8 0.0
.data 5576 5576 0 0.0
.heap 859760 859752 -8 -0.0
.text 1214264 1214288 24 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051224 2051224 0 0.0
.bss 156320 156320 0 0.0
.data 4984 4984 0 0.0
.heap 875144 875144 0 0.0
.text 1013824 1013824 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 870183 870235 52 0.0
bss 112640 112644 4 0.0
rodata 96784 96804 20 0.0
text 585136 585136 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 832551 832603 52 0.0
bss 108992 108996 4 0.0
rodata 87968 87988 20 0.0
text 559304 559304 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795222 795242 20 0.0
bss 114012 114016 4 0.0
rodata 92040 92060 20 0.0
text 514600 514600 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 842299 842319 20 0.0
bss 109672 109676 4 0.0
rodata 92788 92808 20 0.0
text 564380 564380 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 767586 767606 20 0.0
bss 111084 111088 4 0.0
rodata 88076 88096 20 0.0
text 493936 493936 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 848407 848427 20 0.0
bss 109812 109816 4 0.0
rodata 94496 94516 20 0.0
text 568560 568560 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841999 842019 20 0.0
bss 109708 109712 4 0.0
rodata 92744 92764 20 0.0
text 564000 564000 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778907 778907 0 0.0
bss 109184 109184 0 0.0
rodata 73304 73304 0 0.0
text 521828 521828 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693962 693962 0 0.0
bss 110168 110168 0 0.0
rodata 67948 67948 0 0.0
text 442436 442436 0 0.0
p6 all-clusters-app default (read/write) 2306904 2306920 16 0.0
.bss 113376 113384 8 0.0
.data 2536 2536 0 0.0
.heap 917432 917424 -8 -0.0
.text 1265168 1265184 16 0.0
lock-app default (read/write) 2218904 2218920 16 0.0
.bss 100968 100976 8 0.0
.data 2416 2416 0 0.0
.heap 929960 929952 -8 -0.0
.text 1177168 1177184 16 0.0
qpg lighting-app qpg6100+debug (read only) 497012 497032 20 0.0
(read/write) 114140 114140 0 0.0
.bss 50360 50368 8 0.0
.data 1020 1020 0 0.0
.text 491692 491712 20 0.0
lock-app qpg6100+debug (read only) 470916 470936 20 0.0
(read/write) 114144 114144 0 0.0
.bss 49232 49240 8 0.0
.data 976 976 0 0.0
.text 465596 465616 20 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 771514 771550 36 0.0
bss 79216 79220 4 0.0
noinit 37160 37160 0 0.0
text 535570 535570 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 24, 2021 •
edited
Loading

PR #12177: Size comparison from b87d1fa to 9b0c7bd

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b87d1fa 9b0c7bd change % change
efr32 lighting-app BRD4161A (read only) 757072 757088 16 0.0
.text 757064 757080 16 0.0
BRD4161A+rpc (read only) 744524 744548 24 0.0
.text 744516 744540 24 0.0
lock-app BRD4161A (read only) 732936 732960 24 0.0
.text 732928 732952 24 0.0
window-app BRD4161A (read only) 736368 736392 24 0.0
.text 736360 736384 24 0.0
esp32 all-clusters-app c3devkit (read/write) 1222362 1222402 40 0.0
.dram0.bss 57824 57832 8 0.0
.flash.rodata 165184 165208 24 0.0
m5stack (read/write) 421676 421708 32 0.0
.dram0.bss 63216 63224 8 0.0
.flash.rodata 193108 193132 24 0.0
k32w lighting-app k32w061+se05x+release (read/write) 711816 711844 28 0.0
.bss 78132 78140 8 0.0
.text 625948 625968 20 0.0
lock-app k32w061+debug (read/write) 602028 602056 28 0.0
.bss 68572 68580 8 0.0
.text 525752 525772 20 0.0
shell k32w061+debug (read/write) 667520 667540 20 0.0
.text 580108 580128 20 0.0
linux all-clusters-app debug (read only) 1765289 1765313 24 0.0
(read/write) 129432 129464 32 0.0
.data.rel.ro 64384 64416 32 0.0
bridge-app debug+rpc (read only) 1340837 1340861 24 0.0
chip-tool debug (read only) 5957109 5957133 24 0.0
(read/write) 197104 197136 32 0.0
.data.rel.ro 149320 149352 32 0.0
lighting-app debug+rpc (read only) 1614113 1614137 24 0.0
(read/write) 110656 110688 32 0.0
.data.rel.ro 56784 56816 32 0.1
ota-provider-app debug (read only) 1305001 1305025 24 0.0
(read/write) 75864 75928 64 0.1
.bss 44064 44096 32 0.1
.data.rel.ro 25736 25768 32 0.1
ota-requestor-app debug (read only) 1401537 1401561 24 0.0
tv-app debug (read only) 1910681 1910737 56 0.0
(read/write) 319624 319656 32 0.0
.data.rel.ro 61136 61168 32 0.1
.rodata 159208 159240 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293808 2293824 16 0.0
.text 1256408 1256424 16 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2278008 2278024 16 0.0
.text 1240608 1240624 16 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2252392 2252408 16 0.0
.text 1214992 1215008 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 870919 870939 20 0.0
bss 112628 112632 4 0.0
rodata 96496 96516 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 833287 833307 20 0.0
bss 108980 108984 4 0.0
rodata 87680 87700 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795962 795982 20 0.0
bss 114000 114004 4 0.0
rodata 91756 91776 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 843011 843031 20 0.0
bss 109660 109664 4 0.0
rodata 92500 92520 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 768282 768334 52 0.0
bss 111072 111076 4 0.0
rodata 87788 87808 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 849143 849163 20 0.0
bss 109800 109804 4 0.0
rodata 94208 94228 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 842703 842755 52 0.0
bss 109696 109700 4 0.0
rodata 92456 92476 20 0.0
p6 all-clusters-app default (read/write) 2309128 2309144 16 0.0
.bss 113368 113376 8 0.0
.text 1267392 1267408 16 0.0
lock-app default (read/write) 2221128 2221144 16 0.0
.text 1179392 1179408 16 0.0
qpg lighting-app qpg6100+debug (read only) 498664 498684 20 0.0
.text 493344 493364 20 0.0
lock-app qpg6100+debug (read only) 472568 472588 20 0.0
.text 467248 467268 20 0.0
telink lighting-app tlsr9518adk80d (read/write) 772310 772330 20 0.0
bss 79204 79208 4 0.0
Decreases (1 build for p6)
platform target config section b87d1fa 9b0c7bd change % change
p6 all-clusters-app default .heap 917432 917424 -8 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b87d1fa 9b0c7bd change % change
efr32 lighting-app BRD4161A (read only) 757072 757088 16 0.0
(read/write) 119788 119788 0 0.0
.bss 117972 117972 0 0.0
.data 1816 1816 0 0.0
.text 757064 757080 16 0.0
BRD4161A+rpc (read only) 744524 744548 24 0.0
(read/write) 136416 136416 0 0.0
.bss 134476 134476 0 0.0
.data 1940 1940 0 0.0
.text 744516 744540 24 0.0
lock-app BRD4161A (read only) 732936 732960 24 0.0
(read/write) 117508 117508 0 0.0
.bss 115732 115732 0 0.0
.data 1772 1772 0 0.0
.text 732928 732952 24 0.0
window-app BRD4161A (read only) 736368 736392 24 0.0
(read/write) 117868 117868 0 0.0
.bss 116084 116084 0 0.0
.data 1780 1780 0 0.0
.text 736360 736384 24 0.0
esp32 all-clusters-app c3devkit (read only) 835272 835272 0 0.0
(read/write) 1222362 1222402 40 0.0
.dram0.bss 57824 57832 8 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165184 165208 24 0.0
.flash.text 835272 835272 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 906691 906691 0 0.0
(read/write) 421676 421708 32 0.0
.dram0.bss 63216 63224 8 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193108 193132 24 0.0
.flash.text 901307 901307 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 711816 711844 28 0.0
.bss 78132 78140 8 0.0
.data 1936 1936 0 0.0
.text 625948 625968 20 0.0
lock-app k32w061+debug (read/write) 602028 602056 28 0.0
.bss 68572 68580 8 0.0
.data 1904 1904 0 0.0
.text 525752 525772 20 0.0
shell k32w061+debug (read/write) 667520 667540 20 0.0
.bss 79740 79740 0 0.0
.data 1872 1872 0 0.0
.text 580108 580128 20 0.0
linux all-clusters-app debug (read only) 1765289 1765313 24 0.0
(read/write) 129432 129464 32 0.0
.bss 58576 58576 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64384 64416 32 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138357 138357 0 0.0
.text 1488946 1488946 0 0.0
bridge-app debug+rpc (read only) 1340837 1340861 24 0.0
(read/write) 77376 77376 0 0.0
.bss 41488 41488 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29184 29184 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 112924 112924 0 0.0
.text 1128181 1128181 0 0.0
chip-tool debug (read only) 5957109 5957133 24 0.0
(read/write) 197104 197136 32 0.0
.bss 39840 39840 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 149320 149352 32 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283848 283848 0 0.0
.text 5289941 5289941 0 0.0
lighting-app debug+rpc (read only) 1614113 1614137 24 0.0
(read/write) 110656 110688 32 0.0
.bss 47184 47184 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56784 56816 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131281 131281 0 0.0
.text 1345474 1345474 0 0.0
ota-provider-app debug (read only) 1305001 1305025 24 0.0
(read/write) 75864 75928 64 0.1
.bss 44064 44096 32 0.1
.data 912 912 0 0.0
.data.rel.ro 25736 25768 32 0.1
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114704 114704 0 0.0
.text 1090306 1090306 0 0.0
ota-requestor-app debug (read only) 1401537 1401561 24 0.0
(read/write) 79760 79760 0 0.0
.bss 46528 46528 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27096 27096 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126144 126144 0 0.0
.text 1172610 1172610 0 0.0
shell debug (read only) 818721 818721 0 0.0
(read/write) 66520 66520 0 0.0
.bss 23240 23240 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38392 38392 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78991 78991 0 0.0
.text 633378 633378 0 0.0
tv-app debug (read only) 1910681 1910737 56 0.0
(read/write) 319624 319656 32 0.0
.bss 249928 249928 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61136 61168 32 0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159208 159240 32 0.0
.text 1603634 1603634 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293808 2293824 16 0.0
.bss 180380 180380 0 0.0
.data 5240 5240 0 0.0
.heap 850824 850824 0 0.0
.text 1256408 1256424 16 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278008 2278024 16 0.0
.bss 172284 172284 0 0.0
.data 5600 5600 0 0.0
.heap 858560 858560 0 0.0
.text 1240608 1240624 16 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252392 2252408 16 0.0
.bss 171100 171100 0 0.0
.data 5584 5584 0 0.0
.heap 859760 859760 0 0.0
.text 1214992 1215008 16 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050648 2050648 0 0.0
.bss 156304 156304 0 0.0
.data 4984 4984 0 0.0
.heap 875160 875160 0 0.0
.text 1013248 1013248 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 870919 870939 20 0.0
bss 112628 112632 4 0.0
rodata 96496 96516 20 0.0
text 586156 586156 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 833287 833307 20 0.0
bss 108980 108984 4 0.0
rodata 87680 87700 20 0.0
text 560324 560324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795962 795982 20 0.0
bss 114000 114004 4 0.0
rodata 91756 91776 20 0.0
text 515616 515616 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 843011 843031 20 0.0
bss 109660 109664 4 0.0
rodata 92500 92520 20 0.0
text 565400 565400 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 768282 768334 52 0.0
bss 111072 111076 4 0.0
rodata 87788 87808 20 0.0
text 494952 494952 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 849143 849163 20 0.0
bss 109800 109804 4 0.0
rodata 94208 94228 20 0.0
text 569580 569580 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 842703 842755 52 0.0
bss 109696 109700 4 0.0
rodata 92456 92476 20 0.0
text 565020 565020 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778311 778311 0 0.0
bss 109168 109168 0 0.0
rodata 72996 72996 0 0.0
text 521532 521532 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693350 693350 0 0.0
bss 110152 110152 0 0.0
rodata 67640 67640 0 0.0
text 442140 442140 0 0.0
p6 all-clusters-app default (read/write) 2309128 2309144 16 0.0
.bss 113368 113376 8 0.0
.data 2544 2544 0 0.0
.heap 917432 917424 -8 -0.0
.text 1267392 1267408 16 0.0
lock-app default (read/write) 2221128 2221144 16 0.0
.bss 100960 100960 0 0.0
.data 2416 2416 0 0.0
.heap 929968 929968 0 0.0
.text 1179392 1179408 16 0.0
qpg lighting-app qpg6100+debug (read only) 498664 498684 20 0.0
(read/write) 114140 114140 0 0.0
.bss 50368 50368 0 0.0
.data 1020 1020 0 0.0
.text 493344 493364 20 0.0
lock-app qpg6100+debug (read only) 472568 472588 20 0.0
(read/write) 114144 114144 0 0.0
.bss 49240 49240 0 0.0
.data 976 976 0 0.0
.text 467248 467268 20 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 772310 772330 20 0.0
bss 79204 79208 4 0.0
noinit 37160 37160 0 0.0
text 536388 536388 0 0.0

@andy31415
Copy link
Contributor

fast track: this just enables zap configurations on mandatory fields

@andy31415 andy31415 merged commit a9656d5 into project-chip:master Nov 24, 2021
@yufengwangca yufengwangca deleted the pr/featuremap/general branch November 24, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinh0 austinh0 austinh0 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller darwin examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @andy31415 @austinh0