Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app] decouple CASESession from OperationalDevice #12148

Merged
merged 2 commits into from
Dec 8, 2021
Merged

[app] decouple CASESession from OperationalDevice #12148

merged 2 commits into from
Dec 8, 2021

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Nov 23, 2021

Problem

There is an CASESession object in each OperationalDevice. The CASESession object is large and won't be used after authentication. For device-to-device communication such as binding, the object size will be a concern.

Change overview

This change decouples CASESession from OperationalDevice. Now the device will dynamically allocate from a session pool and release it after being authenticated.

Testing

Tested with chip-tool pairing and chip-tool onoff toggle

@gjc13
Copy link
Contributor Author

gjc13 commented Dec 3, 2021 •
edited
Loading

@gjc13 What are the next steps here? Agree the magic number of 2 seems not applicable for many SDK clients.

The number of outbound clients has been made configurable. For device controllers the limit has been also increased to 16. @woody-apple @msandstedt PTAL.

@gjc13 gjc13 force-pushed the device-session-decouple branch from 68995eb to bcba7a3 Compare December 3, 2021 06:02
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12148: Size comparison from f111727 to bcba7a3

Increases above 0.2%:

platform target config section f111727 bcba7a3 change % change
linux ota-requestor-app debug .rodata 133776 134192 416 0.3
tv-app debug (read/write) 320000 340160 20160 6.3
.bss 247224 267256 20032 8.1
Increases (3 builds for linux)
platform target config section f111727 bcba7a3 change % change
linux chip-tool debug (read only) 6622533 6625629 3096 0.0
(read/write) 202376 202536 160 0.1
.data.rel.ro 161208 161344 136 0.1
.rodata 307640 307992 352 0.1
.text 5904133 5906661 2528 0.0
ota-requestor-app debug (read only) 1490137 1491721 1584 0.1
.rodata 133776 134192 416 0.3
.text 1247666 1248882 1216 0.1
tv-app debug (read only) 2020441 2023569 3128 0.2
(read/write) 320000 340160 20160 6.3
.bss 247224 267256 20032 8.1
.data.rel.ro 64200 64344 144 0.2
.rodata 173608 173992 384 0.2
.text 1692354 1694882 2528 0.1
Decreases (1 build for linux)
platform target config section f111727 bcba7a3 change % change
linux ota-requestor-app debug (read/write) 76784 76752 -32 -0.0
.data.rel.ro 29592 29576 -16 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f111727 bcba7a3 change % change
efr32 lighting-app BRD4161A (read only) 751536 751536 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751528 751528 0 0.0
BRD4161A+rpc (read only) 780216 780216 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780208 780208 0 0.0
lock-app BRD4161A (read only) 725392 725392 0 0.0
(read/write) 117736 117736 0 0.0
.bss 115952 115952 0 0.0
.data 1784 1784 0 0.0
.text 725384 725384 0 0.0
window-app BRD4161A (read only) 728704 728704 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 728696 728696 0 0.0
esp32 all-clusters-app c3devkit (read only) 847818 847818 0 0.0
(read/write) 1223842 1223842 0 0.0
.dram0.bss 56576 56576 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167760 167760 0 0.0
.flash.text 847818 847818 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918227 918227 0 0.0
(read/write) 422820 422820 0 0.0
.dram0.bss 61960 61960 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195564 195564 0 0.0
.flash.text 912843 912843 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728716 728716 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641744 641744 0 0.0
lock-app k32w061+debug (read/write) 617700 617700 0 0.0
.bss 69752 69752 0 0.0
.data 1824 1824 0 0.0
.text 540324 540324 0 0.0
shell k32w061+debug (read/write) 683608 683608 0 0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594612 594612 0 0.0
linux all-clusters-app debug (read only) 1848081 1848081 0 0.0
(read/write) 124520 124520 0 0.0
.bss 50896 50896 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67088 67088 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 148501 148501 0 0.0
.text 1556690 1556690 0 0.0
bridge-app debug+rpc (read only) 1426261 1426261 0 0.0
(read/write) 74616 74616 0 0.0
.bss 36240 36240 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 120652 120652 0 0.0
.text 1200709 1200709 0 0.0
chip-tool debug (read only) 6622533 6625629 3096 0.0
(read/write) 202376 202536 160 0.1
.bss 34504 34504 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 161208 161344 136 0.1
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307640 307992 352 0.1
.text 5904133 5906661 2528 0.0
lighting-app debug+rpc (read only) 1710801 1710801 0 0.0
(read/write) 107648 107648 0 0.0
.bss 41936 41936 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 140721 140721 0 0.0
.text 1427410 1427410 0 0.0
ota-provider-app debug (read only) 1386329 1386329 0 0.0
(read/write) 72816 72816 0 0.0
.bss 38816 38816 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121448 121448 0 0.0
.text 1160194 1160194 0 0.0
ota-requestor-app debug (read only) 1490137 1491721 1584 0.1
(read/write) 76784 76752 -32 -0.0
.bss 40960 40960 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29576 -16 -0.1
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 133776 134192 416 0.3
.text 1247666 1248882 1216 0.1
shell debug (read only) 819625 819625 0 0.0
(read/write) 60584 60584 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3512 3512 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83570 83570 0 0.0
.text 629314 629314 0 0.0
tv-app debug (read only) 2020441 2023569 3128 0.2
(read/write) 320000 340160 20160 6.3
.bss 247224 267256 20032 8.1
.data 2768 2768 0 0.0
.data.rel.ro 64200 64344 144 0.2
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 173608 173992 384 0.2
.text 1692354 1694882 2528 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309224 2309224 0 0.0
.bss 179636 179636 0 0.0
.data 5184 5184 0 0.0
.heap 851624 851624 0 0.0
.text 1271800 1271800 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295616 2295616 0 0.0
.bss 173272 173272 0 0.0
.data 5496 5496 0 0.0
.heap 857680 857680 0 0.0
.text 1258216 1258216 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268648 2268648 0 0.0
.bss 172088 172088 0 0.0
.data 5496 5496 0 0.0
.heap 858864 858864 0 0.0
.text 1231248 1231248 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046960 2046960 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009560 1009560 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891475 891475 0 0.0
bss 113756 113756 0 0.0
rodata 99428 99428 0 0.0
text 602740 602740 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 854851 854851 0 0.0
bss 110104 110104 0 0.0
rodata 90788 90788 0 0.0
text 577736 577736 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817370 817370 0 0.0
bss 115128 115128 0 0.0
rodata 94684 94684 0 0.0
text 533076 533076 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862331 862331 0 0.0
bss 110792 110792 0 0.0
rodata 95164 95164 0 0.0
text 580992 580992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788486 788486 0 0.0
bss 112204 112204 0 0.0
rodata 90456 90456 0 0.0
text 511420 511420 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868347 868347 0 0.0
bss 110928 110928 0 0.0
rodata 96900 96900 0 0.0
text 585056 585056 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861411 861411 0 0.0
bss 110808 110808 0 0.0
rodata 95036 95036 0 0.0
text 580116 580116 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779891 779891 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521908 521908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442512 442512 0 0.0
p6 all-clusters-app default (read/write) 2339504 2339504 0 0.0
.bss 107820 107820 0 0.0
.data 2456 2456 0 0.0
.heap 923064 923064 0 0.0
.text 1297768 1297768 0 0.0
light-app default (read/write) 2278856 2278856 0 0.0
.bss 98504 98504 0 0.0
.data 2336 2336 0 0.0
.heap 932504 932504 0 0.0
.text 1237120 1237120 0 0.0
lock-app default (read/write) 2254208 2254208 0 0.0
.bss 97160 97160 0 0.0
.data 2296 2296 0 0.0
.heap 933888 933888 0 0.0
.text 1212472 1212472 0 0.0
qpg lighting-app qpg6100+debug (read only) 510500 510500 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505180 505180 0 0.0
lock-app qpg6100+debug (read only) 483308 483308 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79184 79184 0 0.0
.data 916 916 0 0.0
.text 477988 477988 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794566 794566 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554526 554526 0 0.0

@gjc13 gjc13 force-pushed the device-session-decouple branch from bcba7a3 to 9342cd8 Compare December 3, 2021 07:53
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12148: Size comparison from 70af2c4 to 9342cd8

Increases above 0.2%:

platform target config section 70af2c4 9342cd8 change % change
linux ota-requestor-app debug .rodata 134096 134512 416 0.3
tv-app debug (read/write) 320000 340160 20160 6.3
.bss 247224 267256 20032 8.1
Increases (3 builds for linux)
platform target config section 70af2c4 9342cd8 change % change
linux chip-tool debug (read only) 6684229 6687341 3112 0.0
(read/write) 202376 202536 160 0.1
.data.rel.ro 161208 161344 136 0.1
.rodata 308504 308856 352 0.1
.text 5964965 5967509 2544 0.0
ota-requestor-app debug (read only) 1493337 1494921 1584 0.1
.rodata 134096 134512 416 0.3
.text 1250546 1251762 1216 0.1
tv-app debug (read only) 2022841 2025937 3096 0.2
(read/write) 320000 340160 20160 6.3
.bss 247224 267256 20032 8.1
.data.rel.ro 64200 64344 144 0.2
.rodata 173960 174312 352 0.2
.text 1694402 1696930 2528 0.1
Decreases (1 build for linux)
platform target config section 70af2c4 9342cd8 change % change
linux ota-requestor-app debug (read/write) 76784 76752 -32 -0.0
.data.rel.ro 29592 29576 -16 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 70af2c4 9342cd8 change % change
efr32 lighting-app BRD4161A (read only) 751848 751848 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751840 751840 0 0.0
BRD4161A+rpc (read only) 780512 780512 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780504 780504 0 0.0
lock-app BRD4161A (read only) 725704 725704 0 0.0
(read/write) 117736 117736 0 0.0
.bss 115952 115952 0 0.0
.data 1784 1784 0 0.0
.text 725696 725696 0 0.0
window-app BRD4161A (read only) 729016 729016 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 729008 729008 0 0.0
esp32 all-clusters-app c3devkit (read only) 847956 847956 0 0.0
(read/write) 1224026 1224026 0 0.0
.dram0.bss 56576 56576 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167944 167944 0 0.0
.flash.text 847956 847956 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918355 918355 0 0.0
(read/write) 422996 422996 0 0.0
.dram0.bss 61960 61960 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195740 195740 0 0.0
.flash.text 912971 912971 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728748 728748 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641776 641776 0 0.0
lock-app k32w061+debug (read/write) 617700 617700 0 0.0
.bss 69752 69752 0 0.0
.data 1824 1824 0 0.0
.text 540324 540324 0 0.0
shell k32w061+debug (read/write) 683608 683608 0 0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594612 594612 0 0.0
linux all-clusters-app debug (read only) 1848689 1848689 0 0.0
(read/write) 124520 124520 0 0.0
.bss 50896 50896 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67088 67088 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 148725 148725 0 0.0
.text 1557074 1557074 0 0.0
bridge-app debug+rpc (read only) 1426837 1426837 0 0.0
(read/write) 74616 74616 0 0.0
.bss 36240 36240 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 120844 120844 0 0.0
.text 1201093 1201093 0 0.0
chip-tool debug (read only) 6684229 6687341 3112 0.0
(read/write) 202376 202536 160 0.1
.bss 34504 34504 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 161208 161344 136 0.1
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 308504 308856 352 0.1
.text 5964965 5967509 2544 0.0
lighting-app debug+rpc (read only) 1711985 1711985 0 0.0
(read/write) 107648 107648 0 0.0
.bss 41936 41936 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 141521 141521 0 0.0
.text 1427794 1427794 0 0.0
ota-provider-app debug (read only) 1386889 1386889 0 0.0
(read/write) 72816 72816 0 0.0
.bss 38816 38816 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121608 121608 0 0.0
.text 1160594 1160594 0 0.0
ota-requestor-app debug (read only) 1493337 1494921 1584 0.1
(read/write) 76784 76752 -32 -0.0
.bss 40960 40960 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29576 -16 -0.1
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 134096 134512 416 0.3
.text 1250546 1251762 1216 0.1
shell debug (read only) 819625 819625 0 0.0
(read/write) 60584 60584 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3512 3512 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83570 83570 0 0.0
.text 629314 629314 0 0.0
tv-app debug (read only) 2022841 2025937 3096 0.2
(read/write) 320000 340160 20160 6.3
.bss 247224 267256 20032 8.1
.data 2768 2768 0 0.0
.data.rel.ro 64200 64344 144 0.2
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 173960 174312 352 0.2
.text 1694402 1696930 2528 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309544 2309544 0 0.0
.bss 179636 179636 0 0.0
.data 5184 5184 0 0.0
.heap 851624 851624 0 0.0
.text 1272120 1272120 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295872 2295872 0 0.0
.bss 173272 173272 0 0.0
.data 5496 5496 0 0.0
.heap 857680 857680 0 0.0
.text 1258472 1258472 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268904 2268904 0 0.0
.bss 172088 172088 0 0.0
.data 5496 5496 0 0.0
.heap 858864 858864 0 0.0
.text 1231504 1231504 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046960 2046960 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009560 1009560 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891767 891767 0 0.0
bss 113756 113756 0 0.0
rodata 99608 99608 0 0.0
text 602860 602860 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 855143 855143 0 0.0
bss 110104 110104 0 0.0
rodata 90968 90968 0 0.0
text 577856 577856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817678 817678 0 0.0
bss 115128 115128 0 0.0
rodata 94864 94864 0 0.0
text 533196 533196 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862591 862591 0 0.0
bss 110792 110792 0 0.0
rodata 95344 95344 0 0.0
text 581080 581080 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788746 788746 0 0.0
bss 112204 112204 0 0.0
rodata 90636 90636 0 0.0
text 511508 511508 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868607 868607 0 0.0
bss 110928 110928 0 0.0
rodata 97080 97080 0 0.0
text 585144 585144 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861671 861671 0 0.0
bss 110808 110808 0 0.0
rodata 95216 95216 0 0.0
text 580204 580204 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779891 779891 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521908 521908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442512 442512 0 0.0
p6 all-clusters-app default (read/write) 2339800 2339800 0 0.0
.bss 107820 107820 0 0.0
.data 2456 2456 0 0.0
.heap 923064 923064 0 0.0
.text 1298064 1298064 0 0.0
light-app default (read/write) 2279168 2279168 0 0.0
.bss 98504 98504 0 0.0
.data 2336 2336 0 0.0
.heap 932504 932504 0 0.0
.text 1237432 1237432 0 0.0
lock-app default (read/write) 2254504 2254504 0 0.0
.bss 97160 97160 0 0.0
.data 2296 2296 0 0.0
.heap 933888 933888 0 0.0
.text 1212768 1212768 0 0.0
qpg lighting-app qpg6100+debug (read only) 510540 510540 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505220 505220 0 0.0
lock-app qpg6100+debug (read only) 483308 483308 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79184 79184 0 0.0
.data 916 916 0 0.0
.text 477988 477988 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794862 794862 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554638 554638 0 0.0

@gjc13 gjc13 requested a review from msandstedt December 3, 2021 08:13
@gjc13 gjc13 force-pushed the device-session-decouple branch from 9342cd8 to 1b09c8c Compare December 6, 2021 11:27
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12148: Size comparison from bfdbd45 to 1b09c8c

Increases above 0.2%:

platform target config section bfdbd45 1b09c8c change % change
linux ota-requestor-app debug .rodata 135600 135952 352 0.3
tv-app debug (read/write) 320032 359840 39808 12.4
.bss 247288 286840 39552 16.0
.data.rel.ro 64168 64424 256 0.4
.rodata 174352 174832 480 0.3
Increases (3 builds for linux)
platform target config section bfdbd45 1b09c8c change % change
linux chip-tool debug (read only) 6628165 6632317 4152 0.1
(read/write) 199752 200040 288 0.1
.data.rel.ro 158520 158808 288 0.2
.rodata 310776 311032 256 0.1
.text 5912661 5916053 3392 0.1
ota-requestor-app debug (read only) 1510209 1511745 1536 0.1
.rodata 135600 135952 352 0.3
.text 1265970 1267202 1232 0.1
tv-app debug (read only) 2046473 2050849 4376 0.2
(read/write) 320032 359840 39808 12.4
.bss 247288 286840 39552 16.0
.data.rel.ro 64168 64424 256 0.4
.rodata 174352 174832 480 0.3
.text 1717378 1720770 3392 0.2
Decreases (1 build for linux)
platform target config section bfdbd45 1b09c8c change % change
linux ota-requestor-app debug (read/write) 77896 77864 -32 -0.0
.data.rel.ro 29656 29640 -16 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bfdbd45 1b09c8c change % change
efr32 lighting-app BRD4161A (read only) 758896 758896 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 758888 758888 0 0.0
BRD4161A+rpc (read only) 787544 787544 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 787536 787536 0 0.0
lock-app BRD4161A (read only) 733952 733952 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 733944 733944 0 0.0
window-app BRD4161A (read only) 736224 736224 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 736216 736216 0 0.0
esp32 all-clusters-app c3devkit (read only) 852538 852538 0 0.0
(read/write) 1290914 1290914 0 0.0
.dram0.bss 56352 56352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 169520 169520 0 0.0
.flash.text 852538 852538 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 922399 922399 0 0.0
(read/write) 424356 424356 0 0.0
.dram0.bss 61736 61736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 197324 197324 0 0.0
.flash.text 917015 917015 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731908 731908 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644936 644936 0 0.0
lock-app k32w061+debug (read/write) 622076 622076 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 544472 544472 0 0.0
shell k32w061+debug (read/write) 687968 687968 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598744 598744 0 0.0
linux all-clusters-app debug (read only) 1872825 1872825 0 0.0
(read/write) 124336 124336 0 0.0
.bss 50672 50672 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152117 152117 0 0.0
.text 1577602 1577602 0 0.0
bridge-app debug+rpc (read only) 1444277 1444277 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121500 121500 0 0.0
.text 1217877 1217877 0 0.0
chip-tool debug (read only) 6628165 6632317 4152 0.1
(read/write) 199752 200040 288 0.1
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158808 288 0.2
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 310776 311032 256 0.1
.text 5912661 5916053 3392 0.1
lighting-app debug+rpc (read only) 1729441 1729441 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142161 142161 0 0.0
.text 1444610 1444610 0 0.0
ota-provider-app debug (read only) 1400953 1400953 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122856 122856 0 0.0
.text 1173410 1173410 0 0.0
ota-requestor-app debug (read only) 1510209 1511745 1536 0.1
(read/write) 77896 77864 -32 -0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29640 -16 -0.1
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135600 135952 352 0.3
.text 1265970 1267202 1232 0.1
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046473 2050849 4376 0.2
(read/write) 320032 359840 39808 12.4
.bss 247288 286840 39552 16.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64424 256 0.4
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174352 174832 480 0.3
.text 1717378 1720770 3392 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313152 2313152 0 0.0
.bss 179404 179404 0 0.0
.data 5184 5184 0 0.0
.heap 851856 851856 0 0.0
.text 1275728 1275728 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299096 2299096 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1261696 1261696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273088 2273088 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1235688 1235688 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894879 894879 0 0.0
bss 113756 113756 0 0.0
rodata 99680 99680 0 0.0
text 605896 605896 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 858255 858255 0 0.0
bss 110104 110104 0 0.0
rodata 91040 91040 0 0.0
text 580892 580892 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820790 820790 0 0.0
bss 115128 115128 0 0.0
rodata 94936 94936 0 0.0
text 536232 536232 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 866899 866899 0 0.0
bss 111016 111016 0 0.0
rodata 95796 95796 0 0.0
text 584708 584708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793050 793050 0 0.0
bss 112428 112428 0 0.0
rodata 91084 91084 0 0.0
text 515132 515132 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871683 871683 0 0.0
bss 110928 110928 0 0.0
rodata 97148 97148 0 0.0
text 588156 588156 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864927 864927 0 0.0
bss 110808 110808 0 0.0
rodata 95288 95288 0 0.0
text 583388 583388 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2349448 2349448 0 0.0
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1307712 1307712 0 0.0
light-app default (read/write) 2284072 2284072 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1242336 1242336 0 0.0
lock-app default (read/write) 2260624 2260624 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1218888 1218888 0 0.0
qpg lighting-app qpg6100+debug (read only) 513724 513724 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 508404 508404 0 0.0
lock-app qpg6100+debug (read only) 487464 487464 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 482144 482144 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798382 798382 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 558088 558088 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple
Copy link
Contributor

@pan-apple @bzbarsky-apple ?

@woody-apple woody-apple force-pushed the device-session-decouple branch from 1b09c8c to 4048ea4 Compare December 6, 2021 21:38
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12148: Size comparison from a1cb341 to 4048ea4

Increases above 0.2%:

platform target config section a1cb341 4048ea4 change % change
linux ota-requestor-app debug .rodata 136823 137207 384 0.3
tv-app debug (read/write) 320320 360128 39808 12.4
.bss 247480 287032 39552 16.0
.data.rel.ro 64240 64496 256 0.4
.rodata 175532 175980 448 0.3
Increases (4 builds for esp32, linux)
platform target config section a1cb341 4048ea4 change % change
esp32 all-clusters-app m5stack (read only) 956539 956887 348 0.0
(read/write) 439528 439616 88 0.0
.flash.rodata 208132 208220 88 0.0
.flash.text 951155 951503 348 0.0
linux chip-tool debug (read only) 6652053 6656205 4152 0.1
(read/write) 200040 200296 256 0.1
.data.rel.ro 158600 158872 272 0.2
.rodata 313873 314129 256 0.1
.text 5933285 5936677 3392 0.1
ota-requestor-app debug (read only) 1517249 1518817 1568 0.1
.rodata 136823 137207 384 0.3
.text 1271618 1272850 1232 0.1
tv-app debug (read only) 2052297 2056625 4328 0.2
(read/write) 320320 360128 39808 12.4
.bss 247480 287032 39552 16.0
.data.rel.ro 64240 64496 256 0.4
.rodata 175532 175980 448 0.3
.text 1721858 1725234 3376 0.2
Decreases (1 build for linux)
platform target config section a1cb341 4048ea4 change % change
linux ota-requestor-app debug (read/write) 78152 78120 -32 -0.0
.data.rel.ro 29720 29704 -16 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a1cb341 4048ea4 change % change
efr32 lighting-app BRD4161A (read only) 797548 797548 0 0.0
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 797540 797540 0 0.0
BRD4161A+rpc (read only) 825516 825516 0 0.0
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 825508 825508 0 0.0
lock-app BRD4161A (read only) 772216 772216 0 0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 772208 772208 0 0.0
window-app BRD4161A (read only) 774504 774504 0 0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 774496 774496 0 0.0
esp32 all-clusters-app c3devkit (read only) 852296 852296 0 0.0
(read/write) 1295154 1295154 0 0.0
.dram0.bss 58232 58232 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 169792 169792 0 0.0
.flash.text 852296 852296 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956539 956887 348 0.0
(read/write) 439528 439616 88 0.0
.dram0.bss 65592 65592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208220 88 0.0
.flash.text 951155 951503 348 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 731576 0 0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644508 644508 0 0.0
lock-app k32w061+debug (read/write) 622292 622292 0 0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544592 544592 0 0.0
shell k32w061+debug (read/write) 688184 688184 0 0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598864 598864 0 0.0
linux all-clusters-app debug (read only) 1871337 1871337 0 0.0
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 153717 153717 0 0.0
.text 1574322 1574322 0 0.0
bridge-app debug+rpc (read only) 1450341 1450341 0 0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 122692 122692 0 0.0
.text 1222581 1222581 0 0.0
chip-tool debug (read only) 6652053 6656205 4152 0.1
(read/write) 200040 200296 256 0.1
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158872 272 0.2
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313873 314129 256 0.1
.text 5933285 5936677 3392 0.1
lighting-app debug+rpc (read only) 1736201 1736201 0 0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143345 143345 0 0.0
.text 1450018 1450018 0 0.0
ota-provider-app debug (read only) 1407897 1407897 0 0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124078 124078 0 0.0
.text 1178962 1178962 0 0.0
ota-requestor-app debug (read only) 1517249 1518817 1568 0.1
(read/write) 78152 78120 -32 -0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29704 -16 -0.1
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136823 137207 384 0.3
.text 1271618 1272850 1232 0.1
shell debug (read only) 823577 823577 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84754 84754 0 0.0
.text 631986 631986 0 0.0
tv-app debug (read only) 2052297 2056625 4328 0.2
(read/write) 320320 360128 39808 12.4
.bss 247480 287032 39552 16.0
.data 2768 2768 0 0.0
.data.rel.ro 64240 64496 256 0.4
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175532 175980 448 0.3
.text 1721858 1725234 3376 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312192 2312192 0 0.0
.bss 181412 181412 0 0.0
.data 5192 5192 0 0.0
.heap 849840 849840 0 0.0
.text 1274768 1274768 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300032 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262632 1262632 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 894603 0 0.0
bss 113852 113852 0 0.0
rodata 99676 99676 0 0.0
text 605532 605532 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 857979 857979 0 0.0
bss 110200 110200 0 0.0
rodata 91036 91036 0 0.0
text 580528 580528 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820502 820502 0 0.0
bss 115224 115224 0 0.0
rodata 94936 94936 0 0.0
text 535856 535856 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 867203 867203 0 0.0
bss 111112 111112 0 0.0
rodata 95796 95796 0 0.0
text 584904 584904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793338 0 0.0
bss 112524 112524 0 0.0
rodata 91084 91084 0 0.0
text 515324 515324 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871939 871939 0 0.0
bss 111024 111024 0 0.0
rodata 97148 97148 0 0.0
text 588304 588304 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865147 0 0.0
bss 110904 110904 0 0.0
rodata 95284 95284 0 0.0
text 583512 583512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346600 2346600 0 0.0
.bss 107692 107692 0 0.0
.data 2464 2464 0 0.0
.heap 923184 923184 0 0.0
.text 1304864 1304864 0 0.0
light-app default (read/write) 2283848 2283848 0 0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1242112 1242112 0 0.0
lock-app default (read/write) 2259984 2259984 0 0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1218248 1218248 0 0.0
qpg lighting-app qpg6100+debug (read only) 513276 513276 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507956 507956 0 0.0
lock-app qpg6100+debug (read only) 487580 487580 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482260 482260 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798390 0 0.0
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557996 557996 0 0.0

@gjc13 gjc13 force-pushed the device-session-decouple branch from 4048ea4 to 44a82d1 Compare December 7, 2021 03:20
@gjc13 gjc13 force-pushed the device-session-decouple branch from 44a82d1 to baef6d6 Compare December 7, 2021 03:25
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12148: Size comparison from 5c70530 to baef6d6

Increases above 0.2%:

platform target config section 5c70530 baef6d6 change % change
linux ota-requestor-app debug .rodata 136823 137207 384 0.3
tv-app debug (read/write) 320320 360128 39808 12.4
.bss 247480 287032 39552 16.0
.data.rel.ro 64240 64496 256 0.4
.rodata 175436 175884 448 0.3
Increases (4 builds for esp32, linux)
platform target config section 5c70530 baef6d6 change % change
esp32 all-clusters-app m5stack (read only) 956475 956823 348 0.0
(read/write) 439528 439616 88 0.0
.flash.rodata 208132 208220 88 0.0
.flash.text 951091 951439 348 0.0
linux chip-tool debug (read only) 6651717 6655789 4072 0.1
(read/write) 200040 200296 256 0.1
.data.rel.ro 158600 158872 272 0.2
.rodata 313777 314033 256 0.1
.text 5933045 5936357 3312 0.1
ota-requestor-app debug (read only) 1516993 1518561 1568 0.1
.rodata 136823 137207 384 0.3
.text 1271362 1272594 1232 0.1
tv-app debug (read only) 2051945 2056209 4264 0.2
(read/write) 320320 360128 39808 12.4
.bss 247480 287032 39552 16.0
.data.rel.ro 64240 64496 256 0.4
.rodata 175436 175884 448 0.3
.text 1721602 1724914 3312 0.2
Decreases (1 build for linux)
platform target config section 5c70530 baef6d6 change % change
linux ota-requestor-app debug (read/write) 78152 78120 -32 -0.0
.data.rel.ro 29720 29704 -16 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5c70530 baef6d6 change % change
efr32 lighting-app BRD4161A (read only) 797468 797468 0 0.0
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 797460 797460 0 0.0
BRD4161A+rpc (read only) 825436 825436 0 0.0
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 825428 825428 0 0.0
lock-app BRD4161A (read only) 772152 772152 0 0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 772144 772144 0 0.0
window-app BRD4161A (read only) 774424 774424 0 0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 774416 774416 0 0.0
esp32 all-clusters-app c3devkit (read only) 852210 852210 0 0.0
(read/write) 1295154 1295154 0 0.0
.dram0.bss 58232 58232 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 169792 169792 0 0.0
.flash.text 852210 852210 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956475 956823 348 0.0
(read/write) 439528 439616 88 0.0
.dram0.bss 65592 65592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208220 88 0.0
.flash.text 951091 951439 348 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731512 731512 0 0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644444 644444 0 0.0
lock-app k32w061+debug (read/write) 622212 622212 0 0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544512 544512 0 0.0
shell k32w061+debug (read/write) 688120 688120 0 0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598800 598800 0 0.0
linux all-clusters-app debug (read only) 1871081 1871081 0 0.0
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 153717 153717 0 0.0
.text 1574066 1574066 0 0.0
bridge-app debug+rpc (read only) 1450101 1450101 0 0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 122692 122692 0 0.0
.text 1222341 1222341 0 0.0
chip-tool debug (read only) 6651717 6655789 4072 0.1
(read/write) 200040 200296 256 0.1
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158872 272 0.2
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313777 314033 256 0.1
.text 5933045 5936357 3312 0.1
lighting-app debug+rpc (read only) 1735881 1735881 0 0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143281 143281 0 0.0
.text 1449762 1449762 0 0.0
ota-provider-app debug (read only) 1407641 1407641 0 0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124078 124078 0 0.0
.text 1178706 1178706 0 0.0
ota-requestor-app debug (read only) 1516993 1518561 1568 0.1
(read/write) 78152 78120 -32 -0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29704 -16 -0.1
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136823 137207 384 0.3
.text 1271362 1272594 1232 0.1
shell debug (read only) 823577 823577 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84754 84754 0 0.0
.text 631986 631986 0 0.0
tv-app debug (read only) 2051945 2056209 4264 0.2
(read/write) 320320 360128 39808 12.4
.bss 247480 287032 39552 16.0
.data 2768 2768 0 0.0
.data.rel.ro 64240 64496 256 0.4
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175436 175884 448 0.3
.text 1721602 1724914 3312 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312128 2312128 0 0.0
.bss 181412 181412 0 0.0
.data 5192 5192 0 0.0
.heap 849840 849840 0 0.0
.text 1274704 1274704 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300032 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262632 1262632 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894539 894539 0 0.0
bss 113852 113852 0 0.0
rodata 99676 99676 0 0.0
text 605460 605460 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 857915 857915 0 0.0
bss 110200 110200 0 0.0
rodata 91036 91036 0 0.0
text 580456 580456 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820438 820438 0 0.0
bss 115224 115224 0 0.0
rodata 94936 94936 0 0.0
text 535784 535784 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 867123 867123 0 0.0
bss 111112 111112 0 0.0
rodata 95796 95796 0 0.0
text 584832 584832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793258 793258 0 0.0
bss 112524 112524 0 0.0
rodata 91084 91084 0 0.0
text 515252 515252 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871859 871859 0 0.0
bss 111024 111024 0 0.0
rodata 97148 97148 0 0.0
text 588232 588232 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865083 865083 0 0.0
bss 110904 110904 0 0.0
rodata 95284 95284 0 0.0
text 583440 583440 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346536 2346536 0 0.0
.bss 107692 107692 0 0.0
.data 2464 2464 0 0.0
.heap 923184 923184 0 0.0
.text 1304800 1304800 0 0.0
light-app default (read/write) 2283768 2283768 0 0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1242032 1242032 0 0.0
lock-app default (read/write) 2259920 2259920 0 0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1218184 1218184 0 0.0
qpg lighting-app qpg6100+debug (read only) 513204 513204 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507884 507884 0 0.0
lock-app qpg6100+debug (read only) 487508 487508 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482188 482188 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798310 798310 0 0.0
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557916 557916 0 0.0

@gjc13
Copy link
Contributor Author

gjc13 commented Dec 8, 2021

@msandstedt PTAL

@andy31415 andy31415 merged commit aba3c81 into project-chip:master Dec 8, 2021
@gjc13 gjc13 mentioned this pull request Dec 9, 2021
Merged
@msandstedt msandstedt mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-apple pan-apple pan-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@vijs vijs Awaiting requested review from vijs

Assignees
No one assigned
Labels
app controller lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gjc13 @woody-apple @tcarmelveilleux @andy31415 @msandstedt @yunhanw-google @pan-apple