dynamic tv apps #12125

chrisdecenzo · 2021-11-23T00:08:01Z

Problem

tv-app does not support dynamic endpoints
tv-app does not provide examples of app-assisted user-directed-commissioning

Change overview

Enable dynamic endpoints in tv-app
Add ContentApp and ContentAppPlatform abstract classes in app/util. These require platform-specific implementations.
Add dummy Linux ContentApp and ContentAppPlatform which maintain a set of ContentApp objects (vids 1, 2, 9050)
ContentApp with matching vendor id can be used during user directed commissioning to obtain the pin-code
Hooked up AppPlatform to apps for AppBasic cluster attribute reads and writes

Testing

From the tv-app shell, to set a pin for a given app:

app setpin [vid] [pincode]

From the tv-app shell, to initiate commissioning for UDC table index 0 using app with matching vid to get the pin:

app commission [udc-entry]

Here is the complete test:

start tv-app:
tv-app shell>./out/host/chip-tv-app --secured-device-port 5640
start tv-casting-app:
tv-casting-app shell>./out/host/chip-tv-casting-app
trigger UDC from tv-casting-app
tv-casting-app shell>0
commission from tv-app using pin code obtained from app corresponding to tv-casting-app vid (usually 9050)
tv-casting-app shell>app commission 0

TODOs for next PR:

add more clusters to the tv-apps

todo · 2021-11-23T00:08:03Z

Need a generated file from ZAP to define these!

connectedhomeip/examples/tv-app/linux/AppPlatform.cpp

Lines 281 to 291 in c1d23e0

    
           // Device types for dynamic endpoints: TODO Need a generated file from ZAP to define these! 
        
           // (taken from chip-devices.xml) 
        
           #define DEVICE_TYPE_CONTENT_APP 0x0024 
        
           // --------------------------------------------------------------------------- 
        
           // 
        
           // CONTENT APP ENDPOINT: contains the following clusters: 
        
           //   - Descriptor 
        
           //   - Application Basic 
        
           // Declare Descriptor cluster attributes

This comment was generated by todo based on a `TODO` comment in `c1d23e0` in #12125. cc @project-chip.

todo · 2021-11-23T00:08:06Z

add missing attributes once schema is updated

connectedhomeip/examples/tv-app/linux/AppPlatform.cpp

Lines 300 to 310 in c1d23e0

    
           // TODO: add missing attributes once schema is updated 
        
           DECLARE_DYNAMIC_ATTRIBUTE_LIST_BEGIN(applicationBasicAttrs) 
        
           DECLARE_DYNAMIC_ATTRIBUTE(ZCL_APPLICATION_VENDOR_NAME_ATTRIBUTE_ID, CHAR_STRING, kNameSize, 0), /* VendorName */ 
        
               DECLARE_DYNAMIC_ATTRIBUTE(ZCL_APPLICATION_VENDOR_ID_ATTRIBUTE_ID, INT16U, 1, 0),            /* VendorID */ 
        
               DECLARE_DYNAMIC_ATTRIBUTE(ZCL_APPLICATION_NAME_ATTRIBUTE_ID, CHAR_STRING, kNameSize, 0),    /* ApplicationName */ 
        
               DECLARE_DYNAMIC_ATTRIBUTE(ZCL_APPLICATION_PRODUCT_ID_ATTRIBUTE_ID, INT16U, 1, 0),           /* ProductID */ 
        
               DECLARE_DYNAMIC_ATTRIBUTE(ZCL_APPLICATION_STATUS_ATTRIBUTE_ID, INT8U, 1, 0)                 /* ApplicationStatus */ 
        
               DECLARE_DYNAMIC_ATTRIBUTE_LIST_END(); 
        
           // Declare Cluster List for Content App endpoint 
        
           DECLARE_DYNAMIC_CLUSTER_LIST_BEGIN(contentAppClusters)

This comment was generated by todo based on a `TODO` comment in `c1d23e0` in #12125. cc @project-chip.

todo · 2021-11-23T00:08:09Z

the definition of DYNAMIC_ENDPOINT_COUNT needs find a common home!

connectedhomeip/examples/tv-app/linux/BUILD.gn

Lines 69 to 78 in c1d23e0

    
             # TODO: the definition of DYNAMIC_ENDPOINT_COUNT needs find a common home! 
        
             cflags += [ "-DDYNAMIC_ENDPOINT_COUNT=16" ] 
        
             if (chip_build_libshell) { 
        
               cflags += [ "-DENABLE_CHIP_SHELL" ] 
        
             } 
        
             output_dir = root_out_dir 
        
           }

This comment was generated by todo based on a `TODO` comment in `c1d23e0` in #12125. cc @project-chip.

todo · 2021-11-23T00:08:12Z

the definition of DYNAMIC_ENDPOINT_COUNT needs find a common home!

connectedhomeip/examples/tv-app/tv-common/BUILD.gn

Lines 26 to 29 in c1d23e0

    
             # TODO: the definition of DYNAMIC_ENDPOINT_COUNT needs find a common home! 
        
             cflags = [ "-DDYNAMIC_ENDPOINT_COUNT=16" ] 
        
           }

This comment was generated by todo based on a `TODO` comment in `c1d23e0` in #12125. cc @project-chip.

github-actions · 2021-11-23T00:29:36Z

PR #12125: Size comparison from 2e16d32 to c1d23e0

Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`2e16d32`	`c1d23e0`
efr32	lighting-app	BRD4161A	(read only)	751376	751376
			(read/write)	119692	119692
			.bss	117884	117884
			.data	1808	1808
			.text	751368	751368
		BRD4161A+rpc	(read only)	738884	738884
			(read/write)	136320	136320
			.bss	134388	134388
			.data	1932	1932
			.text	738876	738876
	lock-app	BRD4161A	(read only)	728448	728448
			(read/write)	117476	117476
			.bss	115708	115708
			.data	1764	1764
			.text	728440	728440
	window-app	BRD4161A	(read only)	731896	731896
			(read/write)	117836	117836
			.bss	116060	116060
			.data	1772	1772
			.text	731888	731888
esp32	all-clusters-app	c3devkit	(read only)	833664	833664
			(read/write)	1222106	1222106
			.dram0.bss	57760	57760
			.dram0.data	14100	14100
			.flash.rodata	164992	164992
			.flash.text	833664	833664
			.iram0.text	61394	61394
		m5stack	(read only)	904711	904711
			(read/write)	421400	421400
			.dram0.bss	63120	63120
			.dram0.data	34064	34064
			.flash.rodata	192936	192936
			.flash.text	899327	899327
			.iram0.text	122943	122943
k32w	lighting-app	k32w061+se05x+release	(read/write)	707928	707928
			.bss	77212	77212
			.data	1920	1920
			.text	622996	622996
	lock-app	k32w061+debug	(read/write)	599368	599368
			.bss	67724	67724
			.data	1888	1888
			.text	523956	523956
	shell	k32w061+debug	(read/write)	664744	664744
			.bss	78884	78884
			.data	1856	1856
			.text	578204	578204
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2290672	2290672
			.bss	180308	180308
			.data	5232	5232
			.heap	850904	850904
			.text	1253272	1253272
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2274800	2274800
			.bss	172212	172212
			.data	5584	5584
			.heap	858648	858648
			.text	1237400	1237400
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2250632	2250632
			.bss	171092	171092
			.data	5576	5576
			.heap	859776	859776
			.text	1213232	1213232
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139744	1139744
			.bss	11752	11752
			.data	4368	4368
			.heap	1020328	1020328
			.text	103128	103128
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2050872	2050872
			.bss	156280	156280
			.data	4976	4976
			.heap	875192	875192
			.text	1013472	1013472
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	865667	865667
			bss	110616	110616
			rodata	95980	95980
			text	583444	583444
		nrf52840dk_nrf52840+rpc	(read/write)	828035	828035
			bss	106972	106972
			rodata	87164	87164
			text	557612	557612
		nrf5340dk_nrf5340_cpuapp	(read/write)	790706	790706
			bss	111992	111992
			rodata	91236	91236
			text	512912	512912
	lock-app	nrf52840dk_nrf52840	(read/write)	841099	841099
			bss	109640	109640
			rodata	92452	92452
			text	563540	563540
		nrf5340dk_nrf5340_cpuapp	(read/write)	766386	766386
			bss	111052	111052
			rodata	87756	87756
			text	493096	493096
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327
			bss	51824	51824
			rodata	45780	45780
			text	339436	339436
	pump-app	nrf52840dk_nrf52840	(read/write)	847207	847207
			bss	109780	109780
			rodata	94160	94160
			text	567720	567720
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	840799	840799
			bss	109676	109676
			rodata	92408	92408
			text	563160	563160
	shell	nrf52840dk_nrf52840	(read/write)	778639	778639
			bss	109160	109160
			rodata	73196	73196
			text	521668	521668
		nrf5340dk_nrf5340_cpuapp	(read/write)	693662	693662
			bss	110144	110144
			rodata	67840	67840
			text	442276	442276
p6	all-clusters-app	default	(read/write)	2303656	2303656
			.bss	113296	113296
			.data	2536	2536
			.heap	917512	917512
			.text	`1261920`	`1261920`
	lock-app	default	(read/write)	2216840	2216840
			.bss	100952	100952
			.data	2408	2408
			.heap	929984	929984
			.text	`1175104`	`1175104`
qpg	lighting-app	qpg6100+debug	(read only)	494680	494680
			(read/write)	114144	114144
			.bss	50264	50264
			.data	1016	1016
			.text	489360	489360
	lock-app	qpg6100+debug	(read only)	469660	469660
			(read/write)	114140	114140
			.bss	49200	49200
			.data	972	972
			.text	464340	464340
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408
			(read/write)	114142	114142
			.bss	8986	8986
			.data	272	272
			.text	100088	100088
telink	lighting-app	tlsr9518adk80d	(read/write)	769042	769042
			bss	79136	79136
			noinit	37160	37160
			text	534004	534004

… tv-apps

github-actions · 2021-11-23T20:21:38Z

PR #12125: Size comparison from 972406e to c3a53d9

Increases above 0.2%:

platform	target	config	section	`972406e`	`c3a53d9`	change	% change
linux	tv-app	debug	(read only)	1900353	`1909969`	9616	0.5
			(read/write)	319288	320552	1264	0.4
			.bss	250072	250872	800	0.3
			.data	2784	3200	416	14.9
			.init_array	632	648	16	2.5
			.rodata	159325	161149	1824	1.1
			.text	1594386	`1601938`	7552	0.5

Increases (2 builds for linux)

platform	target	config	section	`972406e`	`c3a53d9`	change	% change
linux	chip-tool	debug	(read only)	`5924485`	5925301	816	0.0
			.rodata	283834	283866	32	0.0
			.text	`5259541`	5260325	784	0.0
	tv-app	debug	(read only)	1900353	`1909969`	9616	0.5
			(read/write)	319288	320552	1264	0.4
			.bss	250072	250872	800	0.3
			.data	2784	3200	416	14.9
			.data.rel.ro	60752	60784	32	0.1
			.init_array	632	648	16	2.5
			.rodata	159325	161149	1824	1.1
			.text	1594386	`1601938`	7552	0.5

Full report (15 builds for esp32, linux, mbed)

platform	target	config	section	`972406e`	`c3a53d9`	change	% change
esp32	all-clusters-app	c3devkit	(read only)	834076	834076	0	0.0
			(read/write)	1222394	1222394	0	0.0
			.dram0.bss	57840	57840	0	0.0
			.dram0.data	14100	14100	0	0.0
			.flash.rodata	165200	165200	0	0.0
			.flash.text	834076	834076	0	0.0
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	905135	905135	0	0.0
			(read/write)	421700	421700	0	0.0
			.dram0.bss	63232	63232	0	0.0
			.dram0.data	34064	34064	0	0.0
			.flash.rodata	193124	193124	0	0.0
			.flash.text	899751	899751	0	0.0
			.iram0.text	122943	122943	0	0.0
linux	all-clusters-app	debug	(read only)	1752209	1752209	0	0.0
			(read/write)	129016	129016	0	0.0
			.bss	58672	58672	0	0.0
			.data	1042	1042	0	0.0
			.data.rel.ro	63984	63984	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	576	576	0	0.0
			.rodata	138453	138453	0	0.0
			.text	1476994	1476994	0	0.0
	bridge-app	debug+rpc	(read only)	1330677	1330677	0	0.0
			(read/write)	76960	76960	0	0.0
			.bss	41552	41552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	28784	28784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	113052	113052	0	0.0
			.text	1119093	1119093	0	0.0
	chip-tool	debug	(read only)	`5924485`	5925301	816	0.0
			(read/write)	196328	196328	0	0.0
			.bss	39960	39960	0	0.0
			.data	2288	2288	0	0.0
			.data.rel.ro	148520	148520	0	0.0
			.dynamic	592	592	0	0.0
			.got	4456	4456	0	0.0
			.init	27	27	0	0.0
			.init_array	488	488	0	0.0
			.rodata	283834	283866	32	0.0
			.text	`5259541`	5260325	784	0.0
	lighting-app	debug+rpc	(read only)	1601569	1601569	0	0.0
			(read/write)	110240	110240	0	0.0
			.bss	47312	47312	0	0.0
			.data	1234	1234	0	0.0
			.data.rel.ro	56368	56368	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	131409	131409	0	0.0
			.text	1334002	1334002	0	0.0
	ota-provider-app	debug	(read only)	1281601	1281601	0	0.0
			(read/write)	75480	75480	0	0.0
			.bss	44192	44192	0	0.0
			.data	800	800	0	0.0
			.data.rel.ro	25368	25368	0	0.0
			.dynamic	592	592	0	0.0
			.got	4048	4048	0	0.0
			.init	27	27	0	0.0
			.init_array	464	464	0	0.0
			.rodata	114775	114775	0	0.0
			.text	1068034	1068034	0	0.0
	ota-requestor-app	debug	(read only)	`1378105`	`1378105`	0	0.0
			(read/write)	79344	79344	0	0.0
			.bss	46656	46656	0	0.0
			.data	864	864	0	0.0
			.data.rel.ro	26696	26696	0	0.0
			.dynamic	592	592	0	0.0
			.got	4032	4032	0	0.0
			.init	27	27	0	0.0
			.init_array	488	488	0	0.0
			.rodata	126184	126184	0	0.0
			.text	`1150338`	`1150338`	0	0.0
	shell	debug	(read only)	805705	805705	0	0.0
			(read/write)	66200	66200	0	0.0
			.bss	23368	23368	0	0.0
			.data	274	274	0	0.0
			.data.rel.ro	38024	38024	0	0.0
			.dynamic	592	592	0	0.0
			.got	3560	3560	0	0.0
			.init	27	27	0	0.0
			.init_array	360	360	0	0.0
			.rodata	79055	79055	0	0.0
			.text	621474	621474	0	0.0
	tv-app	debug	(read only)	1900353	`1909969`	9616	0.5
			(read/write)	319288	320552	1264	0.4
			.bss	250072	250872	800	0.3
			.data	2784	3200	416	14.9
			.data.rel.ro	60752	60784	32	0.1
			.dynamic	592	592	0	0.0
			.got	4432	4432	0	0.0
			.init	27	27	0	0.0
			.init_array	632	648	16	2.5
			.rodata	159325	161149	1824	1.1
			.text	1594386	`1601938`	7552	0.5
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2291112	2291112	0	0.0
			.bss	180388	180388	0	0.0
			.data	5240	5240	0	0.0
			.heap	850816	850816	0	0.0
			.text	1253712	1253712	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2275320	2275320	0	0.0
			.bss	172292	172292	0	0.0
			.data	5592	5592	0	0.0
			.heap	858560	858560	0	0.0
			.text	1237920	1237920	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2251120`	`2251120`	0	0.0
			.bss	171108	171108	0	0.0
			.data	5576	5576	0	0.0
			.heap	859760	859760	0	0.0
			.text	1213720	1213720	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2050992	2050992	0	0.0
			.bss	156320	156320	0	0.0
			.data	4984	4984	0	0.0
			.heap	875144	875144	0	0.0
			.text	1013592	1013592	0	0.0

…ntent apps

github-actions · 2021-11-24T01:53:24Z

PR #12125: Size comparison from 2e85d48 to 251f64e

Full report (9 builds for efr32, esp32, p6, telink)

platform	target	config	section	`2e85d48`	`251f64e`
efr32	lighting-app	BRD4161A	(read only)	754832	754832
			(read/write)	119796	119796
			.bss	117980	117980
			.data	1812	1812
			.text	754824	754824
		BRD4161A+rpc	(read only)	742292	742292
			(read/write)	136420	136420
			.bss	134484	134484
			.data	1936	1936
			.text	742284	742284
	lock-app	BRD4161A	(read only)	730688	730688
			(read/write)	117508	117508
			.bss	115740	115740
			.data	1768	1768
			.text	730680	730680
	window-app	BRD4161A	(read only)	734136	734136
			(read/write)	117868	117868
			.bss	116092	116092
			.data	1776	1776
			.text	734128	734128
esp32	all-clusters-app	c3devkit	(read only)	834242	834242
			(read/write)	`1222658`	`1222658`
			.dram0.bss	57832	57832
			.dram0.data	14100	14100
			.flash.rodata	165464	165464
			.flash.text	834242	834242
			.iram0.text	61394	61394
		m5stack	(read only)	905103	905103
			(read/write)	421956	421956
			.dram0.bss	63224	63224
			.dram0.data	34064	34064
			.flash.rodata	193388	193388
			.flash.text	899719	899719
			.iram0.text	122943	122943
p6	all-clusters-app	default	(read/write)	`2306904`	`2306904`
			.bss	113376	113376
			.data	2536	2536
			.heap	917432	917432
			.text	1265168	1265168
	lock-app	default	(read/write)	2218904	2218904
			.bss	100968	100968
			.data	2416	2416
			.heap	929960	929960
			.text	1177168	1177168
telink	lighting-app	tlsr9518adk80d	(read/write)	771514	771514
			bss	79216	79216
			noinit	37160	37160
			text	535570	535570

todo · 2021-11-24T18:37:29Z

Fix hardcoded app endpoints 3-5, fix test cases

connectedhomeip/examples/tv-app/linux/include/application-basic/ApplicationBasicManager.cpp

Lines 167 to 176 in 4b7acc6

    
                       // TODO: Fix hardcoded app endpoints 3-5, fix test cases 
        
                       return true; 
        
                   } 
        
                   ChipLogProgress(Zcl, "No app for endpoint %d", endpoint); 
        
                   return false; 
        
               } 
        
               app->SetApplicationStatus(status); 
        
               return true; 
        
           }

This comment was generated by todo based on a `TODO` comment in `4b7acc6` in #12125. cc @project-chip.

github-actions · 2021-11-24T19:00:07Z

PR #12125: Size comparison from 8bfdc13 to 4b7acc6

Increases above 0.2%:

platform	target	config	section	`8bfdc13`	`4b7acc6`	change	% change
linux	lighting-app	debug+rpc	.init_array	552	560	8	1.4
	tv-app	debug	(read only)	1912529	1923225	10696	0.6
			(read/write)	320088	322184	2096	0.7
			.bss	250168	250968	800	0.3
			.data	2880	4128	1248	43.3
			.init_array	632	648	16	2.5
			.rodata	159176	161192	2016	1.3
			.text	`1605154`	1613426	8272	0.5

Increases (4 builds for linux)

platform	target	config	section	`8bfdc13`	`4b7acc6`	change	% change
linux	all-clusters-app	debug	(read only)	1767121	1767185	64	0.0
			.rodata	138293	138325	32	0.0
			.text	1490482	1490514	32	0.0
	chip-tool	debug	(read only)	5959517	5960333	816	0.0
			.rodata	283880	283912	32	0.0
			.text	`5291957`	5292741	784	0.0
	lighting-app	debug+rpc	(read only)	1615929	`1616065`	136	0.0
			(read/write)	111072	111080	8	0.0
			.init_array	552	560	8	1.4
			.text	1346994	1347106	112	0.0
	tv-app	debug	(read only)	1912529	1923225	10696	0.6
			(read/write)	320088	322184	2096	0.7
			.bss	250168	250968	800	0.3
			.data	2880	4128	1248	43.3
			.data.rel.ro	61368	61400	32	0.1
			.init_array	632	648	16	2.5
			.rodata	159176	161192	2016	1.3
			.text	`1605154`	1613426	8272	0.5

Full report (20 builds for efr32, linux, mbed, qpg)

platform	target	config	section	`8bfdc13`	`4b7acc6`	change	% change
efr32	lighting-app	BRD4161A	(read only)	757184	757184	0	0.0
			(read/write)	119788	119788	0	0.0
			.bss	117972	117972	0	0.0
			.data	1816	1816	0	0.0
			.text	757176	757176	0	0.0
		BRD4161A+rpc	(read only)	744644	744644	0	0.0
			(read/write)	136416	136416	0	0.0
			.bss	134476	134476	0	0.0
			.data	1940	1940	0	0.0
			.text	744636	744636	0	0.0
	lock-app	BRD4161A	(read only)	733040	733040	0	0.0
			(read/write)	117508	117508	0	0.0
			.bss	115732	115732	0	0.0
			.data	1772	1772	0	0.0
			.text	733032	733032	0	0.0
	window-app	BRD4161A	(read only)	736488	736488	0	0.0
			(read/write)	117868	117868	0	0.0
			.bss	116084	116084	0	0.0
			.data	1780	1780	0	0.0
			.text	736480	736480	0	0.0
linux	all-clusters-app	debug	(read only)	1767121	1767185	64	0.0
			(read/write)	129880	129880	0	0.0
			.bss	58800	58800	0	0.0
			.data	1170	1170	0	0.0
			.data.rel.ro	64608	64608	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	576	576	0	0.0
			.rodata	138293	138325	32	0.0
			.text	1490482	1490514	32	0.0
	bridge-app	debug+rpc	(read only)	1342765	1342765	0	0.0
			(read/write)	77824	77824	0	0.0
			.bss	41712	41712	0	0.0
			.data	1680	1680	0	0.0
			.data.rel.ro	29384	29384	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	112924	112924	0	0.0
			.text	1129749	1129749	0	0.0
	chip-tool	debug	(read only)	5959517	5960333	816	0.0
			(read/write)	197584	197584	0	0.0
			.bss	40064	40064	0	0.0
			.data	2384	2384	0	0.0
			.data.rel.ro	149552	149552	0	0.0
			.dynamic	592	592	0	0.0
			.got	4456	4456	0	0.0
			.init	27	27	0	0.0
			.init_array	488	488	0	0.0
			.rodata	283880	283912	32	0.0
			.text	`5291957`	5292741	784	0.0
	lighting-app	debug+rpc	(read only)	1615929	`1616065`	136	0.0
			(read/write)	111072	111080	8	0.0
			.bss	47408	47408	0	0.0
			.data	1362	1362	0	0.0
			.data.rel.ro	56976	56976	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	552	560	8	1.4
			.rodata	131217	131217	0	0.0
			.text	1346994	1347106	112	0.0
	ota-provider-app	debug	(read only)	1306817	1306817	0	0.0
			(read/write)	76312	76312	0	0.0
			.bss	44320	44320	0	0.0
			.data	912	912	0	0.0
			.data.rel.ro	25944	25944	0	0.0
			.dynamic	592	592	0	0.0
			.got	4048	4048	0	0.0
			.init	27	27	0	0.0
			.init_array	464	464	0	0.0
			.rodata	114640	114640	0	0.0
			.text	1091826	1091826	0	0.0
	ota-requestor-app	debug	(read only)	1403353	1403353	0	0.0
			(read/write)	80144	80144	0	0.0
			.bss	46752	46752	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27272	27272	0	0.0
			.dynamic	592	592	0	0.0
			.got	4032	4032	0	0.0
			.init	27	27	0	0.0
			.init_array	488	488	0	0.0
			.rodata	126080	126080	0	0.0
			.text	1174130	1174130	0	0.0
	shell	debug	(read only)	820129	820129	0	0.0
			(read/write)	66936	66936	0	0.0
			.bss	23496	23496	0	0.0
			.data	338	338	0	0.0
			.data.rel.ro	38560	38560	0	0.0
			.dynamic	592	592	0	0.0
			.got	3560	3560	0	0.0
			.init	27	27	0	0.0
			.init_array	360	360	0	0.0
			.rodata	78927	78927	0	0.0
			.text	634514	634514	0	0.0
	tv-app	debug	(read only)	1912529	1923225	10696	0.6
			(read/write)	320088	322184	2096	0.7
			.bss	250168	250968	800	0.3
			.data	2880	4128	1248	43.3
			.data.rel.ro	61368	61400	32	0.1
			.dynamic	592	592	0	0.0
			.got	4432	4432	0	0.0
			.init	27	27	0	0.0
			.init_array	632	648	16	2.5
			.rodata	159176	161192	2016	1.3
			.text	`1605154`	1613426	8272	0.5
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2294096	2294096	0	0.0
			.bss	180500	180500	0	0.0
			.data	5240	5240	0	0.0
			.heap	850704	850704	0	0.0
			.text	`1256696`	`1256696`	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2278352	2278352	0	0.0
			.bss	172404	172404	0	0.0
			.data	5600	5600	0	0.0
			.heap	858440	858440	0	0.0
			.text	1240952	1240952	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2252672	2252672	0	0.0
			.bss	171220	171220	0	0.0
			.data	5584	5584	0	0.0
			.heap	859640	859640	0	0.0
			.text	1215272	1215272	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2050800	2050800	0	0.0
			.bss	156424	156424	0	0.0
			.data	4984	4984	0	0.0
			.heap	875040	875040	0	0.0
			.text	1013400	1013400	0	0.0
qpg	lighting-app	qpg6100+debug	(read only)	498732	498732	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	50368	50368	0	0.0
			.data	1020	1020	0	0.0
			.text	493412	493412	0	0.0
	lock-app	qpg6100+debug	(read only)	472636	472636	0	0.0
			(read/write)	114144	114144	0	0.0
			.bss	49240	49240	0	0.0
			.data	976	976	0	0.0
			.text	467316	467316	0	0.0
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8986	8986	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0

github-actions · 2021-11-25T00:18:46Z

PR #12125: Size comparison from 1315dec to 2dacaf4

Full report (12 builds for esp32, k32w, mbed, p6)

platform	target	config	section	`1315dec`	`2dacaf4`
esp32	all-clusters-app	c3devkit	(read only)	835374	835374
			(read/write)	1224114	1224114
			.dram0.bss	59240	59240
			.dram0.data	14100	14100
			.flash.rodata	165512	165512
			.flash.text	835374	835374
			.iram0.text	61394	61394
		m5stack	(read only)	906835	906835
			(read/write)	423372	423372
			.dram0.bss	64632	64632
			.dram0.data	34072	34072
			.flash.rodata	193388	193388
			.flash.text	901451	901451
			.iram0.text	122943	122943
k32w	lighting-app	k32w061+se05x+release	(read/write)	718472	718472
			.bss	78252	78252
			.data	1952	1952
			.text	632468	632468
	lock-app	k32w061+debug	(read/write)	608764	608764
			.bss	68692	68692
			.data	1920	1920
			.text	532352	532352
	shell	k32w061+debug	(read/write)	674164	674164
			.bss	79852	79852
			.data	1888	1888
			.text	586624	586624
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2294328	2294328
			.bss	181788	181788
			.data	5240	5240
			.heap	849416	849416
			.text	1256928	1256928
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2278352	2278352
			.bss	172404	172404
			.data	5600	5600
			.heap	858440	858440
			.text	1240952	1240952
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2252672	2252672
			.bss	171220	171220
			.data	5584	5584
			.heap	859640	859640
			.text	1215272	1215272
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139744	1139744
			.bss	11752	11752
			.data	4368	4368
			.heap	1020328	1020328
			.text	103128	103128
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2050800	2050800
			.bss	156424	156424
			.data	4984	4984
			.heap	875040	875040
			.text	1013400	1013400
p6	all-clusters-app	default	(read/write)	2309824	2309824
			.bss	114784	114784
			.data	2544	2544
			.heap	916016	916016
			.text	`1268088`	`1268088`
	lock-app	default	(read/write)	2221608	2221608
			.bss	101080	101080
			.data	2416	2416
			.heap	929848	929848
			.text	1179872	1179872

woody-apple · 2021-12-03T00:28:11Z

Fast tracking this, given it's been in review for a while.

github-actions · 2021-12-03T00:50:35Z

PR #12125: Size comparison from 7cba51d to e41100b

Increases above 0.2%:

platform	target	config	section	`7cba51d`	`e41100b`	change	% change
linux	all-clusters-app	debug	(read only)	`1842697`	1848425	5728	0.3
			(read/write)	124256	124520	264	0.2
			.bss	50768	50896	128	0.3
			.init_array	552	688	136	24.6
			.rodata	146453	148533	2080	1.4
			.text	1553890	1557026	3136	0.2
	bridge-app	debug+rpc	(read only)	`1423037`	1426541	3504	0.2
			(read/write)	74416	74584	168	0.2
			.bss	36144	36240	96	0.3
			.got	3984	3992	8	0.2
			.init_array	408	480	72	17.6
			.rodata	119500	120620	1120	0.9
	chip-tool	debug	.init_array	480	568	88	18.3
	lighting-app	debug+rpc	(read only)	1707121	1711081	3960	0.2
			.bss	41808	41936	128	0.3
			.init_array	536	616	80	14.9
			.rodata	139281	140689	1408	1.0
	ota-provider-app	debug	(read only)	`1383857`	1386713	2856	0.2
			(read/write)	72648	72816	168	0.2
			.bss	38720	38816	96	0.2
			.init_array	448	520	72	16.1
			.rodata	120776	121480	704	0.6
	ota-requestor-app	debug	(read only)	1483945	1490489	6544	0.4
			(read/write)	76512	76784	272	0.4
			.bss	40832	40960	128	0.3
			.got	4032	4072	40	1.0
			.init_array	472	552	80	16.9
			.rodata	132688	133776	1088	0.8
			.text	1243458	1248018	4560	0.4
	shell	debug	.got	3504	3512	8	0.2
	tv-app	debug	(read only)	2000921	`2020785`	19864	1.0
			(read/write)	317616	320000	2384	0.8
			.bss	246712	247224	512	0.2
			.data	1520	2768	1248	82.1
			.data.rel.ro	63720	64200	480	0.8
			.init_array	624	736	112	17.9
			.rodata	169320	173640	4320	2.6
			.text	1678722	1692690	13968	0.8

Increases (11 builds for k32w, linux)

platform	target	config	section	`7cba51d`	`e41100b`	change	% change
k32w	lighting-app	k32w061+se05x+release	(read/write)	728720	728752	32	0.0
			.text	641756	641788	32	0.0
	lock-app	k32w061+debug	(read/write)	617704	617736	32	0.0
			.text	540336	540368	32	0.0
	shell	k32w061+debug	(read/write)	683604	683636	32	0.0
			.text	594608	594640	32	0.0
linux	all-clusters-app	debug	(read only)	`1842697`	1848425	5728	0.3
			(read/write)	124256	124520	264	0.2
			.bss	50768	50896	128	0.3
			.got	4112	4120	8	0.2
			.init_array	552	688	136	24.6
			.rodata	146453	148533	2080	1.4
			.text	1553890	1557026	3136	0.2
	bridge-app	debug+rpc	(read only)	`1423037`	1426541	3504	0.2
			(read/write)	74416	74584	168	0.2
			.bss	36144	36240	96	0.3
			.got	3984	3992	8	0.2
			.init_array	408	480	72	17.6
			.rodata	119500	120620	1120	0.9
			.text	`1198981`	1201045	2064	0.2
	chip-tool	debug	(read only)	6618837	6621877	3040	0.0
			(read/write)	202128	202280	152	0.1
			.bss	34440	34504	64	0.2
			.got	4464	4472	8	0.2
			.init_array	480	568	88	18.3
			.rodata	307224	307640	416	0.1
			.text	`5901429`	5903669	2240	0.0
	lighting-app	debug+rpc	(read only)	1707121	1711081	3960	0.2
			(read/write)	107408	107616	208	0.2
			.bss	41808	41936	128	0.3
			.got	4136	4144	8	0.2
			.init_array	536	616	80	14.9
			.rodata	139281	140689	1408	1.0
			.text	1425538	1427746	2208	0.2
	ota-provider-app	debug	(read only)	`1383857`	1386713	2856	0.2
			(read/write)	72648	72816	168	0.2
			.bss	38720	38816	96	0.2
			.got	4048	4056	8	0.2
			.init_array	448	520	72	16.1
			.rodata	120776	121480	704	0.6
			.text	1158722	1160546	1824	0.2
	ota-requestor-app	debug	(read only)	1483945	1490489	6544	0.4
			(read/write)	76512	76784	272	0.4
			.bss	40832	40960	128	0.3
			.data.rel.ro	29576	29592	16	0.1
			.got	4032	4072	40	1.0
			.init_array	472	552	80	16.9
			.rodata	132688	133776	1088	0.8
			.text	1243458	1248018	4560	0.4
	shell	debug	(read only)	818561	819625	1064	0.1
			.got	3504	3512	8	0.2
			.rodata	83506	83570	64	0.1
			.text	628418	629314	896	0.1
	tv-app	debug	(read only)	2000921	`2020785`	19864	1.0
			(read/write)	317616	320000	2384	0.8
			.bss	246712	247224	512	0.2
			.data	1520	2768	1248	82.1
			.data.rel.ro	63720	64200	480	0.8
			.got	4424	4432	8	0.2
			.init_array	624	736	112	17.9
			.rodata	169320	173640	4320	2.6
			.text	1678722	1692690	13968	0.8

Full report (11 builds for k32w, linux)

platform	target	config	section	`7cba51d`	`e41100b`	change	% change
k32w	lighting-app	k32w061+se05x+release	(read/write)	728720	728752	32	0.0
			.bss	79304	79304	0	0.0
			.data	1860	1860	0	0.0
			.text	641756	641788	32	0.0
	lock-app	k32w061+debug	(read/write)	617704	617736	32	0.0
			.bss	69744	69744	0	0.0
			.data	1824	1824	0	0.0
			.text	540336	540368	32	0.0
	shell	k32w061+debug	(read/write)	683604	683636	32	0.0
			.bss	81400	81400	0	0.0
			.data	1796	1796	0	0.0
			.text	594608	594640	32	0.0
linux	all-clusters-app	debug	(read only)	`1842697`	1848425	5728	0.3
			(read/write)	124256	124520	264	0.2
			.bss	50768	50896	128	0.3
			.data	1120	1120	0	0.0
			.data.rel.ro	67088	67088	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4120	8	0.2
			.init	27	27	0	0.0
			.init_array	552	688	136	24.6
			.rodata	146453	148533	2080	1.4
			.text	1553890	1557026	3136	0.2
	bridge-app	debug+rpc	(read only)	`1423037`	1426541	3504	0.2
			(read/write)	74416	74584	168	0.2
			.bss	36144	36240	96	0.3
			.data	1728	1728	0	0.0
			.data.rel.ro	31528	31528	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3992	8	0.2
			.init	27	27	0	0.0
			.init_array	408	480	72	17.6
			.rodata	119500	120620	1120	0.9
			.text	`1198981`	1201045	2064	0.2
	chip-tool	debug	(read only)	6618837	6621877	3040	0.0
			(read/write)	202128	202280	152	0.1
			.bss	34440	34504	64	0.2
			.data	1024	1024	0	0.0
			.data.rel.ro	161112	161112	0	0.0
			.dynamic	592	592	0	0.0
			.got	4464	4472	8	0.2
			.init	27	27	0	0.0
			.init_array	480	568	88	18.3
			.rodata	307224	307640	416	0.1
			.text	`5901429`	5903669	2240	0.0
	lighting-app	debug+rpc	(read only)	1707121	1711081	3960	0.2
			(read/write)	107408	107616	208	0.2
			.bss	41808	41936	128	0.3
			.data	1280	1280	0	0.0
			.data.rel.ro	59024	59024	0	0.0
			.dynamic	608	608	0	0.0
			.got	4136	4144	8	0.2
			.init	27	27	0	0.0
			.init_array	536	616	80	14.9
			.rodata	139281	140689	1408	1.0
			.text	1425538	1427746	2208	0.2
	ota-provider-app	debug	(read only)	`1383857`	1386713	2856	0.2
			(read/write)	72648	72816	168	0.2
			.bss	38720	38816	96	0.2
			.data	928	928	0	0.0
			.data.rel.ro	27880	27880	0	0.0
			.dynamic	592	592	0	0.0
			.got	4048	4056	8	0.2
			.init	27	27	0	0.0
			.init_array	448	520	72	16.1
			.rodata	120776	121480	704	0.6
			.text	1158722	1160546	1824	0.2
	ota-requestor-app	debug	(read only)	1483945	1490489	6544	0.4
			(read/write)	76512	76784	272	0.4
			.bss	40832	40960	128	0.3
			.data	992	992	0	0.0
			.data.rel.ro	29576	29592	16	0.1
			.dynamic	592	592	0	0.0
			.got	4032	4072	40	1.0
			.init	27	27	0	0.0
			.init_array	472	552	80	16.9
			.rodata	132688	133776	1088	0.8
			.text	1243458	1248018	4560	0.4
	shell	debug	(read only)	818561	819625	1064	0.1
			(read/write)	60584	60584	0	0.0
			.bss	16936	16936	0	0.0
			.data	256	256	0	0.0
			.data.rel.ro	38936	38936	0	0.0
			.dynamic	592	592	0	0.0
			.got	3504	3512	8	0.2
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	83506	83570	64	0.1
			.text	628418	629314	896	0.1
	tv-app	debug	(read only)	2000921	`2020785`	19864	1.0
			(read/write)	317616	320000	2384	0.8
			.bss	246712	247224	512	0.2
			.data	1520	2768	1248	82.1
			.data.rel.ro	63720	64200	480	0.8
			.dynamic	592	592	0	0.0
			.got	4424	4432	8	0.2
			.init	27	27	0	0.0
			.init_array	624	736	112	17.9
			.rodata	169320	173640	4320	2.6
			.text	1678722	1692690	13968	0.8

examples/tv-app/linux/AppImpl.cpp

src/app/util/ContentApp.cpp

src/app/util/ContentAppPlatform.cpp

src/protocols/user_directed_commissioning/UDCClientState.h

draft - dynamic apps

c1d23e0

boring-cyborg bot added the examples label Nov 23, 2021

restyled-io bot mentioned this pull request Nov 23, 2021

Restyle draft - dynamic tv apps #12126

Closed

andy31415 marked this pull request as draft November 23, 2021 14:24

Merge branch 'master' of github.com:project-chip/connectedhomeip into…

b247db1

… tv-apps

chrisdecenzo requested review from lazarkov, vivien-apple, sharadb-amazon, Byungjoo-Lee and a team November 23, 2021 18:51

sync to TOT

c3a53d9

centralize commissioning logic in AppMain, add all clusters to the co…

251f64e

…ntent apps

temp fix for integration tests

4b7acc6

cleanup and prepare for moving app platform to common code

2dacaf4

chrisdecenzo requested a review from xylophone21 November 25, 2021 16:49

move ContentApp and ContentAppPlatform to common code

f642595

boring-cyborg bot added the app label Nov 29, 2021

chrisdecenzo changed the title ~~draft - dynamic tv apps~~ dynamic tv apps Nov 30, 2021

pullapprove bot requested review from jelderton, jepenven-silabs, jmartinez-silabs, kghost, kpschoedel, LuDuda, mlepage-google, msandstedt, mspang, saurabhst, selissia, tecimovic, turon, vijs, wbschiller and yunhanw-google December 2, 2021 15:41

pullapprove bot added the review - pending label Dec 2, 2021

sync to TOT, resolve merge conflicts

e41100b

woody-apple added the fast track label Dec 3, 2021

hawk248 approved these changes Dec 3, 2021

View reviewed changes

woody-apple merged commit 2b0679a into master Dec 3, 2021

woody-apple deleted the tv-apps branch December 3, 2021 01:47

This was referenced Dec 3, 2021

add CHIPProjectAppConfig.h to esp32 #12530

Closed

Need a generated file from ZAP to define these! #12531

Closed

add missing attributes once schema is updated #12532

Closed

Fix hardcoded app endpoints 3-5, fix test cases #12533

Closed

bzbarsky-apple reviewed Dec 3, 2021

View reviewed changes

bzbarsky-apple mentioned this pull request Dec 3, 2021

Address review comments on content app platform #12543

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dynamic tv apps #12125

dynamic tv apps #12125

chrisdecenzo commented Nov 23, 2021 •

edited

Loading

todo bot commented Nov 23, 2021

todo bot commented Nov 23, 2021

todo bot commented Nov 23, 2021

todo bot commented Nov 23, 2021

github-actions bot commented Nov 23, 2021 •

edited

Loading

github-actions bot commented Nov 23, 2021 •

edited

Loading

github-actions bot commented Nov 24, 2021 •

edited

Loading

todo bot commented Nov 24, 2021

github-actions bot commented Nov 24, 2021 •

edited

Loading

github-actions bot commented Nov 25, 2021 •

edited

Loading

woody-apple commented Dec 3, 2021

github-actions bot commented Dec 3, 2021 •

edited

Loading

dynamic tv apps #12125

dynamic tv apps #12125

Conversation

chrisdecenzo commented Nov 23, 2021 • edited Loading

Problem

Change overview

Testing

todo bot commented Nov 23, 2021

Need a generated file from ZAP to define these!

This comment was generated by todo based on a TODO comment in c1d23e0 in #12125. cc @project-chip.

todo bot commented Nov 23, 2021

add missing attributes once schema is updated

This comment was generated by todo based on a TODO comment in c1d23e0 in #12125. cc @project-chip.

todo bot commented Nov 23, 2021

the definition of DYNAMIC_ENDPOINT_COUNT needs find a common home!

This comment was generated by todo based on a TODO comment in c1d23e0 in #12125. cc @project-chip.

todo bot commented Nov 23, 2021

the definition of DYNAMIC_ENDPOINT_COUNT needs find a common home!

This comment was generated by todo based on a TODO comment in c1d23e0 in #12125. cc @project-chip.

github-actions bot commented Nov 23, 2021 • edited Loading

github-actions bot commented Nov 23, 2021 • edited Loading

github-actions bot commented Nov 24, 2021 • edited Loading

todo bot commented Nov 24, 2021

Fix hardcoded app endpoints 3-5, fix test cases

This comment was generated by todo based on a TODO comment in 4b7acc6 in #12125. cc @project-chip.

github-actions bot commented Nov 24, 2021 • edited Loading

github-actions bot commented Nov 25, 2021 • edited Loading

woody-apple commented Dec 3, 2021

github-actions bot commented Dec 3, 2021 • edited Loading

chrisdecenzo commented Nov 23, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `c1d23e0` in #12125. cc @project-chip.

This comment was generated by todo based on a `TODO` comment in `c1d23e0` in #12125. cc @project-chip.

This comment was generated by todo based on a `TODO` comment in `c1d23e0` in #12125. cc @project-chip.

This comment was generated by todo based on a `TODO` comment in `c1d23e0` in #12125. cc @project-chip.

github-actions bot commented Nov 23, 2021 •

edited

Loading

github-actions bot commented Nov 23, 2021 •

edited

Loading

github-actions bot commented Nov 24, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `4b7acc6` in #12125. cc @project-chip.

github-actions bot commented Nov 24, 2021 •

edited

Loading

github-actions bot commented Nov 25, 2021 •

edited

Loading

github-actions bot commented Dec 3, 2021 •

edited

Loading