Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[group] Replace manual onSuccess call for group message by onDone callback #12121

Merged
merged 5 commits into from
Nov 25, 2021
Merged

[group] Replace manual onSuccess call for group message by onDone callback #12121

merged 5 commits into from
Nov 25, 2021

Conversation

mkardous-silabs
Copy link
Contributor

Problem

Change overview

  • Added onDone callback mencanic for groups messaging

Testing

  • Automated tests to validate that the group messaging test passes
  • Automated tests to validate no regressions were caused

@github-actions
Copy link

github-actions bot commented Nov 22, 2021 •
edited
Loading

PR #12121: Size comparison from 53721c0 to 836ec3d

Decreases (1 build for linux)
platform target config section 53721c0 836ec3d change % change
linux chip-tool debug (read only) 5875885 5870637 -5248 -0.1
.text 5216741 5211493 -5248 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 53721c0 836ec3d change % change
efr32 lighting-app BRD4161A (read only) 751376 751376 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117884 117884 0 0.0
.data 1808 1808 0 0.0
.text 751368 751368 0 0.0
BRD4161A+rpc (read only) 738884 738884 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134388 134388 0 0.0
.data 1932 1932 0 0.0
.text 738876 738876 0 0.0
lock-app BRD4161A (read only) 728448 728448 0 0.0
(read/write) 117476 117476 0 0.0
.bss 115708 115708 0 0.0
.data 1764 1764 0 0.0
.text 728440 728440 0 0.0
window-app BRD4161A (read only) 731896 731896 0 0.0
(read/write) 117836 117836 0 0.0
.bss 116060 116060 0 0.0
.data 1772 1772 0 0.0
.text 731888 731888 0 0.0
esp32 all-clusters-app c3devkit (read only) 833664 833664 0 0.0
(read/write) 1222106 1222106 0 0.0
.dram0.bss 57760 57760 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 164992 164992 0 0.0
.flash.text 833664 833664 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 904711 904711 0 0.0
(read/write) 421400 421400 0 0.0
.dram0.bss 63120 63120 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 192936 192936 0 0.0
.flash.text 899327 899327 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707928 707928 0 0.0
.bss 77212 77212 0 0.0
.data 1920 1920 0 0.0
.text 622996 622996 0 0.0
lock-app k32w061+debug (read/write) 599368 599368 0 0.0
.bss 67724 67724 0 0.0
.data 1888 1888 0 0.0
.text 523956 523956 0 0.0
shell k32w061+debug (read/write) 664744 664744 0 0.0
.bss 78884 78884 0 0.0
.data 1856 1856 0 0.0
.text 578204 578204 0 0.0
linux all-clusters-app debug (read only) 1748801 1748801 0 0.0
(read/write) 128688 128688 0 0.0
.bss 58576 58576 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63760 63760 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 138549 138549 0 0.0
.text 1473874 1473874 0 0.0
bridge-app debug+rpc (read only) 1328645 1328645 0 0.0
(read/write) 76760 76760 0 0.0
.bss 41552 41552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 28608 28608 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 113116 113116 0 0.0
.text 1117381 1117381 0 0.0
chip-tool debug (read only) 5875885 5870637 -5248 -0.1
(read/write) 195936 195936 0 0.0
.bss 39896 39896 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 148192 148192 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 278778 278778 0 0.0
.text 5216741 5211493 -5248 -0.1
lighting-app debug+rpc (read only) 1597849 1597849 0 0.0
(read/write) 109976 109976 0 0.0
.bss 47216 47216 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 56208 56208 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 130833 130833 0 0.0
.text 1331266 1331266 0 0.0
ota-provider-app debug (read only) 1279465 1279465 0 0.0
(read/write) 75376 75376 0 0.0
.bss 44128 44128 0 0.0
.data 800 800 0 0.0
.data.rel.ro 25336 25336 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 456 456 0 0.0
.rodata 114903 114903 0 0.0
.text 1065890 1065890 0 0.0
ota-requestor-app debug (read only) 1375729 1375729 0 0.0
(read/write) 79240 79240 0 0.0
.bss 46592 46592 0 0.0
.data 864 864 0 0.0
.data.rel.ro 26664 26664 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 126312 126312 0 0.0
.text 1147954 1147954 0 0.0
shell debug (read only) 804577 804577 0 0.0
(read/write) 66160 66160 0 0.0
.bss 23336 23336 0 0.0
.data 274 274 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 352 352 0 0.0
.rodata 79279 79279 0 0.0
.text 620194 620194 0 0.0
tv-app debug (read only) 1890329 1890329 0 0.0
(read/write) 318832 318832 0 0.0
.bss 249848 249848 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 60520 60520 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159389 159389 0 0.0
.text 1584754 1584754 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290672 2290672 0 0.0
.bss 180308 180308 0 0.0
.data 5232 5232 0 0.0
.heap 850904 850904 0 0.0
.text 1253272 1253272 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274800 2274800 0 0.0
.bss 172212 172212 0 0.0
.data 5584 5584 0 0.0
.heap 858648 858648 0 0.0
.text 1237400 1237400 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250632 2250632 0 0.0
.bss 171092 171092 0 0.0
.data 5576 5576 0 0.0
.heap 859776 859776 0 0.0
.text 1213232 1213232 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050872 2050872 0 0.0
.bss 156280 156280 0 0.0
.data 4976 4976 0 0.0
.heap 875192 875192 0 0.0
.text 1013472 1013472 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865667 865667 0 0.0
bss 110616 110616 0 0.0
rodata 95980 95980 0 0.0
text 583444 583444 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 828035 828035 0 0.0
bss 106972 106972 0 0.0
rodata 87164 87164 0 0.0
text 557612 557612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790706 790706 0 0.0
bss 111992 111992 0 0.0
rodata 91236 91236 0 0.0
text 512912 512912 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841099 841099 0 0.0
bss 109640 109640 0 0.0
rodata 92452 92452 0 0.0
text 563540 563540 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 766386 766386 0 0.0
bss 111052 111052 0 0.0
rodata 87756 87756 0 0.0
text 493096 493096 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847207 847207 0 0.0
bss 109780 109780 0 0.0
rodata 94160 94160 0 0.0
text 567720 567720 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840799 840799 0 0.0
bss 109676 109676 0 0.0
rodata 92408 92408 0 0.0
text 563160 563160 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778639 778639 0 0.0
bss 109160 109160 0 0.0
rodata 73196 73196 0 0.0
text 521668 521668 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693662 693662 0 0.0
bss 110144 110144 0 0.0
rodata 67840 67840 0 0.0
text 442276 442276 0 0.0
p6 all-clusters-app default (read/write) 2303656 2303656 0 0.0
.bss 113296 113296 0 0.0
.data 2536 2536 0 0.0
.heap 917512 917512 0 0.0
.text 1261920 1261920 0 0.0
lock-app default (read/write) 2216840 2216840 0 0.0
.bss 100952 100952 0 0.0
.data 2408 2408 0 0.0
.heap 929984 929984 0 0.0
.text 1175104 1175104 0 0.0
qpg lighting-app qpg6100+debug (read only) 494680 494680 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50264 50264 0 0.0
.data 1016 1016 0 0.0
.text 489360 489360 0 0.0
lock-app qpg6100+debug (read only) 469660 469660 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 972 972 0 0.0
.text 464340 464340 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769042 769042 0 0.0
bss 79136 79136 0 0.0
noinit 37160 37160 0 0.0
text 534004 534004 0 0.0

@mkardous-silabs mkardous-silabs changed the title Replace manual onSuccess call for group message by onDone callback [group] Replace manual onSuccess call for group message by onDone callback Nov 23, 2021
andy31415
andy31415 approved these changes Nov 24, 2021
View reviewed changes
src/controller/CHIPCluster.h Outdated Show resolved Hide resolved
@andy31415
Copy link
Contributor

fast track: open for a while, has a few checkmarks

@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #12121: Size comparison from 15929eb to 31e8273

Decreases (1 build for linux)
platform target config section 15929eb 31e8273 change % change
linux chip-tool debug (read only) 6070205 6064957 -5248 -0.1
.text 5391077 5385829 -5248 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 15929eb 31e8273 change % change
efr32 lighting-app BRD4161A (read only) 759568 759568 0 0.0
(read/write) 119812 119812 0 0.0
.bss 117988 117988 0 0.0
.data 1820 1820 0 0.0
.text 759560 759560 0 0.0
BRD4161A+rpc (read only) 747236 747236 0 0.0
(read/write) 136436 136436 0 0.0
.bss 134492 134492 0 0.0
.data 1944 1944 0 0.0
.text 747228 747228 0 0.0
lock-app BRD4161A (read only) 735504 735504 0 0.0
(read/write) 117524 117524 0 0.0
.bss 115748 115748 0 0.0
.data 1776 1776 0 0.0
.text 735496 735496 0 0.0
window-app BRD4161A (read only) 738960 738960 0 0.0
(read/write) 117884 117884 0 0.0
.bss 116100 116100 0 0.0
.data 1784 1784 0 0.0
.text 738952 738952 0 0.0
esp32 all-clusters-app c3devkit (read only) 835796 835796 0 0.0
(read/write) 1224250 1224250 0 0.0
.dram0.bss 59120 59120 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165776 165776 0 0.0
.flash.text 835796 835796 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907139 907139 0 0.0
(read/write) 423492 423492 0 0.0
.dram0.bss 64512 64512 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193628 193628 0 0.0
.flash.text 901755 901755 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 721348 721348 0 0.0
.bss 78276 78276 0 0.0
.data 1956 1956 0 0.0
.text 635316 635316 0 0.0
lock-app k32w061+debug (read/write) 611668 611668 0 0.0
.bss 68716 68716 0 0.0
.data 1920 1920 0 0.0
.text 535232 535232 0 0.0
shell k32w061+debug (read/write) 676972 676972 0 0.0
.bss 79868 79868 0 0.0
.data 1892 1892 0 0.0
.text 589412 589412 0 0.0
linux all-clusters-app debug (read only) 1770537 1770537 0 0.0
(read/write) 131480 131480 0 0.0
.bss 60080 60080 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138453 138453 0 0.0
.text 1493714 1493714 0 0.0
bridge-app debug+rpc (read only) 1346365 1346365 0 0.0
(read/write) 77824 77824 0 0.0
.bss 41712 41712 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113084 113084 0 0.0
.text 1133189 1133189 0 0.0
chip-tool debug (read only) 6070205 6064957 -5248 -0.1
(read/write) 199728 199728 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151712 151712 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 290408 290408 0 0.0
.text 5391077 5385829 -5248 -0.1
lighting-app debug+rpc (read only) 1619433 1619433 0 0.0
(read/write) 111072 111072 0 0.0
.bss 47408 47408 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131377 131377 0 0.0
.text 1350338 1350338 0 0.0
ota-provider-app debug (read only) 1309361 1309361 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114736 114736 0 0.0
.text 1094274 1094274 0 0.0
ota-requestor-app debug (read only) 1405849 1405849 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126208 126208 0 0.0
.text 1176498 1176498 0 0.0
shell debug (read only) 820129 820129 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78927 78927 0 0.0
.text 634514 634514 0 0.0
tv-app debug (read only) 1916225 1916225 0 0.0
(read/write) 320088 320088 0 0.0
.bss 250168 250168 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159432 159432 0 0.0
.text 1608594 1608594 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293680 2293680 0 0.0
.bss 181668 181668 0 0.0
.data 5240 5240 0 0.0
.heap 849536 849536 0 0.0
.text 1256280 1256280 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2277712 2277712 0 0.0
.bss 172284 172284 0 0.0
.data 5600 5600 0 0.0
.heap 858560 858560 0 0.0
.text 1240312 1240312 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252096 2252096 0 0.0
.bss 171100 171100 0 0.0
.data 5584 5584 0 0.0
.heap 859760 859760 0 0.0
.text 1214696 1214696 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050584 2050584 0 0.0
.bss 156304 156304 0 0.0
.data 4984 4984 0 0.0
.heap 875160 875160 0 0.0
.text 1013184 1013184 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 873643 873643 0 0.0
bss 112644 112644 0 0.0
rodata 96788 96788 0 0.0
text 588544 588544 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 836203 836203 0 0.0
bss 108996 108996 0 0.0
rodata 88036 88036 0 0.0
text 562844 562844 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 798666 798666 0 0.0
bss 114020 114020 0 0.0
rodata 92044 92044 0 0.0
text 518004 518004 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 845799 845799 0 0.0
bss 109680 109680 0 0.0
rodata 92792 92792 0 0.0
text 567856 567856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771070 771070 0 0.0
bss 111088 111088 0 0.0
rodata 88080 88080 0 0.0
text 497412 497412 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 851899 851899 0 0.0
bss 109816 109816 0 0.0
rodata 94500 94500 0 0.0
text 572040 572040 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845491 845491 0 0.0
bss 109712 109712 0 0.0
rodata 92748 92748 0 0.0
text 567476 567476 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778319 778319 0 0.0
bss 109180 109180 0 0.0
rodata 72988 72988 0 0.0
text 521552 521552 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693374 693374 0 0.0
bss 110164 110164 0 0.0
rodata 67632 67632 0 0.0
text 442160 442160 0 0.0
p6 all-clusters-app default (read/write) 2310568 2310568 0 0.0
.bss 114664 114664 0 0.0
.data 2544 2544 0 0.0
.heap 916136 916136 0 0.0
.text 1268832 1268832 0 0.0
lock-app default (read/write) 2222400 2222400 0 0.0
.bss 100960 100960 0 0.0
.data 2416 2416 0 0.0
.heap 929968 929968 0 0.0
.text 1180664 1180664 0 0.0
qpg lighting-app qpg6100+debug (read only) 501148 501148 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50384 50384 0 0.0
.data 1024 1024 0 0.0
.text 495828 495828 0 0.0
lock-app qpg6100+debug (read only) 475116 475116 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49256 49256 0 0.0
.data 980 980 0 0.0
.text 469796 469796 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 775246 775246 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 539022 539022 0 0.0

@jepenven-silabs jepenven-silabs merged commit aa8c58e into project-chip:master Nov 25, 2021
@mkardous-silabs mkardous-silabs deleted the fix/write_success branch November 25, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

Assignees
No one assigned
Labels
app controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove OnSuccessCb from WriteInteraction.h
3 participants
@mkardous-silabs @andy31415 @jepenven-silabs