Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Requestor refactoring 1 #12120

Closed
wants to merge 23 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Nov 22, 2021

A duplicate of #12119 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@todo
Copy link

todo bot commented Nov 22, 2021

This can be removed once OperationalDeviceProxy can resolve the IP Address from Node ID

// TODO: This can be removed once OperationalDeviceProxy can resolve the IP Address from Node ID
{ "ipaddress", chip::ArgParser::kArgumentRequired, kOptionIPAddress },
{ "delayQuery", chip::ArgParser::kArgumentRequired, kOptionDelayQuery },
{},
};
OptionSet cmdLineOptions = { HandleOptions, cmdLineOptionsDef, "PROGRAM OPTIONS",
" -n/--providerNodeId <node ID>\n"
" Node ID of the OTA Provider to connect to (hex format)\n\n"
" This assumes that you've already commissioned the OTA Provider node with chip-tool.\n"
" -f/--providerFabricIndex <fabric index>\n"


This comment was generated by todo based on a TODO comment in ec1f79d in #12120. cc @project-chip.

@todo
Copy link

todo bot commented Nov 22, 2021

enable SetDownloaderInstance(downloaderCore);

// TODO: enable SetDownloaderInstance(downloaderCore);
LinuxOTAImageProcessor * downloaderUser = new LinuxOTAImageProcessor;
// Connect the two objects
downloaderCore->SetImageProcessorDelegate(downloaderUser);
// If a delay is provided, QueryImage after the timer expires REFACTOR DELETE THIS ??
// if (delayQueryTimeInSec > 0)
// {
// chip::DeviceLayer::SystemLayer().StartTimer(chip::System::Clock::Milliseconds32(delayQueryTimeInSec * 1000),


This comment was generated by todo based on a TODO comment in ec1f79d in #12120. cc @project-chip.

@todo
Copy link

todo bot commented Nov 22, 2021

Determine where this should be instantiated

// TODO: Determine where this should be instantiated
.imDelegate = chip::Platform::New<chip::Controller::DeviceControllerInteractionModelDelegate>(),
};
chip::CASESessionManagerConfig sessionManagerConfig = {
.sessionInitParams = initParams,
.dnsCache = nullptr,
};
mCASESessionManager = chip::Platform::New<chip::CASESessionManager>(sessionManagerConfig);
}


This comment was generated by todo based on a TODO comment in ec1f79d in #12120. cc @project-chip.

…essfully.

The top-level build fails for all-cluster app.
@restyled-io restyled-io bot force-pushed the restyled/requestor_refactoring_1 branch from ec1f79d to 18dc08a Compare November 23, 2021 15:30
…estor app

Update .gn files so that clusters/ota-requestor is not built for all example apps (this is different from the rest of the clusters). Instead, explicitly specify clusters/ota-requestor sources in the OTA-Requestor example app
@restyled-io restyled-io bot force-pushed the restyled/requestor_refactoring_1 branch from 18dc08a to 12a90cc Compare November 23, 2021 15:56
@restyled-io restyled-io bot force-pushed the restyled/requestor_refactoring_1 branch from 12a90cc to cef2d51 Compare November 23, 2021 19:26
@restyled-io restyled-io bot force-pushed the restyled/requestor_refactoring_1 branch from cef2d51 to 58a9376 Compare November 23, 2021 20:19
@restyled-io restyled-io bot closed this Nov 24, 2021
@restyled-io restyled-io bot deleted the restyled/requestor_refactoring_1 branch November 24, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants