Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting relevant attribute change when various faults are detected #12116

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Reporting relevant attribute change when various faults are detected #12116

merged 3 commits into from
Nov 23, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • We need to mark relevant attributes dirty and notify reporting engine when various device faults are detected.

Change overview

Add interface to report relevant attribute change when various faults are detected.

Please note, the actual user scenarios of this feature is embedded system. Each embedded platform need to call the corresponding defined delegate API when various faults are detected. No reference implementation on Linux to simulate those device faults.

Testing

How was this tested? (at least one bullet point required)

  • No good way to test this feature until any embedded platform support this feature. No reference implementation is implemented on Linux simulation. Regression is covered by CI.

@boring-cyborg boring-cyborg bot added the app label Nov 22, 2021
@github-actions
Copy link

github-actions bot commented Nov 22, 2021 •
edited
Loading

PR #12116: Size comparison from 779ef51 to e119b2a

Increases above 0.2%:

platform target config section 779ef51 e119b2a change % change
linux bridge-app debug+rpc .data.rel.ro 28608 28688 80 0.3
Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 779ef51 e119b2a change % change
efr32 lighting-app BRD4161A (read only) 751376 751928 552 0.1
.text 751368 751920 552 0.1
BRD4161A+rpc (read only) 738884 739436 552 0.1
.text 738876 739428 552 0.1
lock-app BRD4161A (read only) 728448 729000 552 0.1
.text 728440 728992 552 0.1
window-app BRD4161A (read only) 731896 732448 552 0.1
.text 731888 732440 552 0.1
esp32 all-clusters-app c3devkit (read only) 833664 833952 288 0.0
(read/write) 1222106 1222186 80 0.0
.flash.rodata 164992 165072 80 0.0
.flash.text 833664 833952 288 0.0
m5stack (read only) 904711 904963 252 0.0
(read/write) 421400 421480 80 0.0
.flash.rodata 192936 193016 80 0.0
.flash.text 899327 899579 252 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707928 708244 316 0.0
.text 622996 623312 316 0.1
lock-app k32w061+debug (read/write) 599368 599684 316 0.1
.text 523956 524272 316 0.1
shell k32w061+debug (read/write) 664744 665060 316 0.0
.text 578204 578520 316 0.1
linux all-clusters-app debug (read only) 1748801 1749593 792 0.0
(read/write) 128688 128784 96 0.1
.data.rel.ro 63760 63856 96 0.2
.rodata 138549 138581 32 0.0
.text 1473874 1474418 544 0.0
bridge-app debug+rpc (read only) 1328645 1329469 824 0.1
(read/write) 76760 76856 96 0.1
.data.rel.ro 28608 28688 80 0.3
.rodata 113116 113180 64 0.1
.text 1117381 1117925 544 0.0
lighting-app debug+rpc (read only) 1597849 1598673 824 0.1
(read/write) 109976 110008 32 0.0
.data.rel.ro 56208 56240 32 0.1
.rodata 130833 130897 64 0.0
.text 1331266 1331810 544 0.0
tv-app debug (read only) 1890329 1891153 824 0.0
(read/write) 318832 318928 96 0.0
.data.rel.ro 60520 60616 96 0.2
.rodata 159389 159453 64 0.0
.text 1584754 1585298 544 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290672 2290936 264 0.0
.text 1253272 1253536 264 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274800 2275128 328 0.0
.text 1237400 1237728 328 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250632 2250968 336 0.0
.text 1213232 1213568 336 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865667 865967 300 0.0
rodata 95980 96056 76 0.1
text 583444 583672 228 0.0
nrf52840dk_nrf52840+rpc (read/write) 828035 828335 300 0.0
rodata 87164 87240 76 0.1
text 557612 557840 228 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790706 791006 300 0.0
rodata 91236 91312 76 0.1
text 512912 513140 228 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841099 841399 300 0.0
rodata 92452 92528 76 0.1
text 563540 563768 228 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 766386 766686 300 0.0
rodata 87756 87832 76 0.1
text 493096 493324 228 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847207 847507 300 0.0
rodata 94160 94236 76 0.1
text 567720 567948 228 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840799 841099 300 0.0
rodata 92408 92484 76 0.1
text 563160 563388 228 0.0
p6 all-clusters-app default (read/write) 2303656 2304208 552 0.0
.text 1261920 1262472 552 0.0
lock-app default (read/write) 2216840 2217392 552 0.0
.text 1175104 1175656 552 0.0
qpg lighting-app qpg6100+debug (read only) 494680 494996 316 0.1
.text 489360 489676 316 0.1
lock-app qpg6100+debug (read only) 469660 469960 300 0.1
.text 464340 464640 300 0.1
telink lighting-app tlsr9518adk80d (read/write) 769042 769406 364 0.0
text 534004 534292 288 0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 779ef51 e119b2a change % change
efr32 lighting-app BRD4161A (read only) 751376 751928 552 0.1
(read/write) 119692 119692 0 0.0
.bss 117884 117884 0 0.0
.data 1808 1808 0 0.0
.text 751368 751920 552 0.1
BRD4161A+rpc (read only) 738884 739436 552 0.1
(read/write) 136320 136320 0 0.0
.bss 134388 134388 0 0.0
.data 1932 1932 0 0.0
.text 738876 739428 552 0.1
lock-app BRD4161A (read only) 728448 729000 552 0.1
(read/write) 117476 117476 0 0.0
.bss 115708 115708 0 0.0
.data 1764 1764 0 0.0
.text 728440 728992 552 0.1
window-app BRD4161A (read only) 731896 732448 552 0.1
(read/write) 117836 117836 0 0.0
.bss 116060 116060 0 0.0
.data 1772 1772 0 0.0
.text 731888 732440 552 0.1
esp32 all-clusters-app c3devkit (read only) 833664 833952 288 0.0
(read/write) 1222106 1222186 80 0.0
.dram0.bss 57760 57760 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 164992 165072 80 0.0
.flash.text 833664 833952 288 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 904711 904963 252 0.0
(read/write) 421400 421480 80 0.0
.dram0.bss 63120 63120 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 192936 193016 80 0.0
.flash.text 899327 899579 252 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707928 708244 316 0.0
.bss 77212 77212 0 0.0
.data 1920 1920 0 0.0
.text 622996 623312 316 0.1
lock-app k32w061+debug (read/write) 599368 599684 316 0.1
.bss 67724 67724 0 0.0
.data 1888 1888 0 0.0
.text 523956 524272 316 0.1
shell k32w061+debug (read/write) 664744 665060 316 0.0
.bss 78884 78884 0 0.0
.data 1856 1856 0 0.0
.text 578204 578520 316 0.1
linux all-clusters-app debug (read only) 1748801 1749593 792 0.0
(read/write) 128688 128784 96 0.1
.bss 58576 58576 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63760 63856 96 0.2
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 138549 138581 32 0.0
.text 1473874 1474418 544 0.0
bridge-app debug+rpc (read only) 1328645 1329469 824 0.1
(read/write) 76760 76856 96 0.1
.bss 41552 41552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 28608 28688 80 0.3
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 113116 113180 64 0.1
.text 1117381 1117925 544 0.0
chip-tool debug (read only) 5875885 5875885 0 0.0
(read/write) 195936 195936 0 0.0
.bss 39896 39896 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 148192 148192 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 278778 278778 0 0.0
.text 5216741 5216741 0 0.0
lighting-app debug+rpc (read only) 1597849 1598673 824 0.1
(read/write) 109976 110008 32 0.0
.bss 47216 47216 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 56208 56240 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 130833 130897 64 0.0
.text 1331266 1331810 544 0.0
ota-provider-app debug (read only) 1279465 1279465 0 0.0
(read/write) 75376 75376 0 0.0
.bss 44128 44128 0 0.0
.data 800 800 0 0.0
.data.rel.ro 25336 25336 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 456 456 0 0.0
.rodata 114903 114903 0 0.0
.text 1065890 1065890 0 0.0
ota-requestor-app debug (read only) 1375729 1375729 0 0.0
(read/write) 79240 79240 0 0.0
.bss 46592 46592 0 0.0
.data 864 864 0 0.0
.data.rel.ro 26664 26664 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 126312 126312 0 0.0
.text 1147954 1147954 0 0.0
shell debug (read only) 804577 804577 0 0.0
(read/write) 66160 66160 0 0.0
.bss 23336 23336 0 0.0
.data 274 274 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 352 352 0 0.0
.rodata 79279 79279 0 0.0
.text 620194 620194 0 0.0
tv-app debug (read only) 1890329 1891153 824 0.0
(read/write) 318832 318928 96 0.0
.bss 249848 249848 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 60520 60616 96 0.2
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159389 159453 64 0.0
.text 1584754 1585298 544 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290672 2290936 264 0.0
.bss 180308 180308 0 0.0
.data 5232 5232 0 0.0
.heap 850904 850904 0 0.0
.text 1253272 1253536 264 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274800 2275128 328 0.0
.bss 172212 172212 0 0.0
.data 5584 5584 0 0.0
.heap 858648 858648 0 0.0
.text 1237400 1237728 328 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250632 2250968 336 0.0
.bss 171092 171092 0 0.0
.data 5576 5576 0 0.0
.heap 859776 859776 0 0.0
.text 1213232 1213568 336 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050872 2050872 0 0.0
.bss 156280 156280 0 0.0
.data 4976 4976 0 0.0
.heap 875192 875192 0 0.0
.text 1013472 1013472 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865667 865967 300 0.0
bss 110616 110616 0 0.0
rodata 95980 96056 76 0.1
text 583444 583672 228 0.0
nrf52840dk_nrf52840+rpc (read/write) 828035 828335 300 0.0
bss 106972 106972 0 0.0
rodata 87164 87240 76 0.1
text 557612 557840 228 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790706 791006 300 0.0
bss 111992 111992 0 0.0
rodata 91236 91312 76 0.1
text 512912 513140 228 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841099 841399 300 0.0
bss 109640 109640 0 0.0
rodata 92452 92528 76 0.1
text 563540 563768 228 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 766386 766686 300 0.0
bss 111052 111052 0 0.0
rodata 87756 87832 76 0.1
text 493096 493324 228 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847207 847507 300 0.0
bss 109780 109780 0 0.0
rodata 94160 94236 76 0.1
text 567720 567948 228 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840799 841099 300 0.0
bss 109676 109676 0 0.0
rodata 92408 92484 76 0.1
text 563160 563388 228 0.0
shell nrf52840dk_nrf52840 (read/write) 778639 778639 0 0.0
bss 109160 109160 0 0.0
rodata 73196 73196 0 0.0
text 521668 521668 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693662 693662 0 0.0
bss 110144 110144 0 0.0
rodata 67840 67840 0 0.0
text 442276 442276 0 0.0
p6 all-clusters-app default (read/write) 2303656 2304208 552 0.0
.bss 113296 113296 0 0.0
.data 2536 2536 0 0.0
.heap 917512 917512 0 0.0
.text 1261920 1262472 552 0.0
lock-app default (read/write) 2216840 2217392 552 0.0
.bss 100952 100952 0 0.0
.data 2408 2408 0 0.0
.heap 929984 929984 0 0.0
.text 1175104 1175656 552 0.0
qpg lighting-app qpg6100+debug (read only) 494680 494996 316 0.1
(read/write) 114144 114144 0 0.0
.bss 50264 50264 0 0.0
.data 1016 1016 0 0.0
.text 489360 489676 316 0.1
lock-app qpg6100+debug (read only) 469660 469960 300 0.1
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 972 972 0 0.0
.text 464340 464640 300 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769042 769406 364 0.0
bss 79136 79136 0 0.0
noinit 37160 37160 0 0.0
text 534004 534292 288 0.1

yunhanw-google
yunhanw-google approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andy31415
Copy link
Contributor

fast track: change by domain owner, sufficient time passed for all timezone review.

@andy31415 andy31415 merged commit 594ccf1 into project-chip:master Nov 23, 2021
@yufengwangca yufengwangca deleted the pr/diagnostic/general branch November 23, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @andy31415 @msandstedt @yunhanw-google