-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Yaml] WindowCovering: Fix and Update WNCV_1_1 and WNCV_2_1 #12096
Merged
andy31415
merged 8 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-fix-basic-test
Nov 23, 2021
Merged
[Yaml] WindowCovering: Fix and Update WNCV_1_1 and WNCV_2_1 #12096
andy31415
merged 8 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-fix-basic-test
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
November 22, 2021 14:37
pullapprove
bot
requested review from
tecimovic,
turon,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
November 22, 2021 14:37
PR #12096: Size comparison from b0a7973 to c56d53a Increases above 0.2%:
Increases (1 build for linux)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
PR #12096: Size comparison from befd208 to 3de4897 Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast track: sample app change and tests |
@jmeg-sfy - merge conflicts |
ReneJosefsen
approved these changes
Nov 23, 2021
jmeg-sfy
force-pushed
the
jmeg-sfy/window-covering-fix-basic-test
branch
from
November 23, 2021 10:30
3de4897
to
6c7370c
Compare
PR #12096: Size comparison from 79fe72a to 6c7370c Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Some checks on Attributes weren't correct for other devices on Test Events
Change overview
We are now capable to check feature map presence
BUT are not capable of checking ATTRIBUTE mandate following it (later PR to fix it)
Testing
How was this tested? (at least one bullet point required)
Tested with chip tool with EFR32 WindowCovering implementation
Pass the CI with attributes to their defaulted values