-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch Basic Information and Bridged Device Basic Information Clusters in SDK vs spec (Issue 10908) #12094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple and
saurabhst
November 22, 2021 13:09
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
November 22, 2021 13:09
PR #12094: Size comparison from beb6096 to 2e73af0 Increases (17 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (3 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
tcarmelveilleux
approved these changes
Nov 22, 2021
jmartinez-silabs
approved these changes
Nov 22, 2021
pjzander-signify
force-pushed
the
issue_10908
branch
from
November 22, 2021 15:04
794d21f
to
aa2b3c2
Compare
PR #12094: Size comparison from befd208 to aa2b3c2 Increases (17 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (3 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pjzander-signify
force-pushed
the
issue_10908
branch
from
November 23, 2021 08:52
aa2b3c2
to
91bae31
Compare
PR #12094: Size comparison from b83502b to 91bae31 Increases (10 builds for efr32, k32w, linux, p6, qpg, telink)
Decreases (1 build for p6)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
pjzander-signify
force-pushed
the
issue_10908
branch
from
November 23, 2021 11:14
7f957c8
to
ff1e15c
Compare
PR #12094: Size comparison from 79fe72a to ff1e15c Increases (17 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (3 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast track: spec change for examples app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a mismatch between the spec and the implementation of the Basic Information cluster and the Bridged Device Basic Information cluster.
See #10908.
Change overview
Modified SDK to be compliant with the spec,
Testing
All CI tests are passed.