-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACLs: Added SessionType and CATs Parameters #12027
ACLs: Added SessionType and CATs Parameters #12027
Conversation
PR #12027: Size comparison from 1adaf7a to ee79c69 Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
ee79c69
to
8bdd20d
Compare
PR #12027: Size comparison from 5bad4ed to 8bdd20d Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
The spec was updated with #4646 merge |
PR #12027: Size comparison from 4bb1e67 to 7365d5b Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'm OK with it, though I don't know a lot about the cert details. As long as we can get the CATs, with ID and version, into the secure session objects, we can then begin feeding them into the SubjectDescriptor for use by Access Control. Tennessee had a few comments.
5cc2f78
to
724eb70
Compare
@bzbarsky-apple PTAL and approve. Your and other comments were addressed. |
PR #12027: Size comparison from 7d55d2e to 724eb70 Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
Fast tracking given this has been in review for a while. |
…ingSession Classes
724eb70
to
dde81a6
Compare
PR #12027: Size comparison from 6c3004e to dde81a6 Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Part of work on #10243
Change overview
Added SessionType and CATs Parameters to SecureSession and PairingSession Classes
Testing
Unit testing. Added new tests