Return only operational devices GetConnectedDevice #11993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the exception of commissioning, all cluster commands should be sent over operational connection. Falling back to the PASE connection is probably not what we actually want here. For commissioning, callers should either use the provided commissioning flow in the SDK or use the provided GetDeviceBeingCommissioned. This also makes it much more obvious in the code which connection is being used.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
|
PR #11993: Size comparison from ef6455d to 37b4b08 Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
requested changes
Nov 19, 2021
msandstedt
approved these changes
Nov 19, 2021
bzbarsky-apple
approved these changes
Nov 20, 2021
chip-device-ctrl BLE commissioning procedure is very manual which means folks are actually sending commands manually over the PASE connection to add and enable the network. This first checks the PASE connection and sends over CASE if we're not currently commissioning the device.
|
PR #11993: Size comparison from 53721c0 to 6fbd391 Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 24, 2021
|
PR #11993: Size comparison from 8bfdc13 to f504542 Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #11993: Size comparison from 8a2fd0d to d406ec0 Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GetConnectedDevice should return the OperationalDeviceProxy.
With the exception of commissioning, all cluster commands should
be sent over operational connection. Falling back to the PASE
connection is probably not what we actually want here. For
commissioning, callers should either use the provided commissioning
flow in the SDK or use the provided GetDeviceBeingCommissioned.
This also makes it much more obvious in the code which connection
is being used.
Change overview
Changed return type on the OnDeviceConnectedFn callback, removed
fallback to PASE connected device in GetConnectedDevice.
Testing
Covered by cirque / darwin tests. Tested manually with chip-tool