-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DiagnosticDataProvider interface #11981
Implement DiagnosticDataProvider interface #11981
Conversation
Get stack info of each threadconnectedhomeip/src/platform/Linux/DiagnosticDataProviderImpl.cpp Lines 115 to 125 in ea1da16
This comment was generated by todo based on a
|
PR #11981: Size comparison from ef6455d to ea1da16 Increases above 0.2%:
Increases (7 builds for k32w, p6, qpg)
Decreases (3 builds for k32w, p6)
Full report (8 builds for k32w, p6, qpg)
|
PR #11981: Size comparison from ef6455d to 16b4acf Increases above 0.2%:
Increases (23 builds for efr32, k32w, linux, mbed, p6, qpg)
Decreases (11 builds for efr32, k32w, mbed, p6)
Full report (25 builds for efr32, k32w, linux, mbed, p6, qpg)
|
PR #11981: Size comparison from 7653f00 to 07adbad Increases above 0.2%:
Increases (25 builds for efr32, esp32, k32w, linux, mbed, p6, qpg)
Decreases (19 builds for efr32, k32w, mbed, nrfconnect, p6, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure Zephyr's implementation is used in nRF connect and Telink platforms, and is initialized properly.
PR #11981: Size comparison from aa8a6d0 to 8b88ffd Increases above 0.2%:
Increases (5 builds for k32w, qpg)
Decreases (1 build for qpg)
Full report (6 builds for k32w, qpg)
|
PR #11981: Size comparison from f58ad86 to 83daa49 Increases above 0.2%:
Increases (2 builds for qpg)
Decreases (1 build for qpg)
Full report (3 builds for qpg)
|
PR #11981: Size comparison from 9a6c97b to cb367b9 Increases above 0.2%:
Increases (7 builds for k32w, p6, qpg)
Decreases (3 builds for p6, qpg)
Full report (8 builds for k32w, p6, qpg)
|
PR #11981: Size comparison from 63ea01b to 1158afe Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (11 builds for efr32, mbed, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
What is being fixed? Examples:
Current exiting platform interfaces based on CRTP are complicated and over-bloated. Instead of plugging all operations to existing APIs, we will introduce dedicated DiagnosticDataProvider + DiagnosticsDelegate platform interface for all diagnostics clusters, and migrate all diagnostics attributes to use this new interface.
Fixes Introduce DiagnosticDataProvider + DiagnosticsDelegate for all diagnostics clusters. #11922
Change overview
Implement DiagnosticDataProvider interface
Diagnostics attributes in ConnectivityMgr will be migrated in another PR.
Testing
How was this tested? (at least one bullet point required)