-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32C3] remove unused external component #11970
Merged
andy31415
merged 1 commit into
project-chip:master
from
zwx1995esp:feature/remove_esp32c3_unused_extra_component
Nov 22, 2021
Merged
[ESP32C3] remove unused external component #11970
andy31415
merged 1 commit into
project-chip:master
from
zwx1995esp:feature/remove_esp32c3_unused_extra_component
Nov 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwx1995esp
changed the title
ESP32C3: remove unused external component
[ESP32C3] remove unused external component
Nov 18, 2021
Damian-Nordic
approved these changes
Nov 18, 2021
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lzgrablic02,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
November 19, 2021 02:56
pullapprove
bot
requested review from
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
November 19, 2021 02:56
dhrishi
reviewed
Nov 20, 2021
zwx1995esp
force-pushed
the
feature/remove_esp32c3_unused_extra_component
branch
from
November 22, 2021 06:15
0aedd9b
to
200dff9
Compare
andy31415
approved these changes
Nov 22, 2021
fast track: platform specific change |
PR #11970: Size comparison from 4bb1e67 to 200dff9 Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
with the tag
release/v4.4
of the ESP-IDF, there is a commit (cccdb3e) which has already movedexamples/peripherals/rmt/led_strip/component/led_strip
to theexamples/common_components
. In the commit05cdfbfa3c
we have already added the new dirs${IDF_PATH}/examples/common_components
, but did not removed this unused external component.