Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some alerts founded the LGTM system #11966

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Fix some alerts founded the LGTM system #11966

merged 1 commit into from
Nov 26, 2021

Conversation

tdrozdovsky
Copy link
Contributor

Signed-off-by: Taras Drozdovskyi [email protected]

Problem

Fix LGTM alerts
Change overview

Some LGTM alerts are fixed.

@github-actions
Copy link

github-actions bot commented Nov 18, 2021 •
edited
Loading

PR #11966: Size comparison from 2a7eaf0 to 1003259

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2a7eaf0 1003259 change % change
efr32 lighting-app BRD4161A (read only) 749456 749456 0 0.0
(read/write) 115540 115540 0 0.0
.bss 113740 113740 0 0.0
.data 1800 1800 0 0.0
.text 749448 749448 0 0.0
BRD4161A+rpc (read only) 736988 736988 0 0.0
(read/write) 132168 132168 0 0.0
.bss 130244 130244 0 0.0
.data 1924 1924 0 0.0
.text 736980 736980 0 0.0
lock-app BRD4161A (read only) 726528 726528 0 0.0
(read/write) 113324 113324 0 0.0
.bss 111564 111564 0 0.0
.data 1756 1756 0 0.0
.text 726520 726520 0 0.0
window-app BRD4161A (read only) 727504 727504 0 0.0
(read/write) 113644 113644 0 0.0
.bss 111884 111884 0 0.0
.data 1760 1760 0 0.0
.text 727496 727496 0 0.0
esp32 all-clusters-app c3devkit (read only) 828296 828296 0 0.0
(read/write) 1220130 1220130 0 0.0
.dram0.bss 56688 56688 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164104 164104 0 0.0
.flash.text 828296 828296 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899319 899319 0 0.0
(read/write) 419452 419452 0 0.0
.dram0.bss 62040 62040 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192076 192076 0 0.0
.flash.text 893935 893935 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706636 706636 0 0.0
.bss 77164 77164 0 0.0
.data 1912 1912 0 0.0
.text 621760 621760 0 0.0
lock-app k32w061+debug (read/write) 598076 598076 0 0.0
.bss 67676 67676 0 0.0
.data 1880 1880 0 0.0
.text 522720 522720 0 0.0
shell k32w061+debug (read/write) 663420 663420 0 0.0
.bss 78804 78804 0 0.0
.data 1848 1848 0 0.0
.text 576968 576968 0 0.0
linux all-clusters-app debug (read only) 1724201 1724201 0 0.0
(read/write) 126816 126816 0 0.0
.bss 57392 57392 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136341 136341 0 0.0
.text 1453906 1453906 0 0.0
bridge-app debug+rpc (read only) 1319301 1319301 0 0.0
(read/write) 77008 77008 0 0.0
.bss 42096 42096 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111684 111684 0 0.0
.text 1110213 1110213 0 0.0
chip-tool debug (read only) 4980557 4980557 0 0.0
(read/write) 166920 166920 0 0.0
.bss 40456 40456 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268362 268362 0 0.0
.text 4401685 4401685 0 0.0
lighting-app debug+rpc (read only) 1588385 1588385 0 0.0
(read/write) 110224 110224 0 0.0
.bss 47760 47760 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129265 129265 0 0.0
.text 1324114 1324114 0 0.0
ota-provider-app debug (read only) 1267993 1267993 0 0.0
(read/write) 75656 75656 0 0.0
.bss 44704 44704 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113855 113855 0 0.0
.text 1056546 1056546 0 0.0
ota-requestor-app debug (read only) 1353665 1353665 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47168 47168 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124872 124872 0 0.0
.text 1128818 1128818 0 0.0
shell debug (read only) 798209 798209 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 615490 615490 0 0.0
tv-app debug (read only) 1870881 1870881 0 0.0
(read/write) 318968 318968 0 0.0
.bss 250376 250376 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157669 157669 0 0.0
.text 1568082 1568082 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287384 2287384 0 0.0
.bss 179284 179284 0 0.0
.data 5216 5216 0 0.0
.heap 851944 851944 0 0.0
.text 1249984 1249984 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273320 2273320 0 0.0
.bss 172148 172148 0 0.0
.data 5576 5576 0 0.0
.heap 858720 858720 0 0.0
.text 1235920 1235920 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249160 2249160 0 0.0
.bss 171036 171036 0 0.0
.data 5568 5568 0 0.0
.heap 859840 859840 0 0.0
.text 1211760 1211760 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050352 2050352 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1012952 1012952 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864295 864295 0 0.0
bss 110560 110560 0 0.0
rodata 95784 95784 0 0.0
text 582344 582344 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 826695 826695 0 0.0
bss 106916 106916 0 0.0
rodata 86968 86968 0 0.0
text 556512 556512 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789354 789354 0 0.0
bss 111936 111936 0 0.0
rodata 91044 91044 0 0.0
text 511816 511816 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839727 839727 0 0.0
bss 109584 109584 0 0.0
rodata 92256 92256 0 0.0
text 562436 562436 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765014 765014 0 0.0
bss 110996 110996 0 0.0
rodata 87560 87560 0 0.0
text 492000 492000 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845835 845835 0 0.0
bss 109724 109724 0 0.0
rodata 93964 93964 0 0.0
text 566620 566620 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839427 839427 0 0.0
bss 109620 109620 0 0.0
rodata 92212 92212 0 0.0
text 562056 562056 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777795 777795 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521068 521068 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692850 692850 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441680 441680 0 0.0
p6 all-clusters-app default (read/write) 2297480 2297480 0 0.0
.bss 112272 112272 0 0.0
.data 2520 2520 0 0.0
.heap 918552 918552 0 0.0
.text 1255744 1255744 0 0.0
lock-app default (read/write) 2214968 2214968 0 0.0
.bss 100896 100896 0 0.0
.data 2400 2400 0 0.0
.heap 930048 930048 0 0.0
.text 1173232 1173232 0 0.0
qpg lighting-app qpg6100+debug (read only) 493472 493472 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50208 50208 0 0.0
.data 1008 1008 0 0.0
.text 488152 488152 0 0.0
lock-app qpg6100+debug (read only) 468452 468452 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49152 49152 0 0.0
.data 964 964 0 0.0
.text 463132 463132 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767742 767742 0 0.0
bss 79072 79072 0 0.0
noinit 37160 37160 0 0.0
text 532972 532972 0 0.0

@andy31415
Copy link
Contributor

@tdrozdovsky - zap failures. Guessing some python files are generated from zap and you have to update the zap templates. Also make sure that the templates will not eventually use the given imports

@github-actions
Copy link

github-actions bot commented Nov 18, 2021 •
edited
Loading

PR #11966: Size comparison from ef6455d to 2dda27d

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ef6455d 2dda27d change % change
efr32 lighting-app BRD4161A (read only) 749928 749928 0 0.0
(read/write) 115540 115540 0 0.0
.bss 113740 113740 0 0.0
.data 1800 1800 0 0.0
.text 749920 749920 0 0.0
BRD4161A+rpc (read only) 737468 737468 0 0.0
(read/write) 132168 132168 0 0.0
.bss 130244 130244 0 0.0
.data 1924 1924 0 0.0
.text 737460 737460 0 0.0
lock-app BRD4161A (read only) 726984 726984 0 0.0
(read/write) 113324 113324 0 0.0
.bss 111564 111564 0 0.0
.data 1756 1756 0 0.0
.text 726976 726976 0 0.0
window-app BRD4161A (read only) 727968 727968 0 0.0
(read/write) 113644 113644 0 0.0
.bss 111884 111884 0 0.0
.data 1760 1760 0 0.0
.text 727960 727960 0 0.0
esp32 all-clusters-app c3devkit (read only) 828536 828536 0 0.0
(read/write) 1220178 1220178 0 0.0
.dram0.bss 56688 56688 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164152 164152 0 0.0
.flash.text 828536 828536 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899555 899555 0 0.0
(read/write) 419492 419492 0 0.0
.dram0.bss 62040 62040 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192116 192116 0 0.0
.flash.text 894171 894171 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706840 706840 0 0.0
.bss 77164 77164 0 0.0
.data 1912 1912 0 0.0
.text 621964 621964 0 0.0
lock-app k32w061+debug (read/write) 598280 598280 0 0.0
.bss 67676 67676 0 0.0
.data 1880 1880 0 0.0
.text 522924 522924 0 0.0
shell k32w061+debug (read/write) 663624 663624 0 0.0
.bss 78804 78804 0 0.0
.data 1848 1848 0 0.0
.text 577172 577172 0 0.0
linux all-clusters-app debug (read only) 1726009 1726009 0 0.0
(read/write) 126816 126816 0 0.0
.bss 57392 57392 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136661 136661 0 0.0
.text 1455394 1455394 0 0.0
bridge-app debug+rpc (read only) 1321037 1321037 0 0.0
(read/write) 77008 77008 0 0.0
.bss 42096 42096 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111932 111932 0 0.0
.text 1111701 1111701 0 0.0
chip-tool debug (read only) 4985917 4985917 0 0.0
(read/write) 166888 166888 0 0.0
.bss 40456 40456 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118672 118672 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268458 268458 0 0.0
.text 4406949 4406949 0 0.0
lighting-app debug+rpc (read only) 1590161 1590161 0 0.0
(read/write) 110224 110224 0 0.0
.bss 47760 47760 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129553 129553 0 0.0
.text 1325602 1325602 0 0.0
ota-provider-app debug (read only) 1268601 1268601 0 0.0
(read/write) 75656 75656 0 0.0
.bss 44704 44704 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113951 113951 0 0.0
.text 1057058 1057058 0 0.0
ota-requestor-app debug (read only) 1354337 1354337 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47168 47168 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124968 124968 0 0.0
.text 1129394 1129394 0 0.0
shell debug (read only) 798801 798801 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616082 616082 0 0.0
tv-app debug (read only) 1872657 1872657 0 0.0
(read/write) 318968 318968 0 0.0
.bss 250376 250376 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60144 60144 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157893 157893 0 0.0
.text 1569634 1569634 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287616 2287616 0 0.0
.bss 179284 179284 0 0.0
.data 5216 5216 0 0.0
.heap 851944 851944 0 0.0
.text 1250216 1250216 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273552 2273552 0 0.0
.bss 172148 172148 0 0.0
.data 5576 5576 0 0.0
.heap 858720 858720 0 0.0
.text 1236152 1236152 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249392 2249392 0 0.0
.bss 171036 171036 0 0.0
.data 5568 5568 0 0.0
.heap 859840 859840 0 0.0
.text 1211992 1211992 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864563 864563 0 0.0
bss 110560 110560 0 0.0
rodata 95828 95828 0 0.0
text 582568 582568 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 826963 826963 0 0.0
bss 106916 106916 0 0.0
rodata 87012 87012 0 0.0
text 556736 556736 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789618 789618 0 0.0
bss 111936 111936 0 0.0
rodata 91084 91084 0 0.0
text 512040 512040 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839995 839995 0 0.0
bss 109584 109584 0 0.0
rodata 92300 92300 0 0.0
text 562660 562660 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765282 765282 0 0.0
bss 110996 110996 0 0.0
rodata 87604 87604 0 0.0
text 492224 492224 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846103 846103 0 0.0
bss 109724 109724 0 0.0
rodata 94008 94008 0 0.0
text 566844 566844 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839695 839695 0 0.0
bss 109620 109620 0 0.0
rodata 92256 92256 0 0.0
text 562280 562280 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777971 777971 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521236 521236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693026 693026 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441848 441848 0 0.0
p6 all-clusters-app default (read/write) 2297936 2297936 0 0.0
.bss 112272 112272 0 0.0
.data 2520 2520 0 0.0
.heap 918552 918552 0 0.0
.text 1256200 1256200 0 0.0
lock-app default (read/write) 2215424 2215424 0 0.0
.bss 100896 100896 0 0.0
.data 2400 2400 0 0.0
.heap 930048 930048 0 0.0
.text 1173688 1173688 0 0.0
qpg lighting-app qpg6100+debug (read only) 493688 493688 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50208 50208 0 0.0
.data 1008 1008 0 0.0
.text 488368 488368 0 0.0
lock-app qpg6100+debug (read only) 468652 468652 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49152 49152 0 0.0
.data 964 964 0 0.0
.text 463332 463332 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767986 767986 0 0.0
bss 79072 79072 0 0.0
noinit 37160 37160 0 0.0
text 533170 533170 0 0.0

@tdrozdovsky
Copy link
Contributor Author

@tdrozdovsky - zap failures. Guessing some python files are generated from zap and you have to update the zap templates. Also make sure that the templates will not eventually use the given imports

@andy31415 I excluded this file. Next time I carefully examine this question. Thank you!

@andy31415 andy31415 merged commit 22255ab into project-chip:master Nov 26, 2021
@andy31415
Copy link
Contributor

After ToT merging I got:

ImportError: Failed to import test module: test_generated_clusterobjects
Traceback (most recent call last):
  File "/usr/lib/python3.9/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.9/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/__w/connectedhomeip/connectedhomeip/src/controller/python/test/unit_tests/test_generated_clusterobjects.py", line 2, in <module>
    import chip.clusters as Clusters
  File "/__w/connectedhomeip/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/chip/clusters/__init__.py", line 25, in <module>
    from . import Attribute
  File "/__w/connectedhomeip/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/chip/clusters/Attribute.py", line 199, in <module>
    None, py_object, c_uint16, c_uint32, c_uint32, c_uint16, c_void_p, c_size_t)
NameError: name 'c_void_p' is not defined

@andy31415
Copy link
Contributor

At this point I am not sure I trust this LGTM thing. For the '== None' vs 'is None' fine, but the various improvements in imports seems not very stable.

andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Nov 26, 2021
@andy31415
Revert "Fix some alerts founded the LGTM system (project-chip#11966)"
cb72f67 
This reverts commit 22255ab.
andy31415 added a commit that referenced this pull request Nov 26, 2021
@andy31415
Revert "Fix some alerts founded the LGTM system (#11966)" (#12295)
65f4475 
This reverts commit 22255ab.
@andy31415
Copy link
Contributor

In hindsight maybe a /rebase before merging such PRs would have helped with CI. guessing new usages of things appeared in time.

@tdrozdovsky
Copy link
Contributor Author

@andy31415

After ToT merging I got:

ImportError: Failed to import test module: test_generated_clusterobjects
Traceback (most recent call last):
  File "/usr/lib/python3.9/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.9/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/__w/connectedhomeip/connectedhomeip/src/controller/python/test/unit_tests/test_generated_clusterobjects.py", line 2, in <module>
    import chip.clusters as Clusters
  File "/__w/connectedhomeip/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/chip/clusters/__init__.py", line 25, in <module>
    from . import Attribute
  File "/__w/connectedhomeip/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/chip/clusters/Attribute.py", line 199, in <module>
    None, py_object, c_uint16, c_uint32, c_uint32, c_uint16, c_void_p, c_size_t)
NameError: name 'c_void_p' is not defined

Looking at these lines, I see that there is the error. Tell me please, what you did I would like to reproduce to avoid further.
Of course this import is a smell code and in this case, I can suggest exclude this type of error as false-positive.

Please give me the answer or what do think about it. It is very important for me.
P.S. From the LGTM side, it is only recommendations, but if you look deeper from the security side, the incorrect transformation of pointers can lead to vulnerability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tdrozdovsky @andy31415 @msandstedt @bzbarsky-apple @Damian-Nordic