-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix status report ec nullout and suppress status response during read #11955
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/nullout_ec_status_response
Nov 20, 2021
Merged
Fix status report ec nullout and suppress status response during read #11955
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/nullout_ec_status_response
Nov 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic and
turon
November 18, 2021 05:31
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
November 18, 2021 05:31
PR #11955: Size comparison from 2b52b36 to b7c0d35 Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/nullout_ec_status_response
branch
2 times, most recently
from
November 18, 2021 19:27
f11e65d
to
e9f9305
Compare
yunhanw-google
force-pushed
the
feature/nullout_ec_status_response
branch
from
November 18, 2021 23:10
e9f9305
to
7bb28dc
Compare
PR #11955: Size comparison from 7653f00 to 7bb28dc Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 20, 2021
jmartinez-silabs
approved these changes
Nov 20, 2021
LuDuda
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
--check the return value of SendStatusResponse in ProcessReportData and dropping our ref to the exchange context if it fails
--suppress status response for non-chunk report during read
Change overview
See above
Testing
Update existing test with suppress flag