-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make device attestation data parser future proof #11946
Merged
tcarmelveilleux
merged 6 commits into
project-chip:master
from
tcarmelveilleux:fix-11247-deconstruct-attest-too-strict
Nov 19, 2021
Merged
Make device attestation data parser future proof #11946
tcarmelveilleux
merged 6 commits into
project-chip:master
from
tcarmelveilleux:fix-11247-deconstruct-attest-too-strict
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviceAttestationDeconstructor was too stringent in expecting no unknown tags at all, preventing future tags from breaking backward compatibility when they are benign if ignored. - Fix DeviceAttestationDeconstructor to skip unexpected tags - Simplify logic for ensuring in-order tags - Fix a corner case of the vendor-specific data iterator not caught before - Clean-up extraction of profileNum in CHIP tags Fixes project-chip#11247
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
November 17, 2021 22:15
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
November 17, 2021 22:15
tcarmelveilleux
commented
Nov 17, 2021
PR #11946: Size comparison from 2b52b36 to d9e4140 Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 18, 2021
Co-authored-by: Boris Zbarsky <[email protected]>
PR #11946: Size comparison from d6f8390 to 62bef80 Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 18, 2021
…-strict' into fix-11247-deconstruct-attest-too-strict
vijs
approved these changes
Nov 18, 2021
PR #11946: Size comparison from ef6455d to 959d8ed Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
hawk248
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DeviceAttestationDeconstructor was too stringent in expecting no
unknown tags at all, preventing future tags from breaking backward
compatibility when they are benign if ignored.
Fixes #11247
Change overview
caught before
Testing