-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub work flow for simulated device. #11931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krypton36
force-pushed
the
AddGithubWorkFlow
branch
from
November 17, 2021 17:50
bd2b5ac
to
5b71c51
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple and
saurabhst
November 17, 2021 17:51
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
November 17, 2021 17:51
PR #11931: Size comparison from e568d70 to 5b71c51 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
krypton36
force-pushed
the
AddGithubWorkFlow
branch
from
November 17, 2021 22:58
5b71c51
to
311124f
Compare
PR #11931: Size comparison from 2b52b36 to 311124f Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 18, 2021
krypton36
force-pushed
the
AddGithubWorkFlow
branch
from
November 18, 2021 17:32
311124f
to
541ba77
Compare
PR #11931: Size comparison from ef6455d to 541ba77 Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
PR #11931: Size comparison from ef6455d to a45271e Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 22, 2021
fast track: CI changes for more validation. PR has been up for review for sufficient time for all timezone review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Simulated device was not building during the creation of PR. If there was a build failure, it would not get caught until after it has been merged.
Change overview
Testing