-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for odd-sized (3, 5, 6, 7 bytes) integer types for attributes #11870
Add support for odd-sized (3, 5, 6, 7 bytes) integer types for attributes #11870
Conversation
a83e6e2
to
afa4259
Compare
PR #11870: Size comparison from 1d76b09 to afa4259 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested on unit tests: these are basic functions that are isolated and ideal candidates for unit testing. We should be able to validate the code.
Additionaly, it would be nice to split out endianess logic somehow so that unit tests for big endiand do not need to be run on big endian machines (that will not happen: we are testing on linux and darwin generally which are little endian)
41a0061
to
23c1750
Compare
23c1750
to
c45a92a
Compare
PR #11870: Size comparison from 098e736 to c45a92a Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast track: domain owner change, has unit tests for new code. |
c45a92a
to
503cb75
Compare
PR #11870: Size comparison from 2e85d48 to 503cb75 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
503cb75
to
6693873
Compare
PR #11870: Size comparison from 2e85d48 to 6693873 Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Fixes #8202
Problem
No read/write support for int24/40/48/56 types.
Change overview
Add Accessors and to/from TLV support.
Testing
Manual testing using int24u values. This could really use YAML tests.