Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size reports: Fix parent SHA race #11841

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Size reports: Fix parent SHA race #11841

merged 4 commits into from
Nov 16, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

For a GitHub PR, the actual parent may be different from the commit
given by github.event.pull_request.base.sha (see
actions/checkout#27). In this case, size
reports incorrectly include changes from commit(s) between the purported
and actual parent.

Change overview

Extract the actual parent from the PR merge commit subject.

Testing

Manually checked externally
https://github.com/kpschoedel/actiontest/runs/4226639507
Actual confirmation can only happen on live CI runs.

@kpschoedel
Size reports: Fix parent SHA race
c61e299 
#### Problem

For a GitHub PR, the actual parent may be different from the commit
given by `github.event.pull_request.base.sha` (see
actions/checkout#27). In this case, size
reports incorrectly include changes from commit(s) between the purported
and actual parent.

#### Change overview

Extract the actual parent from the PR merge commit subject.

#### Testing

Manually checked externally
    https://github.com/kpschoedel/actiontest/runs/4226639507
Actual confirmation can only happen on live CI runs.
@kpschoedel kpschoedel marked this pull request as draft November 16, 2021 15:59
@kpschoedel
Copy link
Contributor Author

kpschoedel commented Nov 16, 2021 •
edited
Loading

Temporarily set to draft — $GH_EVENT_PARENT is used by gh_sizes.py so it needs to be set earlier. Done

@kpschoedel kpschoedel marked this pull request as ready for review November 16, 2021 16:04
@andy31415 andy31415 merged commit 1d76b09 into project-chip:master Nov 16, 2021
@github-actions
Copy link

PR #11841: Size comparison from 0c88b57 to d17272d

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0c88b57 d17272d change % change
efr32 lighting-app BRD4161A (read only) 745208 745208 0 0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745200 745200 0 0.0
lock-app BRD4161A (read only) 722296 722296 0 0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722288 722288 0 0.0
window-app BRD4161A (read only) 723272 723272 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723264 723264 0 0.0
lighting-app BRD4161A+rpc (read only) 732724 732724 0 0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732716 732716 0 0.0
esp32 all-clusters-app c3devkit (read only) 824912 824912 0 0.0
(read/write) 1219650 1219650 0 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163800 0 0.0
.flash.text 824912 824912 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 895819 0 0.0
(read/write) 418980 418980 0 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191780 0 0.0
.flash.text 890435 890435 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lock-app k32w061+debug (read/write) 595020 595020 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 519840 519840 0 0.0
shell k32w061+debug (read/write) 660252 660252 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574040 574040 0 0.0
lighting-app k32w061+se05x+release (read/write) 703576 703576 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 618876 618876 0 0.0
linux all-clusters-app debug (read only) 1701841 1701841 0 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135253 0 0.0
.text 1433138 1433138 0 0.0
chip-tool debug (read only) 4892293 4892293 0 0.0
(read/write) 166280 166280 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 117936 117936 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265554 265554 0 0.0
.text 4317765 4317765 0 0.0
ota-provider-app debug (read only) 1252473 1252473 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112999 0 0.0
.text 1042386 1042386 0 0.0
ota-requestor-app debug (read only) 1335393 1335393 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123792 123792 0 0.0
.text 1112178 1112178 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1838569 1838569 0 0.0
(read/write) 405016 405016 0 0.0
.bss 336968 336968 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155149 155149 0 0.0
.text 1539154 1539154 0 0.0
bridge-app debug+rpc (read only) 1297013 1297013 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110668 0 0.0
.text 1089445 1089445 0 0.0
lighting-app debug+rpc (read only) 1566073 1566073 0 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128273 0 0.0
.text 1303298 1303298 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2283728 0 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1246328 1246328 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2269720 0 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1232320 1232320 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2245560 0 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1208160 1208160 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860183 0 0.0
bss 110384 110384 0 0.0
rodata 95032 95032 0 0.0
text 579140 579140 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835579 835579 0 0.0
bss 109408 109408 0 0.0
rodata 91500 91500 0 0.0
text 559236 559236 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 841723 0 0.0
bss 109548 109548 0 0.0
rodata 93212 93212 0 0.0
text 563420 563420 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835315 0 0.0
bss 109444 109444 0 0.0
rodata 91460 91460 0 0.0
text 558856 558856 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822551 0 0.0
bss 106740 106740 0 0.0
rodata 86216 86216 0 0.0
text 553312 553312 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785222 0 0.0
bss 111760 111760 0 0.0
rodata 90288 90288 0 0.0
text 508608 508608 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 760902 0 0.0
bss 110820 110820 0 0.0
rodata 86808 86808 0 0.0
text 488796 488796 0 0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292608 2292608 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1250872 1250872 0 0.0
lock-app default (read/write) 2210080 2210080 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168344 1168344 0 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489736 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484416 484416 0 0.0
lock-app qpg6100+debug (read only) 464692 464692 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459372 459372 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763014 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529210 529210 0 0.0

@kpschoedel kpschoedel deleted the nubloat-report-14-race branch November 18, 2021 17:01
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Nov 18, 2021
@kpschoedel
Size reports: Fix parent SHA race (project-chip#11841)
d16edf3 
* Size reports: Fix parent SHA race

#### Problem

For a GitHub PR, the actual parent may be different from the commit
given by `github.event.pull_request.base.sha` (see
actions/checkout#27). In this case, size
reports incorrectly include changes from commit(s) between the purported
and actual parent.

#### Change overview

Extract the actual parent from the PR merge commit subject.

#### Testing

Manually checked externally
    https://github.com/kpschoedel/actiontest/runs/4226639507
Actual confirmation can only happen on live CI runs.

* set $GH_EVENT_PARENT before gh_sizes.py runs

* Use `test` instead of `[[`

* POSIX `test`
raqbit pushed a commit to raqbit/connectedhomeip that referenced this pull request Nov 19, 2021
@kpschoedel @raqbit
Size reports: Fix parent SHA race (project-chip#11841)
5071507 
* Size reports: Fix parent SHA race

#### Problem

For a GitHub PR, the actual parent may be different from the commit
given by `github.event.pull_request.base.sha` (see
actions/checkout#27). In this case, size
reports incorrectly include changes from commit(s) between the purported
and actual parent.

#### Change overview

Extract the actual parent from the PR merge commit subject.

#### Testing

Manually checked externally
    https://github.com/kpschoedel/actiontest/runs/4226639507
Actual confirmation can only happen on live CI runs.

* set $GH_EVENT_PARENT before gh_sizes.py runs

* Use `test` instead of `[[`

* POSIX `test`
@kpschoedel kpschoedel mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
fast track github review - pending workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpschoedel @tcarmelveilleux @andy31415 @msandstedt