-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Update TestCommand.cpp so it does not automatically wait for the device to be retrieved but do it conditionally if WaitForCommissionee is used in the test #11833
Conversation
PR #11833: Size comparison from bbd19d9 to 9b6e229 Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Don't you think this was maybe better to do it per Cluster rather than having it into every single test file ? |
This is unrelated to clusters themselves so it has to live into the test file. |
9b6e229
to
0cb6f9a
Compare
PR #11833: Size comparison from 40320ad to 0cb6f9a Increases above 0.2%:
Increases (1 build for linux)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
0cb6f9a
to
cb34b1b
Compare
PR #11833: Size comparison from e755a26 to cb34b1b Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
cb34b1b
to
f9d0ca4
Compare
PR #11833: Size comparison from c79b67b to f9d0ca4 Full report (9 builds for k32w, p6, qpg, telink)
|
f9d0ca4
to
bad14b1
Compare
PR #11833: Size comparison from c79b67b to bad14b1 Increases above 0.2%:
Increases (1 build for linux)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
bad14b1
to
43bd9de
Compare
PR #11833: Size comparison from 914b58e to 43bd9de Increases above 0.2%:
Increases (1 build for linux)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
43bd9de
to
4519e48
Compare
PR #11833: Size comparison from 914b58e to 4519e48 Increases above 0.2%:
Increases (1 build for linux)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
6506389
to
5f2672d
Compare
PR #11833: Size comparison from badf2e4 to 5f2672d Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
Fast tracking given this enables tests. |
…ce to be retrieved but do it conditionally if WaitForCommissionee is used in the test
5f2672d
to
b80dadd
Compare
PR #11833: Size comparison from 02bd2c7 to b80dadd Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
YAML tests can not be used for testing commissioning since they automatically try to retrieve a device previously commissioned.
Change overview
WaitForCommissionee
commandTesting
The test step has been added to most step (except 1)