Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup IM messagedef #11811

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Cleanup IM messagedef #11811

merged 1 commit into from
Nov 16, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Nov 15, 2021 •
edited
Loading

Problem

Replace buidler/parser base with structBuilder/Parser for the rest of IM struct type message.
Replace ReturnLogErroronFailure and VerifyLogErrorOnFailure without log since CHIP_ERROR has recorded the initial error location.

Change overview

See above

Testing

Presubmit test validates it, no logic change

@yunhanw-google
Cleanup IM messagedef
9b29b02 
Replace buidler/parser base with  structBuilder/Parser for rest struct message.
Replace ReturnLogErroronFailure and VerifyLogErrorOnFailure without log since CHIP_ERROR has recorded the initial error location.
@boring-cyborg boring-cyborg bot added the app label Nov 15, 2021
@github-actions
Copy link

github-actions bot commented Nov 15, 2021 •
edited
Loading

PR #11811: Size comparison from 1903401 to 9b29b02

Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1903401 9b29b02 change % change
efr32 lighting-app BRD4161A (read only) 746648 745224 -1424 -0.2
.text 746640 745216 -1424 -0.2
BRD4161A+rpc (read only) 734188 732740 -1448 -0.2
.text 734180 732732 -1448 -0.2
lock-app BRD4161A (read only) 723712 722312 -1400 -0.2
.text 723704 722304 -1400 -0.2
window-app BRD4161A (read only) 724704 723288 -1416 -0.2
.text 724696 723280 -1416 -0.2
esp32 all-clusters-app c3devkit (read only) 825820 824912 -908 -0.1
(read/write) 1220258 1219650 -608 -0.0
.flash.rodata 164408 163800 -608 -0.4
.flash.text 825820 824912 -908 -0.1
m5stack (read only) 896619 895815 -804 -0.1
(read/write) 419580 418980 -600 -0.1
.flash.rodata 192380 191780 -600 -0.3
.flash.text 891235 890431 -804 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 705032 703608 -1424 -0.2
.text 620332 618908 -1424 -0.2
lock-app k32w061+debug (read/write) 596448 595052 -1396 -0.2
.text 521268 519872 -1396 -0.3
shell k32w061+debug (read/write) 661664 660284 -1380 -0.2
.text 575452 574072 -1380 -0.2
linux all-clusters-app debug (read only) 1709953 1701841 -8112 -0.5
.rodata 135349 135253 -96 -0.1
.text 1441154 1433138 -8016 -0.6
bridge-app debug+rpc (read only) 1305125 1297013 -8112 -0.6
.rodata 110764 110668 -96 -0.1
.text 1097461 1089445 -8016 -0.7
chip-tool debug (read only) 4900629 4892277 -8352 -0.2
.rodata 265618 265554 -64 -0.0
.text 4326037 4317749 -8288 -0.2
lighting-app debug+rpc (read only) 1574153 1566073 -8080 -0.5
.rodata 128337 128273 -64 -0.0
.text 1311314 1303298 -8016 -0.6
ota-provider-app debug (read only) 1260553 1252473 -8080 -0.6
.rodata 113063 112999 -64 -0.1
.text 1050402 1042386 -8016 -0.8
ota-requestor-app debug (read only) 1343681 1335393 -8288 -0.6
.rodata 123888 123792 -96 -0.1
.text 1120370 1112178 -8192 -0.7
tv-app debug (read only) 1846809 1838553 -8256 -0.4
.rodata 155213 155149 -64 -0.0
.text 1547330 1539138 -8192 -0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2285472 2283728 -1744 -0.1
.text 1248072 1246328 -1744 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271408 2269720 -1688 -0.1
.text 1234008 1232320 -1688 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2247312 2245560 -1752 -0.1
.text 1209912 1208160 -1752 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861319 860215 -1104 -0.1
rodata 95400 95032 -368 -0.4
text 579904 579168 -736 -0.1
nrf52840dk_nrf52840+rpc (read/write) 823691 822583 -1108 -0.1
rodata 86588 86216 -372 -0.4
text 554076 553340 -736 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 786362 785254 -1108 -0.1
rodata 90660 90288 -372 -0.4
text 509372 508636 -736 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 836719 835595 -1124 -0.1
rodata 91872 91500 -372 -0.4
text 560004 559264 -740 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 762038 760934 -1104 -0.1
rodata 87176 86808 -368 -0.4
text 489564 488824 -740 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 842859 841755 -1104 -0.1
rodata 93580 93212 -368 -0.4
text 564184 563448 -736 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 836451 835331 -1120 -0.1
rodata 91828 91460 -368 -0.4
text 559624 558884 -740 -0.1
p6 all-clusters-app default (read/write) 2294024 2292608 -1416 -0.1
.text 1252288 1250872 -1416 -0.1
lock-app default (read/write) 2211448 2210080 -1368 -0.1
.text 1169712 1168344 -1368 -0.1
qpg lighting-app qpg6100+debug (read only) 491108 489760 -1348 -0.3
.text 485788 484440 -1348 -0.3
lock-app qpg6100+debug (read only) 466040 464716 -1324 -0.3
.text 460720 459396 -1324 -0.3
telink lighting-app tlsr9518adk80d (read/write) 764266 763030 -1236 -0.2
text 530138 529228 -910 -0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1903401 9b29b02 change % change
efr32 lighting-app BRD4161A (read only) 746648 745224 -1424 -0.2
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 746640 745216 -1424 -0.2
BRD4161A+rpc (read only) 734188 732740 -1448 -0.2
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 734180 732732 -1448 -0.2
lock-app BRD4161A (read only) 723712 722312 -1400 -0.2
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 723704 722304 -1400 -0.2
window-app BRD4161A (read only) 724704 723288 -1416 -0.2
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 724696 723280 -1416 -0.2
esp32 all-clusters-app c3devkit (read only) 825820 824912 -908 -0.1
(read/write) 1220258 1219650 -608 -0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164408 163800 -608 -0.4
.flash.text 825820 824912 -908 -0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896619 895815 -804 -0.1
(read/write) 419580 418980 -600 -0.1
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192380 191780 -600 -0.3
.flash.text 891235 890431 -804 -0.1
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 705032 703608 -1424 -0.2
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 620332 618908 -1424 -0.2
lock-app k32w061+debug (read/write) 596448 595052 -1396 -0.2
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 521268 519872 -1396 -0.3
shell k32w061+debug (read/write) 661664 660284 -1380 -0.2
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 575452 574072 -1380 -0.2
linux all-clusters-app debug (read only) 1709953 1701841 -8112 -0.5
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135253 -96 -0.1
.text 1441154 1433138 -8016 -0.6
bridge-app debug+rpc (read only) 1305125 1297013 -8112 -0.6
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 110668 -96 -0.1
.text 1097461 1089445 -8016 -0.7
chip-tool debug (read only) 4900629 4892277 -8352 -0.2
(read/write) 166280 166280 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 117936 117936 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265618 265554 -64 -0.0
.text 4326037 4317749 -8288 -0.2
lighting-app debug+rpc (read only) 1574153 1566073 -8080 -0.5
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128337 128273 -64 -0.0
.text 1311314 1303298 -8016 -0.6
ota-provider-app debug (read only) 1260553 1252473 -8080 -0.6
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 112999 -64 -0.1
.text 1050402 1042386 -8016 -0.8
ota-requestor-app debug (read only) 1343681 1335393 -8288 -0.6
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123888 123792 -96 -0.1
.text 1120370 1112178 -8192 -0.7
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1846809 1838553 -8256 -0.4
(read/write) 405016 405016 0 0.0
.bss 336968 336968 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155213 155149 -64 -0.0
.text 1547330 1539138 -8192 -0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2285472 2283728 -1744 -0.1
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1248072 1246328 -1744 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271408 2269720 -1688 -0.1
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1234008 1232320 -1688 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247312 2245560 -1752 -0.1
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1209912 1208160 -1752 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861319 860215 -1104 -0.1
bss 110384 110384 0 0.0
rodata 95400 95032 -368 -0.4
text 579904 579168 -736 -0.1
nrf52840dk_nrf52840+rpc (read/write) 823691 822583 -1108 -0.1
bss 106740 106740 0 0.0
rodata 86588 86216 -372 -0.4
text 554076 553340 -736 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 786362 785254 -1108 -0.1
bss 111760 111760 0 0.0
rodata 90660 90288 -372 -0.4
text 509372 508636 -736 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 836719 835595 -1124 -0.1
bss 109408 109408 0 0.0
rodata 91872 91500 -372 -0.4
text 560004 559264 -740 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 762038 760934 -1104 -0.1
bss 110820 110820 0 0.0
rodata 87176 86808 -368 -0.4
text 489564 488824 -740 -0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842859 841755 -1104 -0.1
bss 109548 109548 0 0.0
rodata 93580 93212 -368 -0.4
text 564184 563448 -736 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 836451 835331 -1120 -0.1
bss 109444 109444 0 0.0
rodata 91828 91460 -368 -0.4
text 559624 558884 -740 -0.1
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2294024 2292608 -1416 -0.1
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1252288 1250872 -1416 -0.1
lock-app default (read/write) 2211448 2210080 -1368 -0.1
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1169712 1168344 -1368 -0.1
qpg lighting-app qpg6100+debug (read only) 491108 489760 -1348 -0.3
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 485788 484440 -1348 -0.3
lock-app qpg6100+debug (read only) 466040 464716 -1324 -0.3
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 460720 459396 -1324 -0.3
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 764266 763030 -1236 -0.2
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 530138 529228 -910 -0.2

@andy31415
Copy link
Contributor

fast track: change made by domain owner, general cleanup only (replace class inheritance and code deletion), well covered by unit tests, has been up sufficiently to allow all timezones to view.

@andy31415 andy31415 merged commit 33a869d into project-chip:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunhanw-google @andy31415