Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix darwin mdns log #11797

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Fix darwin mdns log #11797

merged 1 commit into from
Nov 15, 2021

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Nov 15, 2021

Problem

log has a spelling error and says its from chip tool when it's not

Change overview

Fix log line in darwin mdns.

Testing

darwin tests.

@andy31415
Copy link
Contributor

fast track: typo fix

@github-actions
Copy link

github-actions bot commented Nov 15, 2021 •
edited
Loading

PR #11797: Size comparison from eb40a4c to 6c0570a

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eb40a4c 6c0570a change % change
efr32 lighting-app BRD4161A (read only) 746448 746448 0 0.0
(read/write) 115892 115892 0 0.0
.bss 114092 114092 0 0.0
.data 1800 1800 0 0.0
.text 746440 746440 0 0.0
BRD4161A+rpc (read only) 733980 733980 0 0.0
(read/write) 132520 132520 0 0.0
.bss 130596 130596 0 0.0
.data 1924 1924 0 0.0
.text 733972 733972 0 0.0
lock-app BRD4161A (read only) 723512 723512 0 0.0
(read/write) 113676 113676 0 0.0
.bss 111916 111916 0 0.0
.data 1756 1756 0 0.0
.text 723504 723504 0 0.0
window-app BRD4161A (read only) 724504 724504 0 0.0
(read/write) 113996 113996 0 0.0
.bss 112236 112236 0 0.0
.data 1760 1760 0 0.0
.text 724496 724496 0 0.0
esp32 all-clusters-app c3devkit (read only) 825722 825722 0 0.0
(read/write) 1221338 1221338 0 0.0
.dram0.bss 57048 57048 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164944 164944 0 0.0
.flash.text 825722 825722 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896527 896527 0 0.0
(read/write) 420644 420644 0 0.0
.dram0.bss 62400 62400 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192908 192908 0 0.0
.flash.text 891143 891143 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 705948 705948 0 0.0
.bss 77516 77516 0 0.0
.data 1912 1912 0 0.0
.text 620720 620720 0 0.0
lock-app k32w061+debug (read/write) 597372 597372 0 0.0
.bss 68036 68036 0 0.0
.data 1880 1880 0 0.0
.text 521656 521656 0 0.0
shell k32w061+debug (read/write) 662580 662580 0 0.0
.bss 79092 79092 0 0.0
.data 1848 1848 0 0.0
.text 575840 575840 0 0.0
linux all-clusters-app debug (read only) 1710041 1710041 0 0.0
(read/write) 127168 127168 0 0.0
.bss 58064 58064 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135541 135541 0 0.0
.text 1440930 1440930 0 0.0
bridge-app debug+rpc (read only) 1305277 1305277 0 0.0
(read/write) 77360 77360 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111020 111020 0 0.0
.text 1097237 1097237 0 0.0
chip-tool debug (read only) 4899829 4899829 0 0.0
(read/write) 166280 166280 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 117936 117936 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265266 265266 0 0.0
.text 4325589 4325589 0 0.0
lighting-app debug+rpc (read only) 1574273 1574273 0 0.0
(read/write) 110608 110608 0 0.0
.bss 48432 48432 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128561 128561 0 0.0
.text 1311090 1311090 0 0.0
ota-provider-app debug (read only) 1260233 1260233 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112743 112743 0 0.0
.text 1050402 1050402 0 0.0
ota-requestor-app debug (read only) 1343361 1343361 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123568 123568 0 0.0
.text 1120370 1120370 0 0.0
shell debug (read only) 794377 794377 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1846961 1846961 0 0.0
(read/write) 405560 405560 0 0.0
.bss 337512 337512 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155469 155469 0 0.0
.text 1547106 1547106 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2285872 2285872 0 0.0
.bss 179644 179644 0 0.0
.data 5216 5216 0 0.0
.heap 851584 851584 0 0.0
.text 1248472 1248472 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271816 2271816 0 0.0
.bss 172508 172508 0 0.0
.data 5576 5576 0 0.0
.heap 858360 858360 0 0.0
.text 1234416 1234416 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247712 2247712 0 0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1210312 1210312 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049456 2049456 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012056 1012056 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862251 862251 0 0.0
bss 110916 110916 0 0.0
rodata 95932 95932 0 0.0
text 579768 579768 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824623 824623 0 0.0
bss 107272 107272 0 0.0
rodata 87120 87120 0 0.0
text 553940 553940 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787294 787294 0 0.0
bss 112292 112292 0 0.0
rodata 91192 91192 0 0.0
text 509236 509236 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837651 837651 0 0.0
bss 109940 109940 0 0.0
rodata 92404 92404 0 0.0
text 559868 559868 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762954 762954 0 0.0
bss 111352 111352 0 0.0
rodata 87708 87708 0 0.0
text 489428 489428 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843759 843759 0 0.0
bss 110080 110080 0 0.0
rodata 94112 94112 0 0.0
text 564048 564048 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837351 837351 0 0.0
bss 109976 109976 0 0.0
rodata 92360 92360 0 0.0
text 559488 559488 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2294360 2294360 0 0.0
.bss 112632 112632 0 0.0
.data 2520 2520 0 0.0
.heap 918192 918192 0 0.0
.text 1252624 1252624 0 0.0
lock-app default (read/write) 2211784 2211784 0 0.0
.bss 101248 101248 0 0.0
.data 2400 2400 0 0.0
.heap 929696 929696 0 0.0
.text 1170048 1170048 0 0.0
qpg lighting-app qpg6100+debug (read only) 491504 491504 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50592 50592 0 0.0
.data 1008 1008 0 0.0
.text 486184 486184 0 0.0
lock-app qpg6100+debug (read only) 466436 466436 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49528 49528 0 0.0
.data 964 964 0 0.0
.text 461116 461116 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 765206 765206 0 0.0
bss 79428 79428 0 0.0
noinit 37160 37160 0 0.0
text 530008 530008 0 0.0

@andy31415 andy31415 merged commit da558a9 into project-chip:master Nov 15, 2021
@cecille cecille deleted the fix_darwin_log branch November 24, 2021 20:46
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@cecille
Fix darwin mdns log (project-chip#11797)
9050b37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
darwin fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cecille @andy31415 @msandstedt @saurabhst