Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/Split ExchangeMgrDelegate #11789

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Refactor/Split ExchangeMgrDelegate #11789

merged 1 commit into from
Nov 17, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Nov 15, 2021 •
edited
Loading

Problem

SessionManageDelegate and ExchangeMgrDelegate do not fit their role.

Change overview

There are totally 4 callbacks in SessionManageDelegate:

  • OnNewConnection
  • OnConnectionExpired
  • OnMessageReceived
  • OnReceiveError

ExchangeMgrDelegate duplicate 2 callbacks:

  • OnNewConnection
  • OnConnectionExpired

This shouldn't be how these callback works.

In This PR, these callbacks will be split into 3 delegate classes:

  • SessionCreationDelegate::OnNewSession: device controller is the only receiver now, exchange manager doesn't need this event.
  • SessionReleaseDelegate::OnSessionReleased: everything holding a session should be the receiver of this event, including ExchangeManager, DeviceController,
  • SessionMessageDelegate::OnMessageReceived: ExchangeManager is the only receiver, all messages are handled by the ExchangeManager

OnReceiveError event is removed, we log all error path inside SessionManager the event is not needed for applications.

Testing

Verified using unit-tests.

@todo
Copy link

todo bot commented Nov 15, 2021

this should be test only, after OnSessionReleased is move to SessionHandle within the exchange context

connectedhomeip/src/messaging/ExchangeMgr.h

Lines 251 to 256 in 7931e6d

// TODO: this should be test only, after OnSessionReleased is move to SessionHandle within the exchange context
// Expire all exchanges associated with the given session
void ExpireExchangesForSession(SessionHandle session);
};
} // namespace Messaging

This comment was generated by todo based on a TODO comment in 7931e6d in #11789. cc @kghost.

@todo
Copy link

todo bot commented Nov 15, 2021

This is a temporary solution to release sessions, in the near future, SessionReleaseDelegate will be

connectedhomeip/src/transport/SessionManager.h

Lines 272 to 279 in 7931e6d

// TODO: This is a temporary solution to release sessions, in the near future, SessionReleaseDelegate will be
// directly associated with the every SessionHandle. Then the callback function is called on over the handle
// delegate directly, in order to prevent dangling handles.
BitMapObjectPool<std::reference_wrapper<SessionReleaseDelegate>, 4> mSessionReleaseDelegates;
TransportMgrBase * mTransportMgr = nullptr;
Transport::MessageCounterManagerInterface * mMessageCounterManager = nullptr;

This comment was generated by todo based on a TODO comment in 7931e6d in #11789. cc @kghost.

@restyled-io restyled-io bot mentioned this pull request Nov 15, 2021
Closed
@kghost kghost force-pushed the session-event-dispatch branch from 7931e6d to f929607 Compare November 15, 2021 17:32
@andy31415
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the session-event-dispatch branch from f929607 to c404895 Compare November 15, 2021 18:55
@kghost kghost force-pushed the session-event-dispatch branch from c404895 to 0e52d04 Compare November 16, 2021 09:36
@boring-cyborg boring-cyborg bot added the lib label Nov 16, 2021
@github-actions
Copy link

github-actions bot commented Nov 16, 2021 •
edited
Loading

PR #11789: Size comparison from bbd19d9 to 0e52d04

Increases above 0.2%:

platform target config section bbd19d9 0e52d04 change % change
linux bridge-app debug+rpc .bss 42224 42352 128 0.3
chip-tool debug .bss 40584 40712 128 0.3
lighting-app debug+rpc .bss 47888 48016 128 0.3
ota-provider-app debug .bss 44832 44960 128 0.3
ota-requestor-app debug .bss 47296 47424 128 0.3
shell debug .bss 23816 23944 128 0.5
tv-app debug (read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bbd19d9 0e52d04 change % change
efr32 lighting-app BRD4161A (read only) 746648 746744 96 0.0
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.text 746640 746736 96 0.0
BRD4161A+rpc (read only) 734188 734284 96 0.0
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.text 734180 734276 96 0.0
lock-app BRD4161A (read only) 723712 723808 96 0.0
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.text 723704 723800 96 0.0
window-app BRD4161A (read only) 724704 724800 96 0.0
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.text 724696 724792 96 0.0
esp32 all-clusters-app c3devkit (read only) 825820 825868 48 0.0
(read/write) 1220258 1220298 40 0.0
.dram0.bss 56512 56576 64 0.1
.flash.text 825820 825868 48 0.0
m5stack (read only) 896619 896655 36 0.0
(read/write) 419580 419620 40 0.0
.dram0.bss 61864 61928 64 0.1
.flash.text 891235 891271 36 0.0
k32w lighting-app k32w061+se05x+release (read/write) 705032 705108 76 0.0
.bss 76988 77052 64 0.1
.text 620332 620344 12 0.0
lock-app k32w061+debug (read/write) 596448 596520 72 0.0
.bss 67500 67564 64 0.1
.text 521268 521276 8 0.0
shell k32w061+debug (read/write) 661664 661848 184 0.0
.bss 78564 78692 128 0.2
.text 575452 575508 56 0.0
linux all-clusters-app debug (read only) 1709953 1710425 472 0.0
(read/write) 126624 126816 192 0.2
.bss 57520 57648 128 0.2
.data.rel.ro 62784 62832 48 0.1
.text 1441154 1441746 592 0.0
bridge-app debug+rpc (read only) 1305125 1305581 456 0.0
(read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
.data.rel.ro 28024 28056 32 0.1
.text 1097461 1098069 608 0.1
chip-tool debug (read only) 4900645 4901349 704 0.0
(read/write) 166280 166472 192 0.1
.bss 40584 40712 128 0.3
.data.rel.ro 117936 117984 48 0.0
.text 4326053 4326901 848 0.0
lighting-app debug+rpc (read only) 1574153 1574641 488 0.0
(read/write) 110064 110224 160 0.1
.bss 47888 48016 128 0.3
.data.rel.ro 55616 55648 32 0.1
.text 1311314 1311922 608 0.0
ota-provider-app debug (read only) 1260553 1261041 488 0.0
(read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
.data.rel.ro 24840 24888 48 0.2
.text 1050402 1051010 608 0.1
ota-requestor-app debug (read only) 1343681 1344329 648 0.0
(read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data.rel.ro 26024 26088 64 0.2
.text 1120370 1121090 720 0.1
shell debug (read only) 794665 795681 1016 0.1
(read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.data.rel.ro 37520 37560 40 0.1
.text 612674 613842 1168 0.2
tv-app debug (read only) 1846825 1847529 704 0.0
(read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
.data.rel.ro 59600 59648 48 0.1
.text 1547346 1548194 848 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179108 179172 64 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171972 172036 64 0.0
lock-app CY8CPROTO_062_4343W+release .bss 170860 170924 64 0.0
shell CY8CPROTO_062_4343W+release .bss 156160 156224 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861319 861375 56 0.0
bss 110384 110448 64 0.1
text 579904 579928 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 823691 823755 64 0.0
bss 106740 106804 64 0.1
text 554076 554100 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786362 786434 72 0.0
bss 111760 111824 64 0.1
text 509372 509400 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836719 836775 56 0.0
bss 109408 109472 64 0.1
text 560004 560028 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762038 762110 72 0.0
bss 110820 110884 64 0.1
text 489564 489592 28 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842859 842915 56 0.0
bss 109548 109612 64 0.1
text 564184 564208 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836451 836507 56 0.0
bss 109444 109508 64 0.1
text 559624 559648 24 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776359 120 0.0
bss 109004 109068 64 0.1
text 520124 520192 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691414 120 0.0
bss 109988 110052 64 0.1
text 440732 440804 72 0.0
p6 all-clusters-app default (read/write) 2294024 2294312 288 0.0
.bss 112096 112160 64 0.1
.text 1252288 1252576 288 0.0
lock-app default (read/write) 2211448 2211720 272 0.0
.bss 100720 100784 64 0.1
.text 1169712 1169984 272 0.0
qpg lighting-app qpg6100+debug (read only) 491108 491124 16 0.0
.bss 50056 50120 64 0.1
.text 485788 485804 16 0.0
lock-app qpg6100+debug (read only) 466040 466056 16 0.0
.bss 49000 49064 64 0.1
.text 460720 460736 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 764266 764362 96 0.0
bss 78896 78960 64 0.1
text 530138 530194 56 0.0
Decreases (23 builds for esp32, linux, mbed, nrfconnect, p6)
platform target config section bbd19d9 0e52d04 change % change
esp32 all-clusters-app c3devkit .flash.rodata 164408 164384 -24 -0.0
m5stack .flash.rodata 192380 192356 -24 -0.0
linux all-clusters-app debug .rodata 135349 135253 -96 -0.1
bridge-app debug+rpc .rodata 110764 110636 -128 -0.1
lighting-app debug+rpc .rodata 128337 128241 -96 -0.1
ota-provider-app debug .rodata 113063 112967 -96 -0.1
ota-requestor-app debug .rodata 123888 123792 -96 -0.1
shell debug .rodata 78479 78351 -128 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2285472 2285064 -408 -0.0
.heap 852120 852056 -64 -0.0
.text 1248072 1247664 -408 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271408 2271056 -352 -0.0
.heap 858896 858832 -64 -0.0
.text 1234008 1233656 -352 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2247312 2246896 -416 -0.0
.heap 860016 859952 -64 -0.0
.text 1209912 1209496 -416 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2049520 2049168 -352 -0.0
.heap 875320 875256 -64 -0.0
.text 1012120 1011768 -352 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 95400 95376 -24 -0.0
nrf52840dk_nrf52840+rpc rodata 86588 86572 -16 -0.0
nrf5340dk_nrf5340_cpuapp rodata 90660 90636 -24 -0.0
lock-app nrf52840dk_nrf52840 rodata 91872 91848 -24 -0.0
nrf5340dk_nrf5340_cpuapp rodata 87176 87152 -24 -0.0
pump-app nrf52840dk_nrf52840 rodata 93580 93556 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 rodata 91828 91804 -24 -0.0
shell nrf52840dk_nrf52840 rodata 72516 72492 -24 -0.0
nrf5340dk_nrf5340_cpuapp rodata 67160 67136 -24 -0.0
p6 all-clusters-app default .heap 918728 918664 -64 -0.0
lock-app default .heap 930224 930160 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bbd19d9 0e52d04 change % change
efr32 lighting-app BRD4161A (read only) 746648 746744 96 0.0
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.data 1800 1800 0 0.0
.text 746640 746736 96 0.0
BRD4161A+rpc (read only) 734188 734284 96 0.0
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.data 1924 1924 0 0.0
.text 734180 734276 96 0.0
lock-app BRD4161A (read only) 723712 723808 96 0.0
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.data 1756 1756 0 0.0
.text 723704 723800 96 0.0
window-app BRD4161A (read only) 724704 724800 96 0.0
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.data 1760 1760 0 0.0
.text 724696 724792 96 0.0
esp32 all-clusters-app c3devkit (read only) 825820 825868 48 0.0
(read/write) 1220258 1220298 40 0.0
.dram0.bss 56512 56576 64 0.1
.dram0.data 14084 14084 0 0.0
.flash.rodata 164408 164384 -24 -0.0
.flash.text 825820 825868 48 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896619 896655 36 0.0
(read/write) 419580 419620 40 0.0
.dram0.bss 61864 61928 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 192380 192356 -24 -0.0
.flash.text 891235 891271 36 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 705032 705108 76 0.0
.bss 76988 77052 64 0.1
.data 1912 1912 0 0.0
.text 620332 620344 12 0.0
lock-app k32w061+debug (read/write) 596448 596520 72 0.0
.bss 67500 67564 64 0.1
.data 1880 1880 0 0.0
.text 521268 521276 8 0.0
shell k32w061+debug (read/write) 661664 661848 184 0.0
.bss 78564 78692 128 0.2
.data 1848 1848 0 0.0
.text 575452 575508 56 0.0
linux all-clusters-app debug (read only) 1709953 1710425 472 0.0
(read/write) 126624 126816 192 0.2
.bss 57520 57648 128 0.2
.data 1042 1042 0 0.0
.data.rel.ro 62784 62832 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135253 -96 -0.1
.text 1441154 1441746 592 0.0
bridge-app debug+rpc (read only) 1305125 1305581 456 0.0
(read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
.data 1568 1568 0 0.0
.data.rel.ro 28024 28056 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 110636 -128 -0.1
.text 1097461 1098069 608 0.1
chip-tool debug (read only) 4900645 4901349 704 0.0
(read/write) 166280 166472 192 0.1
.bss 40584 40712 128 0.3
.data 2272 2272 0 0.0
.data.rel.ro 117936 117984 48 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265618 265618 0 0.0
.text 4326053 4326901 848 0.0
lighting-app debug+rpc (read only) 1574153 1574641 488 0.0
(read/write) 110064 110224 160 0.1
.bss 47888 48016 128 0.3
.data 1234 1234 0 0.0
.data.rel.ro 55616 55648 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128337 128241 -96 -0.1
.text 1311314 1311922 608 0.0
ota-provider-app debug (read only) 1260553 1261041 488 0.0
(read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
.data 784 784 0 0.0
.data.rel.ro 24840 24888 48 0.2
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 112967 -96 -0.1
.text 1050402 1051010 608 0.1
ota-requestor-app debug (read only) 1343681 1344329 648 0.0
(read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data 848 848 0 0.0
.data.rel.ro 26024 26088 64 0.2
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123888 123792 -96 -0.1
.text 1120370 1121090 720 0.1
shell debug (read only) 794665 795681 1016 0.1
(read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.data 242 242 0 0.0
.data.rel.ro 37520 37560 40 0.1
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78351 -128 -0.2
.text 612674 613842 1168 0.2
tv-app debug (read only) 1846825 1847529 704 0.0
(read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
.data 2768 2768 0 0.0
.data.rel.ro 59600 59648 48 0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155213 155213 0 0.0
.text 1547346 1548194 848 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2285472 2285064 -408 -0.0
.bss 179108 179172 64 0.0
.data 5216 5216 0 0.0
.heap 852120 852056 -64 -0.0
.text 1248072 1247664 -408 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271408 2271056 -352 -0.0
.bss 171972 172036 64 0.0
.data 5576 5576 0 0.0
.heap 858896 858832 -64 -0.0
.text 1234008 1233656 -352 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247312 2246896 -416 -0.0
.bss 170860 170924 64 0.0
.data 5568 5568 0 0.0
.heap 860016 859952 -64 -0.0
.text 1209912 1209496 -416 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049168 -352 -0.0
.bss 156160 156224 64 0.0
.data 4968 4968 0 0.0
.heap 875320 875256 -64 -0.0
.text 1012120 1011768 -352 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861319 861375 56 0.0
bss 110384 110448 64 0.1
rodata 95400 95376 -24 -0.0
text 579904 579928 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 823691 823755 64 0.0
bss 106740 106804 64 0.1
rodata 86588 86572 -16 -0.0
text 554076 554100 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786362 786434 72 0.0
bss 111760 111824 64 0.1
rodata 90660 90636 -24 -0.0
text 509372 509400 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836719 836775 56 0.0
bss 109408 109472 64 0.1
rodata 91872 91848 -24 -0.0
text 560004 560028 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762038 762110 72 0.0
bss 110820 110884 64 0.1
rodata 87176 87152 -24 -0.0
text 489564 489592 28 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842859 842915 56 0.0
bss 109548 109612 64 0.1
rodata 93580 93556 -24 -0.0
text 564184 564208 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836451 836507 56 0.0
bss 109444 109508 64 0.1
rodata 91828 91804 -24 -0.0
text 559624 559648 24 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776359 120 0.0
bss 109004 109068 64 0.1
rodata 72516 72492 -24 -0.0
text 520124 520192 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691414 120 0.0
bss 109988 110052 64 0.1
rodata 67160 67136 -24 -0.0
text 440732 440804 72 0.0
p6 all-clusters-app default (read/write) 2294024 2294312 288 0.0
.bss 112096 112160 64 0.1
.data 2520 2520 0 0.0
.heap 918728 918664 -64 -0.0
.text 1252288 1252576 288 0.0
lock-app default (read/write) 2211448 2211720 272 0.0
.bss 100720 100784 64 0.1
.data 2400 2400 0 0.0
.heap 930224 930160 -64 -0.0
.text 1169712 1169984 272 0.0
qpg lighting-app qpg6100+debug (read only) 491108 491124 16 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50120 64 0.1
.data 1008 1008 0 0.0
.text 485788 485804 16 0.0
lock-app qpg6100+debug (read only) 466040 466056 16 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49064 64 0.1
.data 964 964 0 0.0
.text 460720 460736 16 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 764266 764362 96 0.0
bss 78896 78960 64 0.1
noinit 37160 37160 0 0.0
text 530138 530194 56 0.0

@kghost kghost linked an issue Nov 16, 2021 that may be closed by this pull request
Exchange Mgr needs to be able to track multiple delegates. Delegate API should b... #10081
Closed
andy31415
andy31415 approved these changes Nov 16, 2021
View reviewed changes
@kghost kghost force-pushed the session-event-dispatch branch from 0e52d04 to 7acbf45 Compare November 16, 2021 14:01
@github-actions
Copy link

github-actions bot commented Nov 16, 2021 •
edited
Loading

PR #11789: Size comparison from 4500190 to 7acbf45

Increases above 0.2%:

platform target config section 4500190 7acbf45 change % change
linux bridge-app debug+rpc .bss 42224 42352 128 0.3
chip-tool debug .bss 40584 40712 128 0.3
lighting-app debug+rpc .bss 47888 48016 128 0.3
ota-provider-app debug .bss 44832 44960 128 0.3
ota-requestor-app debug .bss 47296 47424 128 0.3
shell debug .bss 23816 23944 128 0.5
tv-app debug (read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
Increases (31 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 4500190 7acbf45 change % change
efr32 lighting-app BRD4161A (read only) 745224 745288 64 0.0
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.text 745216 745280 64 0.0
BRD4161A+rpc (read only) 732740 732804 64 0.0
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.text 732732 732796 64 0.0
lock-app BRD4161A (read only) 722312 722376 64 0.0
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.text 722304 722368 64 0.0
window-app BRD4161A (read only) 723288 723336 48 0.0
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.text 723280 723328 48 0.0
esp32 all-clusters-app c3devkit (read only) 824912 824960 48 0.0
(read/write) 1219650 1219690 40 0.0
.dram0.bss 56512 56576 64 0.1
.flash.text 824912 824960 48 0.0
m5stack (read only) 895819 895855 36 0.0
(read/write) 418980 419020 40 0.0
.dram0.bss 61864 61928 64 0.1
.flash.text 890435 890471 36 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703608 703684 76 0.0
.bss 76988 77052 64 0.1
.text 618908 618920 12 0.0
lock-app k32w061+debug (read/write) 595052 595124 72 0.0
.bss 67500 67564 64 0.1
.text 519872 519880 8 0.0
shell k32w061+debug (read/write) 660284 660468 184 0.0
.bss 78564 78692 128 0.2
.text 574072 574128 56 0.0
linux all-clusters-app debug (read only) 1701841 1702233 392 0.0
(read/write) 126624 126816 192 0.2
.bss 57520 57648 128 0.2
.data.rel.ro 62784 62832 48 0.1
.text 1433138 1433698 560 0.0
bridge-app debug+rpc (read only) 1297013 1297373 360 0.0
(read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
.data.rel.ro 28024 28056 32 0.1
.text 1089445 1090005 560 0.1
chip-tool debug (read only) 4892293 4892917 624 0.0
(read/write) 166280 166472 192 0.1
.bss 40584 40712 128 0.3
.data.rel.ro 117936 117984 48 0.0
.text 4317765 4318581 816 0.0
lighting-app debug+rpc (read only) 1566073 1566465 392 0.0
(read/write) 110064 110224 160 0.1
.bss 47888 48016 128 0.3
.data.rel.ro 55616 55648 32 0.1
.text 1303298 1303858 560 0.0
ota-provider-app debug (read only) 1252473 1252865 392 0.0
(read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
.data.rel.ro 24840 24888 48 0.2
.text 1042386 1042946 560 0.1
ota-requestor-app debug (read only) 1335393 1335945 552 0.0
(read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data.rel.ro 26024 26088 64 0.2
.text 1112178 1112850 672 0.1
shell debug (read only) 794665 795601 936 0.1
(read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.data.rel.ro 37520 37560 40 0.1
.text 612674 613810 1136 0.2
tv-app debug (read only) 1838569 1839177 608 0.0
(read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
.data.rel.ro 59600 59648 48 0.1
.text 1539154 1539954 800 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860215 860271 56 0.0
bss 110384 110448 64 0.1
text 579168 579192 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 822583 822647 64 0.0
bss 106740 106804 64 0.1
text 553340 553364 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785254 785326 72 0.0
bss 111760 111824 64 0.1
text 508636 508664 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835595 835667 72 0.0
bss 109408 109472 64 0.1
text 559264 559288 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 760934 761006 72 0.0
bss 110820 110884 64 0.1
text 488824 488852 28 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841755 841811 56 0.0
bss 109548 109612 64 0.1
text 563448 563472 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835331 835403 72 0.0
bss 109444 109508 64 0.1
text 558884 558908 24 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776359 120 0.0
bss 109004 109068 64 0.1
text 520124 520192 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691414 120 0.0
bss 109988 110052 64 0.1
text 440732 440804 72 0.0
p6 all-clusters-app default (read/write) 2292608 2292848 240 0.0
.bss 112096 112160 64 0.1
.text 1250872 1251112 240 0.0
lock-app default (read/write) 2210080 2210320 240 0.0
.bss 100720 100784 64 0.1
.text 1168344 1168584 240 0.0
qpg lighting-app qpg6100+debug (read only) 489760 489776 16 0.0
.bss 50056 50120 64 0.1
.text 484440 484456 16 0.0
lock-app qpg6100+debug (read only) 464716 464732 16 0.0
.bss 49000 49064 64 0.1
.text 459396 459412 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 763030 763126 96 0.0
bss 78896 78960 64 0.1
text 529228 529284 56 0.0
Decreases (19 builds for esp32, linux, nrfconnect, p6)
platform target config section 4500190 7acbf45 change % change
esp32 all-clusters-app c3devkit .flash.rodata 163800 163776 -24 -0.0
m5stack .flash.rodata 191780 191756 -24 -0.0
linux all-clusters-app debug .rodata 135253 135157 -96 -0.1
bridge-app debug+rpc .rodata 110668 110540 -128 -0.1
lighting-app debug+rpc .rodata 128273 128177 -96 -0.1
ota-provider-app debug .rodata 112999 112903 -96 -0.1
ota-requestor-app debug .rodata 123792 123696 -96 -0.1
shell debug .rodata 78479 78351 -128 -0.2
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 95032 95008 -24 -0.0
nrf52840dk_nrf52840+rpc rodata 86216 86200 -16 -0.0
nrf5340dk_nrf5340_cpuapp rodata 90288 90264 -24 -0.0
lock-app nrf52840dk_nrf52840 rodata 91500 91476 -24 -0.0
nrf5340dk_nrf5340_cpuapp rodata 86808 86784 -24 -0.0
pump-app nrf52840dk_nrf52840 rodata 93212 93188 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 rodata 91460 91436 -24 -0.0
shell nrf52840dk_nrf52840 rodata 72516 72492 -24 -0.0
nrf5340dk_nrf5340_cpuapp rodata 67160 67136 -24 -0.0
p6 all-clusters-app default .heap 918728 918664 -64 -0.0
lock-app default .heap 930224 930160 -64 -0.0
Full report (33 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 4500190 7acbf45 change % change
efr32 lighting-app BRD4161A (read only) 745224 745288 64 0.0
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.data 1800 1800 0 0.0
.text 745216 745280 64 0.0
BRD4161A+rpc (read only) 732740 732804 64 0.0
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.data 1924 1924 0 0.0
.text 732732 732796 64 0.0
lock-app BRD4161A (read only) 722312 722376 64 0.0
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.data 1756 1756 0 0.0
.text 722304 722368 64 0.0
window-app BRD4161A (read only) 723288 723336 48 0.0
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.data 1760 1760 0 0.0
.text 723280 723328 48 0.0
esp32 all-clusters-app c3devkit (read only) 824912 824960 48 0.0
(read/write) 1219650 1219690 40 0.0
.dram0.bss 56512 56576 64 0.1
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163776 -24 -0.0
.flash.text 824912 824960 48 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 895855 36 0.0
(read/write) 418980 419020 40 0.0
.dram0.bss 61864 61928 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191756 -24 -0.0
.flash.text 890435 890471 36 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703608 703684 76 0.0
.bss 76988 77052 64 0.1
.data 1912 1912 0 0.0
.text 618908 618920 12 0.0
lock-app k32w061+debug (read/write) 595052 595124 72 0.0
.bss 67500 67564 64 0.1
.data 1880 1880 0 0.0
.text 519872 519880 8 0.0
shell k32w061+debug (read/write) 660284 660468 184 0.0
.bss 78564 78692 128 0.2
.data 1848 1848 0 0.0
.text 574072 574128 56 0.0
linux all-clusters-app debug (read only) 1701841 1702233 392 0.0
(read/write) 126624 126816 192 0.2
.bss 57520 57648 128 0.2
.data 1042 1042 0 0.0
.data.rel.ro 62784 62832 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135157 -96 -0.1
.text 1433138 1433698 560 0.0
bridge-app debug+rpc (read only) 1297013 1297373 360 0.0
(read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
.data 1568 1568 0 0.0
.data.rel.ro 28024 28056 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110540 -128 -0.1
.text 1089445 1090005 560 0.1
chip-tool debug (read only) 4892293 4892917 624 0.0
(read/write) 166280 166472 192 0.1
.bss 40584 40712 128 0.3
.data 2272 2272 0 0.0
.data.rel.ro 117936 117984 48 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265554 265554 0 0.0
.text 4317765 4318581 816 0.0
lighting-app debug+rpc (read only) 1566073 1566465 392 0.0
(read/write) 110064 110224 160 0.1
.bss 47888 48016 128 0.3
.data 1234 1234 0 0.0
.data.rel.ro 55616 55648 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128177 -96 -0.1
.text 1303298 1303858 560 0.0
ota-provider-app debug (read only) 1252473 1252865 392 0.0
(read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
.data 784 784 0 0.0
.data.rel.ro 24840 24888 48 0.2
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112903 -96 -0.1
.text 1042386 1042946 560 0.1
ota-requestor-app debug (read only) 1335393 1335945 552 0.0
(read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data 848 848 0 0.0
.data.rel.ro 26024 26088 64 0.2
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123792 123696 -96 -0.1
.text 1112178 1112850 672 0.1
shell debug (read only) 794665 795601 936 0.1
(read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.data 242 242 0 0.0
.data.rel.ro 37520 37560 40 0.1
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78351 -128 -0.2
.text 612674 613810 1136 0.2
tv-app debug (read only) 1838569 1839177 608 0.0
(read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
.data 2768 2768 0 0.0
.data.rel.ro 59600 59648 48 0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155149 155149 0 0.0
.text 1539154 1539954 800 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860215 860271 56 0.0
bss 110384 110448 64 0.1
rodata 95032 95008 -24 -0.0
text 579168 579192 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 822583 822647 64 0.0
bss 106740 106804 64 0.1
rodata 86216 86200 -16 -0.0
text 553340 553364 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785254 785326 72 0.0
bss 111760 111824 64 0.1
rodata 90288 90264 -24 -0.0
text 508636 508664 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835595 835667 72 0.0
bss 109408 109472 64 0.1
rodata 91500 91476 -24 -0.0
text 559264 559288 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 760934 761006 72 0.0
bss 110820 110884 64 0.1
rodata 86808 86784 -24 -0.0
text 488824 488852 28 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841755 841811 56 0.0
bss 109548 109612 64 0.1
rodata 93212 93188 -24 -0.0
text 563448 563472 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835331 835403 72 0.0
bss 109444 109508 64 0.1
rodata 91460 91436 -24 -0.0
text 558884 558908 24 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776359 120 0.0
bss 109004 109068 64 0.1
rodata 72516 72492 -24 -0.0
text 520124 520192 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691414 120 0.0
bss 109988 110052 64 0.1
rodata 67160 67136 -24 -0.0
text 440732 440804 72 0.0
p6 all-clusters-app default (read/write) 2292608 2292848 240 0.0
.bss 112096 112160 64 0.1
.data 2520 2520 0 0.0
.heap 918728 918664 -64 -0.0
.text 1250872 1251112 240 0.0
lock-app default (read/write) 2210080 2210320 240 0.0
.bss 100720 100784 64 0.1
.data 2400 2400 0 0.0
.heap 930224 930160 -64 -0.0
.text 1168344 1168584 240 0.0
qpg lighting-app qpg6100+debug (read only) 489760 489776 16 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50120 64 0.1
.data 1008 1008 0 0.0
.text 484440 484456 16 0.0
lock-app qpg6100+debug (read only) 464716 464732 16 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49064 64 0.1
.data 964 964 0 0.0
.text 459396 459412 16 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763030 763126 96 0.0
bss 78896 78960 64 0.1
noinit 37160 37160 0 0.0
text 529228 529284 56 0.0

@kghost kghost force-pushed the session-event-dispatch branch from 7acbf45 to ffab23f Compare November 16, 2021 17:33
@restyled-io restyled-io bot mentioned this pull request Nov 16, 2021
Closed
@kghost kghost force-pushed the session-event-dispatch branch 2 times, most recently from e1def42 to a4b8d66 Compare November 16, 2021 17:56
@github-actions
Copy link

PR #11789: Size comparison from 0c88b57 to a4b8d66

Increases above 0.2%:

platform target config section 0c88b57 a4b8d66 change % change
linux all-clusters-app debug .bss 57520 57648 128 0.2
chip-tool debug .bss 40584 40712 128 0.3
ota-provider-app debug (read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
ota-requestor-app debug (read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data.rel.ro 26024 26088 64 0.2
shell debug (read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.text 612674 614242 1568 0.3
tv-app debug (read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
bridge-app debug+rpc (read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
lighting-app debug+rpc .bss 47888 48016 128 0.3
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0c88b57 a4b8d66 change % change
efr32 lighting-app BRD4161A (read only) 745208 745304 96 0.0
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.text 745200 745296 96 0.0
lock-app BRD4161A (read only) 722296 722392 96 0.0
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.text 722288 722384 96 0.0
window-app BRD4161A (read only) 723272 723368 96 0.0
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.text 723264 723360 96 0.0
lighting-app BRD4161A+rpc (read only) 732724 732820 96 0.0
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.text 732716 732812 96 0.0
esp32 all-clusters-app c3devkit (read only) 824912 825008 96 0.0
(read/write) 1219650 1219690 40 0.0
.dram0.bss 56512 56576 64 0.1
.flash.text 824912 825008 96 0.0
m5stack (read only) 895819 895919 100 0.0
(read/write) 418980 419020 40 0.0
.dram0.bss 61864 61928 64 0.1
.flash.text 890435 890535 100 0.0
k32w lock-app k32w061+debug (read/write) 595020 595108 88 0.0
.bss 67500 67564 64 0.1
.text 519840 519864 24 0.0
shell k32w061+debug (read/write) 660252 660436 184 0.0
.bss 78564 78692 128 0.2
.text 574040 574096 56 0.0
lighting-app k32w061+se05x+release (read/write) 703576 703668 92 0.0
.bss 76988 77052 64 0.1
.text 618876 618904 28 0.0
linux all-clusters-app debug (read only) 1701841 1702729 888 0.1
(read/write) 126624 126816 192 0.2
.bss 57520 57648 128 0.2
.data.rel.ro 62784 62832 48 0.1
.text 1433138 1434162 1024 0.1
chip-tool debug (read only) 4892293 4893909 1616 0.0
(read/write) 166280 166472 192 0.1
.bss 40584 40712 128 0.3
.data.rel.ro 117936 117984 48 0.0
.rodata 265554 265650 96 0.0
.text 4317765 4319477 1712 0.0
ota-provider-app debug (read only) 1252473 1253361 888 0.1
(read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
.data.rel.ro 24840 24888 48 0.2
.text 1042386 1043410 1024 0.1
ota-requestor-app debug (read only) 1335393 1336441 1048 0.1
(read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data.rel.ro 26024 26088 64 0.2
.text 1112178 1113314 1136 0.1
shell debug (read only) 794665 796097 1432 0.2
(read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.data.rel.ro 37520 37560 40 0.1
.text 612674 614242 1568 0.3
tv-app debug (read only) 1838569 1840185 1616 0.1
(read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
.data.rel.ro 59600 59648 48 0.1
.rodata 155149 155245 96 0.1
.text 1539154 1540866 1712 0.1
bridge-app debug+rpc (read only) 1297013 1297901 888 0.1
(read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
.data.rel.ro 28024 28056 32 0.1
.text 1089445 1090469 1024 0.1
lighting-app debug+rpc (read only) 1566073 1566961 888 0.1
(read/write) 110064 110224 160 0.1
.bss 47888 48016 128 0.3
.data.rel.ro 55616 55648 32 0.1
.text 1303298 1304322 1024 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179108 179172 64 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171972 172036 64 0.0
lock-app CY8CPROTO_062_4343W+release .bss 170860 170924 64 0.0
shell CY8CPROTO_062_4343W+release .bss 156160 156224 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860239 56 0.0
bss 110384 110448 64 0.1
text 579140 579164 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835579 835635 56 0.0
bss 109408 109472 64 0.1
text 559236 559260 24 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 841779 56 0.0
bss 109548 109612 64 0.1
text 563420 563444 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835371 56 0.0
bss 109444 109508 64 0.1
text 558856 558880 24 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776359 120 0.0
bss 109004 109068 64 0.1
text 520124 520192 68 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822631 80 0.0
bss 106740 106804 64 0.1
text 553312 553336 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785294 72 0.0
bss 111760 111824 64 0.1
text 508608 508636 28 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 760974 72 0.0
bss 110820 110884 64 0.1
text 488796 488824 28 0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 691294 691414 120 0.0
bss 109988 110052 64 0.1
text 440732 440804 72 0.0
p6 all-clusters-app default (read/write) 2292608 2292880 272 0.0
.bss 112096 112160 64 0.1
.text 1250872 1251144 272 0.0
lock-app default (read/write) 2210080 2210352 272 0.0
.bss 100720 100784 64 0.1
.text 1168344 1168616 272 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489744 8 0.0
.bss 50056 50120 64 0.1
.text 484416 484424 8 0.0
lock-app qpg6100+debug (read only) 464692 464700 8 0.0
.bss 49000 49064 64 0.1
.text 459372 459380 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763110 96 0.0
bss 78896 78960 64 0.1
text 529210 529266 56 0.0
Decreases (23 builds for esp32, linux, mbed, nrfconnect, p6)
platform target config section 0c88b57 a4b8d66 change % change
esp32 all-clusters-app c3devkit .flash.rodata 163800 163776 -24 -0.0
m5stack .flash.rodata 191780 191756 -24 -0.0
linux all-clusters-app debug .rodata 135253 135189 -64 -0.0
ota-provider-app debug .rodata 112999 112935 -64 -0.1
ota-requestor-app debug .rodata 123792 123728 -64 -0.1
shell debug .rodata 78479 78415 -64 -0.1
bridge-app debug+rpc .rodata 110668 110604 -64 -0.1
lighting-app debug+rpc .rodata 128273 128209 -64 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2283728 2283312 -416 -0.0
.heap 852120 852056 -64 -0.0
.text 1246328 1245912 -416 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2269720 2269312 -408 -0.0
.heap 858896 858832 -64 -0.0
.text 1232320 1231912 -408 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2245560 2245152 -408 -0.0
.heap 860016 859952 -64 -0.0
.text 1208160 1207752 -408 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2049520 2049168 -352 -0.0
.heap 875320 875256 -64 -0.0
.text 1012120 1011768 -352 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 95032 95008 -24 -0.0
lock-app nrf52840dk_nrf52840 rodata 91500 91476 -24 -0.0
pump-app nrf52840dk_nrf52840 rodata 93212 93188 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 rodata 91460 91436 -24 -0.0
shell nrf52840dk_nrf52840 rodata 72516 72492 -24 -0.0
lighting-app nrf52840dk_nrf52840+rpc rodata 86216 86200 -16 -0.0
nrf5340dk_nrf5340_cpuapp rodata 90288 90264 -24 -0.0
lock-app nrf5340dk_nrf5340_cpuapp rodata 86808 86784 -24 -0.0
shell nrf5340dk_nrf5340_cpuapp rodata 67160 67136 -24 -0.0
p6 all-clusters-app default .heap 918728 918664 -64 -0.0
lock-app default .heap 930224 930160 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0c88b57 a4b8d66 change % change
efr32 lighting-app BRD4161A (read only) 745208 745304 96 0.0
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.data 1800 1800 0 0.0
.text 745200 745296 96 0.0
lock-app BRD4161A (read only) 722296 722392 96 0.0
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.data 1756 1756 0 0.0
.text 722288 722384 96 0.0
window-app BRD4161A (read only) 723272 723368 96 0.0
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.data 1760 1760 0 0.0
.text 723264 723360 96 0.0
lighting-app BRD4161A+rpc (read only) 732724 732820 96 0.0
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.data 1924 1924 0 0.0
.text 732716 732812 96 0.0
esp32 all-clusters-app c3devkit (read only) 824912 825008 96 0.0
(read/write) 1219650 1219690 40 0.0
.dram0.bss 56512 56576 64 0.1
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163776 -24 -0.0
.flash.text 824912 825008 96 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 895919 100 0.0
(read/write) 418980 419020 40 0.0
.dram0.bss 61864 61928 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191756 -24 -0.0
.flash.text 890435 890535 100 0.0
.iram0.text 122943 122943 0 0.0
k32w lock-app k32w061+debug (read/write) 595020 595108 88 0.0
.bss 67500 67564 64 0.1
.data 1880 1880 0 0.0
.text 519840 519864 24 0.0
shell k32w061+debug (read/write) 660252 660436 184 0.0
.bss 78564 78692 128 0.2
.data 1848 1848 0 0.0
.text 574040 574096 56 0.0
lighting-app k32w061+se05x+release (read/write) 703576 703668 92 0.0
.bss 76988 77052 64 0.1
.data 1912 1912 0 0.0
.text 618876 618904 28 0.0
linux all-clusters-app debug (read only) 1701841 1702729 888 0.1
(read/write) 126624 126816 192 0.2
.bss 57520 57648 128 0.2
.data 1042 1042 0 0.0
.data.rel.ro 62784 62832 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135189 -64 -0.0
.text 1433138 1434162 1024 0.1
chip-tool debug (read only) 4892293 4893909 1616 0.0
(read/write) 166280 166472 192 0.1
.bss 40584 40712 128 0.3
.data 2272 2272 0 0.0
.data.rel.ro 117936 117984 48 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265554 265650 96 0.0
.text 4317765 4319477 1712 0.0
ota-provider-app debug (read only) 1252473 1253361 888 0.1
(read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
.data 784 784 0 0.0
.data.rel.ro 24840 24888 48 0.2
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112935 -64 -0.1
.text 1042386 1043410 1024 0.1
ota-requestor-app debug (read only) 1335393 1336441 1048 0.1
(read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data 848 848 0 0.0
.data.rel.ro 26024 26088 64 0.2
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123792 123728 -64 -0.1
.text 1112178 1113314 1136 0.1
shell debug (read only) 794665 796097 1432 0.2
(read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.data 242 242 0 0.0
.data.rel.ro 37520 37560 40 0.1
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78415 -64 -0.1
.text 612674 614242 1568 0.3
tv-app debug (read only) 1838569 1840185 1616 0.1
(read/write) 405016 406200 1184 0.3
.bss 336968 338120 1152 0.3
.data 2768 2768 0 0.0
.data.rel.ro 59600 59648 48 0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155149 155245 96 0.1
.text 1539154 1540866 1712 0.1
bridge-app debug+rpc (read only) 1297013 1297901 888 0.1
(read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
.data 1568 1568 0 0.0
.data.rel.ro 28024 28056 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110604 -64 -0.1
.text 1089445 1090469 1024 0.1
lighting-app debug+rpc (read only) 1566073 1566961 888 0.1
(read/write) 110064 110224 160 0.1
.bss 47888 48016 128 0.3
.data 1234 1234 0 0.0
.data.rel.ro 55616 55648 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128209 -64 -0.0
.text 1303298 1304322 1024 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2283312 -416 -0.0
.bss 179108 179172 64 0.0
.data 5216 5216 0 0.0
.heap 852120 852056 -64 -0.0
.text 1246328 1245912 -416 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2269312 -408 -0.0
.bss 171972 172036 64 0.0
.data 5576 5576 0 0.0
.heap 858896 858832 -64 -0.0
.text 1232320 1231912 -408 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2245152 -408 -0.0
.bss 170860 170924 64 0.0
.data 5568 5568 0 0.0
.heap 860016 859952 -64 -0.0
.text 1208160 1207752 -408 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049168 -352 -0.0
.bss 156160 156224 64 0.0
.data 4968 4968 0 0.0
.heap 875320 875256 -64 -0.0
.text 1012120 1011768 -352 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860239 56 0.0
bss 110384 110448 64 0.1
rodata 95032 95008 -24 -0.0
text 579140 579164 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835579 835635 56 0.0
bss 109408 109472 64 0.1
rodata 91500 91476 -24 -0.0
text 559236 559260 24 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 841779 56 0.0
bss 109548 109612 64 0.1
rodata 93212 93188 -24 -0.0
text 563420 563444 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835371 56 0.0
bss 109444 109508 64 0.1
rodata 91460 91436 -24 -0.0
text 558856 558880 24 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776359 120 0.0
bss 109004 109068 64 0.1
rodata 72516 72492 -24 -0.0
text 520124 520192 68 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822631 80 0.0
bss 106740 106804 64 0.1
rodata 86216 86200 -16 -0.0
text 553312 553336 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785294 72 0.0
bss 111760 111824 64 0.1
rodata 90288 90264 -24 -0.0
text 508608 508636 28 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 760974 72 0.0
bss 110820 110884 64 0.1
rodata 86808 86784 -24 -0.0
text 488796 488824 28 0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 691294 691414 120 0.0
bss 109988 110052 64 0.1
rodata 67160 67136 -24 -0.0
text 440732 440804 72 0.0
p6 all-clusters-app default (read/write) 2292608 2292880 272 0.0
.bss 112096 112160 64 0.1
.data 2520 2520 0 0.0
.heap 918728 918664 -64 -0.0
.text 1250872 1251144 272 0.0
lock-app default (read/write) 2210080 2210352 272 0.0
.bss 100720 100784 64 0.1
.data 2400 2400 0 0.0
.heap 930224 930160 -64 -0.0
.text 1168344 1168616 272 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489744 8 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50120 64 0.1
.data 1008 1008 0 0.0
.text 484416 484424 8 0.0
lock-app qpg6100+debug (read only) 464692 464700 8 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49064 64 0.1
.data 964 964 0 0.0
.text 459372 459380 8 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763110 96 0.0
bss 78896 78960 64 0.1
noinit 37160 37160 0 0.0
text 529210 529266 56 0.0

@kghost kghost force-pushed the session-event-dispatch branch from a4b8d66 to 9fd86ba Compare November 17, 2021 02:06
@todo
Copy link

todo bot commented Nov 17, 2021

Update the MRP params based on the MRP params extracted from CASE, when this is available.

connectedhomeip/src/app/OperationalDeviceProxy.cpp

Lines 232 to 235 in 9fd86ba

// TODO Update the MRP params based on the MRP params extracted from CASE, when this is available.
CHIP_ERROR err = mInitParams.sessionManager->NewPairing(
Optional<Transport::PeerAddress>::Value(mDeviceAddress), mPeerId.GetNodeId(), &mCASESession,
CryptoContext::SessionRole::kInitiator, mInitParams.fabricInfo->GetFabricIndex());

This comment was generated by todo based on a TODO comment in 9fd86ba in #11789. cc @kghost.

@restyled-io restyled-io bot mentioned this pull request Nov 17, 2021
Closed
@kghost kghost force-pushed the session-event-dispatch branch from 9fd86ba to 10cd49d Compare November 17, 2021 03:04
@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11789: Size comparison from cbd3e95 to 10cd49d

Increases above 0.2%:

platform target config section cbd3e95 10cd49d change % change
linux bridge-app debug+rpc .bss 42224 42352 128 0.3
chip-tool debug .bss 40584 40712 128 0.3
lighting-app debug+rpc .bss 47888 48016 128 0.3
ota-provider-app debug .bss 44832 44960 128 0.3
ota-requestor-app debug .bss 47296 47424 128 0.3
shell debug .bss 23816 23944 128 0.5
.text 612674 614242 1568 0.3
tv-app debug (read/write) 318136 318936 800 0.3
.bss 249960 250632 672 0.3
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cbd3e95 10cd49d change % change
efr32 lighting-app BRD4161A (read only) 745448 745544 96 0.0
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.text 745440 745536 96 0.0
BRD4161A+rpc (read only) 732964 733060 96 0.0
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.text 732956 733052 96 0.0
lock-app BRD4161A (read only) 722536 722632 96 0.0
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.text 722528 722624 96 0.0
window-app BRD4161A (read only) 723496 723592 96 0.0
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.text 723488 723584 96 0.0
esp32 all-clusters-app c3devkit (read only) 825128 825224 96 0.0
(read/write) 1219762 1219802 40 0.0
.dram0.bss 56512 56576 64 0.1
.flash.text 825128 825224 96 0.0
m5stack (read only) 896127 896215 88 0.0
(read/write) 419084 419124 40 0.0
.dram0.bss 61864 61928 64 0.1
.flash.text 890743 890831 88 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703856 703948 92 0.0
.bss 76988 77052 64 0.1
.text 619156 619184 28 0.0
lock-app k32w061+debug (read/write) 595300 595388 88 0.0
.bss 67500 67564 64 0.1
.text 520120 520144 24 0.0
shell k32w061+debug (read/write) 660532 660716 184 0.0
.bss 78564 78692 128 0.2
.text 574320 574376 56 0.0
linux all-clusters-app debug (read only) 1702849 1703737 888 0.1
(read/write) 126624 126816 192 0.2
.bss 57520 57648 128 0.2
.data.rel.ro 62784 62832 48 0.1
.text 1434050 1435074 1024 0.1
bridge-app debug+rpc (read only) 1298021 1298925 904 0.1
(read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
.data.rel.ro 28024 28056 32 0.1
.text 1090357 1091397 1040 0.1
chip-tool debug (read only) 4957053 4959789 2736 0.1
(read/write) 166504 166760 256 0.2
.bss 40584 40712 128 0.3
.data.rel.ro 118136 118264 128 0.1
.rodata 267186 267282 96 0.0
.text 4380437 4383077 2640 0.1
lighting-app debug+rpc (read only) 1567113 1568017 904 0.1
(read/write) 110064 110224 160 0.1
.bss 47888 48016 128 0.3
.data.rel.ro 55616 55648 32 0.1
.text 1304210 1305250 1040 0.1
ota-provider-app debug (read only) 1253449 1254353 904 0.1
(read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
.data.rel.ro 24840 24888 48 0.2
.text 1043298 1044338 1040 0.1
ota-requestor-app debug (read only) 1337025 1338073 1048 0.1
(read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data.rel.ro 26024 26088 64 0.2
.text 1113490 1114626 1136 0.1
shell debug (read only) 794665 796097 1432 0.2
(read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.data.rel.ro 37520 37560 40 0.1
.text 612674 614242 1568 0.3
tv-app debug (read only) 1846009 1848745 2736 0.1
(read/write) 318136 318936 800 0.3
.bss 249960 250632 672 0.3
.data.rel.ro 59720 59848 128 0.2
.rodata 156653 156749 96 0.1
.text 1544802 1547442 2640 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179108 179172 64 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171972 172036 64 0.0
lock-app CY8CPROTO_062_4343W+release .bss 170860 170924 64 0.0
shell CY8CPROTO_062_4343W+release .bss 156160 156224 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860463 860519 56 0.0
bss 110384 110448 64 0.1
text 579316 579340 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 822831 822911 80 0.0
bss 106740 106804 64 0.1
text 553488 553512 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785502 785574 72 0.0
bss 111760 111824 64 0.1
text 508788 508816 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835859 835915 56 0.0
bss 109408 109472 64 0.1
text 559416 559440 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 761182 761254 72 0.0
bss 110820 110884 64 0.1
text 488976 489004 28 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842003 842059 56 0.0
bss 109548 109612 64 0.1
text 563596 563620 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835595 835651 56 0.0
bss 109444 109508 64 0.1
text 559036 559060 24 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776359 120 0.0
bss 109004 109068 64 0.1
text 520124 520192 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691414 120 0.0
bss 109988 110052 64 0.1
text 440732 440804 72 0.0
p6 all-clusters-app default (read/write) 2292832 2293120 288 0.0
.bss 112096 112160 64 0.1
.text 1251096 1251384 288 0.0
lock-app default (read/write) 2210320 2210592 272 0.0
.bss 100720 100784 64 0.1
.text 1168584 1168856 272 0.0
qpg lighting-app qpg6100+debug (read only) 490080 490088 8 0.0
.bss 50056 50120 64 0.1
.text 484760 484768 8 0.0
lock-app qpg6100+debug (read only) 465044 465052 8 0.0
.bss 49000 49064 64 0.1
.text 459724 459732 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 763250 763346 96 0.0
bss 78896 78960 64 0.1
text 529344 529400 56 0.0
Decreases (23 builds for esp32, linux, mbed, nrfconnect, p6)
platform target config section cbd3e95 10cd49d change % change
esp32 all-clusters-app c3devkit .flash.rodata 163912 163888 -24 -0.0
m5stack .flash.rodata 191884 191860 -24 -0.0
linux all-clusters-app debug .rodata 135349 135285 -64 -0.0
bridge-app debug+rpc .rodata 110764 110700 -64 -0.1
lighting-app debug+rpc .rodata 128401 128337 -64 -0.0
ota-provider-app debug .rodata 113063 112999 -64 -0.1
ota-requestor-app debug .rodata 124112 124048 -64 -0.1
shell debug .rodata 78479 78415 -64 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2284296 2283880 -416 -0.0
.heap 852120 852056 -64 -0.0
.text 1246896 1246480 -416 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270224 2269880 -344 -0.0
.heap 858896 858832 -64 -0.0
.text 1232824 1232480 -344 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2246128 2245720 -408 -0.0
.heap 860016 859952 -64 -0.0
.text 1208728 1208320 -408 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2049520 2049168 -352 -0.0
.heap 875320 875256 -64 -0.0
.text 1012120 1011768 -352 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 95136 95112 -24 -0.0
nrf52840dk_nrf52840+rpc rodata 86320 86304 -16 -0.0
nrf5340dk_nrf5340_cpuapp rodata 90392 90368 -24 -0.0
lock-app nrf52840dk_nrf52840 rodata 91604 91580 -24 -0.0
nrf5340dk_nrf5340_cpuapp rodata 86912 86888 -24 -0.0
pump-app nrf52840dk_nrf52840 rodata 93316 93292 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 rodata 91564 91540 -24 -0.0
shell nrf52840dk_nrf52840 rodata 72516 72492 -24 -0.0
nrf5340dk_nrf5340_cpuapp rodata 67160 67136 -24 -0.0
p6 all-clusters-app default .heap 918728 918664 -64 -0.0
lock-app default .heap 930224 930160 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cbd3e95 10cd49d change % change
efr32 lighting-app BRD4161A (read only) 745448 745544 96 0.0
(read/write) 115364 115428 64 0.1
.bss 113564 113628 64 0.1
.data 1800 1800 0 0.0
.text 745440 745536 96 0.0
BRD4161A+rpc (read only) 732964 733060 96 0.0
(read/write) 131992 132056 64 0.0
.bss 130068 130132 64 0.0
.data 1924 1924 0 0.0
.text 732956 733052 96 0.0
lock-app BRD4161A (read only) 722536 722632 96 0.0
(read/write) 113148 113212 64 0.1
.bss 111388 111452 64 0.1
.data 1756 1756 0 0.0
.text 722528 722624 96 0.0
window-app BRD4161A (read only) 723496 723592 96 0.0
(read/write) 113468 113532 64 0.1
.bss 111708 111772 64 0.1
.data 1760 1760 0 0.0
.text 723488 723584 96 0.0
esp32 all-clusters-app c3devkit (read only) 825128 825224 96 0.0
(read/write) 1219762 1219802 40 0.0
.dram0.bss 56512 56576 64 0.1
.dram0.data 14084 14084 0 0.0
.flash.rodata 163912 163888 -24 -0.0
.flash.text 825128 825224 96 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896127 896215 88 0.0
(read/write) 419084 419124 40 0.0
.dram0.bss 61864 61928 64 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 191884 191860 -24 -0.0
.flash.text 890743 890831 88 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703856 703948 92 0.0
.bss 76988 77052 64 0.1
.data 1912 1912 0 0.0
.text 619156 619184 28 0.0
lock-app k32w061+debug (read/write) 595300 595388 88 0.0
.bss 67500 67564 64 0.1
.data 1880 1880 0 0.0
.text 520120 520144 24 0.0
shell k32w061+debug (read/write) 660532 660716 184 0.0
.bss 78564 78692 128 0.2
.data 1848 1848 0 0.0
.text 574320 574376 56 0.0
linux all-clusters-app debug (read only) 1702849 1703737 888 0.1
(read/write) 126624 126816 192 0.2
.bss 57520 57648 128 0.2
.data 1042 1042 0 0.0
.data.rel.ro 62784 62832 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135285 -64 -0.0
.text 1434050 1435074 1024 0.1
bridge-app debug+rpc (read only) 1298021 1298925 904 0.1
(read/write) 76816 76976 160 0.2
.bss 42224 42352 128 0.3
.data 1568 1568 0 0.0
.data.rel.ro 28024 28056 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 110700 -64 -0.1
.text 1090357 1091397 1040 0.1
chip-tool debug (read only) 4957053 4959789 2736 0.1
(read/write) 166504 166760 256 0.2
.bss 40584 40712 128 0.3
.data 2272 2272 0 0.0
.data.rel.ro 118136 118264 128 0.1
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267186 267282 96 0.0
.text 4380437 4383077 2640 0.1
lighting-app debug+rpc (read only) 1567113 1568017 904 0.1
(read/write) 110064 110224 160 0.1
.bss 47888 48016 128 0.3
.data 1234 1234 0 0.0
.data.rel.ro 55616 55648 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128401 128337 -64 -0.0
.text 1304210 1305250 1040 0.1
ota-provider-app debug (read only) 1253449 1254353 904 0.1
(read/write) 75560 75720 160 0.2
.bss 44832 44960 128 0.3
.data 784 784 0 0.0
.data.rel.ro 24840 24888 48 0.2
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 112999 -64 -0.1
.text 1043298 1044338 1040 0.1
ota-requestor-app debug (read only) 1337025 1338073 1048 0.1
(read/write) 79264 79456 192 0.2
.bss 47296 47424 128 0.3
.data 848 848 0 0.0
.data.rel.ro 26024 26088 64 0.2
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124112 124048 -64 -0.1
.text 1113490 1114626 1136 0.1
shell debug (read only) 794665 796097 1432 0.2
(read/write) 66088 66248 160 0.2
.bss 23816 23944 128 0.5
.data 242 242 0 0.0
.data.rel.ro 37520 37560 40 0.1
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78415 -64 -0.1
.text 612674 614242 1568 0.3
tv-app debug (read only) 1846009 1848745 2736 0.1
(read/write) 318136 318936 800 0.3
.bss 249960 250632 672 0.3
.data 2768 2768 0 0.0
.data.rel.ro 59720 59848 128 0.2
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156653 156749 96 0.1
.text 1544802 1547442 2640 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284296 2283880 -416 -0.0
.bss 179108 179172 64 0.0
.data 5216 5216 0 0.0
.heap 852120 852056 -64 -0.0
.text 1246896 1246480 -416 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2269880 -344 -0.0
.bss 171972 172036 64 0.0
.data 5576 5576 0 0.0
.heap 858896 858832 -64 -0.0
.text 1232824 1232480 -344 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2246128 2245720 -408 -0.0
.bss 170860 170924 64 0.0
.data 5568 5568 0 0.0
.heap 860016 859952 -64 -0.0
.text 1208728 1208320 -408 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049168 -352 -0.0
.bss 156160 156224 64 0.0
.data 4968 4968 0 0.0
.heap 875320 875256 -64 -0.0
.text 1012120 1011768 -352 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860463 860519 56 0.0
bss 110384 110448 64 0.1
rodata 95136 95112 -24 -0.0
text 579316 579340 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 822831 822911 80 0.0
bss 106740 106804 64 0.1
rodata 86320 86304 -16 -0.0
text 553488 553512 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785502 785574 72 0.0
bss 111760 111824 64 0.1
rodata 90392 90368 -24 -0.0
text 508788 508816 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835859 835915 56 0.0
bss 109408 109472 64 0.1
rodata 91604 91580 -24 -0.0
text 559416 559440 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 761182 761254 72 0.0
bss 110820 110884 64 0.1
rodata 86912 86888 -24 -0.0
text 488976 489004 28 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842003 842059 56 0.0
bss 109548 109612 64 0.1
rodata 93316 93292 -24 -0.0
text 563596 563620 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835595 835651 56 0.0
bss 109444 109508 64 0.1
rodata 91564 91540 -24 -0.0
text 559036 559060 24 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776359 120 0.0
bss 109004 109068 64 0.1
rodata 72516 72492 -24 -0.0
text 520124 520192 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691414 120 0.0
bss 109988 110052 64 0.1
rodata 67160 67136 -24 -0.0
text 440732 440804 72 0.0
p6 all-clusters-app default (read/write) 2292832 2293120 288 0.0
.bss 112096 112160 64 0.1
.data 2520 2520 0 0.0
.heap 918728 918664 -64 -0.0
.text 1251096 1251384 288 0.0
lock-app default (read/write) 2210320 2210592 272 0.0
.bss 100720 100784 64 0.1
.data 2400 2400 0 0.0
.heap 930224 930160 -64 -0.0
.text 1168584 1168856 272 0.0
qpg lighting-app qpg6100+debug (read only) 490080 490088 8 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50120 64 0.1
.data 1008 1008 0 0.0
.text 484760 484768 8 0.0
lock-app qpg6100+debug (read only) 465044 465052 8 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49064 64 0.1
.data 964 964 0 0.0
.text 459724 459732 8 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763250 763346 96 0.0
bss 78896 78960 64 0.1
noinit 37160 37160 0 0.0
text 529344 529400 56 0.0

@andy31415 andy31415 merged commit 6c9f1c5 into project-chip:master Nov 17, 2021
This was referenced Nov 17, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@msandstedt msandstedt msandstedt approved these changes

@pan-apple pan-apple pan-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller lib review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exchange Mgr needs to be able to track multiple delegates. Delegate API should b...
4 participants
@kghost @andy31415 @msandstedt @pan-apple