-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve comments from #11650 #11751
resolve comments from #11650 #11751
Conversation
PR #11751: Size comparison from ea10a5d to b243199 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict in ClusterInfoMapping, please regenerate.
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt
Outdated
Show resolved
Hide resolved
840902c
to
d287234
Compare
PR #11751: Size comparison from 507ba15 to a1d18a4 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
a1d18a4
to
25ece91
Compare
PR #11751: Size comparison from 507ba15 to b6ee43d Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Fast track: platform specific changes, PR has been up for cross timezone review, PR approved by platform owner. |
* resolve comments * Restyled by google-java-format * Restyled by gn * update zap generated code * fix comments * merge with master * fix unwanted format changes * modify clusterinfo mapping to resolve comment * final fix for comments * Delete misc.xml Co-authored-by: Restyled.io <[email protected]>
Change overview
Fix pr comments in #11650
Testing
manually tested.