-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark attribute of type array as external to save storage in attribute store #11744
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/optimize
Nov 15, 2021
Merged
Mark attribute of type array as external to save storage in attribute store #11744
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/optimize
Nov 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #11744: Size comparison from 3c750d3 to 56f1bee Increases (5 builds for mbed, p6)
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #11744: Size comparison from 507ba15 to b8eb692 Increases above 0.2%:
Increases (27 builds for efr32, esp32, linux, mbed, nrfconnect, p6, telink)
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google and
mrjerryjohns
November 15, 2021 06:57
pullapprove
bot
requested review from
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
November 15, 2021 06:57
jmartinez-silabs
approved these changes
Nov 15, 2021
yunhanw-google
approved these changes
Nov 15, 2021
woody-apple
approved these changes
Nov 15, 2021
woody-apple
reviewed
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #11744: Size comparison from cb8fc0f to dc8da6a Increases above 0.2%:
Increases (27 builds for efr32, esp32, linux, mbed, nrfconnect, p6, telink)
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 15, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
… store (project-chip#11744) * Mark attribute of type array as external * Run codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Mark attribute of type array as external to save storage in attribute store
Testing
How was this tested? (at least one bullet point required)