Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32: fix QR code URL in shell command #11668

Merged
merged 3 commits into from
Nov 11, 2021
Merged

esp32: fix QR code URL in shell command #11668

merged 3 commits into from
Nov 11, 2021

Conversation

chshu
Copy link
Contributor

@chshu chshu commented Nov 11, 2021

Problem

The QR code URL is wrong in chip onboardingcodes shell command, in ESP platform:

> chip onboardingcodes
QRCode:            MT:C8XA0SRB00KA0648G00
QRCodeUrl:          https://dhrishi.github.io/connectedhomeip/qrcode.html?data=MT0X1.E249000000055P+0C8XA0SRB00KA0648G00
ManualPairingCode:  34970112332
Done

Change overview

  • fixed the QR code URL format issue
  • use common API to print QR code URL in ESP32 all-clusters-app

Testing

Tested all-clusters-app on ESP32, the QR code URL is correct now:

> chip onboardingcodes
QRCode:            MT:C8XA0SRB00KA0648G00
QRCodeUrl:         https://dhrishi.github.io/connectedhomeip/qrcode.html?data=MT%3AC8XA0SRB00KA0648G00
ManualPairingCode: 34970112332
Done

@restyled-io restyled-io bot mentioned this pull request Nov 11, 2021
Closed
@chshu chshu force-pushed the bug/fix_qr_code branch 2 times, most recently from 954f3bf to d57ff1a Compare November 11, 2021 09:28
@github-actions
Copy link

github-actions bot commented Nov 11, 2021 •
edited
Loading

PR #11668: Size comparison from d45cfaa to d57ff1a

Increases (5 builds for linux, p6)
platform target config section d45cfaa d57ff1a change % change
linux all-clusters-app debug (read only) 1698921 1698985 64 0.0
.rodata 139061 139125 64 0.0
lighting-app debug+rpc (read only) 1558113 1558177 64 0.0
.rodata 128369 128433 64 0.0
shell debug (read only) 788441 788505 64 0.0
.rodata 77519 77583 64 0.1
tv-app debug (read only) 1842905 1842969 64 0.0
.rodata 155757 155821 64 0.0
p6 all-clusters-app default (read/write) 2297136 2297144 8 0.0
.text 1255400 1255408 8 0.0
Decreases (7 builds for k32w, p6, qpg, telink)
platform target config section d45cfaa d57ff1a change % change
k32w lighting-app k32w061+se05x+release (read/write) 699396 699388 -8 -0.0
.text 613676 613668 -8 -0.0
lock-app k32w061+debug (read/write) 592132 592124 -8 -0.0
.text 515908 515900 -8 -0.0
shell k32w061+debug (read/write) 657760 657752 -8 -0.0
.text 570776 570768 -8 -0.0
p6 lock-app default (read/write) 2211760 2211752 -8 -0.0
.text 1170024 1170016 -8 -0.0
qpg lighting-app qpg6100+debug (read only) 490672 490664 -8 -0.0
.text 485352 485344 -8 -0.0
lock-app qpg6100+debug (read only) 466900 466892 -8 -0.0
.text 461580 461572 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663410 -8 -0.0
text 458654 458636 -18 -0.0
Full report (17 builds for k32w, linux, p6, qpg, telink)
platform target config section d45cfaa d57ff1a change % change
k32w lighting-app k32w061+se05x+release (read/write) 699396 699388 -8 -0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613676 613668 -8 -0.0
lock-app k32w061+debug (read/write) 592132 592124 -8 -0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515908 515900 -8 -0.0
shell k32w061+debug (read/write) 657760 657752 -8 -0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570776 570768 -8 -0.0
linux all-clusters-app debug (read only) 1698921 1698985 64 0.0
(read/write) 126432 126432 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62256 62256 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139125 64 0.0
.text 1426370 1426370 0 0.0
bridge-app debug+rpc (read only) 1298741 1298741 0 0.0
(read/write) 77264 77264 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091365 1091365 0 0.0
chip-tool debug (read only) 4813069 4813069 0 0.0
(read/write) 136992 136992 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 103336 103336 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 248298 248298 0 0.0
.text 4288437 4288437 0 0.0
lighting-app debug+rpc (read only) 1558113 1558177 64 0.0
(read/write) 110376 110376 0 0.0
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55328 55328 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128433 64 0.0
.text 1295634 1295634 0 0.0
ota-provider-app debug (read only) 1259977 1259977 0 0.0
(read/write) 75624 75624 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050562 1050562 0 0.0
ota-requestor-app debug (read only) 1345049 1345049 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123728 123728 0 0.0
.text 1121970 1121970 0 0.0
shell debug (read only) 788441 788505 64 0.0
(read/write) 65608 65608 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77583 64 0.1
.text 609026 609026 0 0.0
tv-app debug (read only) 1842905 1842969 64 0.0
(read/write) 408216 408216 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155821 64 0.0
.text 1542674 1542674 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297144 8 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255408 8 0.0
lock-app default (read/write) 2211760 2211752 -8 -0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170024 1170016 -8 -0.0
qpg lighting-app qpg6100+debug (read only) 490672 490664 -8 -0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485352 485344 -8 -0.0
lock-app qpg6100+debug (read only) 466900 466892 -8 -0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461580 461572 -8 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663410 -8 -0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458654 458636 -18 -0.0

chshu added 2 commits November 11, 2021 17:56
@chshu
esp32: use common API to print QR code URL
b67cdaf 
Merge the QR code messages, so it won't be divided by other logs.
@chshu
esp32: fix QR code URL in shell command
01dc1c3
@github-actions
Copy link

github-actions bot commented Nov 11, 2021 •
edited
Loading

PR #11668: Size comparison from d45cfaa to 01dc1c3

Increases (16 builds for esp32, linux, mbed, nrfconnect, p6)
platform target config section d45cfaa 01dc1c3 change % change
esp32 all-clusters-app c3devkit (read only) 879114 879170 56 0.0
.dram0.data 16456 16464 8 0.0
.flash.text 879114 879170 56 0.0
linux all-clusters-app debug (read only) 1698921 1698985 64 0.0
.rodata 139061 139125 64 0.0
lighting-app debug+rpc (read only) 1558113 1558177 64 0.0
.rodata 128369 128433 64 0.0
shell debug (read only) 788441 788505 64 0.0
.rodata 77519 77583 64 0.1
tv-app debug (read only) 1842905 1842969 64 0.0
.rodata 155757 155821 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2289248 2289256 8 0.0
.text 1251848 1251856 8 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270688 2270696 8 0.0
.text 1233288 1233296 8 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2248344 2248352 8 0.0
.text 1210944 1210952 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 96532 96540 8 0.0
nrf52840dk_nrf52840+rpc rodata 87708 87716 8 0.0
nrf5340dk_nrf5340_cpuapp rodata 91788 91796 8 0.0
lock-app nrf52840dk_nrf52840 rodata 92904 92912 8 0.0
nrf5340dk_nrf5340_cpuapp rodata 88208 88216 8 0.0
pump-app nrf52840dk_nrf52840 rodata 94612 94620 8 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838467 838475 8 0.0
rodata 92900 92908 8 0.0
p6 all-clusters-app default (read/write) 2297136 2297144 8 0.0
.text 1255400 1255408 8 0.0
Decreases (17 builds for esp32, k32w, nrfconnect, p6, qpg, telink)
platform target config section d45cfaa 01dc1c3 change % change
esp32 all-clusters-app c3devkit (read/write) 1305968 1305760 -208 -0.0
.flash.rodata 197824 197616 -208 -0.1
m5stack (read only) 910683 910191 -492 -0.1
(read/write) 423308 422900 -408 -0.1
.flash.rodata 204100 203692 -408 -0.2
.flash.text 910683 910191 -492 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 699396 699388 -8 -0.0
.text 613676 613668 -8 -0.0
lock-app k32w061+debug (read/write) 592132 592124 -8 -0.0
.text 515908 515900 -8 -0.0
shell k32w061+debug (read/write) 657760 657752 -8 -0.0
.text 570776 570768 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861907 861899 -8 -0.0
text 578272 578260 -12 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824267 824259 -8 -0.0
text 552444 552432 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786946 786938 -8 -0.0
text 507740 507728 -12 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838615 838607 -8 -0.0
text 559756 559744 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763926 763918 -8 -0.0
text 489316 489304 -12 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844707 844699 -8 -0.0
text 563916 563904 -12 -0.0
pump-controller-app nrf52840dk_nrf52840 text 559492 559480 -12 -0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 690962 690958 -4 -0.0
rodata 66796 66792 -4 -0.0
p6 lock-app default (read/write) 2211760 2211752 -8 -0.0
.text 1170024 1170016 -8 -0.0
qpg lighting-app qpg6100+debug (read only) 490672 490664 -8 -0.0
.text 485352 485344 -8 -0.0
lock-app qpg6100+debug (read only) 466900 466892 -8 -0.0
.text 461580 461572 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663410 -8 -0.0
text 458654 458636 -18 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d45cfaa 01dc1c3 change % change
efr32 lighting-app BRD4161A (read only) 742476 742476 0 0.0
(read/write) 116280 116280 0 0.0
.bss 114500 114500 0 0.0
.data 1780 1780 0 0.0
.text 742468 742468 0 0.0
BRD4161A+rpc (read only) 730040 730040 0 0.0
(read/write) 132900 132900 0 0.0
.bss 131004 131004 0 0.0
.data 1896 1896 0 0.0
.text 730032 730032 0 0.0
lock-app BRD4161A (read only) 721764 721764 0 0.0
(read/write) 114096 114096 0 0.0
.bss 112356 112356 0 0.0
.data 1740 1740 0 0.0
.text 721756 721756 0 0.0
window-app BRD4161A (read only) 722676 722676 0 0.0
(read/write) 114420 114420 0 0.0
.bss 112676 112676 0 0.0
.data 1744 1744 0 0.0
.text 722668 722668 0 0.0
esp32 all-clusters-app c3devkit (read only) 879114 879170 56 0.0
(read/write) 1305968 1305760 -208 -0.0
.dram0.bss 58440 58440 0 0.0
.dram0.data 16456 16464 8 0.0
.flash.rodata 197824 197616 -208 -0.1
.flash.text 879114 879170 56 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910683 910191 -492 -0.1
(read/write) 423308 422900 -408 -0.1
.dram0.bss 60952 60952 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204100 203692 -408 -0.2
.flash.text 910683 910191 -492 -0.1
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699396 699388 -8 -0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613676 613668 -8 -0.0
lock-app k32w061+debug (read/write) 592132 592124 -8 -0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515908 515900 -8 -0.0
shell k32w061+debug (read/write) 657760 657752 -8 -0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570776 570768 -8 -0.0
linux all-clusters-app debug (read only) 1698921 1698985 64 0.0
(read/write) 126432 126432 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62256 62256 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139125 64 0.0
.text 1426370 1426370 0 0.0
bridge-app debug+rpc (read only) 1298741 1298741 0 0.0
(read/write) 77264 77264 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091365 1091365 0 0.0
chip-tool debug (read only) 4813069 4813069 0 0.0
(read/write) 136992 136992 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 103336 103336 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 248298 248298 0 0.0
.text 4288437 4288437 0 0.0
lighting-app debug+rpc (read only) 1558113 1558177 64 0.0
(read/write) 110376 110376 0 0.0
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55328 55328 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128433 64 0.0
.text 1295634 1295634 0 0.0
ota-provider-app debug (read only) 1259977 1259977 0 0.0
(read/write) 75624 75624 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050562 1050562 0 0.0
ota-requestor-app debug (read only) 1345049 1345049 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123728 123728 0 0.0
.text 1121970 1121970 0 0.0
shell debug (read only) 788441 788505 64 0.0
(read/write) 65608 65608 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77583 64 0.1
.text 609026 609026 0 0.0
tv-app debug (read only) 1842905 1842969 64 0.0
(read/write) 408216 408216 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155821 64 0.0
.text 1542674 1542674 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289248 2289256 8 0.0
.bss 179412 179412 0 0.0
.data 5216 5216 0 0.0
.heap 851816 851816 0 0.0
.text 1251848 1251856 8 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270688 2270696 8 0.0
.bss 172508 172508 0 0.0
.data 5576 5576 0 0.0
.heap 858360 858360 0 0.0
.text 1233288 1233296 8 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248344 2248352 8 0.0
.bss 171404 171404 0 0.0
.data 5568 5568 0 0.0
.heap 859472 859472 0 0.0
.text 1210944 1210952 8 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048296 2048296 0 0.0
.bss 156464 156464 0 0.0
.data 4968 4968 0 0.0
.heap 875016 875016 0 0.0
.text 1010896 1010896 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861907 861899 -8 -0.0
bss 111476 111476 0 0.0
rodata 96532 96540 8 0.0
text 578272 578260 -12 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824267 824259 -8 -0.0
bss 107828 107828 0 0.0
rodata 87708 87716 8 0.0
text 552444 552432 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786946 786938 -8 -0.0
bss 112848 112848 0 0.0
rodata 91788 91796 8 0.0
text 507740 507728 -12 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838615 838607 -8 -0.0
bss 110508 110508 0 0.0
rodata 92904 92912 8 0.0
text 559756 559744 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763926 763918 -8 -0.0
bss 111920 111920 0 0.0
rodata 88208 88216 8 0.0
text 489316 489304 -12 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844707 844699 -8 -0.0
bss 110648 110648 0 0.0
rodata 94612 94620 8 0.0
text 563916 563904 -12 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838467 838475 8 0.0
bss 110544 110544 0 0.0
rodata 92900 92908 8 0.0
text 559492 559480 -12 -0.0
shell nrf52840dk_nrf52840 (read/write) 775955 775955 0 0.0
bss 109288 109288 0 0.0
rodata 72152 72152 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690962 690958 -4 -0.0
bss 110272 110272 0 0.0
rodata 66796 66792 -4 -0.0
text 440512 440512 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297144 8 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255408 8 0.0
lock-app default (read/write) 2211760 2211752 -8 -0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170024 1170016 -8 -0.0
qpg lighting-app qpg6100+debug (read only) 490672 490664 -8 -0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485352 485344 -8 -0.0
lock-app qpg6100+debug (read only) 466900 466892 -8 -0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461580 461572 -8 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663410 -8 -0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458654 458636 -18 -0.0

dhrishi
dhrishi reviewed Nov 11, 2021
View reviewed changes
examples/all-clusters-app/esp32/main/main.cpp Outdated Show resolved Hide resolved
examples/all-clusters-app/esp32/main/main.cpp Outdated Show resolved Hide resolved
examples/all-clusters-app/esp32/main/main.cpp Show resolved Hide resolved
src/lib/shell/streamer_esp32.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 11, 2021 •
edited
Loading

PR #11668: Size comparison from d45cfaa to 283e60a

Increases (16 builds for esp32, linux, mbed, nrfconnect, p6)
platform target config section d45cfaa 283e60a change % change
esp32 all-clusters-app c3devkit (read only) 879114 879170 56 0.0
.dram0.data 16456 16464 8 0.0
.flash.text 879114 879170 56 0.0
linux all-clusters-app debug (read only) 1698921 1698985 64 0.0
.rodata 139061 139125 64 0.0
lighting-app debug+rpc (read only) 1558113 1558177 64 0.0
.rodata 128369 128433 64 0.0
shell debug (read only) 788441 788505 64 0.0
.rodata 77519 77583 64 0.1
tv-app debug (read only) 1842905 1842969 64 0.0
.rodata 155757 155821 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2289248 2289256 8 0.0
.text 1251848 1251856 8 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270688 2270696 8 0.0
.text 1233288 1233296 8 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2248344 2248352 8 0.0
.text 1210944 1210952 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 96532 96540 8 0.0
nrf52840dk_nrf52840+rpc rodata 87708 87716 8 0.0
nrf5340dk_nrf5340_cpuapp rodata 91788 91796 8 0.0
lock-app nrf52840dk_nrf52840 rodata 92904 92912 8 0.0
nrf5340dk_nrf5340_cpuapp rodata 88208 88216 8 0.0
pump-app nrf52840dk_nrf52840 rodata 94612 94620 8 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838467 838475 8 0.0
rodata 92900 92908 8 0.0
p6 all-clusters-app default (read/write) 2297136 2297144 8 0.0
.text 1255400 1255408 8 0.0
Decreases (17 builds for esp32, k32w, nrfconnect, p6, qpg, telink)
platform target config section d45cfaa 283e60a change % change
esp32 all-clusters-app c3devkit (read/write) 1305968 1305760 -208 -0.0
.flash.rodata 197824 197616 -208 -0.1
m5stack (read only) 910683 910275 -408 -0.0
(read/write) 423308 422900 -408 -0.1
.flash.rodata 204100 203692 -408 -0.2
.flash.text 910683 910275 -408 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699396 699388 -8 -0.0
.text 613676 613668 -8 -0.0
lock-app k32w061+debug (read/write) 592132 592124 -8 -0.0
.text 515908 515900 -8 -0.0
shell k32w061+debug (read/write) 657760 657752 -8 -0.0
.text 570776 570768 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861907 861899 -8 -0.0
text 578272 578260 -12 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824267 824259 -8 -0.0
text 552444 552432 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786946 786938 -8 -0.0
text 507740 507728 -12 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838615 838607 -8 -0.0
text 559756 559744 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763926 763918 -8 -0.0
text 489316 489304 -12 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844707 844699 -8 -0.0
text 563916 563904 -12 -0.0
pump-controller-app nrf52840dk_nrf52840 text 559492 559480 -12 -0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 690962 690958 -4 -0.0
rodata 66796 66792 -4 -0.0
p6 lock-app default (read/write) 2211760 2211752 -8 -0.0
.text 1170024 1170016 -8 -0.0
qpg lighting-app qpg6100+debug (read only) 490672 490664 -8 -0.0
.text 485352 485344 -8 -0.0
lock-app qpg6100+debug (read only) 466900 466892 -8 -0.0
.text 461580 461572 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663410 -8 -0.0
text 458654 458636 -18 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d45cfaa 283e60a change % change
efr32 lighting-app BRD4161A (read only) 742476 742476 0 0.0
(read/write) 116280 116280 0 0.0
.bss 114500 114500 0 0.0
.data 1780 1780 0 0.0
.text 742468 742468 0 0.0
BRD4161A+rpc (read only) 730040 730040 0 0.0
(read/write) 132900 132900 0 0.0
.bss 131004 131004 0 0.0
.data 1896 1896 0 0.0
.text 730032 730032 0 0.0
lock-app BRD4161A (read only) 721764 721764 0 0.0
(read/write) 114096 114096 0 0.0
.bss 112356 112356 0 0.0
.data 1740 1740 0 0.0
.text 721756 721756 0 0.0
window-app BRD4161A (read only) 722676 722676 0 0.0
(read/write) 114420 114420 0 0.0
.bss 112676 112676 0 0.0
.data 1744 1744 0 0.0
.text 722668 722668 0 0.0
esp32 all-clusters-app c3devkit (read only) 879114 879170 56 0.0
(read/write) 1305968 1305760 -208 -0.0
.dram0.bss 58440 58440 0 0.0
.dram0.data 16456 16464 8 0.0
.flash.rodata 197824 197616 -208 -0.1
.flash.text 879114 879170 56 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910683 910275 -408 -0.0
(read/write) 423308 422900 -408 -0.1
.dram0.bss 60952 60952 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204100 203692 -408 -0.2
.flash.text 910683 910275 -408 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699396 699388 -8 -0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613676 613668 -8 -0.0
lock-app k32w061+debug (read/write) 592132 592124 -8 -0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515908 515900 -8 -0.0
shell k32w061+debug (read/write) 657760 657752 -8 -0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570776 570768 -8 -0.0
linux all-clusters-app debug (read only) 1698921 1698985 64 0.0
(read/write) 126432 126432 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62256 62256 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139125 64 0.0
.text 1426370 1426370 0 0.0
bridge-app debug+rpc (read only) 1298741 1298741 0 0.0
(read/write) 77264 77264 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091365 1091365 0 0.0
chip-tool debug (read only) 4813069 4813069 0 0.0
(read/write) 136992 136992 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 103336 103336 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 248298 248298 0 0.0
.text 4288437 4288437 0 0.0
lighting-app debug+rpc (read only) 1558113 1558177 64 0.0
(read/write) 110376 110376 0 0.0
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55328 55328 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128433 64 0.0
.text 1295634 1295634 0 0.0
ota-provider-app debug (read only) 1259977 1259977 0 0.0
(read/write) 75624 75624 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050562 1050562 0 0.0
ota-requestor-app debug (read only) 1345049 1345049 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123728 123728 0 0.0
.text 1121970 1121970 0 0.0
shell debug (read only) 788441 788505 64 0.0
(read/write) 65608 65608 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77583 64 0.1
.text 609026 609026 0 0.0
tv-app debug (read only) 1842905 1842969 64 0.0
(read/write) 408216 408216 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155821 64 0.0
.text 1542674 1542674 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289248 2289256 8 0.0
.bss 179412 179412 0 0.0
.data 5216 5216 0 0.0
.heap 851816 851816 0 0.0
.text 1251848 1251856 8 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270688 2270696 8 0.0
.bss 172508 172508 0 0.0
.data 5576 5576 0 0.0
.heap 858360 858360 0 0.0
.text 1233288 1233296 8 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248344 2248352 8 0.0
.bss 171404 171404 0 0.0
.data 5568 5568 0 0.0
.heap 859472 859472 0 0.0
.text 1210944 1210952 8 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048296 2048296 0 0.0
.bss 156464 156464 0 0.0
.data 4968 4968 0 0.0
.heap 875016 875016 0 0.0
.text 1010896 1010896 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861907 861899 -8 -0.0
bss 111476 111476 0 0.0
rodata 96532 96540 8 0.0
text 578272 578260 -12 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824267 824259 -8 -0.0
bss 107828 107828 0 0.0
rodata 87708 87716 8 0.0
text 552444 552432 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786946 786938 -8 -0.0
bss 112848 112848 0 0.0
rodata 91788 91796 8 0.0
text 507740 507728 -12 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838615 838607 -8 -0.0
bss 110508 110508 0 0.0
rodata 92904 92912 8 0.0
text 559756 559744 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763926 763918 -8 -0.0
bss 111920 111920 0 0.0
rodata 88208 88216 8 0.0
text 489316 489304 -12 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844707 844699 -8 -0.0
bss 110648 110648 0 0.0
rodata 94612 94620 8 0.0
text 563916 563904 -12 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838467 838475 8 0.0
bss 110544 110544 0 0.0
rodata 92900 92908 8 0.0
text 559492 559480 -12 -0.0
shell nrf52840dk_nrf52840 (read/write) 775955 775955 0 0.0
bss 109288 109288 0 0.0
rodata 72152 72152 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690962 690958 -4 -0.0
bss 110272 110272 0 0.0
rodata 66796 66792 -4 -0.0
text 440512 440512 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297144 8 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255408 8 0.0
lock-app default (read/write) 2211760 2211752 -8 -0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170024 1170016 -8 -0.0
qpg lighting-app qpg6100+debug (read only) 490672 490664 -8 -0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485352 485344 -8 -0.0
lock-app qpg6100+debug (read only) 466900 466892 -8 -0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461580 461572 -8 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663410 -8 -0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458654 458636 -18 -0.0

@woody-apple
Copy link
Contributor

Fast tracking, given platform code updated by platform maintainer.

@woody-apple woody-apple merged commit 1663f83 into project-chip:master Nov 11, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@chshu
esp32: fix QR code URL in shell command (project-chip#11668)
6f68f00 
* esp32: use common API to print QR code URL

Merge the QR code messages, so it won't be divided by other logs.

* esp32: fix QR code URL in shell command

* address the comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrishi dhrishi dhrishi approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app examples fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chshu @woody-apple @dhrishi @jmartinez-silabs