-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[esp32] migrate ESP32 dokcer image to 0.5.27 #11662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
November 11, 2021 04:05
pullapprove
bot
requested review from
selissia,
tecimovic,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
November 11, 2021 04:05
PR #11662: Size comparison from 9964cdb to c3836ec Increases above 0.2%:
Increases (2 builds for esp32)
Decreases (2 builds for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
gjc13
force-pushed
the
fix-esp32-docker-build
branch
from
November 11, 2021 08:08
c3836ec
to
e08c10e
Compare
PR #11662: Size comparison from d45cfaa to e08c10e Increases above 0.2%:
Increases (2 builds for esp32)
Decreases (2 builds for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 11, 2021
dhrishi
approved these changes
Nov 11, 2021
jmartinez-silabs
approved these changes
Nov 11, 2021
andy31415
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Updating to docker image 0.5.27 will cause ESP32 build to fail.
Change overview
As required in #11588, we'll create a separate PR for the build fix.
The MR updates the docker image used for ESP32 and fixes build with ESP-IDF v4.4 release.
Testing
Tested by github action.