Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Refactor RPC examples for better code reuse, and add RPCs to EFR lock app #11633

Merged
merged 2 commits into from
Nov 26, 2021
Merged

RPC: Refactor RPC examples for better code reuse, and add RPCs to EFR lock app #11633

merged 2 commits into from
Nov 26, 2021

Conversation

rgoliver
Copy link

Problem

All RPC examples currently implement there own Rpc.cpp file which creates the service, this is generally all copy pasted.

Change overview

  • Move the Rpc.cpp files to examples/platfrom so they can be shared between platform implementations.
  • Add compiler definitions to indicate which RPC services should be enabled for each application.
  • Add RPCs to the EFR32 lock app as an example for how this is done after the refactor.

Testing

Tested RPCs using the rpc-console on: esp32 all-clusters, nrf lighting, efr32 lighting, efr32 lock.

@rgoliver rgoliver force-pushed the refactor-rpc-examples branch from 200dad1 to c1ee6ea Compare November 10, 2021 14:42
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11633: Size comparison from a27a311 to c1ee6ea

Full report (17 builds for k32w, linux, p6, qpg, telink)
platform target config section a27a311 c1ee6ea change % change
k32w lighting-app k32w061+se05x+release (read/write) 699400 699400 0 0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613680 613680 0 0.0
lock-app k32w061+debug (read/write) 592152 592152 0 0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515928 515928 0 0.0
shell k32w061+debug (read/write) 657780 657780 0 0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570796 570796 0 0.0
linux all-clusters-app debug (read only) 1699057 1699057 0 0.0
(read/write) 126464 126464 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62288 62288 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139061 0 0.0
.text 1426482 1426482 0 0.0
bridge-app debug+rpc (read only) 1298877 1298877 0 0.0
(read/write) 77296 77296 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27952 27952 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091477 1091477 0 0.0
chip-tool debug (read only) 4616445 4616445 0 0.0
(read/write) 135072 135072 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101424 101424 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240746 240746 0 0.0
.text 4103877 4103877 0 0.0
lighting-app debug+rpc (read only) 1558249 1558249 0 0.0
(read/write) 110408 110408 0 0.0
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55360 55360 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128369 0 0.0
.text 1295746 1295746 0 0.0
ota-provider-app debug (read only) 1260113 1260113 0 0.0
(read/write) 75656 75656 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24808 24808 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050674 1050674 0 0.0
ota-requestor-app debug (read only) 1344673 1344673 0 0.0
(read/write) 79424 79424 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26072 26072 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123632 123632 0 0.0
.text 1121666 1121666 0 0.0
shell debug (read only) 788537 788537 0 0.0
(read/write) 65640 65640 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36960 36960 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77519 0 0.0
.text 609074 609074 0 0.0
tv-app debug (read only) 1842881 1842881 0 0.0
(read/write) 408248 408248 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59624 59624 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155757 0 0.0
.text 1542626 1542626 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297136 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255400 0 0.0
lock-app default (read/write) 2211752 2211752 0 0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170016 1170016 0 0.0
qpg lighting-app qpg6100+debug (read only) 490692 490692 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485372 485372 0 0.0
lock-app qpg6100+debug (read only) 466920 466920 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461600 461600 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663446 663446 0 0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458676 458676 0 0.0

@rgoliver rgoliver force-pushed the refactor-rpc-examples branch from c1ee6ea to 24476cf Compare November 10, 2021 15:46
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11633: Size comparison from 125ad20 to 24476cf

Full report (9 builds for k32w, p6, qpg, telink)
platform target config section 125ad20 24476cf change % change
k32w lighting-app k32w061+se05x+release (read/write) 699396 699396 0 0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613676 613676 0 0.0
lock-app k32w061+debug (read/write) 592132 592132 0 0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515908 515908 0 0.0
shell k32w061+debug (read/write) 657760 657760 0 0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570776 570776 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297136 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255400 0 0.0
lock-app default (read/write) 2211760 2211760 0 0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170024 1170024 0 0.0
qpg lighting-app qpg6100+debug (read only) 490672 490672 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485352 485352 0 0.0
lock-app qpg6100+debug (read only) 466900 466900 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461580 461580 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663418 0 0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458654 458654 0 0.0

@rgoliver rgoliver force-pushed the refactor-rpc-examples branch from 24476cf to 4c46458 Compare November 10, 2021 16:21
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11633: Size comparison from 125ad20 to 4c46458

Increases above 0.2%:

platform target config section 125ad20 4c46458 change % change
efr32 lighting-app BRD4161A+rpc (read only) 730040 771092 41052 5.6
(read/write) 132900 134580 1680 1.3
.bss 131004 132700 1696 1.3
.text 730032 771084 41052 5.6
Increases (1 build for efr32)
platform target config section 125ad20 4c46458 change % change
efr32 lighting-app BRD4161A+rpc (read only) 730040 771092 41052 5.6
(read/write) 132900 134580 1680 1.3
.bss 131004 132700 1696 1.3
.text 730032 771084 41052 5.6
Decreases (1 build for efr32)
platform target config section 125ad20 4c46458 change % change
efr32 lighting-app BRD4161A+rpc .data 1896 1880 -16 -0.8
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 125ad20 4c46458 change % change
efr32 lighting-app BRD4161A (read only) 742476 742476 0 0.0
(read/write) 116280 116280 0 0.0
.bss 114500 114500 0 0.0
.data 1780 1780 0 0.0
.text 742468 742468 0 0.0
BRD4161A+rpc (read only) 730040 771092 41052 5.6
(read/write) 132900 134580 1680 1.3
.bss 131004 132700 1696 1.3
.data 1896 1880 -16 -0.8
.text 730032 771084 41052 5.6
lock-app BRD4161A (read only) 721764 721764 0 0.0
(read/write) 114096 114096 0 0.0
.bss 112356 112356 0 0.0
.data 1740 1740 0 0.0
.text 721756 721756 0 0.0
window-app BRD4161A (read only) 722676 722676 0 0.0
(read/write) 114420 114420 0 0.0
.bss 112676 112676 0 0.0
.data 1744 1744 0 0.0
.text 722668 722668 0 0.0
esp32 all-clusters-app c3devkit (read only) 879114 879114 0 0.0
(read/write) 1305968 1305968 0 0.0
.dram0.bss 58440 58440 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197824 197824 0 0.0
.flash.text 879114 879114 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910683 910683 0 0.0
(read/write) 423308 423308 0 0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204100 204100 0 0.0
.flash.text 910683 910683 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699396 699396 0 0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613676 613676 0 0.0
lock-app k32w061+debug (read/write) 592132 592132 0 0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515908 515908 0 0.0
shell k32w061+debug (read/write) 657760 657760 0 0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570776 570776 0 0.0
linux all-clusters-app debug (read only) 1698921 1698921 0 0.0
(read/write) 126432 126432 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62256 62256 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139061 0 0.0
.text 1426370 1426370 0 0.0
bridge-app debug+rpc (read only) 1298741 1298741 0 0.0
(read/write) 77264 77264 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091365 1091365 0 0.0
chip-tool debug (read only) 4616469 4616469 0 0.0
(read/write) 135040 135040 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101400 101400 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240746 240746 0 0.0
.text 4103925 4103925 0 0.0
lighting-app debug+rpc (read only) 1558113 1558113 0 0.0
(read/write) 110376 110376 0 0.0
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55328 55328 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128369 0 0.0
.text 1295634 1295634 0 0.0
ota-provider-app debug (read only) 1259977 1259977 0 0.0
(read/write) 75624 75624 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050562 1050562 0 0.0
ota-requestor-app debug (read only) 1344681 1344681 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123632 123632 0 0.0
.text 1121698 1121698 0 0.0
shell debug (read only) 788441 788441 0 0.0
(read/write) 65608 65608 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77519 0 0.0
.text 609026 609026 0 0.0
tv-app debug (read only) 1842905 1842905 0 0.0
(read/write) 408216 408216 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155757 0 0.0
.text 1542674 1542674 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289248 2289248 0 0.0
.bss 179412 179412 0 0.0
.data 5216 5216 0 0.0
.heap 851816 851816 0 0.0
.text 1251848 1251848 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270688 2270688 0 0.0
.bss 172508 172508 0 0.0
.data 5576 5576 0 0.0
.heap 858360 858360 0 0.0
.text 1233288 1233288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248344 2248344 0 0.0
.bss 171404 171404 0 0.0
.data 5568 5568 0 0.0
.heap 859472 859472 0 0.0
.text 1210944 1210944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048296 2048296 0 0.0
.bss 156464 156464 0 0.0
.data 4968 4968 0 0.0
.heap 875016 875016 0 0.0
.text 1010896 1010896 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861907 861907 0 0.0
bss 111476 111476 0 0.0
rodata 96532 96532 0 0.0
text 578272 578272 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824267 824267 0 0.0
bss 107828 107828 0 0.0
rodata 87708 87708 0 0.0
text 552444 552444 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786946 786946 0 0.0
bss 112848 112848 0 0.0
rodata 91788 91788 0 0.0
text 507740 507740 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838615 838615 0 0.0
bss 110508 110508 0 0.0
rodata 92904 92904 0 0.0
text 559756 559756 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763926 763926 0 0.0
bss 111920 111920 0 0.0
rodata 88208 88208 0 0.0
text 489316 489316 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844707 844707 0 0.0
bss 110648 110648 0 0.0
rodata 94612 94612 0 0.0
text 563916 563916 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838467 838467 0 0.0
bss 110544 110544 0 0.0
rodata 92900 92900 0 0.0
text 559492 559492 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775955 775955 0 0.0
bss 109288 109288 0 0.0
rodata 72152 72152 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690962 690962 0 0.0
bss 110272 110272 0 0.0
rodata 66796 66796 0 0.0
text 440512 440512 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297136 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255400 0 0.0
lock-app default (read/write) 2211760 2211760 0 0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170024 1170024 0 0.0
qpg lighting-app qpg6100+debug (read only) 490672 490672 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485352 485352 0 0.0
lock-app qpg6100+debug (read only) 466900 466900 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461580 461580 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663418 0 0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458654 458654 0 0.0

@rgoliver rgoliver force-pushed the refactor-rpc-examples branch from 4c46458 to 4a490cf Compare November 10, 2021 19:32
@andy31415
Copy link
Contributor

@rgoliver - I believe this requires a rebase/merge to fix both CI conflict and checkout issues.

@rgoliver rgoliver force-pushed the refactor-rpc-examples branch from 4a490cf to f60172e Compare November 16, 2021 15:54
@github-actions
Copy link

PR #11633: Size comparison from 48db955 to f60172e

Increases above 0.2%:

platform target config section 48db955 f60172e change % change
efr32 lighting-app BRD4161A+rpc (read only) 732724 773816 41092 5.6
(read/write) 131992 133668 1676 1.3
.bss 130068 131764 1696 1.3
.text 732716 773808 41092 5.6
Increases (3 builds for efr32, linux, nrfconnect)
platform target config section 48db955 f60172e change % change
efr32 lighting-app BRD4161A+rpc (read only) 732724 773816 41092 5.6
(read/write) 131992 133668 1676 1.3
.bss 130068 131764 1696 1.3
.text 732716 773808 41092 5.6
linux lighting-app debug+rpc (read only) 1566073 1566089 16 0.0
.text 1303298 1303314 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822567 16 0.0
text 553312 553324 12 0.0
Decreases (1 build for efr32)
platform target config section 48db955 f60172e change % change
efr32 lighting-app BRD4161A+rpc .data 1924 1900 -24 -1.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 48db955 f60172e change % change
efr32 lighting-app BRD4161A (read only) 745208 745208 0 0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745200 745200 0 0.0
lock-app BRD4161A (read only) 722296 722296 0 0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722288 722288 0 0.0
window-app BRD4161A (read only) 723272 723272 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723264 723264 0 0.0
lighting-app BRD4161A+rpc (read only) 732724 773816 41092 5.6
(read/write) 131992 133668 1676 1.3
.bss 130068 131764 1696 1.3
.data 1924 1900 -24 -1.2
.text 732716 773808 41092 5.6
esp32 all-clusters-app c3devkit (read only) 824912 824912 0 0.0
(read/write) 1219650 1219650 0 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163800 0 0.0
.flash.text 824912 824912 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 895819 0 0.0
(read/write) 418980 418980 0 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191780 0 0.0
.flash.text 890435 890435 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lock-app k32w061+debug (read/write) 595020 595020 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 519840 519840 0 0.0
shell k32w061+debug (read/write) 660252 660252 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574040 574040 0 0.0
lighting-app k32w061+se05x+release (read/write) 703576 703576 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 618876 618876 0 0.0
linux all-clusters-app debug (read only) 1701841 1701841 0 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135253 0 0.0
.text 1433138 1433138 0 0.0
chip-tool debug (read only) 4892293 4892293 0 0.0
(read/write) 166280 166280 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 117936 117936 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265554 265554 0 0.0
.text 4317765 4317765 0 0.0
ota-provider-app debug (read only) 1252473 1252473 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112999 0 0.0
.text 1042386 1042386 0 0.0
ota-requestor-app debug (read only) 1335393 1335393 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123792 123792 0 0.0
.text 1112178 1112178 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1838569 1838569 0 0.0
(read/write) 405016 405016 0 0.0
.bss 336968 336968 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155149 155149 0 0.0
.text 1539154 1539154 0 0.0
bridge-app debug+rpc (read only) 1297013 1297013 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110668 0 0.0
.text 1089445 1089445 0 0.0
lighting-app debug+rpc (read only) 1566073 1566089 16 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128273 0 0.0
.text 1303298 1303314 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2283728 0 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1246328 1246328 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2269720 0 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1232320 1232320 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2245560 0 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1208160 1208160 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860183 0 0.0
bss 110384 110384 0 0.0
rodata 95032 95032 0 0.0
text 579140 579140 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835579 835579 0 0.0
bss 109408 109408 0 0.0
rodata 91500 91500 0 0.0
text 559236 559236 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 841723 0 0.0
bss 109548 109548 0 0.0
rodata 93212 93212 0 0.0
text 563420 563420 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835315 0 0.0
bss 109444 109444 0 0.0
rodata 91460 91460 0 0.0
text 558856 558856 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822567 16 0.0
bss 106740 106740 0 0.0
rodata 86216 86216 0 0.0
text 553312 553324 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785222 0 0.0
bss 111760 111760 0 0.0
rodata 90288 90288 0 0.0
text 508608 508608 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 760902 0 0.0
bss 110820 110820 0 0.0
rodata 86808 86808 0 0.0
text 488796 488796 0 0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292608 2292608 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1250872 1250872 0 0.0
lock-app default (read/write) 2210080 2210080 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168344 1168344 0 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489736 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484416 484416 0 0.0
lock-app qpg6100+debug (read only) 464692 464692 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459372 459372 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763014 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529210 529210 0 0.0

@rgoliver rgoliver force-pushed the refactor-rpc-examples branch from f60172e to 6cc4912 Compare November 23, 2021 14:11
@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

PR #11633: Size comparison from 187a9a3 to 6cc4912

Increases above 0.2%:

platform target config section 187a9a3 6cc4912 change % change
efr32 lighting-app BRD4161A+rpc (read only) 739476 780568 41092 5.6
(read/write) 136384 138060 1676 1.2
.bss 134452 136148 1696 1.3
.text 739468 780560 41092 5.6
Increases (3 builds for efr32, linux, nrfconnect)
platform target config section 187a9a3 6cc4912 change % change
efr32 lighting-app BRD4161A+rpc (read only) 739476 780568 41092 5.6
(read/write) 136384 138060 1676 1.2
.bss 134452 136148 1696 1.3
.text 739468 780560 41092 5.6
linux lighting-app debug+rpc (read only) 1599985 1600001 16 0.0
.text 1332642 1332658 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840+rpc (read/write) 830631 830647 16 0.0
text 558140 558152 12 0.0
Decreases (1 build for efr32)
platform target config section 187a9a3 6cc4912 change % change
efr32 lighting-app BRD4161A+rpc .data 1932 1908 -24 -1.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 187a9a3 6cc4912 change % change
efr32 lighting-app BRD4161A (read only) 751992 751992 0 0.0
(read/write) 119756 119756 0 0.0
.bss 117948 117948 0 0.0
.data 1808 1808 0 0.0
.text 751984 751984 0 0.0
BRD4161A+rpc (read only) 739476 780568 41092 5.6
(read/write) 136384 138060 1676 1.2
.bss 134452 136148 1696 1.3
.data 1932 1908 -24 -1.2
.text 739468 780560 41092 5.6
lock-app BRD4161A (read only) 729008 729008 0 0.0
(read/write) 117476 117476 0 0.0
.bss 115708 115708 0 0.0
.data 1764 1764 0 0.0
.text 729000 729000 0 0.0
window-app BRD4161A (read only) 732456 732456 0 0.0
(read/write) 117836 117836 0 0.0
.bss 116060 116060 0 0.0
.data 1772 1772 0 0.0
.text 732448 732448 0 0.0
esp32 all-clusters-app c3devkit (read only) 833976 833976 0 0.0
(read/write) 1222234 1222234 0 0.0
.dram0.bss 57824 57824 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165056 165056 0 0.0
.flash.text 833976 833976 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 904991 904991 0 0.0
(read/write) 421528 421528 0 0.0
.dram0.bss 63184 63184 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 193000 193000 0 0.0
.flash.text 899607 899607 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 708368 708368 0 0.0
.bss 77284 77284 0 0.0
.data 1920 1920 0 0.0
.text 623364 623364 0 0.0
lock-app k32w061+debug (read/write) 599716 599716 0 0.0
.bss 67724 67724 0 0.0
.data 1888 1888 0 0.0
.text 524304 524304 0 0.0
shell k32w061+debug (read/write) 665080 665080 0 0.0
.bss 78884 78884 0 0.0
.data 1856 1856 0 0.0
.text 578540 578540 0 0.0
linux all-clusters-app debug (read only) 1750609 1750609 0 0.0
(read/write) 128784 128784 0 0.0
.bss 58640 58640 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63792 63792 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 138613 138613 0 0.0
.text 1475618 1475618 0 0.0
bridge-app debug+rpc (read only) 1330101 1330101 0 0.0
(read/write) 76760 76760 0 0.0
.bss 41552 41552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 28608 28608 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 113212 113212 0 0.0
.text 1118741 1118741 0 0.0
chip-tool debug (read only) 5914389 5914389 0 0.0
(read/write) 196032 196032 0 0.0
.bss 39896 39896 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 148272 148272 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 283898 283898 0 0.0
.text 5249957 5249957 0 0.0
lighting-app debug+rpc (read only) 1599985 1600001 16 0.0
(read/write) 110104 110104 0 0.0
.bss 47280 47280 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 56272 56272 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 131569 131569 0 0.0
.text 1332642 1332658 16 0.0
ota-provider-app debug (read only) 1280873 1280873 0 0.0
(read/write) 75376 75376 0 0.0
.bss 44128 44128 0 0.0
.data 800 800 0 0.0
.data.rel.ro 25336 25336 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 456 456 0 0.0
.rodata 114999 114999 0 0.0
.text 1067202 1067202 0 0.0
ota-requestor-app debug (read only) 1377457 1377457 0 0.0
(read/write) 79240 79240 0 0.0
.bss 46592 46592 0 0.0
.data 864 864 0 0.0
.data.rel.ro 26664 26664 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 126408 126408 0 0.0
.text 1149586 1149586 0 0.0
shell debug (read only) 804641 804641 0 0.0
(read/write) 66160 66160 0 0.0
.bss 23336 23336 0 0.0
.data 274 274 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 352 352 0 0.0
.rodata 79279 79279 0 0.0
.text 620258 620258 0 0.0
tv-app debug (read only) 1892073 1892073 0 0.0
(read/write) 318928 318928 0 0.0
.bss 249912 249912 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 60552 60552 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159485 159485 0 0.0
.text 1586402 1586402 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290928 2290928 0 0.0
.bss 180372 180372 0 0.0
.data 5232 5232 0 0.0
.heap 850840 850840 0 0.0
.text 1253528 1253528 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275200 2275200 0 0.0
.bss 172276 172276 0 0.0
.data 5584 5584 0 0.0
.heap 858584 858584 0 0.0
.text 1237800 1237800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2251000 2251000 0 0.0
.bss 171092 171092 0 0.0
.data 5576 5576 0 0.0
.heap 859776 859776 0 0.0
.text 1213600 1213600 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156280 156280 0 0.0
.data 4976 4976 0 0.0
.heap 875192 875192 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 868263 868263 0 0.0
bss 112608 112608 0 0.0
rodata 96064 96064 0 0.0
text 583972 583972 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 830631 830647 16 0.0
bss 108960 108960 0 0.0
rodata 87248 87248 0 0.0
text 558140 558152 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793318 793318 0 0.0
bss 113980 113980 0 0.0
rodata 91320 91320 0 0.0
text 513440 513440 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841415 841415 0 0.0
bss 109640 109640 0 0.0
rodata 92496 92496 0 0.0
text 563824 563824 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 766722 766722 0 0.0
bss 111052 111052 0 0.0
rodata 87804 87804 0 0.0
text 493384 493384 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847543 847543 0 0.0
bss 109780 109780 0 0.0
rodata 94208 94208 0 0.0
text 568008 568008 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841119 841119 0 0.0
bss 109676 109676 0 0.0
rodata 92456 92456 0 0.0
text 563444 563444 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778671 778671 0 0.0
bss 109160 109160 0 0.0
rodata 73196 73196 0 0.0
text 521696 521696 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693678 693678 0 0.0
bss 110144 110144 0 0.0
rodata 67840 67840 0 0.0
text 442304 442304 0 0.0
p6 all-clusters-app default (read/write) 2304232 2304232 0 0.0
.bss 113360 113360 0 0.0
.data 2536 2536 0 0.0
.heap 917448 917448 0 0.0
.text 1262496 1262496 0 0.0
lock-app default (read/write) 2217400 2217400 0 0.0
.bss 100952 100952 0 0.0
.data 2408 2408 0 0.0
.heap 929984 929984 0 0.0
.text 1175664 1175664 0 0.0
qpg lighting-app qpg6100+debug (read only) 495060 495060 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50328 50328 0 0.0
.data 1016 1016 0 0.0
.text 489740 489740 0 0.0
lock-app qpg6100+debug (read only) 469996 469996 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 972 972 0 0.0
.text 464676 464676 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769542 769542 0 0.0
bss 79200 79200 0 0.0
noinit 37160 37160 0 0.0
text 534358 534358 0 0.0

@rgoliver
Copy link
Author

@rgoliver - I believe this requires a rebase/merge to fix both CI conflict and checkout issues.

@andy31415 This is rebased and passing now.

@rgoliver rgoliver force-pushed the refactor-rpc-examples branch from 6cc4912 to 1ed495a Compare November 26, 2021 14:44
@github-actions
Copy link

github-actions bot commented Nov 26, 2021 •
edited
Loading

PR #11633: Size comparison from 67c8f1d to 1ed495a

Increases above 0.2%:

platform target config section 67c8f1d 1ed495a change % change
efr32 lighting-app BRD4161A+rpc (read only) 749740 790520 40780 5.4
(read/write) 136460 138132 1672 1.2
.bss 134516 136212 1696 1.3
.text 749732 790512 40780 5.4
Increases (3 builds for efr32, linux, nrfconnect)
platform target config section 67c8f1d 1ed495a change % change
efr32 lighting-app BRD4161A+rpc (read only) 749740 790520 40780 5.4
(read/write) 136460 138132 1672 1.2
.bss 134516 136212 1696 1.3
.text 749732 790512 40780 5.4
linux lighting-app debug+rpc (read only) 1628153 1628169 16 0.0
.text 1358642 1358658 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840+rpc text 564312 564324 12 0.0
Decreases (1 build for efr32)
platform target config section 67c8f1d 1ed495a change % change
efr32 lighting-app BRD4161A+rpc .data 1944 1920 -24 -1.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 67c8f1d 1ed495a change % change
efr32 lighting-app BRD4161A (read only) 762072 762072 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762064 762064 0 0.0
BRD4161A+rpc (read only) 749740 790520 40780 5.4
(read/write) 136460 138132 1672 1.2
.bss 134516 136212 1696 1.3
.data 1944 1920 -24 -1.2
.text 749732 790512 40780 5.4
lock-app BRD4161A (read only) 736032 736032 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736024 736024 0 0.0
window-app BRD4161A (read only) 739096 739096 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739088 739088 0 0.0
esp32 all-clusters-app c3devkit (read only) 836422 836422 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165968 165968 0 0.0
.flash.text 836422 836422 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907823 907823 0 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193804 193804 0 0.0
.flash.text 902439 902439 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723208 723208 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637160 637160 0 0.0
lock-app k32w061+debug (read/write) 612280 612280 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535820 535820 0 0.0
shell k32w061+debug (read/write) 677600 677600 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 590016 590016 0 0.0
linux all-clusters-app debug (read only) 1774185 1774185 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138869 138869 0 0.0
.text 1496946 1496946 0 0.0
bridge-app debug+rpc (read only) 1348509 1348509 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113500 113500 0 0.0
.text 1134917 1134917 0 0.0
chip-tool debug (read only) 6085653 6085653 0 0.0
(read/write) 199920 199920 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151888 151888 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 291816 291816 0 0.0
.text 5404709 5404709 0 0.0
lighting-app debug+rpc (read only) 1628153 1628169 16 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131793 131793 0 0.0
.text 1358642 1358658 16 0.0
ota-provider-app debug (read only) 1309537 1309537 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114832 114832 0 0.0
.text 1094354 1094354 0 0.0
ota-requestor-app debug (read only) 1405977 1405977 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126304 126304 0 0.0
.text 1176530 1176530 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1918385 1918385 0 0.0
(read/write) 320152 320152 0 0.0
.bss 250232 250232 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159848 159848 0 0.0
.text 1610338 1610338 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294736 2294736 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257336 1257336 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279952 2279952 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242552 1242552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253096 2253096 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215696 1215696 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875499 875499 0 0.0
bss 112660 112660 0 0.0
rodata 97188 97188 0 0.0
text 590008 590008 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838075 838075 0 0.0
bss 109012 109012 0 0.0
rodata 88436 88436 0 0.0
text 564312 564324 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800538 800538 0 0.0
bss 114036 114036 0 0.0
rodata 92444 92444 0 0.0
text 519472 519472 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846427 846427 0 0.0
bss 109700 109700 0 0.0
rodata 92972 92972 0 0.0
text 568280 568280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771698 771698 0 0.0
bss 111108 111108 0 0.0
rodata 88260 88260 0 0.0
text 497832 497832 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852399 852399 0 0.0
bss 109836 109836 0 0.0
rodata 94680 94680 0 0.0
text 572324 572324 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845523 845523 0 0.0
bss 109712 109712 0 0.0
rodata 92844 92844 0 0.0
text 567408 567408 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778447 778447 0 0.0
bss 109180 109180 0 0.0
rodata 73084 73084 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67724 67724 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311176 2311176 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269440 1269440 0 0.0
lock-app default (read/write) 2222992 2222992 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181256 1181256 0 0.0
qpg lighting-app qpg6100+debug (read only) 502992 502992 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497672 497672 0 0.0
lock-app qpg6100+debug (read only) 475708 475708 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470388 470388 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777286 777286 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540616 540616 0 0.0

@andy31415
Copy link
Contributor

fast track: domain owner change for RPC, has checkmarks and has been up for a while now.

@andy31415
Copy link
Contributor

/rebase

Rob Oliver added 2 commits November 26, 2021 18:29
@andy31415
RPC: Move Rpc.cpp to platform
58860aa 
Reduce code duplication by moving the Rpc.cpp file to the platform.
This greatly reduces code required to add rpcs to examples.
@andy31415
RPC: Add RPCs to EFR lock app
e6fdabe
@woody-apple woody-apple force-pushed the refactor-rpc-examples branch from 1ed495a to e6fdabe Compare November 26, 2021 18:29
@github-actions
Copy link

github-actions bot commented Nov 26, 2021 •
edited
Loading

PR #11633: Size comparison from 65f4475 to e6fdabe

Increases above 0.2%:

platform target config section 65f4475 e6fdabe change % change
efr32 lighting-app BRD4161A+rpc (read only) 749740 790520 40780 5.4
(read/write) 136460 138132 1672 1.2
.bss 134516 136212 1696 1.3
.text 749732 790512 40780 5.4
Increases (3 builds for efr32, linux, nrfconnect)
platform target config section 65f4475 e6fdabe change % change
efr32 lighting-app BRD4161A+rpc (read only) 749740 790520 40780 5.4
(read/write) 136460 138132 1672 1.2
.bss 134516 136212 1696 1.3
.text 749732 790512 40780 5.4
linux lighting-app debug+rpc (read only) 1628153 1628169 16 0.0
.text 1358642 1358658 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840+rpc text 564312 564324 12 0.0
Decreases (1 build for efr32)
platform target config section 65f4475 e6fdabe change % change
efr32 lighting-app BRD4161A+rpc .data 1944 1920 -24 -1.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 65f4475 e6fdabe change % change
efr32 lighting-app BRD4161A (read only) 762072 762072 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762064 762064 0 0.0
BRD4161A+rpc (read only) 749740 790520 40780 5.4
(read/write) 136460 138132 1672 1.2
.bss 134516 136212 1696 1.3
.data 1944 1920 -24 -1.2
.text 749732 790512 40780 5.4
lock-app BRD4161A (read only) 736032 736032 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736024 736024 0 0.0
window-app BRD4161A (read only) 739096 739096 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739088 739088 0 0.0
esp32 all-clusters-app c3devkit (read only) 836422 836422 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165968 165968 0 0.0
.flash.text 836422 836422 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907835 907835 0 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193804 193804 0 0.0
.flash.text 902451 902451 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723208 723208 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637160 637160 0 0.0
lock-app k32w061+debug (read/write) 612280 612280 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535820 535820 0 0.0
shell k32w061+debug (read/write) 677600 677600 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 590016 590016 0 0.0
linux all-clusters-app debug (read only) 1774185 1774185 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138869 138869 0 0.0
.text 1496946 1496946 0 0.0
bridge-app debug+rpc (read only) 1348509 1348509 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113500 113500 0 0.0
.text 1134917 1134917 0 0.0
chip-tool debug (read only) 6085653 6085653 0 0.0
(read/write) 199920 199920 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151888 151888 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 291816 291816 0 0.0
.text 5404709 5404709 0 0.0
lighting-app debug+rpc (read only) 1628153 1628169 16 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131793 131793 0 0.0
.text 1358642 1358658 16 0.0
ota-provider-app debug (read only) 1309537 1309537 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114832 114832 0 0.0
.text 1094354 1094354 0 0.0
ota-requestor-app debug (read only) 1405977 1405977 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126304 126304 0 0.0
.text 1176530 1176530 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1918385 1918385 0 0.0
(read/write) 320152 320152 0 0.0
.bss 250232 250232 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159848 159848 0 0.0
.text 1610338 1610338 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294736 2294736 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257336 1257336 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279952 2279952 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242552 1242552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253096 2253096 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215696 1215696 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875499 875499 0 0.0
bss 112660 112660 0 0.0
rodata 97188 97188 0 0.0
text 590008 590008 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838075 838075 0 0.0
bss 109012 109012 0 0.0
rodata 88436 88436 0 0.0
text 564312 564324 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800538 800538 0 0.0
bss 114036 114036 0 0.0
rodata 92444 92444 0 0.0
text 519472 519472 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846427 846427 0 0.0
bss 109700 109700 0 0.0
rodata 92972 92972 0 0.0
text 568280 568280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771698 771698 0 0.0
bss 111108 111108 0 0.0
rodata 88260 88260 0 0.0
text 497832 497832 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852399 852399 0 0.0
bss 109836 109836 0 0.0
rodata 94680 94680 0 0.0
text 572324 572324 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845523 845523 0 0.0
bss 109712 109712 0 0.0
rodata 92844 92844 0 0.0
text 567408 567408 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778447 778447 0 0.0
bss 109180 109180 0 0.0
rodata 73084 73084 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67724 67724 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311176 2311176 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269440 1269440 0 0.0
lock-app default (read/write) 2222992 2222992 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181256 1181256 0 0.0
qpg lighting-app qpg6100+debug (read only) 502992 502992 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497672 497672 0 0.0
lock-app qpg6100+debug (read only) 475708 475708 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470388 470388 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777286 777286 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540616 540616 0 0.0

@andy31415 andy31415 merged commit 8a2fd0d into project-chip:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

Assignees
No one assigned
Labels
examples fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgoliver @andy31415 @jmartinez-silabs