Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Warnings] Update the documentation of some files in src/app and src/… #11626

Merged
merged 1 commit into from
Nov 11, 2021
Merged

[Warnings] Update the documentation of some files in src/app and src/… #11626

merged 1 commit into from
Nov 11, 2021

Conversation

vivien-apple
Copy link
Contributor

…protocols to avoid some warnings when compiling with XCode

Problem

Some other documentation warnings found when compiling with Xcode.

Change overview

  • update the relevant documentation

@vivien-apple
[Warnings] Update the documentation of some files in src/app and src/…
7f5af7b 
…protocols to avoid some warnings when compiling with XCode
@vivien-apple vivien-apple self-assigned this Nov 10, 2021
@boring-cyborg boring-cyborg bot added the app label Nov 10, 2021
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11626: Size comparison from 30e1b97 to 7f5af7b

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 30e1b97 7f5af7b change % change
efr32 lighting-app BRD4161A (read only) 742308 742308 0 0.0
(read/write) 116276 116276 0 0.0
.bss 114492 114492 0 0.0
.data 1784 1784 0 0.0
.text 742300 742300 0 0.0
BRD4161A+rpc (read only) 729832 729832 0 0.0
(read/write) 132900 132900 0 0.0
.bss 130996 130996 0 0.0
.data 1900 1900 0 0.0
.text 729824 729824 0 0.0
lock-app BRD4161A (read only) 721588 721588 0 0.0
(read/write) 114092 114092 0 0.0
.bss 112348 112348 0 0.0
.data 1744 1744 0 0.0
.text 721580 721580 0 0.0
window-app BRD4161A (read only) 722500 722500 0 0.0
(read/write) 114416 114416 0 0.0
.bss 112668 112668 0 0.0
.data 1748 1748 0 0.0
.text 722492 722492 0 0.0
esp32 all-clusters-app c3devkit (read only) 878906 878906 0 0.0
(read/write) 1305920 1305920 0 0.0
.dram0.bss 58432 58432 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197792 197792 0 0.0
.flash.text 878906 878906 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910299 910299 0 0.0
(read/write) 423252 423252 0 0.0
.dram0.bss 60936 60936 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204060 204060 0 0.0
.flash.text 910299 910299 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699104 699104 0 0.0
.bss 78004 78004 0 0.0
.data 1912 1912 0 0.0
.text 613388 613388 0 0.0
lock-app k32w061+debug (read/write) 591832 591832 0 0.0
.bss 68532 68532 0 0.0
.data 1880 1880 0 0.0
.text 515620 515620 0 0.0
shell k32w061+debug (read/write) 657472 657472 0 0.0
.bss 79332 79332 0 0.0
.data 1848 1848 0 0.0
.text 570492 570492 0 0.0
linux all-clusters-app debug (read only) 1697777 1697777 0 0.0
(read/write) 126304 126304 0 0.0
.bss 57872 57872 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62144 62144 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138901 138901 0 0.0
.text 1425794 1425794 0 0.0
bridge-app debug+rpc (read only) 1297565 1297565 0 0.0
(read/write) 77104 77104 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27808 27808 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110740 110740 0 0.0
.text 1090789 1090789 0 0.0
chip-tool debug (read only) 4615109 4615109 0 0.0
(read/write) 134888 134888 0 0.0
.bss 25936 25936 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101280 101280 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240592 240592 0 0.0
.text 4103125 4103125 0 0.0
lighting-app debug+rpc (read only) 1556953 1556953 0 0.0
(read/write) 110216 110216 0 0.0
.bss 48528 48528 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55216 55216 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128177 128177 0 0.0
.text 1295074 1295074 0 0.0
ota-provider-app debug (read only) 1258729 1258729 0 0.0
(read/write) 75464 75464 0 0.0
.bss 44960 44960 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24664 24664 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112416 112416 0 0.0
.text 1049922 1049922 0 0.0
ota-requestor-app debug (read only) 1343289 1343289 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47424 47424 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123432 123432 0 0.0
.text 1120914 1120914 0 0.0
shell debug (read only) 787161 787161 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77327 77327 0 0.0
.text 608322 608322 0 0.0
tv-app debug (read only) 1841641 1841641 0 0.0
(read/write) 408064 408064 0 0.0
.bss 340208 340208 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59480 59480 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155624 155624 0 0.0
.text 1541954 1541954 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288952 2288952 0 0.0
.bss 179404 179404 0 0.0
.data 5216 5216 0 0.0
.heap 851824 851824 0 0.0
.text 1251552 1251552 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270384 2270384 0 0.0
.bss 172500 172500 0 0.0
.data 5584 5584 0 0.0
.heap 858360 858360 0 0.0
.text 1232984 1232984 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248104 2248104 0 0.0
.bss 171396 171396 0 0.0
.data 5568 5568 0 0.0
.heap 859480 859480 0 0.0
.text 1210704 1210704 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048152 2048152 0 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1010752 1010752 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861607 861607 0 0.0
bss 111468 111468 0 0.0
rodata 96488 96488 0 0.0
text 578012 578012 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823935 823935 0 0.0
bss 107820 107820 0 0.0
rodata 87664 87664 0 0.0
text 552160 552160 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786646 786646 0 0.0
bss 112840 112840 0 0.0
rodata 91744 91744 0 0.0
text 507484 507484 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838315 838315 0 0.0
bss 110500 110500 0 0.0
rodata 92860 92860 0 0.0
text 559496 559496 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763626 0 0.0
bss 111912 111912 0 0.0
rodata 88164 88164 0 0.0
text 489060 489060 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844407 844407 0 0.0
bss 110640 110640 0 0.0
rodata 94568 94568 0 0.0
text 563656 563656 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838167 838167 0 0.0
bss 110536 110536 0 0.0
rodata 92856 92856 0 0.0
text 559232 559232 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775719 775719 0 0.0
bss 109280 109280 0 0.0
rodata 72108 72108 0 0.0
text 519752 519752 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690774 690774 0 0.0
bss 110264 110264 0 0.0
rodata 66752 66752 0 0.0
text 440360 440360 0 0.0
p6 all-clusters-app default (read/write) 2296968 2296968 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255232 1255232 0 0.0
lock-app default (read/write) 2211568 2211568 0 0.0
.bss 101264 101264 0 0.0
.data 2408 2408 0 0.0
.heap 929672 929672 0 0.0
.text 1169832 1169832 0 0.0
qpg lighting-app qpg6100+debug (read only) 490396 490396 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51160 51160 0 0.0
.data 1012 1012 0 0.0
.text 485076 485076 0 0.0
lock-app qpg6100+debug (read only) 466608 466608 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50104 50104 0 0.0
.data 968 968 0 0.0
.text 461288 461288 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663174 663174 0 0.0
bss 69280 69280 0 0.0
noinit 33216 33216 0 0.0
text 458464 458464 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking documentation updates.

@woody-apple woody-apple merged commit a7d17ac into project-chip:master Nov 11, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@vivien-apple
[Warnings] Update the documentation of some files in src/app and src/…
7d36e51 
…protocols to avoid some warnings when compiling with XCode (project-chip#11626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @woody-apple @bzbarsky-apple