Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce header files for the OTA Requestor API declarations #11605

Merged
merged 13 commits into from
Nov 12, 2021
Merged

Introduce header files for the OTA Requestor API declarations #11605

merged 13 commits into from
Nov 12, 2021

Conversation

selissia
Copy link
Contributor

@selissia selissia commented Nov 9, 2021 •
edited
Loading

Problem

Need to start introducing APIs for the OTA Requestor refactoring

Change overview

Introduce ota-downloader.h, ota-image-processor.h, ota-requestor-driver.h, ota-requestor.h and ota-requestor-interface.h containing OTA Requestor API declarations.

Testing

No executable code changed. No testing beyond compilation and CI.

@boring-cyborg boring-cyborg bot added the app label Nov 9, 2021
@restyled-io restyled-io bot mentioned this pull request Nov 9, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11605: Size comparison from 89898f8 to 340ac67

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 89898f8 340ac67 change % change
efr32 lighting-app BRD4161A (read only) 742904 742904 0 0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742896 742896 0 0.0
BRD4161A+rpc (read only) 730440 730440 0 0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 730432 730432 0 0.0
lock-app BRD4161A (read only) 722192 722192 0 0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 722184 722184 0 0.0
window-app BRD4161A (read only) 723088 723088 0 0.0
(read/write) 114412 114412 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 723080 723080 0 0.0
esp32 all-clusters-app c3devkit (read only) 880694 880694 0 0.0
(read/write) 1306536 1306536 0 0.0
.dram0.bss 58464 58464 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198360 198360 0 0.0
.flash.text 880694 880694 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911867 911867 0 0.0
(read/write) 423864 423864 0 0.0
.dram0.bss 60968 60968 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204624 204624 0 0.0
.flash.text 911867 911867 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699648 0 0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613940 613940 0 0.0
lock-app k32w061+debug (read/write) 592360 592360 0 0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 516156 516156 0 0.0
shell k32w061+debug (read/write) 658016 658016 0 0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 571044 571044 0 0.0
linux all-clusters-app debug (read only) 1710601 1710601 0 0.0
(read/write) 126528 126528 0 0.0
.bss 57872 57872 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62352 62352 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139765 0 0.0
.text 1437346 1437346 0 0.0
bridge-app debug+rpc (read only) 1298253 1298253 0 0.0
(read/write) 77072 77072 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090821 1090821 0 0.0
chip-tool debug (read only) 4995029 4995029 0 0.0
(read/write) 134760 134760 0 0.0
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101232 101232 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 242064 242064 0 0.0
.text 4481717 4481717 0 0.0
lighting-app debug+rpc (read only) 1557945 1557945 0 0.0
(read/write) 110088 110088 0 0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1295410 1295410 0 0.0
ota-provider-app debug (read only) 1259721 1259721 0 0.0
(read/write) 75336 75336 0 0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1050258 1050258 0 0.0
ota-requestor-app debug (read only) 1344281 1344281 0 0.0
(read/write) 79104 79104 0 0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1121250 1121250 0 0.0
shell debug (read only) 789065 789065 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 609362 609362 0 0.0
tv-app debug (read only) 1842281 1842281 0 0.0
(read/write) 407936 407936 0 0.0
.bss 340112 340112 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59448 59448 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156456 0 0.0
.text 1541906 1541906 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290856 2290856 0 0.0
.bss 179436 179436 0 0.0
.data 5232 5232 0 0.0
.heap 851776 851776 0 0.0
.text 1253456 1253456 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270952 2270952 0 0.0
.bss 172492 172492 0 0.0
.data 5584 5584 0 0.0
.heap 858368 858368 0 0.0
.text 1233552 1233552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248672 2248672 0 0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1211272 1211272 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048864 2048864 0 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1011464 1011464 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862155 862155 0 0.0
bss 111460 111460 0 0.0
rodata 96924 96924 0 0.0
text 578128 578128 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824503 824503 0 0.0
bss 107812 107812 0 0.0
rodata 88104 88104 0 0.0
text 552276 552276 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787162 787162 0 0.0
bss 112832 112832 0 0.0
rodata 92180 92180 0 0.0
text 507600 507600 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838831 838831 0 0.0
bss 110492 110492 0 0.0
rodata 93296 93296 0 0.0
text 559612 559612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764142 764142 0 0.0
bss 111904 111904 0 0.0
rodata 88600 88600 0 0.0
text 489176 489176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844955 844955 0 0.0
bss 110632 110632 0 0.0
rodata 95004 95004 0 0.0
text 563772 563772 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838699 838699 0 0.0
bss 110528 110528 0 0.0
rodata 93292 93292 0 0.0
text 559348 559348 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776431 776431 0 0.0
bss 109280 109280 0 0.0
rodata 72564 72564 0 0.0
text 520004 520004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691482 691482 0 0.0
bss 110264 110264 0 0.0
rodata 67204 67204 0 0.0
text 440612 440612 0 0.0
p6 all-clusters-app default (read/write) 2299528 2299528 0 0.0
.bss 112448 112448 0 0.0
.data 2536 2536 0 0.0
.heap 918360 918360 0 0.0
.text 1257792 1257792 0 0.0
lock-app default (read/write) 2212184 2212184 0 0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1170448 1170448 0 0.0
qpg lighting-app qpg6100+debug (read only) 490776 490776 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 485456 485456 0 0.0
lock-app qpg6100+debug (read only) 466988 466988 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461668 461668 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663750 663750 0 0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458596 458596 0 0.0

@selissia selissia changed the title Introduce ota-requestor.h containing Requestor API declarations Introduce header files for the OTA Requestor API declarations Nov 10, 2021
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11605: Size comparison from 125ad20 to b0090d1

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 125ad20 b0090d1 change % change
efr32 lighting-app BRD4161A (read only) 742476 742476 0 0.0
(read/write) 116280 116280 0 0.0
.bss 114500 114500 0 0.0
.data 1780 1780 0 0.0
.text 742468 742468 0 0.0
BRD4161A+rpc (read only) 730040 730040 0 0.0
(read/write) 132900 132900 0 0.0
.bss 131004 131004 0 0.0
.data 1896 1896 0 0.0
.text 730032 730032 0 0.0
lock-app BRD4161A (read only) 721764 721764 0 0.0
(read/write) 114096 114096 0 0.0
.bss 112356 112356 0 0.0
.data 1740 1740 0 0.0
.text 721756 721756 0 0.0
window-app BRD4161A (read only) 722676 722676 0 0.0
(read/write) 114420 114420 0 0.0
.bss 112676 112676 0 0.0
.data 1744 1744 0 0.0
.text 722668 722668 0 0.0
esp32 all-clusters-app c3devkit (read only) 879114 879114 0 0.0
(read/write) 1305968 1305968 0 0.0
.dram0.bss 58440 58440 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197824 197824 0 0.0
.flash.text 879114 879114 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910683 910683 0 0.0
(read/write) 423308 423308 0 0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204100 204100 0 0.0
.flash.text 910683 910683 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699396 699396 0 0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613676 613676 0 0.0
lock-app k32w061+debug (read/write) 592132 592132 0 0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515908 515908 0 0.0
shell k32w061+debug (read/write) 657760 657760 0 0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570776 570776 0 0.0
linux all-clusters-app debug (read only) 1698921 1698921 0 0.0
(read/write) 126432 126432 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62256 62256 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139061 0 0.0
.text 1426370 1426370 0 0.0
bridge-app debug+rpc (read only) 1298741 1298741 0 0.0
(read/write) 77264 77264 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091365 1091365 0 0.0
chip-tool debug (read only) 4616469 4616469 0 0.0
(read/write) 135040 135040 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101400 101400 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240746 240746 0 0.0
.text 4103925 4103925 0 0.0
lighting-app debug+rpc (read only) 1558113 1558113 0 0.0
(read/write) 110376 110376 0 0.0
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55328 55328 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128369 0 0.0
.text 1295634 1295634 0 0.0
ota-provider-app debug (read only) 1259977 1259977 0 0.0
(read/write) 75624 75624 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050562 1050562 0 0.0
ota-requestor-app debug (read only) 1344681 1344681 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123632 123632 0 0.0
.text 1121698 1121698 0 0.0
shell debug (read only) 788441 788441 0 0.0
(read/write) 65608 65608 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77519 0 0.0
.text 609026 609026 0 0.0
tv-app debug (read only) 1842905 1842905 0 0.0
(read/write) 408216 408216 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155757 0 0.0
.text 1542674 1542674 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289248 2289248 0 0.0
.bss 179412 179412 0 0.0
.data 5216 5216 0 0.0
.heap 851816 851816 0 0.0
.text 1251848 1251848 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270688 2270688 0 0.0
.bss 172508 172508 0 0.0
.data 5576 5576 0 0.0
.heap 858360 858360 0 0.0
.text 1233288 1233288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248344 2248344 0 0.0
.bss 171404 171404 0 0.0
.data 5568 5568 0 0.0
.heap 859472 859472 0 0.0
.text 1210944 1210944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048296 2048296 0 0.0
.bss 156464 156464 0 0.0
.data 4968 4968 0 0.0
.heap 875016 875016 0 0.0
.text 1010896 1010896 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861907 861907 0 0.0
bss 111476 111476 0 0.0
rodata 96532 96532 0 0.0
text 578272 578272 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824267 824267 0 0.0
bss 107828 107828 0 0.0
rodata 87708 87708 0 0.0
text 552444 552444 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786946 786946 0 0.0
bss 112848 112848 0 0.0
rodata 91788 91788 0 0.0
text 507740 507740 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838615 838615 0 0.0
bss 110508 110508 0 0.0
rodata 92904 92904 0 0.0
text 559756 559756 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763926 763926 0 0.0
bss 111920 111920 0 0.0
rodata 88208 88208 0 0.0
text 489316 489316 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844707 844707 0 0.0
bss 110648 110648 0 0.0
rodata 94612 94612 0 0.0
text 563916 563916 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838467 838467 0 0.0
bss 110544 110544 0 0.0
rodata 92900 92900 0 0.0
text 559492 559492 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775955 775955 0 0.0
bss 109288 109288 0 0.0
rodata 72152 72152 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690962 690962 0 0.0
bss 110272 110272 0 0.0
rodata 66796 66796 0 0.0
text 440512 440512 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297136 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255400 0 0.0
lock-app default (read/write) 2211760 2211760 0 0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170024 1170024 0 0.0
qpg lighting-app qpg6100+debug (read only) 490672 490672 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485352 485352 0 0.0
lock-app qpg6100+debug (read only) 466900 466900 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461580 461580 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663418 0 0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458654 458654 0 0.0

@selissia selissia marked this pull request as ready for review November 10, 2021 16:53
@restyled-io restyled-io bot mentioned this pull request Nov 11, 2021
Closed
@selissia selissia requested a review from holbrookt November 11, 2021 14:18
@restyled-io restyled-io bot mentioned this pull request Nov 12, 2021
Closed
@shubhamdp shubhamdp mentioned this pull request Nov 12, 2021
Merged
1 task
@selissia selissia requested review from a user and holbrookt November 12, 2021 12:08
@project-chip project-chip deleted a comment from holbrookt Nov 12, 2021
@selissia selissia mentioned this pull request Nov 12, 2021
Closed
holbrookt
holbrookt approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@holbrookt holbrookt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the other concerns are handled in #11742, I'm ok with this so far. But I would suggest we get at least one more approval from the platform vendors who will be using this

@selissia selissia merged commit c7694b4 into project-chip:master Nov 12, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@selissia @restyled-commits
Introduce header files for the OTA Requestor API declarations (projec…
4bc6996 
…t-chip#11605)

Problem
Need to start introducing APIs for the OTA Requestor refactoring

Change overview
Introduce ota-downloader.h, ota-image-processor.h, ota-requestor-driver.h, ota-requestor.h and ota-requestor-interface.h containing OTA Requestor API declarations.

Testing
No executable code changed. No testing beyond compilation and CI.

* Introduce ota-requestor.h containing Requestor API declarations

* Split OTA Requestor class declarations into multiple headers

* Restyled by whitespace

* Restyled by clang-format

* Clean up comments and function names

* Misc API format changes based on PR comments

* Restyled by clang-format

* Rename some classes and methods

* Rename a method

* Renaming avd vairious formatting changes

* Restyled by clang-format

* Add an API declaration

Co-authored-by: Restyled.io <[email protected]>
@selissia selissia deleted the requestor_refactoring branch May 12, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carol-apple carol-apple carol-apple approved these changes

@shubhamdp shubhamdp shubhamdp left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@holbrookt holbrookt holbrookt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@selissia @holbrookt @shubhamdp @carol-apple @jmartinez-silabs @restyled-commits