-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Update write client for groups #11601
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:update_write_handler
Nov 10, 2021
Merged
[Group] Update write client for groups #11601
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:update_write_handler
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jmartinez-silabs,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tecimovic
November 9, 2021 20:04
pullapprove
bot
requested review from
turon,
vivien-apple,
wbschiller and
woody-apple
November 9, 2021 20:04
PR #11601: Size comparison from e6dab37 to 914c376 Increases (3 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mrjerryjohns
reviewed
Nov 9, 2021
bzbarsky-apple
approved these changes
Nov 9, 2021
woody-apple
approved these changes
Nov 10, 2021
jmartinez-silabs
approved these changes
Nov 10, 2021
andy31415
approved these changes
Nov 10, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Update write client for groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
partial fix of #11078
As discussed with @bzbarsky-apple issue 11078 will be fixed with a multiple of small PR. This will (hopefully) speed up the review process and shouldn't break anything since there's nothing to break regarding group communication.
Change overview
Update write client for group session to allow group attribute write.
Testing
A Unit test was added, however it will need an update once #11078 is complete.