-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run Tests in CI that have the word Simulated in them. #11598
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
krypton36:RenameSimulatedDeviceTest
Nov 9, 2021
Merged
Do not run Tests in CI that have the word Simulated in them. #11598
bzbarsky-apple
merged 1 commit into
project-chip:master
from
krypton36:RenameSimulatedDeviceTest
Nov 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krypton36
force-pushed
the
RenameSimulatedDeviceTest
branch
from
November 9, 2021 19:21
d46d8e8
to
2658b23
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple and
sagar-apple
November 9, 2021 19:22
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
November 9, 2021 19:22
krypton36
force-pushed
the
RenameSimulatedDeviceTest
branch
from
November 9, 2021 19:23
2658b23
to
7dd2f4f
Compare
krypton36
force-pushed
the
RenameSimulatedDeviceTest
branch
from
November 9, 2021 19:24
7dd2f4f
to
aa8c6a9
Compare
bzbarsky-apple
approved these changes
Nov 9, 2021
LuDuda
approved these changes
Nov 9, 2021
du48s03
approved these changes
Nov 9, 2021
PR #11598: Size comparison from e6dab37 to aa8c6a9 Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Simulated tests do not run in CI. We need to skip them when finding available tests to run.
Change overview
Testing
Ran scripts/tests/test_suites.sh script to make sure it is not included.