Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Inet::EndPoint into per-implementation files #11539

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Split Inet::EndPoint into per-implementation files #11539

merged 1 commit into from
Nov 9, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

This is a step toward #7715 Virtualize System and Inet interfaces.

Change overview

Move each Inet::EndPointBasis implementation into its own file.
Each inherits from Inet::EndPointBase, but transitionally each
implementation is statically named EndPointBasis, and initialization
continues to be done in InitEndPointBasis() rather than a constructor.

Testing

CI; no changes to functionality.

@kpschoedel
Split Inet::EndPoint into per-implemention files
e611d5d 
#### Problem

This is a step toward project-chip#7715 _Virtualize System and Inet interfaces_.

#### Change overview

Move each `Inet::EndPointBasis` implementation into its own file.
Each inherits from `Inet::EndPointBase`, but transitionally each
implementation is statically named `EndPointBasis`, and initialization
continues to be done in `InitEndPointBasis()` rather than a constructor.

#### Testing

CI; no changes to functionality.
@boring-cyborg boring-cyborg bot added the inet label Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #11539: Size comparison from 108fd91 to e611d5d

Increases above 0.2%:

platform target config section 108fd91 e611d5d change % change
linux all-clusters-app debug (read/write) 125728 126368 640 0.5
.bss 57200 57712 512 0.9
bridge-app debug+rpc (read/write) 76272 76912 640 0.8
.bss 42096 42608 512 1.2
.data.rel.ro 27640 27760 120 0.4
chip-tool debug (read/write) 133160 133800 640 0.5
.bss 25328 25840 512 2.0
lighting-app debug+rpc (read/write) 109272 109880 608 0.6
.bss 47768 48280 512 1.1
ota-provider-app debug (read/write) 74472 75112 640 0.9
.bss 44192 44704 512 1.2
.data.rel.ro 24440 24568 128 0.5
ota-requestor-app debug (read/write) 83728 84368 640 0.8
.bss 52320 52832 512 1.0
.data.rel.ro 25448 25576 128 0.5
shell debug (read/write) 64648 65320 672 1.0
.bss 23240 23752 512 2.2
.data.rel.ro 36656 36816 160 0.4
p6 all-clusters-app default .bss 111776 112288 512 0.5
lock-app default .bss 100584 101096 512 0.5
Increases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 108fd91 e611d5d change % change
efr32 lighting-app BRD4161A (read only) 741984 742232 248 0.0
(read/write) 116076 116108 32 0.0
.bss 114292 114324 32 0.0
.text 741976 742224 248 0.0
BRD4161A+rpc (read only) 729512 729784 272 0.0
(read/write) 132700 132732 32 0.0
.bss 130796 130828 32 0.0
.text 729504 729776 272 0.0
lock-app BRD4161A (read only) 721264 721520 256 0.0
(read/write) 113892 113924 32 0.0
.bss 112148 112180 32 0.0
.text 721256 721512 256 0.0
window-app BRD4161A (read only) 722160 722416 256 0.0
(read/write) 114220 114252 32 0.0
.bss 112468 112500 32 0.0
.text 722152 722408 256 0.0
esp32 all-clusters-app c3devkit (read only) 880098 880146 48 0.0
(read/write) 1306328 1306408 80 0.0
.dram0.bss 58240 58304 64 0.1
.flash.rodata 198376 198392 16 0.0
.flash.text 880098 880146 48 0.0
m5stack (read only) 911251 911319 68 0.0
(read/write) 423648 423736 88 0.0
.dram0.bss 60744 60808 64 0.1
.flash.rodata 204632 204656 24 0.0
.flash.text 911251 911319 68 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698840 698928 88 0.0
.bss 77816 77832 16 0.0
.text 613312 613384 72 0.0
lock-app k32w061+debug (read/write) 591664 591736 72 0.0
.bss 68348 68364 16 0.0
.text 515636 515692 56 0.0
shell k32w061+debug (read/write) 657160 657232 72 0.0
.bss 78988 79004 16 0.0
.text 570524 570580 56 0.0
linux all-clusters-app debug (read only) 1703505 1704089 584 0.0
(read/write) 125728 126368 640 0.5
.bss 57200 57712 512 0.9
.data.rel.ro 62208 62336 128 0.2
.text 1431010 1431426 416 0.0
bridge-app debug+rpc (read only) 1291541 1292125 584 0.0
(read/write) 76272 76912 640 0.8
.bss 42096 42608 512 1.2
.data.rel.ro 27640 27760 120 0.4
.text 1084789 1085205 416 0.0
chip-tool debug (read only) 4919325 4919909 584 0.0
(read/write) 133160 133800 640 0.5
.bss 25328 25840 512 2.0
.data.rel.ro 100192 100312 120 0.1
.text 4417061 4417477 416 0.0
lighting-app debug+rpc (read only) 1552537 1553121 584 0.0
(read/write) 109272 109880 608 0.6
.bss 47768 48280 512 1.1
.data.rel.ro 55040 55152 112 0.2
.text 1289474 1289890 416 0.0
ota-provider-app debug (read only) 1250729 1251329 600 0.0
(read/write) 74472 75112 640 0.9
.bss 44192 44704 512 1.2
.data.rel.ro 24440 24568 128 0.5
.text 1042562 1042994 432 0.0
ota-requestor-app debug (read only) 1329025 1329625 600 0.0
(read/write) 83728 84368 640 0.8
.bss 52320 52832 512 1.0
.data.rel.ro 25448 25576 128 0.5
.text 1106930 1107362 432 0.0
shell debug (read only) 787113 787961 848 0.1
(read/write) 64648 65320 672 1.0
.bss 23240 23752 512 2.2
.data.rel.ro 36656 36816 160 0.4
.text 607938 608546 608 0.1
tv-app debug (read only) 1816497 1817097 600 0.0
(read/write) 296896 297536 640 0.2
.bss 229840 230352 512 0.2
.data.rel.ro 58696 58816 120 0.2
.text 1519074 1519506 432 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291520 2291600 80 0.0
.bss 179244 179276 32 0.0
.text 1254120 1254200 80 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271680 2271696 16 0.0
.bss 172300 172332 32 0.0
.text 1234280 1234296 16 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249336 2249416 80 0.0
.bss 171196 171228 32 0.0
.text 1211936 1212016 80 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048720 2048888 168 0.0
.bss 156264 156296 32 0.0
.text 1011320 1011488 168 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861475 861559 84 0.0
bss 111284 111300 16 0.0
rodata 96932 96952 20 0.0
text 577628 577660 32 0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823891 84 0.0
bss 107636 107652 16 0.0
rodata 88112 88132 20 0.0
text 551776 551808 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786518 786570 52 0.0
bss 112656 112672 16 0.0
rodata 92192 92212 20 0.0
text 507100 507132 32 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838183 838235 52 0.0
bss 110316 110332 16 0.0
rodata 93304 93324 20 0.0
text 559112 559144 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763494 763546 52 0.0
bss 111728 111744 16 0.0
rodata 88608 88628 20 0.0
text 488676 488708 32 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844275 844359 84 0.0
bss 110456 110472 16 0.0
rodata 95012 95032 20 0.0
text 563272 563304 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838039 838091 52 0.0
bss 110352 110368 16 0.0
rodata 93304 93324 20 0.0
text 558848 558880 32 0.0
shell nrf52840dk_nrf52840 (read/write) 776087 776139 52 0.0
bss 109104 109120 16 0.0
rodata 72540 72560 20 0.0
text 519840 519872 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691142 691194 52 0.0
bss 110088 110104 16 0.0
rodata 67184 67204 20 0.0
text 440448 440480 32 0.0
p6 all-clusters-app default (read/write) 2298552 2298800 248 0.0
.bss 111776 112288 512 0.5
.text 1256816 1257064 248 0.0
lock-app default (read/write) 2211256 2211512 256 0.0
.bss 100584 101096 512 0.5
.text 1169520 1169776 256 0.0
qpg lighting-app qpg6100+debug (read only) 490156 490216 60 0.0
.bss 50976 50992 16 0.0
.text 484836 484896 60 0.0
lock-app qpg6100+debug (read only) 466496 466560 64 0.0
.bss 49920 49936 16 0.0
.text 461176 461240 64 0.0
persistent-storage-app qpg6100+debug .bss 19600 19616 16 0.1
telink lighting-app tlsr9518adk80d (read/write) 663082 663150 68 0.0
bss 69096 69112 16 0.0
text 458086 458122 36 0.0
Decreases (6 builds for mbed, p6)
platform target config section 108fd91 e611d5d change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851968 851936 -32 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858560 858528 -32 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859680 859648 -32 -0.0
shell CY8CPROTO_062_4343W+release .heap 875208 875176 -32 -0.0
p6 all-clusters-app default .heap 919032 918520 -512 -0.1
lock-app default .heap 930352 929840 -512 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 108fd91 e611d5d change % change
efr32 lighting-app BRD4161A (read only) 741984 742232 248 0.0
(read/write) 116076 116108 32 0.0
.bss 114292 114324 32 0.0
.data 1784 1784 0 0.0
.text 741976 742224 248 0.0
BRD4161A+rpc (read only) 729512 729784 272 0.0
(read/write) 132700 132732 32 0.0
.bss 130796 130828 32 0.0
.data 1900 1900 0 0.0
.text 729504 729776 272 0.0
lock-app BRD4161A (read only) 721264 721520 256 0.0
(read/write) 113892 113924 32 0.0
.bss 112148 112180 32 0.0
.data 1744 1744 0 0.0
.text 721256 721512 256 0.0
window-app BRD4161A (read only) 722160 722416 256 0.0
(read/write) 114220 114252 32 0.0
.bss 112468 112500 32 0.0
.data 1748 1748 0 0.0
.text 722152 722408 256 0.0
esp32 all-clusters-app c3devkit (read only) 880098 880146 48 0.0
(read/write) 1306328 1306408 80 0.0
.dram0.bss 58240 58304 64 0.1
.dram0.data 16472 16472 0 0.0
.flash.rodata 198376 198392 16 0.0
.flash.text 880098 880146 48 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911251 911319 68 0.0
(read/write) 423648 423736 88 0.0
.dram0.bss 60744 60808 64 0.1
.dram0.data 32108 32108 0 0.0
.flash.rodata 204632 204656 24 0.0
.flash.text 911251 911319 68 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698840 698928 88 0.0
.bss 77816 77832 16 0.0
.data 1912 1912 0 0.0
.text 613312 613384 72 0.0
lock-app k32w061+debug (read/write) 591664 591736 72 0.0
.bss 68348 68364 16 0.0
.data 1880 1880 0 0.0
.text 515636 515692 56 0.0
shell k32w061+debug (read/write) 657160 657232 72 0.0
.bss 78988 79004 16 0.0
.data 1848 1848 0 0.0
.text 570524 570580 56 0.0
linux all-clusters-app debug (read only) 1703505 1704089 584 0.0
(read/write) 125728 126368 640 0.5
.bss 57200 57712 512 0.9
.data 1042 1042 0 0.0
.data.rel.ro 62208 62336 128 0.2
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139221 139221 0 0.0
.text 1431010 1431426 416 0.0
bridge-app debug+rpc (read only) 1291541 1292125 584 0.0
(read/write) 76272 76912 640 0.8
.bss 42096 42608 512 1.2
.data 1568 1568 0 0.0
.data.rel.ro 27640 27760 120 0.4
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111028 111028 0 0.0
.text 1084789 1085205 416 0.0
chip-tool debug (read only) 4919325 4919909 584 0.0
(read/write) 133160 133800 640 0.5
.bss 25328 25840 512 2.0
.data 2224 2224 0 0.0
.data.rel.ro 100192 100312 120 0.1
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 233488 233488 0 0.0
.text 4417061 4417477 416 0.0
lighting-app debug+rpc (read only) 1552537 1553121 584 0.0
(read/write) 109272 109880 608 0.6
.bss 47768 48280 512 1.1
.data 1170 1170 0 0.0
.data.rel.ro 55040 55152 112 0.2
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1289474 1289890 416 0.0
ota-provider-app debug (read only) 1250729 1251329 600 0.0
(read/write) 74472 75112 640 0.9
.bss 44192 44704 512 1.2
.data 752 752 0 0.0
.data.rel.ro 24440 24568 128 0.5
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112232 112232 0 0.0
.text 1042562 1042994 432 0.0
ota-requestor-app debug (read only) 1329025 1329625 600 0.0
(read/write) 83728 84368 640 0.8
.bss 52320 52832 512 1.0
.data 816 816 0 0.0
.data.rel.ro 25448 25576 128 0.5
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124208 124208 0 0.0
.text 1106930 1107362 432 0.0
shell debug (read only) 787113 787961 848 0.1
(read/write) 64648 65320 672 1.0
.bss 23240 23752 512 2.2
.data 242 242 0 0.0
.data.rel.ro 36656 36816 160 0.4
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 607938 608546 608 0.1
tv-app debug (read only) 1816497 1817097 600 0.0
(read/write) 296896 297536 640 0.2
.bss 229840 230352 512 0.2
.data 2704 2704 0 0.0
.data.rel.ro 58696 58816 120 0.2
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155304 155304 0 0.0
.text 1519074 1519506 432 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291520 2291600 80 0.0
.bss 179244 179276 32 0.0
.data 5232 5232 0 0.0
.heap 851968 851936 -32 -0.0
.text 1254120 1254200 80 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271680 2271696 16 0.0
.bss 172300 172332 32 0.0
.data 5584 5584 0 0.0
.heap 858560 858528 -32 -0.0
.text 1234280 1234296 16 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249336 2249416 80 0.0
.bss 171196 171228 32 0.0
.data 5568 5568 0 0.0
.heap 859680 859648 -32 -0.0
.text 1211936 1212016 80 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048720 2048888 168 0.0
.bss 156264 156296 32 0.0
.data 4976 4976 0 0.0
.heap 875208 875176 -32 -0.0
.text 1011320 1011488 168 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861475 861559 84 0.0
bss 111284 111300 16 0.0
rodata 96932 96952 20 0.0
text 577628 577660 32 0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823891 84 0.0
bss 107636 107652 16 0.0
rodata 88112 88132 20 0.0
text 551776 551808 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786518 786570 52 0.0
bss 112656 112672 16 0.0
rodata 92192 92212 20 0.0
text 507100 507132 32 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838183 838235 52 0.0
bss 110316 110332 16 0.0
rodata 93304 93324 20 0.0
text 559112 559144 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763494 763546 52 0.0
bss 111728 111744 16 0.0
rodata 88608 88628 20 0.0
text 488676 488708 32 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844275 844359 84 0.0
bss 110456 110472 16 0.0
rodata 95012 95032 20 0.0
text 563272 563304 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838039 838091 52 0.0
bss 110352 110368 16 0.0
rodata 93304 93324 20 0.0
text 558848 558880 32 0.0
shell nrf52840dk_nrf52840 (read/write) 776087 776139 52 0.0
bss 109104 109120 16 0.0
rodata 72540 72560 20 0.0
text 519840 519872 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691142 691194 52 0.0
bss 110088 110104 16 0.0
rodata 67184 67204 20 0.0
text 440448 440480 32 0.0
p6 all-clusters-app default (read/write) 2298552 2298800 248 0.0
.bss 111776 112288 512 0.5
.data 2536 2536 0 0.0
.heap 919032 918520 -512 -0.1
.text 1256816 1257064 248 0.0
lock-app default (read/write) 2211256 2211512 256 0.0
.bss 100584 101096 512 0.5
.data 2408 2408 0 0.0
.heap 930352 929840 -512 -0.1
.text 1169520 1169776 256 0.0
qpg lighting-app qpg6100+debug (read only) 490156 490216 60 0.0
(read/write) 114140 114140 0 0.0
.bss 50976 50992 16 0.0
.data 1012 1012 0 0.0
.text 484836 484896 60 0.0
lock-app qpg6100+debug (read only) 466496 466560 64 0.0
(read/write) 114144 114144 0 0.0
.bss 49920 49936 16 0.0
.data 968 968 0 0.0
.text 461176 461240 64 0.0
persistent-storage-app qpg6100+debug (read only) 153364 153364 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19616 16 0.1
.data 364 364 0 0.0
.text 148044 148044 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663082 663150 68 0.0
bss 69096 69112 16 0.0
noinit 33216 33216 0 0.0
text 458086 458122 36 0.0

@andy31415
Copy link
Contributor

fast track: change is a refactor (splitting existing code into separatte files), had sufficient time for review by all timezones.

@andy31415 andy31415 merged commit 0f427a9 into project-chip:master Nov 9, 2021
@kpschoedel kpschoedel deleted the x7715-endpoint-split branch November 9, 2021 14:22
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kpschoedel
Split Inet::EndPoint into per-implemention files (project-chip#11539)
5313a9e 
#### Problem

This is a step toward project-chip#7715 _Virtualize System and Inet interfaces_.

#### Change overview

Move each `Inet::EndPointBasis` implementation into its own file.
Each inherits from `Inet::EndPointBase`, but transitionally each
implementation is statically named `EndPointBasis`, and initialization
continues to be done in `InitEndPointBasis()` rather than a constructor.

#### Testing

CI; no changes to functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track inet review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpschoedel @andy31415 @woody-apple