Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject nodeId from subscribed path to path set by SetDirty #11500

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Inject nodeId from subscribed path to path set by SetDirty #11500

merged 1 commit into from
Nov 6, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Nov 5, 2021 •
edited
Loading

Problem

--SetDirty's input parameter aClusterInfo don't have the nodeId, application just mark all interested
attribute dirty, when generated report, we need explicitly inject node
Id from subscribed path to interested dirty path, then construct correct tlv representation.

Change overview

See above

Testing

Manually check the tlv output

@boring-cyborg boring-cyborg bot added the app label Nov 5, 2021
@restyled-io restyled-io bot mentioned this pull request Nov 5, 2021
Closed
yufengwangca
yufengwangca approved these changes Nov 5, 2021
View reviewed changes
src/app/reporting/Engine.cpp Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Nov 5, 2021
Closed
@yunhanw-google yunhanw-google force-pushed the feature/handle_node_id branch 2 times, most recently from 1762d5d to 9890830 Compare November 5, 2021 20:55
@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11500: Size comparison from 12fbf58 to 9890830

Increases (19 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 12fbf58 9890830 change % change
efr32 lighting-app BRD4161A (read only) 745816 745848 32 0.0
.text 745808 745840 32 0.0
BRD4161A+rpc (read only) 733368 733400 32 0.0
.text 733360 733392 32 0.0
lock-app BRD4161A (read only) 725104 725136 32 0.0
.text 725096 725128 32 0.0
window-app BRD4161A (read only) 726000 726032 32 0.0
.text 725992 726024 32 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699560 32 0.0
.text 614012 614044 32 0.0
lock-app k32w061+debug (read/write) 592332 592364 32 0.0
.text 516316 516348 32 0.0
shell k32w061+debug (read/write) 657828 657860 32 0.0
.text 571204 571236 32 0.0
linux all-clusters-app debug (read only) 1704161 1704241 80 0.0
.text 1431522 1431602 80 0.0
bridge-app debug+rpc (read only) 1292197 1292261 64 0.0
.text 1085301 1085365 64 0.0
chip-tool debug (read only) 4915021 4915101 80 0.0
.text 4413669 4413749 80 0.0
lighting-app debug+rpc (read only) 1553193 1553273 80 0.0
.text 1289986 1290066 80 0.0
ota-provider-app debug (read only) 1251401 1251465 64 0.0
.text 1043090 1043154 64 0.0
ota-requestor-app debug (read only) 1329697 1329761 64 0.0
.text 1107458 1107522 64 0.0
tv-app debug (read only) 1817169 1817233 64 0.0
.text 1519602 1519666 64 0.0
p6 all-clusters-app default (read/write) 2301104 2301136 32 0.0
.text 1259368 1259400 32 0.0
lock-app default (read/write) 2213816 2213848 32 0.0
.text 1172080 1172112 32 0.0
qpg lighting-app qpg6100+debug (read only) 490872 490904 32 0.0
.text 485552 485584 32 0.0
lock-app qpg6100+debug (read only) 467220 467244 24 0.0
.text 461900 461924 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 663226 663242 16 0.0
text 458234 458256 22 0.0
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 12fbf58 9890830 change % change
efr32 lighting-app BRD4161A (read only) 745816 745848 32 0.0
(read/write) 115740 115740 0 0.0
.bss 113964 113964 0 0.0
.data 1776 1776 0 0.0
.text 745808 745840 32 0.0
BRD4161A+rpc (read only) 733368 733400 32 0.0
(read/write) 132364 132364 0 0.0
.bss 130468 130468 0 0.0
.data 1892 1892 0 0.0
.text 733360 733392 32 0.0
lock-app BRD4161A (read only) 725104 725136 32 0.0
(read/write) 113556 113556 0 0.0
.bss 111820 111820 0 0.0
.data 1736 1736 0 0.0
.text 725096 725128 32 0.0
window-app BRD4161A (read only) 726000 726032 32 0.0
(read/write) 113884 113884 0 0.0
.bss 112140 112140 0 0.0
.data 1740 1740 0 0.0
.text 725992 726024 32 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699560 32 0.0
.bss 77808 77808 0 0.0
.data 1908 1908 0 0.0
.text 614012 614044 32 0.0
lock-app k32w061+debug (read/write) 592332 592364 32 0.0
.bss 68340 68340 0 0.0
.data 1876 1876 0 0.0
.text 516316 516348 32 0.0
shell k32w061+debug (read/write) 657828 657860 32 0.0
.bss 78980 78980 0 0.0
.data 1844 1844 0 0.0
.text 571204 571236 32 0.0
linux all-clusters-app debug (read only) 1704161 1704241 80 0.0
(read/write) 119232 119232 0 0.0
.bss 50608 50608 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139221 139221 0 0.0
.text 1431522 1431602 80 0.0
bridge-app debug+rpc (read only) 1292197 1292261 64 0.0
(read/write) 69808 69808 0 0.0
.bss 35536 35536 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111028 111028 0 0.0
.text 1085301 1085365 64 0.0
chip-tool debug (read only) 4915021 4915101 80 0.0
(read/write) 126504 126504 0 0.0
.bss 18736 18736 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100112 100112 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 232816 232816 0 0.0
.text 4413669 4413749 80 0.0
lighting-app debug+rpc (read only) 1553193 1553273 80 0.0
(read/write) 102776 102776 0 0.0
.bss 41176 41176 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55136 55136 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1289986 1290066 80 0.0
ota-provider-app debug (read only) 1251401 1251465 64 0.0
(read/write) 67976 67976 0 0.0
.bss 37600 37600 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24536 24536 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112232 112232 0 0.0
.text 1043090 1043154 64 0.0
ota-requestor-app debug (read only) 1329697 1329761 64 0.0
(read/write) 77232 77232 0 0.0
.bss 45728 45728 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25544 25544 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124208 124208 0 0.0
.text 1107458 1107522 64 0.0
shell debug (read only) 788057 788057 0 0.0
(read/write) 58184 58184 0 0.0
.bss 16648 16648 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36784 36784 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77935 77935 0 0.0
.text 608658 608658 0 0.0
tv-app debug (read only) 1817169 1817233 64 0.0
(read/write) 290400 290400 0 0.0
.bss 223248 223248 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58792 58792 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155304 155304 0 0.0
.text 1519602 1519666 64 0.0
p6 all-clusters-app default (read/write) 2301104 2301136 32 0.0
.bss 106872 106872 0 0.0
.data 2528 2528 0 0.0
.heap 923944 923944 0 0.0
.text 1259368 1259400 32 0.0
lock-app default (read/write) 2213816 2213848 32 0.0
.bss 95680 95680 0 0.0
.data 2400 2400 0 0.0
.heap 935264 935264 0 0.0
.text 1172080 1172112 32 0.0
qpg lighting-app qpg6100+debug (read only) 490872 490904 32 0.0
(read/write) 114144 114144 0 0.0
.bss 50968 50968 0 0.0
.data 1008 1008 0 0.0
.text 485552 485584 32 0.0
lock-app qpg6100+debug (read only) 467220 467244 24 0.0
(read/write) 114140 114140 0 0.0
.bss 49912 49912 0 0.0
.data 964 964 0 0.0
.text 461900 461924 24 0.0
persistent-storage-app qpg6100+debug (read only) 153316 153316 0 0.0
(read/write) 114144 114144 0 0.0
.bss 19448 19448 0 0.0
.data 360 360 0 0.0
.text 147996 147996 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663226 663242 16 0.0
bss 69092 69092 0 0.0
noinit 33216 33216 0 0.0
text 458234 458256 22 0.0

@yunhanw-google
Inject nodeId from subscribed path to path set by SetDirty
95f0284 
--SetDirty don't take the nodeId in clusterInfo, it just mark all interested
attribute dirty, when generated report, we need explicitly inject node
Id from subscribed path to interested dirty path, then
construct correct tlv representation.
@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11500: Size comparison from e07c381 to 95f0284

Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e07c381 95f0284 change % change
efr32 lighting-app BRD4161A (read only) 745816 745848 32 0.0
.text 745808 745840 32 0.0
BRD4161A+rpc (read only) 733368 733400 32 0.0
.text 733360 733392 32 0.0
lock-app BRD4161A (read only) 725104 725136 32 0.0
.text 725096 725128 32 0.0
window-app BRD4161A (read only) 726000 726032 32 0.0
.text 725992 726024 32 0.0
esp32 all-clusters-app c3devkit (read only) 882770 882798 28 0.0
.flash.text 882770 882798 28 0.0
m5stack (read only) 913607 913631 24 0.0
.flash.text 913607 913631 24 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699560 32 0.0
.text 614012 614044 32 0.0
lock-app k32w061+debug (read/write) 592332 592364 32 0.0
.text 516316 516348 32 0.0
shell k32w061+debug (read/write) 657828 657860 32 0.0
.text 571204 571236 32 0.0
linux all-clusters-app debug (read only) 1704161 1704241 80 0.0
.text 1431522 1431602 80 0.0
bridge-app debug+rpc (read only) 1292197 1292261 64 0.0
.text 1085301 1085365 64 0.0
chip-tool debug (read only) 4915021 4915101 80 0.0
.text 4413669 4413749 80 0.0
lighting-app debug+rpc (read only) 1553193 1553273 80 0.0
.text 1289986 1290066 80 0.0
ota-provider-app debug (read only) 1251401 1251465 64 0.0
.text 1043090 1043154 64 0.0
ota-requestor-app debug (read only) 1329697 1329761 64 0.0
.text 1107458 1107522 64 0.0
tv-app debug (read only) 1817169 1817233 64 0.0
.text 1519602 1519666 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291640 2291704 64 0.0
.text 1254240 1254304 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249456 2249520 64 0.0
.text 1212056 1212120 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861619 861651 32 0.0
text 577780 577808 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 823967 823983 16 0.0
text 551928 551956 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786678 16 0.0
text 507240 507268 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838327 838359 32 0.0
text 559260 559288 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763622 763654 32 0.0
text 488812 488840 28 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844419 844451 32 0.0
text 563424 563452 28 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838215 32 0.0
text 558996 559024 28 0.0
p6 all-clusters-app default (read/write) 2301104 2301136 32 0.0
.text 1259368 1259400 32 0.0
lock-app default (read/write) 2213816 2213848 32 0.0
.text 1172080 1172112 32 0.0
qpg lighting-app qpg6100+debug (read only) 490872 490904 32 0.0
.text 485552 485584 32 0.0
lock-app qpg6100+debug (read only) 467220 467244 24 0.0
.text 461900 461924 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 663226 663242 16 0.0
text 458234 458256 22 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e07c381 95f0284 change % change
efr32 lighting-app BRD4161A (read only) 745816 745848 32 0.0
(read/write) 115740 115740 0 0.0
.bss 113964 113964 0 0.0
.data 1776 1776 0 0.0
.text 745808 745840 32 0.0
BRD4161A+rpc (read only) 733368 733400 32 0.0
(read/write) 132364 132364 0 0.0
.bss 130468 130468 0 0.0
.data 1892 1892 0 0.0
.text 733360 733392 32 0.0
lock-app BRD4161A (read only) 725104 725136 32 0.0
(read/write) 113556 113556 0 0.0
.bss 111820 111820 0 0.0
.data 1736 1736 0 0.0
.text 725096 725128 32 0.0
window-app BRD4161A (read only) 726000 726032 32 0.0
(read/write) 113884 113884 0 0.0
.bss 112140 112140 0 0.0
.data 1740 1740 0 0.0
.text 725992 726024 32 0.0
esp32 all-clusters-app c3devkit (read only) 882770 882798 28 0.0
(read/write) 1306040 1306040 0 0.0
.dram0.bss 57608 57608 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198712 198712 0 0.0
.flash.text 882770 882798 28 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913607 913631 24 0.0
(read/write) 423336 423336 0 0.0
.dram0.bss 60112 60112 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204952 204952 0 0.0
.flash.text 913607 913631 24 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699560 32 0.0
.bss 77808 77808 0 0.0
.data 1908 1908 0 0.0
.text 614012 614044 32 0.0
lock-app k32w061+debug (read/write) 592332 592364 32 0.0
.bss 68340 68340 0 0.0
.data 1876 1876 0 0.0
.text 516316 516348 32 0.0
shell k32w061+debug (read/write) 657828 657860 32 0.0
.bss 78980 78980 0 0.0
.data 1844 1844 0 0.0
.text 571204 571236 32 0.0
linux all-clusters-app debug (read only) 1704161 1704241 80 0.0
(read/write) 119232 119232 0 0.0
.bss 50608 50608 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139221 139221 0 0.0
.text 1431522 1431602 80 0.0
bridge-app debug+rpc (read only) 1292197 1292261 64 0.0
(read/write) 69808 69808 0 0.0
.bss 35536 35536 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111028 111028 0 0.0
.text 1085301 1085365 64 0.0
chip-tool debug (read only) 4915021 4915101 80 0.0
(read/write) 126504 126504 0 0.0
.bss 18736 18736 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100112 100112 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 232816 232816 0 0.0
.text 4413669 4413749 80 0.0
lighting-app debug+rpc (read only) 1553193 1553273 80 0.0
(read/write) 102776 102776 0 0.0
.bss 41176 41176 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55136 55136 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1289986 1290066 80 0.0
ota-provider-app debug (read only) 1251401 1251465 64 0.0
(read/write) 67976 67976 0 0.0
.bss 37600 37600 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24536 24536 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112232 112232 0 0.0
.text 1043090 1043154 64 0.0
ota-requestor-app debug (read only) 1329697 1329761 64 0.0
(read/write) 77232 77232 0 0.0
.bss 45728 45728 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25544 25544 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124208 124208 0 0.0
.text 1107458 1107522 64 0.0
shell debug (read only) 788057 788057 0 0.0
(read/write) 58184 58184 0 0.0
.bss 16648 16648 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36784 36784 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77935 77935 0 0.0
.text 608658 608658 0 0.0
tv-app debug (read only) 1817169 1817233 64 0.0
(read/write) 290400 290400 0 0.0
.bss 223248 223248 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58792 58792 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155304 155304 0 0.0
.text 1519602 1519666 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291640 2291704 64 0.0
.bss 178924 178924 0 0.0
.data 5224 5224 0 0.0
.heap 852296 852296 0 0.0
.text 1254240 1254304 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271800 2271800 0 0.0
.bss 171980 171980 0 0.0
.data 5576 5576 0 0.0
.heap 858888 858888 0 0.0
.text 1234400 1234400 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249456 2249520 64 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1212056 1212120 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048696 2048696 0 0.0
.bss 156256 156256 0 0.0
.data 4968 4968 0 0.0
.heap 875224 875224 0 0.0
.text 1011296 1011296 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861619 861651 32 0.0
bss 111280 111280 0 0.0
rodata 96932 96932 0 0.0
text 577780 577808 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 823967 823983 16 0.0
bss 107632 107632 0 0.0
rodata 88112 88112 0 0.0
text 551928 551956 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786678 16 0.0
bss 112652 112652 0 0.0
rodata 92192 92192 0 0.0
text 507240 507268 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838327 838359 32 0.0
bss 110312 110312 0 0.0
rodata 93304 93304 0 0.0
text 559260 559288 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763622 763654 32 0.0
bss 111724 111724 0 0.0
rodata 88608 88608 0 0.0
text 488812 488840 28 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844419 844451 32 0.0
bss 110452 110452 0 0.0
rodata 95012 95012 0 0.0
text 563424 563452 28 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838215 32 0.0
bss 110348 110348 0 0.0
rodata 93304 93304 0 0.0
text 558996 559024 28 0.0
shell nrf52840dk_nrf52840 (read/write) 776231 776231 0 0.0
bss 109100 109100 0 0.0
rodata 72540 72540 0 0.0
text 519992 519992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691270 691270 0 0.0
bss 110084 110084 0 0.0
rodata 67184 67184 0 0.0
text 440588 440588 0 0.0
p6 all-clusters-app default (read/write) 2301104 2301136 32 0.0
.bss 106872 106872 0 0.0
.data 2528 2528 0 0.0
.heap 923944 923944 0 0.0
.text 1259368 1259400 32 0.0
lock-app default (read/write) 2213816 2213848 32 0.0
.bss 95680 95680 0 0.0
.data 2400 2400 0 0.0
.heap 935264 935264 0 0.0
.text 1172080 1172112 32 0.0
qpg lighting-app qpg6100+debug (read only) 490872 490904 32 0.0
(read/write) 114144 114144 0 0.0
.bss 50968 50968 0 0.0
.data 1008 1008 0 0.0
.text 485552 485584 32 0.0
lock-app qpg6100+debug (read only) 467220 467244 24 0.0
(read/write) 114140 114140 0 0.0
.bss 49912 49912 0 0.0
.data 964 964 0 0.0
.text 461900 461924 24 0.0
persistent-storage-app qpg6100+debug (read only) 153316 153316 0 0.0
(read/write) 114144 114144 0 0.0
.bss 19448 19448 0 0.0
.data 360 360 0 0.0
.text 147996 147996 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663226 663242 16 0.0
bss 69092 69092 0 0.0
noinit 33216 33216 0 0.0
text 458234 458256 22 0.0

@yunhanw-google yunhanw-google mentioned this pull request Nov 6, 2021
Closed
@woody-apple woody-apple merged commit 0c35285 into project-chip:master Nov 6, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yunhanw-google
Inject nodeId from subscribed path to path set by SetDirty (project-c…
fa29be2 
…hip#11500)

--SetDirty don't take the nodeId in clusterInfo, it just mark all interested
attribute dirty, when generated report, we need explicitly inject node
Id from subscribed path to interested dirty path, then
construct correct tlv representation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@msandstedt msandstedt msandstedt approved these changes

@LuDuda LuDuda LuDuda approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yunhanw-google @LuDuda @msandstedt @yufengwangca @woody-apple @bzbarsky-apple