Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove Microseconds from System::Clock (#11450)" #11481

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Revert "Remove Microseconds from System::Clock (#11450)" #11481

merged 1 commit into from
Nov 5, 2021

Conversation

andy31415
Copy link
Contributor

This reverts commit 11c32e8.

PWRPC tracing uses microseconds. Builds get:

2021-11-05 15:29:53 INFO    [1265/1352] Building CXX object esp-idf/main/CMakeFiles/__idf_main.dir/__/third_party/connectedhomeip/zzz_generated/all-clusters-app/zap-generated/callback-stub.cpp.obj
2021-11-05 15:29:54 INFO    [1266/1352] Building CXX object esp-idf/main/CMakeFiles/__idf_main.dir/Rpc.cpp.obj
2021-11-05 15:29:54 INFO    FAILED: esp-idf/main/CMakeFiles/__idf_main.dir/Rpc.cpp.obj 
2021-11-05 15:29:54 INFO    /opt/espressif/tools/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-el…1: error: 'class chip::System::Clock::ClockBase' has no member named 'GetMonotonicMicroseconds64'; did you mean 'GetMonotonicMilliseconds64'?
2021-11-05 15:29:54 INFO         return (PW_TRACE_TIME_TYPE) chip::System::SystemClock().GetMonotonicMicroseconds64().count();
2021-11-05 15:29:54 INFO                                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
2021-11-05 15:29:54 INFO                                                                 GetMonotonicMilliseconds64

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Nov 5, 2021
@andy31415 andy31415 merged commit 7addec8 into project-chip:master Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11481: Size comparison from 11c32e8 to b9cca16

Increases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 11c32e8 b9cca16 change % change
efr32 lighting-app BRD4161A (read only) 744776 744880 104 0.0
.text 744768 744872 104 0.0
BRD4161A+rpc (read only) 732320 732408 88 0.0
.text 732312 732400 88 0.0
lock-app BRD4161A (read only) 724072 724160 88 0.0
.text 724064 724152 88 0.0
window-app BRD4161A (read only) 724968 725072 104 0.0
.text 724960 725064 104 0.0
esp32 all-clusters-app c3devkit (read only) 882482 882530 48 0.0
(read/write) 1305952 1305960 8 0.0
.flash.rodata 198656 198664 8 0.0
.flash.text 882482 882530 48 0.0
m5stack (read only) 913363 913403 40 0.0
(read/write) 423260 423268 8 0.0
.flash.rodata 204900 204908 8 0.0
.flash.text 913363 913403 40 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699180 699216 36 0.0
.text 613692 613728 36 0.0
lock-app k32w061+debug (read/write) 591984 592036 52 0.0
.text 515996 516048 52 0.0
shell k32w061+debug (read/write) 657476 657528 52 0.0
.text 570884 570936 52 0.0
linux all-clusters-app debug (read only) 1702769 1703617 848 0.0
(read/write) 118624 118656 32 0.0
.data.rel.ro 62320 62336 16 0.0
.text 1430162 1430962 800 0.1
bridge-app debug+rpc (read only) 1290757 1291605 848 0.1
.data.rel.ro 27752 27768 16 0.1
.text 1083925 1084725 800 0.1
chip-tool debug (read only) 4508293 4508917 624 0.0
.data.rel.ro 100080 100096 16 0.0
.text 4008053 4008629 576 0.0
lighting-app debug+rpc (read only) 1551769 1552617 848 0.1
(read/write) 102168 102200 32 0.0
.data.rel.ro 55152 55168 16 0.0
.text 1288626 1289426 800 0.1
ota-provider-app debug (read only) 1249993 1250841 848 0.1
.data.rel.ro 24552 24568 16 0.1
.text 1041714 1042514 800 0.1
ota-requestor-app debug (read only) 1328289 1329137 848 0.1
(read/write) 76624 76656 32 0.0
.data.rel.ro 25560 25576 16 0.1
.text 1106082 1106882 800 0.1
shell debug (read only) 786905 787529 624 0.1
(read/write) 57576 57608 32 0.1
.data.rel.ro 36800 36816 16 0.0
.text 607538 608114 576 0.1
tv-app debug (read only) 1815729 1816577 848 0.0
(read/write) 289792 289824 32 0.0
.data.rel.ro 58808 58824 16 0.0
.text 1518226 1519026 800 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291336 2291408 72 0.0
.text 1253936 1254008 72 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271496 2271568 72 0.0
.text 1234096 1234168 72 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249216 2249224 8 0.0
.text 1211816 1211824 8 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048456 2048464 8 0.0
.text 1011056 1011064 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861251 861303 52 0.0
rodata 96868 96872 4 0.0
text 577508 577556 48 0.0
nrf52840dk_nrf52840+rpc (read/write) 823579 823631 52 0.0
rodata 88044 88048 4 0.0
text 551656 551704 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786274 786326 52 0.0
rodata 92124 92128 4 0.0
text 506964 507012 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837955 838007 52 0.0
rodata 93236 93240 4 0.0
text 558988 559040 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763254 763306 52 0.0
rodata 88544 88548 4 0.0
text 488536 488588 52 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844051 844103 52 0.0
rodata 94948 94952 4 0.0
text 563152 563200 48 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837811 837863 52 0.0
rodata 93236 93240 4 0.0
text 558724 558776 52 0.0
shell nrf52840dk_nrf52840 (read/write) 775895 775963 68 0.0
rodata 72492 72496 4 0.0
text 519744 519796 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690934 690986 52 0.0
rodata 67136 67140 4 0.0
text 440336 440388 52 0.0
p6 all-clusters-app default (read/write) 2300096 2300168 72 0.0
.text 1258360 1258432 72 0.0
lock-app default (read/write) 2212800 2212872 72 0.0
.text 1171064 1171136 72 0.0
qpg lighting-app qpg6100+debug (read only) 490560 490604 44 0.0
.text 485240 485284 44 0.0
lock-app qpg6100+debug (read only) 466900 466944 44 0.0
.text 461580 461624 44 0.0
persistent-storage-app qpg6100+debug (read only) 153168 153212 44 0.0
.text 147848 147892 44 0.0
telink lighting-app tlsr9518adk80d (read/write) 662834 662902 68 0.0
text 457930 457992 62 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 11c32e8 b9cca16 change % change
efr32 lighting-app BRD4161A (read only) 744776 744880 104 0.0
(read/write) 115708 115708 0 0.0
.bss 113932 113932 0 0.0
.data 1772 1772 0 0.0
.text 744768 744872 104 0.0
BRD4161A+rpc (read only) 732320 732408 88 0.0
(read/write) 132324 132324 0 0.0
.bss 130436 130436 0 0.0
.data 1888 1888 0 0.0
.text 732312 732400 88 0.0
lock-app BRD4161A (read only) 724072 724160 88 0.0
(read/write) 113524 113524 0 0.0
.bss 111788 111788 0 0.0
.data 1732 1732 0 0.0
.text 724064 724152 88 0.0
window-app BRD4161A (read only) 724968 725072 104 0.0
(read/write) 113844 113844 0 0.0
.bss 112108 112108 0 0.0
.data 1736 1736 0 0.0
.text 724960 725064 104 0.0
esp32 all-clusters-app c3devkit (read only) 882482 882530 48 0.0
(read/write) 1305952 1305960 8 0.0
.dram0.bss 57576 57576 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198656 198664 8 0.0
.flash.text 882482 882530 48 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913363 913403 40 0.0
(read/write) 423260 423268 8 0.0
.dram0.bss 60088 60088 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204900 204908 8 0.0
.flash.text 913363 913403 40 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699180 699216 36 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613692 613728 36 0.0
lock-app k32w061+debug (read/write) 591984 592036 52 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 515996 516048 52 0.0
shell k32w061+debug (read/write) 657476 657528 52 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570884 570936 52 0.0
linux all-clusters-app debug (read only) 1702769 1703617 848 0.0
(read/write) 118624 118656 32 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62320 62336 16 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139189 139189 0 0.0
.text 1430162 1430962 800 0.1
bridge-app debug+rpc (read only) 1290757 1291605 848 0.1
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27752 27768 16 0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110964 110964 0 0.0
.text 1083925 1084725 800 0.1
chip-tool debug (read only) 4508293 4508917 624 0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100080 100096 16 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 231824 231824 0 0.0
.text 4008053 4008629 576 0.0
lighting-app debug+rpc (read only) 1551769 1552617 848 0.1
(read/write) 102168 102200 32 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55152 55168 16 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129585 129585 0 0.0
.text 1288626 1289426 800 0.1
ota-provider-app debug (read only) 1249993 1250841 848 0.1
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24552 24568 16 0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112200 112200 0 0.0
.text 1041714 1042514 800 0.1
ota-requestor-app debug (read only) 1328289 1329137 848 0.1
(read/write) 76624 76656 32 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25560 25576 16 0.1
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124176 124176 0 0.0
.text 1106082 1106882 800 0.1
shell debug (read only) 786905 787529 624 0.1
(read/write) 57576 57608 32 0.1
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36800 36816 16 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 607538 608114 576 0.1
tv-app debug (read only) 1815729 1816577 848 0.0
(read/write) 289792 289824 32 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58808 58824 16 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155240 155240 0 0.0
.text 1518226 1519026 800 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291336 2291408 72 0.0
.bss 178892 178892 0 0.0
.data 5224 5224 0 0.0
.heap 852328 852328 0 0.0
.text 1253936 1254008 72 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271496 2271568 72 0.0
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1234096 1234168 72 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249216 2249224 8 0.0
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1211816 1211824 8 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048456 2048464 8 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011056 1011064 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861251 861303 52 0.0
bss 111256 111256 0 0.0
rodata 96868 96872 4 0.0
text 577508 577556 48 0.0
nrf52840dk_nrf52840+rpc (read/write) 823579 823631 52 0.0
bss 107608 107608 0 0.0
rodata 88044 88048 4 0.0
text 551656 551704 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786274 786326 52 0.0
bss 112632 112632 0 0.0
rodata 92124 92128 4 0.0
text 506964 507012 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837955 838007 52 0.0
bss 110292 110292 0 0.0
rodata 93236 93240 4 0.0
text 558988 559040 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763254 763306 52 0.0
bss 111700 111700 0 0.0
rodata 88544 88548 4 0.0
text 488536 488588 52 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844051 844103 52 0.0
bss 110428 110428 0 0.0
rodata 94948 94952 4 0.0
text 563152 563200 48 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837811 837863 52 0.0
bss 110328 110328 0 0.0
rodata 93236 93240 4 0.0
text 558724 558776 52 0.0
shell nrf52840dk_nrf52840 (read/write) 775895 775963 68 0.0
bss 109080 109080 0 0.0
rodata 72492 72496 4 0.0
text 519744 519796 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690934 690986 52 0.0
bss 110060 110060 0 0.0
rodata 67136 67140 4 0.0
text 440336 440388 52 0.0
p6 all-clusters-app default (read/write) 2300096 2300168 72 0.0
.bss 106840 106840 0 0.0
.data 2520 2520 0 0.0
.heap 923984 923984 0 0.0
.text 1258360 1258432 72 0.0
lock-app default (read/write) 2212800 2212872 72 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171064 1171136 72 0.0
qpg lighting-app qpg6100+debug (read only) 490560 490604 44 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485240 485284 44 0.0
lock-app qpg6100+debug (read only) 466900 466944 44 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461580 461624 44 0.0
persistent-storage-app qpg6100+debug (read only) 153168 153212 44 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147848 147892 44 0.0
telink lighting-app tlsr9518adk80d (read/write) 662834 662902 68 0.0
bss 69072 69072 0 0.0
noinit 33216 33216 0 0.0
text 457930 457992 62 0.0

PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@andy31415
Revert "Remove Microseconds from System::Clock (project-chip#11450)" (p…
aa8bd9b 
…roject-chip#11481)

This reverts commit 11c32e8.
@andy31415 andy31415 deleted the fix_build_usec branch June 14, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
esp32 freeRTOS hotfix urgent fix needed, can bypass review lib linux platform system zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy31415