-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K32W0] Fix third_party paths #11480
Conversation
internal: https://jira.sw.nxp.com/browse/MCB-2678connectedhomeip/third_party/nxp/k32w0_sdk/sdk_fixes/patch_k32w_sdk.sh Lines 11 to 19 in 8d087fc
This comment was generated by todo based on a
|
internal: https://jira.sw.nxp.com/browse/MCB-2675connectedhomeip/third_party/nxp/k32w0_sdk/sdk_fixes/patch_k32w_sdk.sh Lines 14 to 19 in 8d087fc
This comment was generated by todo based on a
|
Fast tracking given platform change by platform maintainer, note though it fails. @doru91 |
@doru91 The build bustage on K32W looks real. |
488f535
to
9c7ba68
Compare
PR #11480: Size comparison from d45cfaa to 9c7ba68 Full report (6 builds for p6, qpg, telink)
|
9c7ba68
to
224f30e
Compare
PR #11480: Size comparison from d45cfaa to 224f30e Full report (6 builds for p6, qpg, telink)
|
224f30e
to
357c7b8
Compare
PR #11480: Size comparison from d45cfaa to 357c7b8 Full report (30 builds for efr32, esp32, linux, nrfconnect, p6, qpg, telink)
|
It is real. I need to update the Docker image. I know how to modify the .Dockerfile (https://github.com/project-chip/connectedhomeip/blob/master/integrations/docker/images/chip-build-k32w/Dockerfile) but I don't know how to reference the new version of the Docker image in the CI builds. It looks like the Docker versioning changed a little since the last time I used it. @bzbarsky-apple do you know how to do it? |
I think we are just bumping the version in the CI builds as needed, right? It's just in the relevant .yaml files. |
eedbeaa
to
27d8cc2
Compare
PR #11480: Size comparison from 71a3fb2 to 27d8cc2 Full report (35 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
|
27d8cc2
to
ab2e0c9
Compare
PR #11480: Size comparison from 3872a50 to ab2e0c9 Full report (6 builds for p6, qpg, telink)
|
ab2e0c9
to
45e91d9
Compare
PR #11480: Size comparison from 3872a50 to 45e91d9 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Right, operated the suggested changes, I believe it's ready for merging. |
Change from third_party/k32w_sdk/nxp/k32w/k32w0/ to third_party/nxp/k32w0_sdk Signed-off-by: Doru Gucea <[email protected]>
45e91d9
to
fa21745
Compare
PR #11480: Size comparison from 914b58e to fa21745 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
What is being fixed? Examples:
Fix third_party path for k32w platform.
Change overview
Change the paths from third_party/k32w_sdk/nxp/k32w/k32w0/ to third_party/nxp/k32w0_sdk
Testing
Manual testing of the build.