-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Add Ack check in group msg #11472
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:check_r_flag_msgdispatch
Nov 5, 2021
Merged
[Group] Add Ack check in group msg #11472
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:check_r_flag_msgdispatch
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vivien-apple and
wbschiller
November 5, 2021 13:35
pullapprove
bot
requested review from
woody-apple,
yufengwangca and
yunhanw-google
November 5, 2021 13:35
PR #11472: Size comparison from 3f67119 to 4861d45 Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for efr32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Nov 5, 2021
andy31415
approved these changes
Nov 5, 2021
PR #11472: Size comparison from 3f67119 to da0adc5 Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Decreases (14 builds for efr32, esp32, linux, nrfconnect, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
turon
approved these changes
Nov 5, 2021
msandstedt
approved these changes
Nov 5, 2021
jepenven-silabs
force-pushed
the
check_r_flag_msgdispatch
branch
from
November 5, 2021 18:03
da0adc5
to
4616538
Compare
jmartinez-silabs
approved these changes
Nov 5, 2021
PR #11472: Size comparison from c585fe6 to 4616538 Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Add Ack check in group msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix comment from @msandstedt on PR #11441
Change overview
Discard Group Message if the R flag is set, since group messages should never send an Acknowledge.
Testing
All unit test passed.