Fix Descriptor cluster when linking statically. #11453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes project-chip#11344
woody-apple
approved these changes
Nov 4, 2021
pullapprove
bot
requested review from
andy31415,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
wbschiller and
yunhanw-google
|
PR #11453: Size comparison from 50aae87 to 2e46286 Increases (20 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (4 builds for esp32, mbed, nrfconnect, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
Fast tracking, given this is a fix of a revert. |
mspang
pushed a commit
to mspang/connectedhomeip
that referenced
this pull request
Nov 17, 2021
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes project-chip#11344 (cherry picked from commit b18ecb9)
andy31415
pushed a commit
that referenced
this pull request
Nov 18, 2021
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes #11344 (cherry picked from commit b18ecb9)
doru91
pushed a commit
to doru91/connectedhomeip
that referenced
this pull request
Dec 2, 2021
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes project-chip#11344 (cherry picked from commit b18ecb9)
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes project-chip#11344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific changes:
Stop using weak symbols for cluster init callbacks. The way things
are, if a cluster has no commands its file might not get linked at
all (because the weak symbols satisfy the linker), and hence its
init callback would never be called. This was hitting the
Descriptor cluster.
Add a bunch of no-op cluster init callbacks so we can link successfully.
Add some files to the all-clusters-app link that were missing.
Fixes #11344
This is a reprise of #11392 with the merge problem that caused compile failures corrected.