Convert TimeSource to safer Clock types #11449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
turon,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #11449: Size comparison from 29747a2 to 16ad996 Increases (31 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg)
Decreases (3 builds for esp32, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 4, 2021
|
/rebase |
#### Problem `System::TimeSource` still uses raw integer times rather than the safer `Syste::Clock` types based on `std::chrono::duration`. Followup to project-chip#10062 _Some operations on System::Clock types are not safe_ #### Change overview Convert `TimeSource` and its uses. #### Testing CI; no changes to functionality. Converted `TestTimeSource`.
woody-apple
force-pushed
the
x10062-clock-type-7-timesource
branch
from
16ad996 to
9c999a7
Compare
|
PR #11449: Size comparison from f36b141 to 9c999a7 Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Decreases (2 builds for esp32, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Nov 5, 2021
andy31415
approved these changes
Nov 5, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
#### Problem `System::TimeSource` still uses raw integer times rather than the safer `Syste::Clock` types based on `std::chrono::duration`. Followup to project-chip#10062 _Some operations on System::Clock types are not safe_ #### Change overview Convert `TimeSource` and its uses. #### Testing CI; no changes to functionality. Converted `TestTimeSource`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
System::TimeSourcestill uses raw integer times rather thanthe safer
Syste::Clocktypes based onstd::chrono::duration.Followup to #10062 Some operations on System::Clock types are not safe
Change overview
Convert
TimeSourceand its uses.Testing
CI; no changes to functionality.
Converted
TestTimeSource.