Fix potential leak in TCPEndPoint::LwIPHandleDataReceived #11447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `TCPEndPoint::LwIPHandleDataReceived()` receives a packet buffer and, in the normal case, forwards its ownership via `PostEvent()`. If that fails, `LwIPHandleDataReceived()` is responsible for freeing the pbuf, but doesn't. From LwIP documentation, “If the callback function returns ERR_OK or ERR_ABRT it must have freed the pbuf”. #### Change overview Call `pbuf_free()` if `PostEvent()` fails. #### Testing None; we don't have any way to instrument LwIP to verify this.
|
This issue was discovered by @kghost |
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
turon,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
|
PR #11447: Size comparison from 29747a2 to 0506e50 Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 4, 2021
msandstedt
approved these changes
Nov 5, 2021
bzbarsky-apple
approved these changes
Nov 5, 2021
andy31415
approved these changes
Nov 5, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…ip#11447) #### Problem `TCPEndPoint::LwIPHandleDataReceived()` receives a packet buffer and, in the normal case, forwards its ownership via `PostEvent()`. If that fails, `LwIPHandleDataReceived()` is responsible for freeing the pbuf, but doesn't. From LwIP documentation, “If the callback function returns ERR_OK or ERR_ABRT it must have freed the pbuf”. #### Change overview Call `pbuf_free()` if `PostEvent()` fails. #### Testing None; we don't have any way to instrument LwIP to verify this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TCPEndPoint::LwIPHandleDataReceived()receives a packet buffer and,in the normal case, forwards its ownership via
PostEvent(). If thatfails,
LwIPHandleDataReceived()is responsible for freeing the pbuf,but doesn't.
From LwIP documentation, “If the callback function returns ERR_OK or
ERR_ABRT it must have freed the pbuf”.
Change overview
Call
pbuf_free()ifPostEvent()fails.Testing
None; we don't have any way to instrument LwIP to verify this.