Disable Thermostat Clusters attribute tests from Darwin #11446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbeach59
changed the title
|
@chrisbeach59 could we instead modify the tests to write values that are within spec range? |
|
@andy31415 We will need to generate manual test cases. They can not be auto generated. I have a series of tests that were used to validate the pre-attribute-changed-callback. Different tests need to be run based on the FeatureMap bits. The test results. Right now the scripting engine does not support reading an attribute and using it's value as a condition for other tests. Also the featuremap remains broken for little endian cpu's. I have some #defines in the thermostat-server.cpp code to work around this. (There is a PR in the ZAP project to address this that is still pending) I am hesitant to add the manual test cases to CI until this is addressed for fear of breaking CI, again. |
|
@vivien-apple FIY. From my side I am approving based on comments from Chris |
andy31415
approved these changes
Nov 4, 2021
|
PR #11446: Size comparison from 29747a2 to 40fbf02 Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 4, 2021
|
/rebase |
When the pre-attribute-change-callback is added to the chip-all-clusters-app it is validating against spec constraints. The auto generated tests violate these constraints and cause CI to fail.
woody-apple
force-pushed
the
disable_thermostat_auto
branch
from
40fbf02 to
e084a4f
Compare
pullapprove
bot
requested review from
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
saurabhst and
selissia
chrisdecenzo
approved these changes
Nov 4, 2021
woody-apple
pushed a commit
that referenced
this pull request
Nov 9, 2021
* Remove Thermostat Cluster Tests from Darwin When the pre-attribute-change-callback is added to the chip-all-clusters-app it is validating against spec constraints. The auto generated tests violate these constraints and cause CI to fail. * regen ChipClustersTests.m
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…#11446) * Remove Thermostat Cluster Tests from Darwin When the pre-attribute-change-callback is added to the chip-all-clusters-app it is validating against spec constraints. The auto generated tests violate these constraints and cause CI to fail. * regen ChipClustersTests.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Thermostat Cluster Server implements constraints per the spec.
The automated test generation for the cluster generates write values that are outside constraints
blocks #11058
Change overview
What's in this PR
Added excluding of Thermostat Cluster Attribute tests to Darwin zapt template file
Testing
Validated that after changes were made and regen:
All ZAP generated files generated successfully
ChipClusterTests.m did not contain any Thermostat Cluster tests