Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix Descriptor cluster when linking statically. (#11392)" #11445

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Revert "Fix Descriptor cluster when linking statically. (#11392)" #11445

merged 1 commit into from
Nov 4, 2021

Conversation

andy31415
Copy link
Contributor

This reverts commit abcae0d.

This seems to have introduced errors like:

duplicate symbol 'MatterBridgedActionsPluginServerInitCallback()' in:
    obj/include/chip-all-clusters-app.bridged-actions-stub.cpp.o
    obj/third_party/connectedhomeip/src/app/util/all-clusters-common.util.cpp.o
ld: 1 duplicate symbol for architecture x86_64

across linux/mac and more.

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Nov 4, 2021
@andy31415 andy31415 merged commit 0fb625a into project-chip:master Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11445: Size comparison from abcae0d to b4aed80

Increases above 0.2%:

platform target config section abcae0d b4aed80 change % change
esp32 all-clusters-app m5stack (read/write) 423152 425380 2228 0.5
.flash.rodata 204808 207084 2276 1.1
Increases (3 builds for esp32, mbed, nrfconnect)
platform target config section abcae0d b4aed80 change % change
esp32 all-clusters-app m5stack (read/write) 423152 425380 2228 0.5
.flash.rodata 204808 207084 2276 1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292600 2292664 64 0.0
.text 1255200 1255264 64 0.0
nrfconnect pump-app nrf52840dk_nrf52840 (read/write) 844103 844119 16 0.0
text 563272 563280 8 0.0
Decreases (16 builds for efr32, esp32, k32w, mbed, nrfconnect, qpg, telink)
platform target config section abcae0d b4aed80 change % change
efr32 lighting-app BRD4161A+rpc (read only) 732408 732392 -16 -0.0
.text 732400 732384 -16 -0.0
lock-app BRD4161A (read only) 724144 724128 -16 -0.0
.text 724136 724120 -16 -0.0
window-app BRD4161A (read only) 725056 725024 -32 -0.0
.text 725048 725016 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 882474 880814 -1660 -0.2
(read/write) 1305840 1305592 -248 -0.0
.dram0.bss 57560 57528 -32 -0.1
.dram0.data 16472 16464 -8 -0.0
.flash.rodata 198560 198360 -200 -0.1
.flash.text 882474 880814 -1660 -0.2
.iram0.text 57564 57554 -10 -0.0
m5stack (read only) 913363 912019 -1344 -0.1
.dram0.bss 60072 60032 -40 -0.1
.dram0.data 32108 32100 -8 -0.0
.flash.text 913363 912019 -1344 -0.1
k32w lock-app k32w061+debug (read/write) 592060 592044 -16 -0.0
.text 516072 516056 -16 -0.0
shell k32w061+debug (read/write) 657552 657536 -16 -0.0
.text 570960 570944 -16 -0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2273056 2272992 -64 -0.0
.text 1235656 1235592 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 577628 577624 -4 -0.0
nrf52840dk_nrf52840+rpc text 551776 551772 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786342 786326 -16 -0.0
text 507084 507080 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838027 838011 -16 -0.0
text 559112 559100 -12 -0.0
nrf5340dk_nrf5340_cpuapp text 488660 488648 -12 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837879 837863 -16 -0.0
text 558848 558836 -12 -0.0
qpg lock-app qpg6100+debug (read only) 466968 466952 -16 -0.0
.text 461648 461632 -16 -0.0
telink lighting-app tlsr9518adk80d text 458138 458134 -4 -0.0
Full report (28 builds for efr32, esp32, k32w, mbed, nrfconnect, qpg, telink)
platform target config section abcae0d b4aed80 change % change
efr32 lighting-app BRD4161A (read only) 744860 744860 0 0.0
(read/write) 115696 115696 0 0.0
.bss 113924 113924 0 0.0
.data 1772 1772 0 0.0
.text 744852 744852 0 0.0
BRD4161A+rpc (read only) 732408 732392 -16 -0.0
(read/write) 132316 132316 0 0.0
.bss 130428 130428 0 0.0
.data 1888 1888 0 0.0
.text 732400 732384 -16 -0.0
lock-app BRD4161A (read only) 724144 724128 -16 -0.0
(read/write) 113516 113516 0 0.0
.bss 111780 111780 0 0.0
.data 1732 1732 0 0.0
.text 724136 724120 -16 -0.0
window-app BRD4161A (read only) 725056 725024 -32 -0.0
(read/write) 113836 113836 0 0.0
.bss 112100 112100 0 0.0
.data 1736 1736 0 0.0
.text 725048 725016 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 882474 880814 -1660 -0.2
(read/write) 1305840 1305592 -248 -0.0
.dram0.bss 57560 57528 -32 -0.1
.dram0.data 16472 16464 -8 -0.0
.flash.rodata 198560 198360 -200 -0.1
.flash.text 882474 880814 -1660 -0.2
.iram0.text 57564 57554 -10 -0.0
m5stack (read only) 913363 912019 -1344 -0.1
(read/write) 423152 425380 2228 0.5
.dram0.bss 60072 60032 -40 -0.1
.dram0.data 32108 32100 -8 -0.0
.flash.rodata 204808 207084 2276 1.1
.flash.text 913363 912019 -1344 -0.1
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699240 699240 0 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613752 613752 0 0.0
lock-app k32w061+debug (read/write) 592060 592044 -16 -0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516072 516056 -16 -0.0
shell k32w061+debug (read/write) 657552 657536 -16 -0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570960 570944 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292600 2292664 64 0.0
.bss 178876 178876 0 0.0
.data 5216 5216 0 0.0
.heap 852352 852352 0 0.0
.text 1255200 1255264 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273056 2272992 -64 -0.0
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1235656 1235592 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250712 2250712 0 0.0
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1213312 1213312 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048400 2048400 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011000 1011000 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861303 861303 0 0.0
bss 111248 111248 0 0.0
rodata 96808 96808 0 0.0
text 577628 577624 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823651 823651 0 0.0
bss 107600 107600 0 0.0
rodata 87988 87988 0 0.0
text 551776 551772 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786342 786326 -16 -0.0
bss 112624 112624 0 0.0
rodata 92064 92064 0 0.0
text 507084 507080 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838027 838011 -16 -0.0
bss 110284 110284 0 0.0
rodata 93180 93180 0 0.0
text 559112 559100 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763306 763306 0 0.0
bss 111692 111692 0 0.0
rodata 88484 88484 0 0.0
text 488660 488648 -12 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844103 844119 16 0.0
bss 110420 110420 0 0.0
rodata 94888 94888 0 0.0
text 563272 563280 8 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837879 837863 -16 -0.0
bss 110320 110320 0 0.0
rodata 93176 93176 0 0.0
text 558848 558836 -12 -0.0
shell nrf52840dk_nrf52840 (read/write) 775755 775755 0 0.0
bss 109072 109072 0 0.0
rodata 72432 72432 0 0.0
text 519664 519664 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690794 690794 0 0.0
bss 110052 110052 0 0.0
rodata 67076 67076 0 0.0
text 440256 440256 0 0.0
qpg lighting-app qpg6100+debug (read only) 490628 490628 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485308 485308 0 0.0
lock-app qpg6100+debug (read only) 466968 466952 -16 -0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461648 461632 -16 -0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662982 662982 0 0.0
bss 69064 69064 0 0.0
noinit 33216 33216 0 0.0
text 458138 458134 -4 -0.0

PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@andy31415
Revert "Fix Descriptor cluster when linking statically. (project-chip…
005dc58 
…#11392)" (project-chip#11445)

This reverts commit abcae0d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app examples hotfix urgent fix needed, can bypass review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy31415