-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esp32: support ICMPv6 RIO handling #11412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #11412: Size comparison from 372dc6a to 8a9f645 Full report (9 builds for k32w, p6, qpg, telink)
|
PR #11412: Size comparison from 372dc6a to 4f7cccd Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
PR #11412: Size comparison from 372dc6a to 6efbd21 Increases above 0.2%:
Increases (2 builds for esp32)
Decreases (2 builds for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 9, 2021
dhrishi
approved these changes
Nov 10, 2021
@tcarmelveilleux PTAL |
tcarmelveilleux
approved these changes
Nov 11, 2021
c0ffbf5
to
9f1bcca
Compare
PR #11412: Size comparison from 9964cdb to 9f1bcca Increases above 0.2%:
Increases (2 builds for esp32)
Decreases (2 builds for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
* Add support for ICMPv6 RIO handling * Update ESP-IDF release to v4.4 for route hook support.
PR #11412: Size comparison from d45cfaa to 602d930 Increases above 0.2%:
Increases (2 builds for esp32)
Decreases (2 builds for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
chshu
approved these changes
Nov 12, 2021
gjc13
added a commit
to gjc13/connectedhomeip
that referenced
this pull request
Nov 16, 2021
* esp32: support ICMPv6 RIO handling * Add support for ICMPv6 RIO handling * Update ESP-IDF release to v4.4 for route hook support. * esp32: better rio message parsing * esp32: update v4.4 release branch README * fix review comments
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* esp32: support ICMPv6 RIO handling * Add support for ICMPv6 RIO handling * Update ESP-IDF release to v4.4 for route hook support. * esp32: better rio message parsing * esp32: update v4.4 release branch README * fix review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For TE7 test cases, Wi-FI devices are required to configure the route table rules based on the RIO messages sent by the Thread border router. The lwIP stack lacks support for this feature.
Change overview
Testing
How was this tested? (at least one bullet point required)