Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/Rename AttributePath/AttributePaths/AttributeStatus/AttributeStatuses/WriteResponseMessage, new tag(TagCompression) #11409

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Update/Rename AttributePath/AttributePaths/AttributeStatus/AttributeStatuses/WriteResponseMessage, new tag(TagCompression) #11409

merged 1 commit into from
Nov 5, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Nov 4, 2021 •
edited
Loading

Problem

Update/Rename AttributePath/AttributePaths/AttributeStatus/AttributeStatuses/WriteResponseMessage with latest IM encoding spec
Minor new tag added: TagCompression in Path tag, currently it is disabled at default

Change overview

See above

Testing

The existing test covers, add unit test for TagCompression tag

@boring-cyborg boring-cyborg bot added the app label Nov 4, 2021
@yunhanw-google yunhanw-google force-pushed the feature/update_attribute_path branch from 8f4bdd1 to fe9d52d Compare November 4, 2021 06:35
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11409: Size comparison from ee7682d to fe9d52d

Increases (7 builds for linux)
platform target config section ee7682d fe9d52d change % change
linux all-clusters-app debug .rodata 140469 140533 64 0.0
bridge-app debug+rpc .rodata 111780 111876 96 0.1
chip-tool debug .rodata 226992 227088 96 0.0
lighting-app debug+rpc .rodata 130449 130545 96 0.1
ota-provider-app debug .rodata 113032 113096 64 0.1
ota-requestor-app debug .rodata 124464 124528 64 0.1
tv-app debug .rodata 156040 156136 96 0.1
Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ee7682d fe9d52d change % change
efr32 lighting-app BRD4161A (read only) 737432 737224 -208 -0.0
.text 737424 737216 -208 -0.0
BRD4161A+rpc (read only) 726628 726420 -208 -0.0
.text 726620 726412 -208 -0.0
lock-app BRD4161A (read only) 716696 716488 -208 -0.0
.text 716688 716480 -208 -0.0
window-app BRD4161A (read only) 717612 717388 -224 -0.0
.text 717604 717380 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 880890 880598 -292 -0.0
.flash.text 880890 880598 -292 -0.0
m5stack (read only) 912007 911667 -340 -0.0
.flash.text 912007 911667 -340 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699424 -224 -0.0
.text 614120 613896 -224 -0.0
lock-app k32w061+debug (read/write) 591956 591732 -224 -0.0
.text 515948 515724 -224 -0.0
shell k32w061+debug (read/write) 657904 657680 -224 -0.0
.text 571272 571048 -224 -0.0
linux all-clusters-app debug (read only) 1697761 1697345 -416 -0.0
.text 1423874 1423394 -480 -0.0
bridge-app debug+rpc (read only) 1292477 1292093 -384 -0.0
.text 1084805 1084325 -480 -0.0
chip-tool debug (read only) 4429253 4428741 -512 -0.0
.text 3933941 3933333 -608 -0.0
lighting-app debug+rpc (read only) 1553505 1553121 -384 -0.0
.text 1289474 1288994 -480 -0.0
ota-provider-app debug (read only) 1251761 1251345 -416 -0.0
.text 1042626 1042146 -480 -0.0
ota-requestor-app debug (read only) 1329497 1329081 -416 -0.0
.text 1106978 1106498 -480 -0.0
tv-app debug (read only) 1817113 1816729 -384 -0.0
.text 1518786 1518306 -480 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293328 2291776 -1552 -0.1
.text 1255928 1254376 -1552 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272760 2271208 -1552 -0.1
.text 1235360 1233808 -1552 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2250480 2248928 -1552 -0.1
.text 1213080 1211528 -1552 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861623 861399 -224 -0.0
text 577912 577688 -224 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824003 823779 -224 -0.0
text 552100 551876 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786438 -224 -0.0
text 507372 507148 -224 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838331 838107 -224 -0.0
text 559388 559164 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763402 -224 -0.0
text 488940 488716 -224 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844439 844215 -224 -0.0
text 563568 563344 -224 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 837959 -224 -0.0
text 559124 558900 -224 -0.0
p6 all-clusters-app default (read/write) 2301080 2300872 -208 -0.0
.text 1259344 1259136 -208 -0.0
lock-app default (read/write) 2213928 2213720 -208 -0.0
.text 1172192 1171984 -208 -0.0
qpg lighting-app qpg6100+debug (read only) 490932 490708 -224 -0.0
.text 485612 485388 -224 -0.0
lock-app qpg6100+debug (read only) 467280 467056 -224 -0.0
.text 461960 461736 -224 -0.0
telink lighting-app tlsr9518adk80d (read/write) 663086 662806 -280 -0.0
text 458206 457930 -276 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ee7682d fe9d52d change % change
efr32 lighting-app BRD4161A (read only) 737432 737224 -208 -0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737424 737216 -208 -0.0
BRD4161A+rpc (read only) 726628 726420 -208 -0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726620 726412 -208 -0.0
lock-app BRD4161A (read only) 716696 716488 -208 -0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716688 716480 -208 -0.0
window-app BRD4161A (read only) 717612 717388 -224 -0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717604 717380 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 880890 880598 -292 -0.0
(read/write) 1308120 1308120 0 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199832 199832 0 0.0
.flash.text 880890 880598 -292 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 912007 911667 -340 -0.0
(read/write) 427876 427876 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208524 208524 0 0.0
.flash.text 912007 911667 -340 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699424 -224 -0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 614120 613896 -224 -0.0
lock-app k32w061+debug (read/write) 591956 591732 -224 -0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515948 515724 -224 -0.0
shell k32w061+debug (read/write) 657904 657680 -224 -0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571272 571048 -224 -0.0
linux all-clusters-app debug (read only) 1697761 1697345 -416 -0.0
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140469 140533 64 0.0
.text 1423874 1423394 -480 -0.0
bridge-app debug+rpc (read only) 1292477 1292093 -384 -0.0
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111780 111876 96 0.1
.text 1084805 1084325 -480 -0.0
chip-tool debug (read only) 4429253 4428741 -512 -0.0
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226992 227088 96 0.0
.text 3933941 3933333 -608 -0.0
lighting-app debug+rpc (read only) 1553505 1553121 -384 -0.0
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130449 130545 96 0.1
.text 1289474 1288994 -480 -0.0
ota-provider-app debug (read only) 1251761 1251345 -416 -0.0
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 113032 113096 64 0.1
.text 1042626 1042146 -480 -0.0
ota-requestor-app debug (read only) 1329497 1329081 -416 -0.0
(read/write) 76744 76744 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124464 124528 64 0.1
.text 1106978 1106498 -480 -0.0
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1817113 1816729 -384 -0.0
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 156040 156136 96 0.1
.text 1518786 1518306 -480 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293328 2291776 -1552 -0.1
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255928 1254376 -1552 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272760 2271208 -1552 -0.1
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235360 1233808 -1552 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250480 2248928 -1552 -0.1
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213080 1211528 -1552 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861623 861399 -224 -0.0
bss 111288 111288 0 0.0
rodata 96808 96808 0 0.0
text 577912 577688 -224 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824003 823779 -224 -0.0
bss 107640 107640 0 0.0
rodata 87988 87988 0 0.0
text 552100 551876 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786438 -224 -0.0
bss 112664 112664 0 0.0
rodata 92064 92064 0 0.0
text 507372 507148 -224 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838331 838107 -224 -0.0
bss 110324 110324 0 0.0
rodata 93180 93180 0 0.0
text 559388 559164 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763402 -224 -0.0
bss 111732 111732 0 0.0
rodata 88484 88484 0 0.0
text 488940 488716 -224 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844439 844215 -224 -0.0
bss 110460 110460 0 0.0
rodata 94888 94888 0 0.0
text 563568 563344 -224 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 837959 -224 -0.0
bss 110360 110360 0 0.0
rodata 93176 93176 0 0.0
text 559124 558900 -224 -0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2301080 2300872 -208 -0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1259344 1259136 -208 -0.0
lock-app default (read/write) 2213928 2213720 -208 -0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1172192 1171984 -208 -0.0
qpg lighting-app qpg6100+debug (read only) 490932 490708 -224 -0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485612 485388 -224 -0.0
lock-app qpg6100+debug (read only) 467280 467056 -224 -0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461960 461736 -224 -0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663086 662806 -280 -0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458206 457930 -276 -0.1

@woody-apple
Copy link
Contributor

@yunhanw-google does this also add a feature? (TagCompression) Hard to tell if it's new, or just a diff...

yufengwangca
yufengwangca approved these changes Nov 4, 2021
View reviewed changes
src/app/MessageDef/AttributePathIB.cpp Outdated Show resolved Hide resolved
src/app/MessageDef/AttributePaths.cpp Outdated Show resolved Hide resolved
src/app/MessageDef/AttributePathIB.cpp Show resolved Hide resolved
@yunhanw-google
Copy link
Contributor Author

yunhanw-google commented Nov 4, 2021 •
edited
Loading

@yunhanw-google does this also add a feature? (TagCompression) Hard to tell if it's new, or just a diff...

It has not been used currently by any client/server, and currently it is disabled at default, and occupy the tag position as spec indicates in encoding fields, which can be considered with minor new thing, for others, just rename/relocate. Thanks

@yunhanw-google yunhanw-google force-pushed the feature/update_attribute_path branch 2 times, most recently from 8233720 to 0f6b441 Compare November 4, 2021 16:44
@restyled-io restyled-io bot mentioned this pull request Nov 4, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11409: Size comparison from d91ff7c to 0f6b441

Increases (7 builds for linux)
platform target config section d91ff7c 0f6b441 change % change
linux all-clusters-app debug .rodata 138997 139061 64 0.0
bridge-app debug+rpc .rodata 110852 110948 96 0.1
chip-tool debug .rodata 226192 226288 96 0.0
lighting-app debug+rpc .rodata 129489 129585 96 0.1
ota-provider-app debug .rodata 112104 112168 64 0.1
ota-requestor-app debug .rodata 124112 124176 64 0.1
tv-app debug .rodata 155112 155208 96 0.1
Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d91ff7c 0f6b441 change % change
efr32 lighting-app BRD4161A (read only) 744860 744636 -224 -0.0
.text 744852 744628 -224 -0.0
BRD4161A+rpc (read only) 732392 732168 -224 -0.0
.text 732384 732160 -224 -0.0
lock-app BRD4161A (read only) 724128 723904 -224 -0.0
.text 724120 723896 -224 -0.0
window-app BRD4161A (read only) 725024 724800 -224 -0.0
.text 725016 724792 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 880814 880522 -292 -0.0
.flash.text 880814 880522 -292 -0.0
m5stack (read only) 912019 911655 -364 -0.0
.flash.text 912019 911655 -364 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699240 699016 -224 -0.0
.text 613752 613528 -224 -0.0
lock-app k32w061+debug (read/write) 592044 591820 -224 -0.0
.text 516056 515832 -224 -0.0
shell k32w061+debug (read/write) 657536 657296 -240 -0.0
.text 570944 570704 -240 -0.0
linux all-clusters-app debug (read only) 1703025 1702609 -416 -0.0
.text 1430562 1430082 -480 -0.0
bridge-app debug+rpc (read only) 1291093 1290709 -384 -0.0
.text 1084325 1083845 -480 -0.0
chip-tool debug (read only) 4433685 4433173 -512 -0.0
.text 3939029 3938421 -608 -0.0
lighting-app debug+rpc (read only) 1552089 1551705 -384 -0.0
.text 1288994 1288514 -480 -0.0
ota-provider-app debug (read only) 1250377 1249961 -416 -0.0
.text 1042146 1041666 -480 -0.0
ota-requestor-app debug (read only) 1328705 1328289 -416 -0.0
.text 1106514 1106034 -480 -0.0
tv-app debug (read only) 1815729 1815345 -384 -0.0
.text 1518306 1517826 -480 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292664 2291112 -1552 -0.1
.text 1255264 1253712 -1552 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272992 2271504 -1488 -0.1
.text 1235592 1234104 -1488 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2250712 2249160 -1552 -0.1
.text 1213312 1211760 -1552 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861303 861079 -224 -0.0
text 577624 577400 -224 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823651 823427 -224 -0.0
text 551772 551548 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786326 786102 -224 -0.0
text 507080 506856 -224 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838011 837787 -224 -0.0
text 559100 558876 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763306 763082 -224 -0.0
text 488648 488424 -224 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844119 843895 -224 -0.0
text 563280 563056 -224 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837863 837639 -224 -0.0
text 558836 558612 -224 -0.0
p6 all-clusters-app default (read/write) 2299176 2298968 -208 -0.0
.text 1257440 1257232 -208 -0.0
lock-app default (read/write) 2212896 2212672 -224 -0.0
.text 1171160 1170936 -224 -0.0
qpg lighting-app qpg6100+debug (read only) 490628 490396 -232 -0.0
.text 485308 485076 -232 -0.0
lock-app qpg6100+debug (read only) 466952 466720 -232 -0.0
.text 461632 461400 -232 -0.1
telink lighting-app tlsr9518adk80d (read/write) 662982 662702 -280 -0.0
text 458134 457858 -276 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d91ff7c 0f6b441 change % change
efr32 lighting-app BRD4161A (read only) 744860 744636 -224 -0.0
(read/write) 115696 115696 0 0.0
.bss 113924 113924 0 0.0
.data 1772 1772 0 0.0
.text 744852 744628 -224 -0.0
BRD4161A+rpc (read only) 732392 732168 -224 -0.0
(read/write) 132316 132316 0 0.0
.bss 130428 130428 0 0.0
.data 1888 1888 0 0.0
.text 732384 732160 -224 -0.0
lock-app BRD4161A (read only) 724128 723904 -224 -0.0
(read/write) 113516 113516 0 0.0
.bss 111780 111780 0 0.0
.data 1732 1732 0 0.0
.text 724120 723896 -224 -0.0
window-app BRD4161A (read only) 725024 724800 -224 -0.0
(read/write) 113836 113836 0 0.0
.bss 112100 112100 0 0.0
.data 1736 1736 0 0.0
.text 725016 724792 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 880814 880522 -292 -0.0
(read/write) 1305592 1305592 0 0.0
.dram0.bss 57528 57528 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198360 198360 0 0.0
.flash.text 880814 880522 -292 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 912019 911655 -364 -0.0
(read/write) 425380 425380 0 0.0
.dram0.bss 60032 60032 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 207084 207084 0 0.0
.flash.text 912019 911655 -364 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699240 699016 -224 -0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613752 613528 -224 -0.0
lock-app k32w061+debug (read/write) 592044 591820 -224 -0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516056 515832 -224 -0.0
shell k32w061+debug (read/write) 657536 657296 -240 -0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570944 570704 -240 -0.0
linux all-clusters-app debug (read only) 1703025 1702609 -416 -0.0
(read/write) 118656 118656 0 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62336 62336 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138997 139061 64 0.0
.text 1430562 1430082 -480 -0.0
bridge-app debug+rpc (read only) 1291093 1290709 -384 -0.0
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110852 110948 96 0.1
.text 1084325 1083845 -480 -0.0
chip-tool debug (read only) 4433685 4433173 -512 -0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100096 100096 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 226192 226288 96 0.0
.text 3939029 3938421 -608 -0.0
lighting-app debug+rpc (read only) 1552089 1551705 -384 -0.0
(read/write) 102200 102200 0 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129489 129585 96 0.1
.text 1288994 1288514 -480 -0.0
ota-provider-app debug (read only) 1250377 1249961 -416 -0.0
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112104 112168 64 0.1
.text 1042146 1041666 -480 -0.0
ota-requestor-app debug (read only) 1328705 1328289 -416 -0.0
(read/write) 76656 76656 0 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124112 124176 64 0.1
.text 1106514 1106034 -480 -0.0
shell debug (read only) 786873 786873 0 0.0
(read/write) 57608 57608 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 607458 607458 0 0.0
tv-app debug (read only) 1815729 1815345 -384 -0.0
(read/write) 289824 289824 0 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155112 155208 96 0.1
.text 1518306 1517826 -480 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292664 2291112 -1552 -0.1
.bss 178876 178876 0 0.0
.data 5216 5216 0 0.0
.heap 852352 852352 0 0.0
.text 1255264 1253712 -1552 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272992 2271504 -1488 -0.1
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1235592 1234104 -1488 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250712 2249160 -1552 -0.1
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1213312 1211760 -1552 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048400 2048400 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011000 1011000 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861303 861079 -224 -0.0
bss 111248 111248 0 0.0
rodata 96808 96808 0 0.0
text 577624 577400 -224 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823651 823427 -224 -0.0
bss 107600 107600 0 0.0
rodata 87988 87988 0 0.0
text 551772 551548 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786326 786102 -224 -0.0
bss 112624 112624 0 0.0
rodata 92064 92064 0 0.0
text 507080 506856 -224 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838011 837787 -224 -0.0
bss 110284 110284 0 0.0
rodata 93180 93180 0 0.0
text 559100 558876 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763306 763082 -224 -0.0
bss 111692 111692 0 0.0
rodata 88484 88484 0 0.0
text 488648 488424 -224 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844119 843895 -224 -0.0
bss 110420 110420 0 0.0
rodata 94888 94888 0 0.0
text 563280 563056 -224 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837863 837639 -224 -0.0
bss 110320 110320 0 0.0
rodata 93176 93176 0 0.0
text 558836 558612 -224 -0.0
shell nrf52840dk_nrf52840 (read/write) 775755 775755 0 0.0
bss 109072 109072 0 0.0
rodata 72432 72432 0 0.0
text 519664 519664 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690794 690794 0 0.0
bss 110052 110052 0 0.0
rodata 67076 67076 0 0.0
text 440256 440256 0 0.0
p6 all-clusters-app default (read/write) 2299176 2298968 -208 -0.0
.bss 106824 106824 0 0.0
.data 2520 2520 0 0.0
.heap 924000 924000 0 0.0
.text 1257440 1257232 -208 -0.0
lock-app default (read/write) 2212896 2212672 -224 -0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171160 1170936 -224 -0.0
qpg lighting-app qpg6100+debug (read only) 490628 490396 -232 -0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485308 485076 -232 -0.0
lock-app qpg6100+debug (read only) 466952 466720 -232 -0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461632 461400 -232 -0.1
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662982 662702 -280 -0.0
bss 69064 69064 0 0.0
noinit 33216 33216 0 0.0
text 458134 457858 -276 -0.1

@yunhanw-google yunhanw-google force-pushed the feature/update_attribute_path branch from 0f6b441 to b56ae56 Compare November 4, 2021 20:00
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11409: Size comparison from 29747a2 to b56ae56

Increases (7 builds for linux)
platform target config section 29747a2 b56ae56 change % change
linux all-clusters-app debug .rodata 138997 139061 64 0.0
bridge-app debug+rpc .rodata 110852 110948 96 0.1
chip-tool debug .rodata 226192 226288 96 0.0
lighting-app debug+rpc .rodata 129489 129585 96 0.1
ota-provider-app debug .rodata 112104 112168 64 0.1
ota-requestor-app debug .rodata 124112 124176 64 0.1
tv-app debug .rodata 155112 155208 96 0.1
Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 29747a2 b56ae56 change % change
efr32 lighting-app BRD4161A (read only) 744860 744636 -224 -0.0
.text 744852 744628 -224 -0.0
BRD4161A+rpc (read only) 732392 732168 -224 -0.0
.text 732384 732160 -224 -0.0
lock-app BRD4161A (read only) 724128 723904 -224 -0.0
.text 724120 723896 -224 -0.0
window-app BRD4161A (read only) 725024 724800 -224 -0.0
.text 725016 724792 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 880814 880522 -292 -0.0
.flash.text 880814 880522 -292 -0.0
m5stack (read only) 912095 911655 -440 -0.0
.flash.text 912095 911655 -440 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699240 699016 -224 -0.0
.text 613752 613528 -224 -0.0
lock-app k32w061+debug (read/write) 592044 591820 -224 -0.0
.text 516056 515832 -224 -0.0
shell k32w061+debug (read/write) 657536 657296 -240 -0.0
.text 570944 570704 -240 -0.0
linux all-clusters-app debug (read only) 1703025 1702609 -416 -0.0
.text 1430562 1430082 -480 -0.0
bridge-app debug+rpc (read only) 1291093 1290709 -384 -0.0
.text 1084325 1083845 -480 -0.0
chip-tool debug (read only) 4433685 4433173 -512 -0.0
.text 3939029 3938421 -608 -0.0
lighting-app debug+rpc (read only) 1552089 1551705 -384 -0.0
.text 1288994 1288514 -480 -0.0
ota-provider-app debug (read only) 1250377 1249961 -416 -0.0
.text 1042146 1041666 -480 -0.0
ota-requestor-app debug (read only) 1328705 1328289 -416 -0.0
.text 1106514 1106034 -480 -0.0
tv-app debug (read only) 1815729 1815345 -384 -0.0
.text 1518306 1517826 -480 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292664 2291112 -1552 -0.1
.text 1255264 1253712 -1552 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272992 2271504 -1488 -0.1
.text 1235592 1234104 -1488 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2250712 2249160 -1552 -0.1
.text 1213312 1211760 -1552 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861303 861079 -224 -0.0
text 577624 577400 -224 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823651 823427 -224 -0.0
text 551772 551548 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786326 786102 -224 -0.0
text 507080 506856 -224 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838011 837787 -224 -0.0
text 559100 558876 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763306 763082 -224 -0.0
text 488648 488424 -224 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844119 843895 -224 -0.0
text 563280 563056 -224 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837863 837639 -224 -0.0
text 558836 558612 -224 -0.0
p6 all-clusters-app default (read/write) 2299176 2298968 -208 -0.0
.text 1257440 1257232 -208 -0.0
lock-app default (read/write) 2212896 2212672 -224 -0.0
.text 1171160 1170936 -224 -0.0
qpg lighting-app qpg6100+debug (read only) 490628 490396 -232 -0.0
.text 485308 485076 -232 -0.0
lock-app qpg6100+debug (read only) 466952 466720 -232 -0.0
.text 461632 461400 -232 -0.1
telink lighting-app tlsr9518adk80d (read/write) 662982 662702 -280 -0.0
text 458134 457858 -276 -0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 29747a2 b56ae56 change % change
efr32 lighting-app BRD4161A (read only) 744860 744636 -224 -0.0
(read/write) 115696 115696 0 0.0
.bss 113924 113924 0 0.0
.data 1772 1772 0 0.0
.text 744852 744628 -224 -0.0
BRD4161A+rpc (read only) 732392 732168 -224 -0.0
(read/write) 132316 132316 0 0.0
.bss 130428 130428 0 0.0
.data 1888 1888 0 0.0
.text 732384 732160 -224 -0.0
lock-app BRD4161A (read only) 724128 723904 -224 -0.0
(read/write) 113516 113516 0 0.0
.bss 111780 111780 0 0.0
.data 1732 1732 0 0.0
.text 724120 723896 -224 -0.0
window-app BRD4161A (read only) 725024 724800 -224 -0.0
(read/write) 113836 113836 0 0.0
.bss 112100 112100 0 0.0
.data 1736 1736 0 0.0
.text 725016 724792 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 880814 880522 -292 -0.0
(read/write) 1305592 1305592 0 0.0
.dram0.bss 57528 57528 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198360 198360 0 0.0
.flash.text 880814 880522 -292 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 912095 911655 -440 -0.0
(read/write) 425380 425380 0 0.0
.dram0.bss 60032 60032 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 207084 207084 0 0.0
.flash.text 912095 911655 -440 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699240 699016 -224 -0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613752 613528 -224 -0.0
lock-app k32w061+debug (read/write) 592044 591820 -224 -0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516056 515832 -224 -0.0
shell k32w061+debug (read/write) 657536 657296 -240 -0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570944 570704 -240 -0.0
linux all-clusters-app debug (read only) 1703025 1702609 -416 -0.0
(read/write) 118656 118656 0 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62336 62336 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138997 139061 64 0.0
.text 1430562 1430082 -480 -0.0
bridge-app debug+rpc (read only) 1291093 1290709 -384 -0.0
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110852 110948 96 0.1
.text 1084325 1083845 -480 -0.0
chip-tool debug (read only) 4433685 4433173 -512 -0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100096 100096 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 226192 226288 96 0.0
.text 3939029 3938421 -608 -0.0
lighting-app debug+rpc (read only) 1552089 1551705 -384 -0.0
(read/write) 102200 102200 0 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129489 129585 96 0.1
.text 1288994 1288514 -480 -0.0
ota-provider-app debug (read only) 1250377 1249961 -416 -0.0
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112104 112168 64 0.1
.text 1042146 1041666 -480 -0.0
ota-requestor-app debug (read only) 1328705 1328289 -416 -0.0
(read/write) 76656 76656 0 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124112 124176 64 0.1
.text 1106514 1106034 -480 -0.0
shell debug (read only) 786873 786873 0 0.0
(read/write) 57608 57608 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 607458 607458 0 0.0
tv-app debug (read only) 1815729 1815345 -384 -0.0
(read/write) 289824 289824 0 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155112 155208 96 0.1
.text 1518306 1517826 -480 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292664 2291112 -1552 -0.1
.bss 178876 178876 0 0.0
.data 5216 5216 0 0.0
.heap 852352 852352 0 0.0
.text 1255264 1253712 -1552 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272992 2271504 -1488 -0.1
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1235592 1234104 -1488 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250712 2249160 -1552 -0.1
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1213312 1211760 -1552 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048400 2048400 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011000 1011000 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861303 861079 -224 -0.0
bss 111248 111248 0 0.0
rodata 96808 96808 0 0.0
text 577624 577400 -224 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823651 823427 -224 -0.0
bss 107600 107600 0 0.0
rodata 87988 87988 0 0.0
text 551772 551548 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786326 786102 -224 -0.0
bss 112624 112624 0 0.0
rodata 92064 92064 0 0.0
text 507080 506856 -224 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838011 837787 -224 -0.0
bss 110284 110284 0 0.0
rodata 93180 93180 0 0.0
text 559100 558876 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763306 763082 -224 -0.0
bss 111692 111692 0 0.0
rodata 88484 88484 0 0.0
text 488648 488424 -224 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844119 843895 -224 -0.0
bss 110420 110420 0 0.0
rodata 94888 94888 0 0.0
text 563280 563056 -224 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837863 837639 -224 -0.0
bss 110320 110320 0 0.0
rodata 93176 93176 0 0.0
text 558836 558612 -224 -0.0
shell nrf52840dk_nrf52840 (read/write) 775755 775755 0 0.0
bss 109072 109072 0 0.0
rodata 72432 72432 0 0.0
text 519664 519664 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690794 690794 0 0.0
bss 110052 110052 0 0.0
rodata 67076 67076 0 0.0
text 440256 440256 0 0.0
p6 all-clusters-app default (read/write) 2299176 2298968 -208 -0.0
.bss 106824 106824 0 0.0
.data 2520 2520 0 0.0
.heap 924000 924000 0 0.0
.text 1257440 1257232 -208 -0.0
lock-app default (read/write) 2212896 2212672 -224 -0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171160 1170936 -224 -0.0
qpg lighting-app qpg6100+debug (read only) 490628 490396 -232 -0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485308 485076 -232 -0.0
lock-app qpg6100+debug (read only) 466952 466720 -232 -0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461632 461400 -232 -0.1
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662982 662702 -280 -0.0
bss 69064 69064 0 0.0
noinit 33216 33216 0 0.0
text 458134 457858 -276 -0.1

LuDuda
LuDuda approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@woody-apple
Copy link
Contributor

Looking through this diff, it does indeed add a feature. @yunhanw-google can you update the description and title please? This isn't a simple rename.

@bzbarsky-apple can you take a peek?

@yunhanw-google yunhanw-google changed the title Update/Rename AttributePath/AttributePaths/AttributeStatus/AttributeStatuses/WriteResponseMessage Update/Rename AttributePath/AttributePaths/AttributeStatus/AttributeStatuses/WriteResponseMessage, new tag(TagCompression) Nov 4, 2021
@yunhanw-google
Copy link
Contributor Author

Looking through this diff, it does indeed add a feature. @yunhanw-google can you update the description and title please? This isn't a simple rename.

@bzbarsky-apple can you take a peek?

updated

@yunhanw-google yunhanw-google merged commit 64ffda0 into project-chip:master Nov 5, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yunhanw-google
Update/Rename attributePath/AttributePaths/AttributeStatus/WriteRespo…
6cdc9c6 
…nse with latest encoding spec (project-chip#11409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@LuDuda LuDuda LuDuda approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yunhanw-google @woody-apple @LuDuda @yufengwangca @jmartinez-silabs