Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pigweed Console default timeout #11402

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Pigweed Console default timeout #11402

merged 1 commit into from
Nov 8, 2021

Conversation

AnthonyDiGirolamo
Copy link
Contributor

Problem

  • Set a default timeout for unary RPCs of 5 seconds. This prevents python scripts from hanging indefinitely. The existing timeout of None meant wait indefinitely for a response.

Additional RPC Console Improvements

  • Add all RPCs to the console sentence completer, under the existing
    channel_client variable.
  • Add a hidden by default host log window (useful for Python debugging).

Testing

Flash all-clusters-app and run the rpc_console. Test channel_client.rpcs.pw.rpc.EchoService.Echo(msg='hi') which should fail and observe a failure after 5 seconds.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot mentioned this pull request Nov 3, 2021
Closed
@AnthonyDiGirolamo
Copy link
Contributor Author

@rgoliver Can you take a look at this?

@rgoliver
Copy link

rgoliver commented Nov 4, 2021

@rgoliver Can you take a look at this?

Looks good, just a small restyle: 989d282

@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11402: Size comparison from 3bec0f9 to 7689050

Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 3bec0f9 7689050 change % change
efr32 lighting-app BRD4161A (read only) 737432 737432 0 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737424 737424 0 0.0
BRD4161A+rpc (read only) 726628 726628 0 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726620 726620 0 0.0
lock-app BRD4161A (read only) 716696 716696 0 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716688 716688 0 0.0
window-app BRD4161A (read only) 717612 717612 0 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717604 717604 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699648 0 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 614120 614120 0 0.0
lock-app k32w061+debug (read/write) 591956 591956 0 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515948 515948 0 0.0
shell k32w061+debug (read/write) 657904 657904 0 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571272 571272 0 0.0
linux all-clusters-app debug (read only) 1696289 1696289 0 0.0
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140277 140277 0 0.0
.text 1422594 1422594 0 0.0
bridge-app debug+rpc (read only) 1292477 1292477 0 0.0
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111780 111780 0 0.0
.text 1084805 1084805 0 0.0
chip-tool debug (read only) 4428085 4428085 0 0.0
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226704 226704 0 0.0
.text 3933061 3933061 0 0.0
lighting-app debug+rpc (read only) 1553505 1553505 0 0.0
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130449 130449 0 0.0
.text 1289474 1289474 0 0.0
ota-provider-app debug (read only) 1249025 1249025 0 0.0
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112808 112808 0 0.0
.text 1040114 1040114 0 0.0
ota-requestor-app debug (read only) 1316337 1316337 0 0.0
(read/write) 76808 76808 0 0.0
.bss 45344 45344 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123728 123728 0 0.0
.text 1094818 1094818 0 0.0
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1815641 1815641 0 0.0
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155848 155848 0 0.0
.text 1517506 1517506 0 0.0
p6 all-clusters-app default (read/write) 2300920 2300920 0 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1259184 1259184 0 0.0
lock-app default (read/write) 2213928 2213928 0 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1172192 1172192 0 0.0
qpg lighting-app qpg6100+debug (read only) 490932 490932 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485612 485612 0 0.0
lock-app qpg6100+debug (read only) 467280 467280 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461960 461960 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663086 663086 0 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458206 458206 0 0.0

@woody-apple
Copy link
Contributor

@AnthonyDiGirolamo Can you please restyle this?

@woody-apple
Copy link
Contributor

/rebase

@AnthonyDiGirolamo @woody-apple
Pigweed Console default timeout
d48c5ee 
- Set a default timeout for unary RPCs to 5 seconds.
- Add all RPCs to the console sentence completer, under the existing
  channel_client variable.
- Add a hidden by default host log window (useful for Python debugging).
@woody-apple woody-apple force-pushed the console-default-timeout branch from 7c8a2fe to d48c5ee Compare November 5, 2021 23:58
@github-actions
Copy link

github-actions bot commented Nov 6, 2021 •
edited
Loading

PR #11402: Size comparison from e4ef3bc to d48c5ee

Increases (1 build for esp32)
platform target config section e4ef3bc d48c5ee change % change
esp32 all-clusters-app m5stack (read only) 913607 913623 16 0.0
.flash.text 913607 913623 16 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e4ef3bc d48c5ee change % change
efr32 lighting-app BRD4161A (read only) 745816 745816 0 0.0
(read/write) 115740 115740 0 0.0
.bss 113964 113964 0 0.0
.data 1776 1776 0 0.0
.text 745808 745808 0 0.0
BRD4161A+rpc (read only) 733368 733368 0 0.0
(read/write) 132364 132364 0 0.0
.bss 130468 130468 0 0.0
.data 1892 1892 0 0.0
.text 733360 733360 0 0.0
lock-app BRD4161A (read only) 725104 725104 0 0.0
(read/write) 113556 113556 0 0.0
.bss 111820 111820 0 0.0
.data 1736 1736 0 0.0
.text 725096 725096 0 0.0
window-app BRD4161A (read only) 726000 726000 0 0.0
(read/write) 113884 113884 0 0.0
.bss 112140 112140 0 0.0
.data 1740 1740 0 0.0
.text 725992 725992 0 0.0
esp32 all-clusters-app c3devkit (read only) 882770 882770 0 0.0
(read/write) 1306040 1306040 0 0.0
.dram0.bss 57608 57608 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198712 198712 0 0.0
.flash.text 882770 882770 0 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913607 913623 16 0.0
(read/write) 423336 423336 0 0.0
.dram0.bss 60112 60112 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204952 204952 0 0.0
.flash.text 913607 913623 16 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699528 0 0.0
.bss 77808 77808 0 0.0
.data 1908 1908 0 0.0
.text 614012 614012 0 0.0
lock-app k32w061+debug (read/write) 592332 592332 0 0.0
.bss 68340 68340 0 0.0
.data 1876 1876 0 0.0
.text 516316 516316 0 0.0
shell k32w061+debug (read/write) 657828 657828 0 0.0
.bss 78980 78980 0 0.0
.data 1844 1844 0 0.0
.text 571204 571204 0 0.0
linux all-clusters-app debug (read only) 1704161 1704161 0 0.0
(read/write) 119232 119232 0 0.0
.bss 50608 50608 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139221 139221 0 0.0
.text 1431522 1431522 0 0.0
bridge-app debug+rpc (read only) 1292197 1292197 0 0.0
(read/write) 69808 69808 0 0.0
.bss 35536 35536 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111028 111028 0 0.0
.text 1085301 1085301 0 0.0
chip-tool debug (read only) 4916093 4916093 0 0.0
(read/write) 126504 126504 0 0.0
.bss 18736 18736 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100112 100112 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 232944 232944 0 0.0
.text 4414613 4414613 0 0.0
lighting-app debug+rpc (read only) 1553193 1553193 0 0.0
(read/write) 102776 102776 0 0.0
.bss 41176 41176 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55136 55136 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1289986 1289986 0 0.0
ota-provider-app debug (read only) 1251401 1251401 0 0.0
(read/write) 67976 67976 0 0.0
.bss 37600 37600 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24536 24536 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112232 112232 0 0.0
.text 1043090 1043090 0 0.0
ota-requestor-app debug (read only) 1329697 1329697 0 0.0
(read/write) 77232 77232 0 0.0
.bss 45728 45728 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25544 25544 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124208 124208 0 0.0
.text 1107458 1107458 0 0.0
shell debug (read only) 788057 788057 0 0.0
(read/write) 58184 58184 0 0.0
.bss 16648 16648 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36784 36784 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77935 77935 0 0.0
.text 608658 608658 0 0.0
tv-app debug (read only) 1817169 1817169 0 0.0
(read/write) 290400 290400 0 0.0
.bss 223248 223248 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58792 58792 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155304 155304 0 0.0
.text 1519602 1519602 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291640 2291640 0 0.0
.bss 178924 178924 0 0.0
.data 5224 5224 0 0.0
.heap 852296 852296 0 0.0
.text 1254240 1254240 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271736 2271736 0 0.0
.bss 171980 171980 0 0.0
.data 5576 5576 0 0.0
.heap 858888 858888 0 0.0
.text 1234336 1234336 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249456 2249456 0 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1212056 1212056 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048912 2048912 0 0.0
.bss 156256 156256 0 0.0
.data 4968 4968 0 0.0
.heap 875224 875224 0 0.0
.text 1011512 1011512 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861619 861619 0 0.0
bss 111280 111280 0 0.0
rodata 96932 96932 0 0.0
text 577780 577780 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823967 823967 0 0.0
bss 107632 107632 0 0.0
rodata 88112 88112 0 0.0
text 551928 551928 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786662 0 0.0
bss 112652 112652 0 0.0
rodata 92192 92192 0 0.0
text 507240 507240 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838327 838327 0 0.0
bss 110312 110312 0 0.0
rodata 93304 93304 0 0.0
text 559260 559260 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763622 763622 0 0.0
bss 111724 111724 0 0.0
rodata 88608 88608 0 0.0
text 488812 488812 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844419 844419 0 0.0
bss 110452 110452 0 0.0
rodata 95012 95012 0 0.0
text 563424 563424 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838183 0 0.0
bss 110348 110348 0 0.0
rodata 93304 93304 0 0.0
text 558996 558996 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776231 776231 0 0.0
bss 109100 109100 0 0.0
rodata 72540 72540 0 0.0
text 519992 519992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691270 691270 0 0.0
bss 110084 110084 0 0.0
rodata 67184 67184 0 0.0
text 440588 440588 0 0.0
p6 all-clusters-app default (read/write) 2301104 2301104 0 0.0
.bss 106872 106872 0 0.0
.data 2528 2528 0 0.0
.heap 923944 923944 0 0.0
.text 1259368 1259368 0 0.0
lock-app default (read/write) 2213816 2213816 0 0.0
.bss 95680 95680 0 0.0
.data 2400 2400 0 0.0
.heap 935264 935264 0 0.0
.text 1172080 1172080 0 0.0
qpg lighting-app qpg6100+debug (read only) 490872 490872 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50968 50968 0 0.0
.data 1008 1008 0 0.0
.text 485552 485552 0 0.0
lock-app qpg6100+debug (read only) 467220 467220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49912 49912 0 0.0
.data 964 964 0 0.0
.text 461900 461900 0 0.0
persistent-storage-app qpg6100+debug (read only) 153316 153316 0 0.0
(read/write) 114144 114144 0 0.0
.bss 19448 19448 0 0.0
.data 360 360 0 0.0
.text 147996 147996 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663226 663226 0 0.0
bss 69092 69092 0 0.0
noinit 33216 33216 0 0.0
text 458234 458234 0 0.0

@andy31415 andy31415 merged commit 8b77e91 into project-chip:master Nov 8, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@AnthonyDiGirolamo
Pigweed Console default timeout (project-chip#11402)
499163f 
- Set a default timeout for unary RPCs to 5 seconds.
- Add all RPCs to the console sentence completer, under the existing
  channel_client variable.
- Add a hidden by default host log window (useful for Python debugging).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@rgoliver rgoliver rgoliver approved these changes

@andy31415 andy31415 andy31415 approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AnthonyDiGirolamo @CLAassistant @rgoliver @woody-apple @andy31415 @jmartinez-silabs